[issue20039] Missing documentation for argparse.ArgumentTypeError

2022-02-03 Thread Yassir Karroum


Change by Yassir Karroum :


--
keywords: +patch
nosy: +ukarroum
nosy_count: 6.0 -> 7.0
pull_requests: +29304
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31125

___
Python tracker 
<https://bugs.python.org/issue20039>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44686] use pkgutil.resolve_name in unittest.mock

2022-01-21 Thread Yassir Karroum


Yassir Karroum  added the comment:

I think we can close this one

--
nosy: +ukarroum

___
Python tracker 
<https://bugs.python.org/issue44686>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6686] xml.sax.xmlreader.XMLReader.getProperty (xml.sax.handler.property_xml_string) returns bytes

2022-01-15 Thread Yassir Karroum


Change by Yassir Karroum :


--
nosy: +ukarroum
nosy_count: 7.0 -> 8.0
pull_requests: +28814
pull_request: https://github.com/python/cpython/pull/30612

___
Python tracker 
<https://bugs.python.org/issue6686>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43741] http.client leaks from self.fp.read()

2022-01-15 Thread Yassir Karroum


Yassir Karroum  added the comment:

Hi Hynkek,

Thanks for the bug report.

I'll change the type category to "resource usage", since "crash" is typically 
reserved for issues where python crash (for exemple due to a seg fault).

Can you also provide a minimal code to check your issue ? Where ideally all the 
parameters are fixed (as the url).

--
nosy: +ukarroum
type: crash -> resource usage

___
Python tracker 
<https://bugs.python.org/issue43741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27273] subprocess.run(cmd, input='text') should pass universal_newlines=True to Popen

2022-01-12 Thread Yassir Karroum


Yassir Karroum  added the comment:

As of 3.7, the subprocess.run has a new parameter "text".

IMO it's safer to explicitly set the "text" value instead of inferring it from 
the "input" type.

--
nosy: +ukarroum

___
Python tracker 
<https://bugs.python.org/issue27273>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

2022-01-04 Thread Yassir Karroum


Yassir Karroum  added the comment:

Alright, I'll stop working on it then, thanks for the fix !

--

___
Python tracker 
<https://bugs.python.org/issue25927>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

2022-01-04 Thread Yassir Karroum


Change by Yassir Karroum :


--
versions: +Python 3.11 -Python 3.6

___
Python tracker 
<https://bugs.python.org/issue25927>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46245] Add support for dir_fd in shutil.rmtree()

2022-01-04 Thread Yassir Karroum


Yassir Karroum  added the comment:

No problem, I'll resume working on issue25927, thanks for the fix.

--

___
Python tracker 
<https://bugs.python.org/issue46245>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46245] Add support for dir_fd in shutil.rmtree()

2022-01-03 Thread Yassir Karroum


Change by Yassir Karroum :


--
keywords: +patch
nosy: +ukarroum
nosy_count: 1.0 -> 2.0
pull_requests: +28594
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30386

___
Python tracker 
<https://bugs.python.org/issue46245>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

2022-01-02 Thread Yassir Karroum


Yassir Karroum  added the comment:

I started looking at this issue.

I may need to propagate the change (adding dir_fd as a keyword argument) to 
multiple functions in posixpath module: Functions like abspath, join, isdir, 
etc. The alternative will be to have the logic in tempfile module which feels 
off to me.

Does anyone have an issue with that ?

--
nosy: +ukarroum

___
Python tracker 
<https://bugs.python.org/issue25927>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com