[issue23808] Symlink to directory on Windows 8

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

This behavior is not specific to just Windows 8. Symlinks to directories are 
treated as directories on Windows, in particular, they should be removed with 
RemoveDirectory, not DeleteFile.

Is there any reason this issue is still open?

--
nosy: +izbyshev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +2535

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[Roundup Robot]

Roundup Robot added the comment:

New changeset 19a3e0e664af by Serhiy Storchaka in branch '3.4':
Issues #23808, #25911: Trying to fix walk tests on Windows.
https://hg.python.org/cpython/rev/19a3e0e664af

New changeset f9e22717722d by Serhiy Storchaka in branch '3.5':
Issues #23808, #25911: Trying to fix walk tests on Windows.
https://hg.python.org/cpython/rev/f9e22717722d

New changeset da020e408c7f by Serhiy Storchaka in branch 'default':
Issues #23808, #25911: Trying to fix walk tests on Windows.
https://hg.python.org/cpython/rev/da020e408c7f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
type:  -> behavior
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Then tests should be adapted for Windows 8.

--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[Paul Moore]

Paul Moore added the comment:

It returns True.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23808] Symlink to directory on Windows 8

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Looks as a symlink on Windows 8 can has the FILE_ATTRIBUTE_DIRECTORY flag.

http://buildbot.python.org/all/builders/AMD64%20Windows8%203.4/builds/348/steps/test/logs/stdio
==
FAIL: test_walk_bottom_up (test.test_os.WalkTests)
--
Traceback (most recent call last):
  File "D:\buildarea\3.4.bolen-windows8\build\lib\test\test_os.py", 
line 802, in test_walk_bottom_up
self.sub2_tree)
AssertionError: Tuples differ: ('@test_3872_tmp\\TEST1\\SUB2', 
['broken_link', 'link'], ['tmp3']) != 
('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])

First differing element 1:
['broken_link', 'link']
['link']

- ('@test_3872_tmp\\TEST1\\SUB2', ['broken_link', 
'link'], ['tmp3'])
? --

+ ('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])
? ++


==
FAIL: test_walk_prune (test.test_os.WalkTests)
--
Traceback (most recent call last):
  File "D:\buildarea\3.4.bolen-windows8\build\lib\test\test_os.py", 
line 782, in test_walk_prune
self.assertEqual(all[1], self.sub2_tree)
AssertionError: Tuples differ: ('@test_3872_tmp\\TEST1\\SUB2', 
['broken_link', 'link'], ['tmp3']) != 
('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])

First differing element 1:
['broken_link', 'link']
['link']

- ('@test_3872_tmp\\TEST1\\SUB2', ['broken_link', 
'link'], ['tmp3'])
? --

+ ('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])
? ++


==
FAIL: test_walk_topdown (test.test_os.WalkTests)
--
Traceback (most recent call last):
  File "D:\buildarea\3.4.bolen-windows8\build\lib\test\test_os.py", 
line 765, in test_walk_topdown
self.assertEqual(all[3 - 2 * flipped], self.sub2_tree)
AssertionError: Tuples differ: ('@test_3872_tmp\\TEST1\\SUB2', 
['broken_link', 'link'], ['tmp3']) != 
('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])

First differing element 1:
['broken_link', 'link']
['link']

- ('@test_3872_tmp\\TEST1\\SUB2', ['broken_link', 
'link'], ['tmp3'])
? --

+ ('@test_3872_tmp\\TEST1\\SUB2', ['link'], 
['broken_link', 'tmp3'])
? ++


--

Create broken link:

os.symlink('non_existing_patch', 'broken_link', target_is_directory=True)

What return os.path.isdir('broken_link')?

--
components: Tests, Windows
messages: 239506
nosy: paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Symlink to directory on Windows 8
versions: Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com