[issue35053] Enhance tracemalloc to trace properly free lists

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

A little bit of history.

I opened a bug 2 years ago but I closed it (lack of interest):
https://github.com/vstinner/pytracemalloc/issues/2

I rewrote tracemalloc between version 0.9 and 1.0. In tracemalloc 0.9, there 
was an API to track free lists. Here is the code to handle "alloc" and "free" 
of an object inside a freelist:

https://github.com/vstinner/pytracemalloc/blob/a2b2616fc73cd5ce0ea45d1b68a490e0fc52ccc8/_tracemalloc.c#L291-L337

My PR 10063 has a more correct and efficient implementation:

* It keeps the trace alive when the object moves into the free list to report 
the real memory usage of Python: the free lists consumes memory
* It writes directly into the hash table entry rather than remove/add 
frequently the trace, it should be more efficient

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32797] Tracebacks from Cython modules no longer work

2018-10-24 Thread Petr Viktorin


Petr Viktorin  added the comment:


New changeset 057f4078b044325dae4af55c4c64b684edaca315 by Petr Viktorin 
(jdemeyer) in branch 'master':
bpo-32797: improve documentation of linecache.getline (GH-9540)
https://github.com/python/cpython/commit/057f4078b044325dae4af55c4c64b684edaca315


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35053] Enhance tracemalloc to trace properly free lists

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

> Is performance overhead negligible?

Thank you for asking the most important question :-)

I ran this microbenchmark:

make distclean
./configure --enable-lto
make
./python -m venv env
env/bin/python -m pip install perf
sudo env/bin/python -m perf system tune
env/bin/python -m perf timeit -o FILE.json -v '[]'


My first attempt:

$ env/bin/python -m perf compare_to ref.json patch.json 
Mean +- std dev: [ref] 20.6 ns +- 0.1 ns -> [patch] 22.4 ns +- 0.1 ns: 1.09x 
slower (+9%)

The addition of the _PyTraceMalloc_NewReference() call which does nothing 
(check tracing flag, return) adds 1.7 ns: it's not negligible on such 
micro-benchmark, and I would prefer to avoid it whenever possible since 
_Py_NewReference() is the root of the free list optimization.


New attempt: expose tracemalloc_config and add _Py_unlikely() macro (instruct 
the compiler that tracing is false most of the time):

Mean +- std dev: [ref] 20.6 ns +- 0.1 ns -> [unlikely] 20.4 ns +- 0.3 ns: 1.01x 
faster (-1%)

Good! The overhead is now negligible!


But... is the hardcore low-level _Py_unlikely() optimization really needed?...

$ env/bin/python -m perf compare_to ref.json if_tracing.json 
Benchmark hidden because not significant (1): timeit

=> no, the macro is useless, so I removed it!



New benchmark to double-check on my laptop.

git checkout master
make clean; make
rm -rf env; ./python -m venv env; env/bin/python -m pip install perf
sudo env/bin/python -m perf system tune
env/bin/python -m perf timeit -o ref.json -v '[]' --rigorous

git checkout tracemalloc_newref
make clean; make
rm -rf env; ./python -m venv env; env/bin/python -m pip install perf
env/bin/python -m perf timeit -o patch.json -v '[]' --rigorous

$ env/bin/python -m perf compare_to ref.json patch.json 
Mean +- std dev: [ref] 20.8 ns +- 0.7 ns -> [patch] 20.5 ns +- 0.3 ns: 1.01x 
faster (-1%)


The std dev is a little bit high. I didn't use CPU isolation and Hexchat + 
Firefox was running in the background, *but* it seems like the mean is very 
close, and so that my PR has no significant overhead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35057] Email header refolding adds additional \r in nested parse trees

2018-10-24 Thread Michael Thies


New submission from Michael Thies :

Email header refolding in email._header_value_parser adds additional carriage 
return symbols to the end of nested parse trees, when used with an EmailPolicy 
with linesep='\r\n'. This leads to broken email headers when composing an email 
with a "To:" or "CC:" header having a comma-separated list of recipients with 
some of them containing non-ASCII characters in their DisplayName.

The bug seems to be caused by the following line (in Python 3.7):
`encoded_part = part.fold(policy=policy)[:-1] # strip nl`
(email/_header_value_parser.py, line 2629)

This line calls part.fold() / _refold_parse_tree() recursively and tries to 
remove the trailing newline, which is added by the recursive call of 
_refold_parse_tree(). Unfortunately, it fails to do so, if the length of the 
policy's line separator sequence does not equal 1. Thus, this line should be 
corrected to something like
`encoded_part = part.fold(policy=policy)[:-len(policy.linesep)] # strip nl`

--
components: email
messages: 328362
nosy: barry, michael.thies, r.david.murray
priority: normal
severity: normal
status: open
title: Email header refolding adds additional \r in nested parse trees
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35053] Enhance tracemalloc to trace properly free lists

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

Python 3.8 uses many free lists:
https://pythondev.readthedocs.io/cpython_impl_optim.html#free-lists

Attached dict_wrong_traceback.py shows the bug on the dictionary of an object:

$ ./python ~/dict_wrong_traceback.py 
  File "/home/vstinner/dict_wrong_traceback.py", line 13
p = Point() # first object (dead!)
  File "/home/vstinner/dict_wrong_traceback.py", line 8
self.x = 1

tracemalloc shows the traceback of the first object... which has been destroyed!

With the fix:

$ ./python ~/dict_wrong_traceback.py 
  File "/home/vstinner/dict_wrong_traceback.py", line 16
p = Point() # second object (alive)
  File "/home/vstinner/dict_wrong_traceback.py", line 8
self.x = 1

It's much better: it doesn't show dead objects anymore :-)

--
Added file: https://bugs.python.org/file47889/dict_wrong_traceback.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert PyObject_INIT() and _Py_NewReference() to inlined functions

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
keywords: +patch
pull_requests: +9410
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35056] Test leaks of memory not managed by Python allocator

2018-10-24 Thread Xiang Zhang


Change by Xiang Zhang :


--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35058] Unable to Install Python on Windows

2018-10-24 Thread Steve Dower


Steve Dower  added the comment:

That's unfortunate that you can't find the log files. Without them, there's 
nothing we can do to help.

Can you try running the installer again? On the last (error) page there should 
be a link to the main log file.

--
versions: +Python 3.7 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert PyObject_INIT() and _Py_NewReference() to inlined functions

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +9413

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
title: Convert PyObject_INIT() and _Py_NewReference() to inlined functions -> 
Convert Py_INCREF() and PyObject_INIT() to inlined functions

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

Context: I was unhappy with _Py_NewReference() macro implementation when I had 
to modify it to fix a bug, bpo-35053. That's why I would like to convert it to 
a static inline function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35053] Enhance tracemalloc to trace properly free lists

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

While writing PR 10063, I was unhappy with _Py_NewReference() macro, and so I 
wrote bpo-35059 to convert it to a static inline function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert PyObject_INIT() and _Py_NewReference() to inlined functions

2018-10-24 Thread STINNER Victor


New submission from STINNER Victor :

CPython has been created in 1990. In 1990, it made sense to use C macros. But 
nowadays, inlined functions can be used instead:

"Python versions greater than or equal to 3.6 use C89 with several select C99 
features: (...) static inline functions"
https://www.python.org/dev/peps/pep-0007/#c-dialect

I propose to convert 4 macros to inlined functions:

* PyObject_INIT(), PyObject_INIT_VAR()
* _Py_NewReference(), _Py_ForgetReference()

Advantages:

* Functions use regular C syntax
* No more corner cases ("traps") of macros
* Function arguments have a type

Drawbacks:

* Require a specific type can introduce compiler warnings if the caller doesn't 
pass the proper type (PyObject* or PyVarObject*). _Py_NewReference() and 
_Py_ForgetReference() seem to be properly used, but not PyObject_INIT() and 
PyObject_INIT_VAR().

The two attached PRs implements these changes.

--
components: Interpreter Core
messages: 328367
nosy: vstinner
priority: normal
severity: normal
status: open
title: Convert PyObject_INIT() and _Py_NewReference() to inlined functions
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35058] Unable to Install Python on Windows

2018-10-24 Thread Alex Bach


Alex Bach  added the comment:

Hi, I downloaded through this link.

https://www.python.org/ftp/python/3.7.1/python-3.7.1.exe

Also, I couldn't find any file related to Python in the Temp Folder but I've 
still attached the screenshot in case it helps.

--
Added file: https://bugs.python.org/file47890/thread.jpg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

Very strange, I tried with 3.8a and I did not get this issue.

Normally we use a pipe for stdin and stdout when we use check_output, so in 
this case, there is no relation with the size of the terminal. this is just a 
stream.

second point, you explain that you use python 3.5, could you try with 3.6 or 
3.7 because 3.5 is in security mode and we won't work on this issue.

Thank you

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35053] Enhance tracemalloc to trace properly free lists

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

Even if Python 3.6 and 3.7 are impacted by the bug, I propose to only fix 
Python 3.8 since the change modifies a _Py_NewReference() function which is 
critical for performance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35047] Better error messages in unittest.mock

2018-10-24 Thread Petter S


Petter S  added the comment:

(The example above should have been "m.assert_has_calls([mock.call(3)])" but it 
does not affect my point.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17305] IDNA2008 encoding is missing

2018-10-24 Thread Johannes Frank


Change by Johannes Frank :


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35058] Unable to Install Python on Windows

2018-10-24 Thread Steve Dower


Steve Dower  added the comment:

In your %TEMP% directory there will be some log files starting with "Python". 
Could you find and attach them to this bug so we can take a look?

Also, could you provide the link to the download you used? Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert PyObject_INIT() and _Py_NewReference() to inlined functions

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +9412

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

#33766 was about documenting the C tokenizer change, some years ago, that made 
end-of-file EOF and end-of-string EOS generate the NEWLINE token required to 
properly terminate statements.  "The end of input also serves
as an implicit terminator for the final physical line."

Although the tokenizer module intentionally does not exactly mirror the C 
tokenizer (it adds COMMENT tokens), it plausibly seems like a bug that it was 
not changed along with the C tokenizer, as it has since been tokenizing valid 
code as grammatically invalid.  But I agree that this fix is too disruptive for 
2.7.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Edward Pratt


New submission from Edward Pratt :

I am looking for a string inside of a process, and it seems that the output of 
the check_output command depends on the screen size of the terminal I run the 
code in. 

Here I ran the code with a normal screen resolution:
>>> result = subprocess.check_output(['ps', 'aux']).decode('ascii', 
>>> errors='ignore')
>>> 'app-id' in result
False
 
Then I zoom out to the point where I can barely read the text on the screen, 
and this is the output I get:
>>> result = subprocess.check_output(['ps', 'aux']).decode('ascii', 
>>> errors='ignore')
>>> 'app-id' in result
True

--
components: Demos and Tools
messages: 328371
nosy: epsolos
priority: normal
severity: normal
status: open
title: subprocess output seems to depend on size of terminal screen
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34895] Mark optional stdlib modules in documentation

2018-10-24 Thread Marcus

Marcus  added the comment:

My concern is that certain missing build-time dependencies do not stop the 
build but trigger an easy to miss message at the end of the build stage (only). 
Also the end user doesn't get to see this. At the same time these modules are 
sort of expected to be part of a complete Python distribution.

Two issues I see with this: 1. By omission, the distributor might inadvertently 
create an incomplete distribution. 2. The enduser, running a script (possibly 
created elsewhere) receives a standard “ModuleNotFoundError” and is left in the 
dark about its origin as the documentation seems to confirm that the affected 
module ought to be available.

$ grep -F missing.append setup.py
 missing.append('spwd')
 missing.append('readline')
 missing.append('_ssl')
 missing.append('_hashlib')
 missing.append('_sqlite3')
 missing.append('_dbm')
 missing.append('_gdbm')
 missing.append('nis')
 missing.append('_curses')
 missing.append('_curses_panel')
 missing.append('zlib')
 missing.append('zlib')
 missing.append('zlib')
 missing.append('_bz2')
 missing.append('_lzma')
 missing.append('_elementtree')
 missing.append('ossaudiodev')
 missing.append('_tkinter')
 missing.append('_uuid')

All modules in the above list are potentially affected, although some 
(ossaudiodev, nis) might be considered platform specific. Arguably 
availablility some of these modules could be perhaps turned into build-time 
requirements with opt-out mechanics.

In any case a hint to the end user debugging such issues would be rather 
helpful and a big timesaver (see initial report).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35047] Better error messages in unittest.mock

2018-10-24 Thread Petter S


Petter S  added the comment:

Sure, consider the following code:

from unittest import mock

m = mock.Mock()
m(1, 3)
m("Test", data=[42])


When I call

m.assert_not_called()

I get the following error message:

AssertionError: Expected 'mock' to not have been called. Called 2 times.

This is what I would like to improve. On the other hand, if I call

m.assert_has_calls(mock.call(3))

I get the following error:

AssertionError: Calls not found.
Expected: ['', (3,), {}]
Actual: [call(1, 3), call('Test', data=[42])]

This is great and may serve as a template for what I want to introduce.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35058] Unable to Install Python on Windows

2018-10-24 Thread Alex Bach


New submission from Alex Bach :

So I had to learn Python this semester and eventually I followed an online 
tutorial to install python on Windows 7 (64 bit). 

But during the installation, I got the error: 0x80070643: Failed to Install MSI 
Package: 

What's wrong with the installation? I even tried the x84 bit setup as well.

--
components: Windows
messages: 328366
nosy: alexbach, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Unable to Install Python on Windows
type: crash
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +9411

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34424] Unicode names break email header

2018-10-24 Thread R. David Murray


R. David Murray  added the comment:

Michael, if you could check if Jens patch fixes your problem I would appreciate 
it.

--
nosy: +michael.thies

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset a1f45ec73f0486b187633e7ebc0a4f559d29d7d9 by Benjamin Peterson 
(Tal Einat) in branch '2.7':
bpo-33899: Revert tokenize module adding an implicit final NEWLINE (GH-10072)
https://github.com/python/cpython/commit/a1f45ec73f0486b187633e7ebc0a4f559d29d7d9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23460] Decimals do not obey ':g' exponential notation formatting rules

2018-10-24 Thread Sergey Fedoseev


Change by Sergey Fedoseev :


--
nosy: +sir-sigurd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Eryk Sun


Eryk Sun  added the comment:

This is due to the ps command itself. You'd have the same problem when piping 
to grep or redirecting output to a file. I don't know how it determines 
terminal size. I tried overriding stdin, stdout and stderr to pipes and calling 
setsid() in the forked child process to detach from the controlling terminal, 
but it still detected the terminal size. Anyway, the "ww" option of ps 
overrides this behavior.

--
nosy: +eryksun
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33015] Fix function cast warning in thread_pthread.h

2018-10-24 Thread Gregory P. Smith


Gregory P. Smith  added the comment:

I left comments on the github PRs with reasons why, but PR 6008 seems correct.  
PR 10057 would leave us with undefined behavior.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35049] argparse.ArgumentParser fails on arguments with leading dash and comma

2018-10-24 Thread paul j3


Change by paul j3 :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35049] argparse.ArgumentParser fails on arguments with leading dash and comma

2018-10-24 Thread paul j3


paul j3  added the comment:

I think it's the same issue. A dash argument that is not clearly a number is 
interpreted as an optional's flag.  With few exceptions, the parser does not 
examine the contents of the string

It tests the initial character, it tests for space, it tests for numbers (I'm 
not sure scientific notation is accepted).  That's about it.

Argparse has a minimum of constrains on what is a valid flag string.  For 
example, the following is ok:

parser.add_argument('-1,2')
# appearing the namespace as: Namespace(**{'1,2': None})

--
nosy: +paul.j3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-10-24 Thread Gregory P. Smith


Change by Gregory P. Smith :


--
nosy: +gregory.p.smith
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33015] Fix function cast warning in thread_pthread.h

2018-10-24 Thread Gregory P. Smith


Gregory P. Smith  added the comment:

This is presumably also present in 3.6 and 2.7 so I've tagged those on the 
issue, but for this kind of change i'd leave it up to release managers to see 
if they want to backport something of this nature that late in those release 
cycles.

Observable side effect: It adds a small memory allocation & free around every 
thread creation and an additional small C stack frame.  I do not expect that to 
be observable performance wise given CPython threading not being a high 
performer thanks to the GIL anyways.

--
versions: +Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

just one question, did you use this command in the REPL?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34424] Unicode names break email header

2018-10-24 Thread R. David Murray


R. David Murray  added the comment:

I've requested some small changes on the PR.  If Jens doesn't respond in 
another week or so someone else could pick it up.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35051] Fix pep8 on Lib/turtledemo module

2018-10-24 Thread Brett Cannon


Change by Brett Cannon :


--
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35047] Better error messages in unittest.mock

2018-10-24 Thread Emmanuel Arias


Emmanuel Arias  added the comment:

I think that is a good change. 

Maybe you can apply the change on 3.6, 3.7 and 3.8

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Edward Pratt

Edward Pratt  added the comment:

You are correct. It works as expected outside of the REPL.

> On Oct 24, 2018, at 4:34 PM, Stéphane Wirtel  wrote:
> 
> 
> Stéphane Wirtel  added the comment:
> 
> My script:
> 
> #!/usr/bin/env python
> import pathlib
> import subprocess
> 
> output = subprocess.check_output(['ps', 'aux'])
> pathlib.Path('/tmp/ps_aux.txt').write_bytes(output)
> 
> 
> When I execute the following script in the REPL, I get your issue but for me, 
> it's normal because the REPL is running in a terminal with a limited size. 
> 
> And when I execute the same script like as a simple python script, I don't 
> have your issue.
> 
> --
> status: closed -> open
> 
> ___
> Python tracker 
> 
> ___

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35057] Email header refolding adds additional \r in nested parse trees

2018-10-24 Thread R. David Murray


R. David Murray  added the comment:

Thank you for the report.  This is a duplicate of #34424, which has a PR.

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Edward Pratt

Edward Pratt  added the comment:

I don’t think that is true. I tried grepping for what I need in a very small 
terminal and still got the correct result.

> On Oct 24, 2018, at 1:40 PM, Eryk Sun  wrote:
> 
> 
> Eryk Sun  added the comment:
> 
> This is due to the ps command itself. You'd have the same problem when piping 
> to grep or redirecting output to a file. I don't know how it determines 
> terminal size. I tried overriding stdin, stdout and stderr to pipes and 
> calling setsid() in the forked child process to detach from the controlling 
> terminal, but it still detected the terminal size. Anyway, the "ww" option of 
> ps overrides this behavior.
> 
> --
> nosy: +eryksun
> resolution:  -> third party
> stage:  -> resolved
> status: open -> closed
> 
> ___
> Python tracker 
> 
> ___

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

My script:

#!/usr/bin/env python
import pathlib
import subprocess

output = subprocess.check_output(['ps', 'aux'])
pathlib.Path('/tmp/ps_aux.txt').write_bytes(output)


When I execute the following script in the REPL, I get your issue but for me, 
it's normal because the REPL is running in a terminal with a limited size. 

And when I execute the same script like as a simple python script, I don't have 
your issue.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-24 Thread Raymond Hettinger


Change by Raymond Hettinger :


--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32285] In `unicodedata`, it should be possible to check a unistr's normal form without necessarily copying it

2018-10-24 Thread Maxime Belanger


Change by Maxime Belanger :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

rhettinger: "status: open -> closed"

I guess that https://github.com/python/cpython/pull/10002 should be closed as 
well?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35061] Specify libffi.so soname for ctypes

2018-10-24 Thread Yongkwan Kim


New submission from Yongkwan Kim :

As python 3.7 excludes libffi from it's package, my build on centos6 doesn't 
work on centos7. Error message is following.

ImportError: libffi.so.5: cannot open shared object file: No such file or 
directory

centos7 have libffi.so.6 instead of libffi.so.5 as does centos6. I hope to 
specify libffi version with libffi.so. I figured out that any configure option  
can fix this through seeing setup.py .

Thanks in advance.

--
messages: 328406
nosy: tturbs
priority: normal
severity: normal
status: open
title: Specify libffi.so soname for ctypes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Ned Deily


Change by Ned Deily :


--
pull_requests:  -9411

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Ned Deily


Change by Ned Deily :


--
pull_requests:  -9415

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-24 Thread Xiang Zhang


New submission from Xiang Zhang :

io.IncrementalNewlineDecoder gets a *translate* bitwise struct field, but it 
could be assigned arbitrary int value. This leads to inconsistent behaviour, 
evens are evaluated to False and odds to True.

>>> io.IncrementalNewlineDecoder(encodings.utf_8.IncrementalDecoder(), 
>>> 4).decode(b"abcd\r\n")
u'abcd\r\n'
>>> io.IncrementalNewlineDecoder(encodings.utf_8.IncrementalDecoder(), 
>>> 5).decode(b"abcd\r\n")
u'abcd\n'

--
components: IO
messages: 328407
nosy: xiang.zhang
priority: normal
severity: normal
stage: needs patch
status: open
title: io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct 
field
type: behavior
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 5ad36f9b21a3aa3b2265b1b43d73522cc3322df2 by Victor Stinner 
(serge-sans-paille) in branch 'master':
bpo-28015: Support LTO build with clang (GH-9908)
https://github.com/python/cpython/commit/5ad36f9b21a3aa3b2265b1b43d73522cc3322df2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33015] Fix function cast warning in thread_pthread.h

2018-10-24 Thread Benjamin Peterson


Benjamin Peterson  added the comment:

Shall we introduce a new thread-starting API that takes a function with the 
"correct" pthread signature? It seems like Windows already allocates.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

2018-10-24 Thread miss-islington


Change by miss-islington :


--
pull_requests: +9417, 9418

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

2018-10-24 Thread miss-islington


Change by miss-islington :


--
pull_requests: +9417

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

2018-10-24 Thread miss-islington


miss-islington  added the comment:


New changeset 69a3f153a92fd8c86080e8da477ee50df18fc0d1 by Miss Islington (bot) 
in branch '3.7':
bpo-28015: Support LTO build with clang (GH-9908)
https://github.com/python/cpython/commit/69a3f153a92fd8c86080e8da477ee50df18fc0d1


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

2018-10-24 Thread Benjamin Peterson


Benjamin Peterson  added the comment:

Does this slow down debug builds at all? It probably will not end will if 
Py_INCREF is ever not inlined.

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Stéphane Wirtel

Change by Stéphane Wirtel :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35060] subprocess output seems to depend on size of terminal screen

2018-10-24 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

Here is the doc from ps with man.

> man ps

If ps cannot determine display width, as when output is redirected (piped) into 
a file or another command, the output width is undefined (it may be 80, 
unlimited, determined by the TERM variable, and so on).  The COLUMNS 
environment variable or --cols option may be used to exactly determine the 
width in this case.  The w or -w option may be also be used to adjust width.

-w Wide output.  Use this option twice for unlimited width.


So for my part, in my terminal, the COLUMNS envvar is different in function of 
the size of my window, from 86 to 131 etc...

so, I think we can definitively close this issue.

Thank you,

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34260] shutil.copy2 is not the same as cp -p

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 4a59c9699ca8688359c460f98127a12e2db6e63b by Victor Stinner (Zsolt 
Cserna) in branch '2.7':
[2.7] bpo-34260, shutil: fix copy2 and copystat documentation (GH-8523) 
(GH-10071)
https://github.com/python/cpython/commit/4a59c9699ca8688359c460f98127a12e2db6e63b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34260] shutil.copy2 is not the same as cp -p

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

Thanks Zsolt Cserna for the report and for the documentation enhancements! The 
doc is now way better.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34272] Reorganize C API tests

2018-10-24 Thread Daniel Pope


Change by Daniel Pope :


--
pull_requests: +9414

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35039] remove unused vars in Lib/turtledemo module

2018-10-24 Thread STINNER Victor

STINNER Victor  added the comment:

Thanks శ్రీనివాస్ రెడ్డి తాటిపర్తి for your fix ;-)

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35039] remove unused vars in Lib/turtledemo module

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-24 Thread STINNER Victor


Change by STINNER Victor :


--
nosy: +eric.snow, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

2018-10-24 Thread Aaron Hall


Change by Aaron Hall :


--
nosy: +Aaron Hall

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset e80e77a484983ffb527ef22d336ff9500589dce3 by Victor Stinner 
(TilmanK) in branch 'master':
bpo-35027, distutils doc: Correct note on setup.py change in Python 3.7 
(GH-10032)
https://github.com/python/cpython/commit/e80e77a484983ffb527ef22d336ff9500589dce3


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

2018-10-24 Thread miss-islington


Change by miss-islington :


--
pull_requests: +9416

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

2018-10-24 Thread miss-islington


miss-islington  added the comment:


New changeset f2679afda06d1eeaf34852e49bbcf4fb39736d19 by Miss Islington (bot) 
in branch '3.7':
bpo-35027, distutils doc: Correct note on setup.py change in Python 3.7 
(GH-10032)
https://github.com/python/cpython/commit/f2679afda06d1eeaf34852e49bbcf4fb39736d19


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34866] CGI DOS vulnerability via long post list

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

For 3.7 an 3.6 changes, you have to specify the minor Python version (3.7.x and 
3.6.x) in which the change has been introduce. Same comment for Python 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tim Graham


Change by Tim Graham :


--
pull_requests: +9415

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14117] Turtledemo: exception and minor glitches.

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

See also bpo-35039 which removed now useless clock() calls from 
Lib/turtledemo/penrose.py.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34866] CGI DOS vulnerability via long post list

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

> https://github.com/python/cpython/commit/209144831b0a19715bda3bd72b14a3e6192d9cc1

This commit adds a new max_num_fields=None parameter to FieldStorage, 
parse_qs() and parse_qsl(): you must update the documentation in Doc/library/ 
as well.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31553] Extend json.tool to handle jsonlines (with a flag)

2018-10-24 Thread STINNER Victor


STINNER Victor  added the comment:

> The output is not a valid JSON format, and is not a valid JSON Lines format. 
> What you are going to do with it?

It looks useful to me to read a nicely indented JSON in the terminal (without 
specifying an output file). It's more readable that compact JSON on a single 
line.

But should we add an option to write the output on a single line? It would be 
the opposite of the tool description:
"A simple command line interface for json module to validate and *pretty-print* 
JSON objects."

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-10-24 Thread Michael Airey


Michael Airey  added the comment:

Try this - https://github.com/siddhesh/cpython/tree/func-cast

--
nosy: +resmord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field

2018-10-24 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35058] Unable to Install Python on Windows

2018-10-24 Thread Michael Airey


Michael Airey  added the comment:

Did you try to use SubInACL tool by Microsoft? Perhaps, it can fix your issue. 
Here, I'm adding references for the same i.e. download link & guide (Method 
#13) to use it:

1. https://www.microsoft.com/en-in/download/details.aspx?id=23510

2. https://validedge.com/0x80070643/

--
nosy: +resmord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35050] Off-by-one bug in AF_ALG

2018-10-24 Thread Michael Airey


Michael Airey  added the comment:

The error checking code for salg_name and salg_type have an off-by-one bug. 
Must check that both strings are NUL terminated strings.

--
nosy: +resmord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Tal Einat  added the comment:

See PR GH-10072 for reverting in 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Change by Tal Einat :


--
pull_requests: +9406

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Gregory P. Smith


Gregory P. Smith  added the comment:

FYI, An example of other fallout from this change - patsy broke and needed this 
fix:

https://github.com/pydata/patsy/commit/4f53bbaf58c0bf1a9bed73fc67c7c6d0aa7f4e20#diff-53c70e68c6dfd4fe9b08427792cb2bd6

--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Change by Tal Einat :


--
pull_requests: +9407

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Gregory P. Smith


Gregory P. Smith  added the comment:


New changeset dfba1f67e7f1381ceb7cec8fbcfa37337620a9b0 by Gregory P. Smith (Tal 
Einat) in branch 'master':
bpo-33899: Mention tokenize behavior change in What's New (GH-10073)
https://github.com/python/cpython/commit/dfba1f67e7f1381ceb7cec8fbcfa37337620a9b0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Change by Tal Einat :


--
pull_requests: +9408

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Tal Einat  added the comment:

See PR GH-10073 adding mention in "What's New".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Gregory P. Smith


Gregory P. Smith  added the comment:

some pylint fallout appears to be addressed in 
https://github.com/PyCQA/pylint/commit/2698cbe56b44df7974de1c3374db8700296c6fad

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Change by Tal Einat :


--
pull_requests: +9409

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread miss-islington


miss-islington  added the comment:


New changeset b4c9874f5c7f64e1d41cbc588e515b8851bbb90c by Miss Islington (bot) 
(Tal Einat) in branch '3.7':
[3.7] bpo-33899: Mention tokenize behavior change in What's New (GH-10073) 
(GH-10074)
https://github.com/python/cpython/commit/b4c9874f5c7f64e1d41cbc588e515b8851bbb90c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread miss-islington


miss-islington  added the comment:


New changeset 9a0476283393f9988d0946491052d7724a7f9d21 by Miss Islington (bot) 
(Tal Einat) in branch '3.6':
[3.6] bpo-33899: Mention tokenize behavior change in What's New (GH-10073) 
(GH-10075)
https://github.com/python/cpython/commit/9a0476283393f9988d0946491052d7724a7f9d21


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-24 Thread Tal Einat


Tal Einat  added the comment:

Thanks for helping with the fallout from this, Gregory.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com