Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
Le 02/08/2022 à 09:56, Thomas Huth a écrit : The note about the removal of '-soundhw' has been accidentally added to the section of removed "linux-user mode CPUs" ... it should reside in the section about removed "System emulator command line arguments" instead. Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw") Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index c7b9dadd5d..925e22016f 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -396,6 +396,13 @@ Use ``-display sdl`` instead. Use ``-display curses`` instead. +Creating sound card devices using ``-soundhw`` (removed in 7.1) +''' + +Sound card devices should be created using ``-device`` or ``-audio``. +The exception is ``pcspk`` which can be activated using ``-machine +pcspk-audiodev=``. + QEMU Machine Protocol (QMP) commands @@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite broken. For that reason the maintainers strongly suspected no one actually used it. -Creating sound card devices using ``-soundhw`` (removed in 7.1) -''' - -Sound card devices should be created using ``-device`` or ``-audio``. -The exception is ``pcspk`` which can be activated using ``-machine -pcspk-audiodev=``. - TCG introspection features -- Applied to my trivial-patches branch. Thanks, Laurent
Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
On Dienstag, 2. August 2022 09:56:11 CEST Thomas Huth wrote: > The note about the removal of '-soundhw' has been accidentally added > to the section of removed "linux-user mode CPUs" ... it should reside > in the section about removed "System emulator command line arguments" > instead. > > Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw") > Signed-off-by: Thomas Huth > --- Reviewed-by: Christian Schoenebeck That can easily happen unfortunately, as the hierarchy syntax here, like in MAINTAINERS BTW, is not exactly perfect for the human eye. > docs/about/removed-features.rst | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/docs/about/removed-features.rst > b/docs/about/removed-features.rst index c7b9dadd5d..925e22016f 100644 > --- a/docs/about/removed-features.rst > +++ b/docs/about/removed-features.rst > @@ -396,6 +396,13 @@ Use ``-display sdl`` instead. > > Use ``-display curses`` instead. > > +Creating sound card devices using ``-soundhw`` (removed in 7.1) > +''' > + > +Sound card devices should be created using ``-device`` or ``-audio``. > +The exception is ``pcspk`` which can be activated using ``-machine > +pcspk-audiodev=``. > + > > QEMU Machine Protocol (QMP) commands > > @@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite > broken. For that reason the maintainers strongly suspected no one actually > used it. > > > -Creating sound card devices using ``-soundhw`` (removed in 7.1) > -''' > - > -Sound card devices should be created using ``-device`` or ``-audio``. > -The exception is ``pcspk`` which can be activated using ``-machine > -pcspk-audiodev=``. > - > TCG introspection features > --
Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
On Tue, Aug 02, 2022 at 09:56:11AM +0200, Thomas Huth wrote: > The note about the removal of '-soundhw' has been accidentally added > to the section of removed "linux-user mode CPUs" ... it should reside > in the section about removed "System emulator command line arguments" > instead. > > Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw") > Signed-off-by: Thomas Huth > --- > docs/about/removed-features.rst | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|