Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On 13 March 2018 at 22:46, Paolo Bonzini wrote: > Not sure why this didn't make it to the list yesterday---most likely I > didn't remove --dry-run... Now I understand why everybody was waiting > for my pull request. > > The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 > 13:21:53 +) > > are available in the Git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 0790f86861079b1932679d0f011e431aaf4ee9e2: > > tcg: fix cpu_io_recompile (2018-03-12 17:10:38 +0100) > > > * Record-replay lockstep execution, log dumper and fixes (Alex, Pavel) > * SCSI fix to pass maximum transfer size (Daniel Barboza) > * chardev fixes and improved iothread support (Daniel Berrangé, Peter) > * checkpatch tweak (Eric) > * make help tweak (Marc-André) > * make more PCI NICs available with -net or -nic (myself) > * change default q35 NIC to e1000e (myself) > * SCSI support for NDOB bit (myself) > * membarrier system call support (myself) > * SuperIO refactoring (Philippe) > * miscellaneous cleanups and fixes (Thomas) > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On 14/03/2018 12:30, Eric Blake wrote: > On 03/14/2018 05:12 AM, Paolo Bonzini wrote: > Checking PATCH 16/69: chardev: tcp: postpone async connection setup... Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context... >>> >>> It seems that Dan's last patch is still missing in the pull >>> request: >>> >>> http://patchwork.ozlabs.org/patch/883155/ >> >> Yes, this is a pull request I prepared last Monday and forgot to send. >> I'll send that out separately, it's a bugfix so it can be submitted >> after soft freeze. > > Or, since my pre-freeze QAPI pull request needs a v2, I can include it > there, if I have an ACK or R-b by Paolo. Sure, go ahead and include it! Paolo
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On Wed, Mar 14, 2018 at 06:30:33AM -0500, Eric Blake wrote: > On 03/14/2018 05:12 AM, Paolo Bonzini wrote: > > > > > Checking PATCH 16/69: chardev: tcp: postpone async connection setup... > > > > Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context... > > > > > > It seems that Dan's last patch is still missing in the pull > > > request: > > > > > > http://patchwork.ozlabs.org/patch/883155/ > > > > Yes, this is a pull request I prepared last Monday and forgot to send. > > I'll send that out separately, it's a bugfix so it can be submitted > > after soft freeze. > > Or, since my pre-freeze QAPI pull request needs a v2, I can include it > there, if I have an ACK or R-b by Paolo. Yeah, both would work for me. I'll just leave the decision to you maintainers. Anyways, my thanks to both of you on your help! -- Peter Xu
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On 03/14/2018 05:12 AM, Paolo Bonzini wrote: Checking PATCH 16/69: chardev: tcp: postpone async connection setup... Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context... It seems that Dan's last patch is still missing in the pull request: http://patchwork.ozlabs.org/patch/883155/ Yes, this is a pull request I prepared last Monday and forgot to send. I'll send that out separately, it's a bugfix so it can be submitted after soft freeze. Or, since my pre-freeze QAPI pull request needs a v2, I can include it there, if I have an ACK or R-b by Paolo. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On 14/03/2018 04:35, Peter Xu wrote: > On Tue, Mar 13, 2018 at 05:15:41PM -0700, no-re...@patchew.org wrote: > > [...] > >> Your patch has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. >> Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic... >> Checking PATCH 3/69: q35: change default NIC to e1000e... >> Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY >> emulation... >> Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and >> -netdev hubport... >> Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame >> deprecation again... >> Checking PATCH 7/69: build-sys: make help could have 'modules' target... >> Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is >> not necessary... >> Checking PATCH 9/69: checkpatch: Exempt long URLs... >> Checking PATCH 10/69: vl: export machine_init_done... >> Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev... >> Checking PATCH 12/69: chardev: update net listener gcontext... >> Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext... >> Checking PATCH 14/69: chardev: introduce chr_machine_done hook... >> Checking PATCH 15/69: chardev: use chardev's gcontext for async connect... >> Checking PATCH 16/69: chardev: tcp: postpone async connection setup... >> Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context... > > It seems that Dan's last patch is still missing in the pull > request: > > http://patchwork.ozlabs.org/patch/883155/ Yes, this is a pull request I prepared last Monday and forgot to send. I'll send that out separately, it's a bugfix so it can be submitted after soft freeze. Paolo
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
On Tue, Mar 13, 2018 at 05:15:41PM -0700, no-re...@patchew.org wrote: [...] > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 2/69: net: allow using any PCI NICs in -net or -nic... > Checking PATCH 3/69: q35: change default NIC to e1000e... > Checking PATCH 4/69: scsi-disk.c: consider bl->max_transfer in INQUIRY > emulation... > Checking PATCH 5/69: qemu-doc: update deprecation section to use -nic and > -netdev hubport... > Checking PATCH 6/69: qemu-doc: Add the paragraph about the -no-frame > deprecation again... > Checking PATCH 7/69: build-sys: make help could have 'modules' target... > Checking PATCH 8/69: hw: Do not include "sysemu/block-backend.h" if it is not > necessary... > Checking PATCH 9/69: checkpatch: Exempt long URLs... > Checking PATCH 10/69: vl: export machine_init_done... > Checking PATCH 11/69: chardev: fix handling of EAGAIN for TCP chardev... > Checking PATCH 12/69: chardev: update net listener gcontext... > Checking PATCH 13/69: chardev: allow telnet gsource to switch gcontext... > Checking PATCH 14/69: chardev: introduce chr_machine_done hook... > Checking PATCH 15/69: chardev: use chardev's gcontext for async connect... > Checking PATCH 16/69: chardev: tcp: postpone async connection setup... > Checking PATCH 17/69: chardev: tcp: let TLS run on chardev context... It seems that Dan's last patch is still missing in the pull request: http://patchwork.ozlabs.org/patch/883155/ I hope the monitor-oob series can survive the qtests even without that single patch... Thanks, -- Peter Xu
Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180313224719.4954-1-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180313224719.4954-1-pbonz...@redhat.com -> patchew/20180313224719.4954-1-pbonz...@redhat.com Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Switched to a new branch 'test' 20b2d41547 tcg: fix cpu_io_recompile c46131d9ac replay: update documentation ebbeee6c00 replay: save vmstate of the asynchronous events 6a1d180135 replay: don't process async events when warping the clock d878031ce3 scripts/replay-dump.py: replay log dumper fa49388d29 replay: avoid recursive call of checkpoints 8425f8a33b replay: check return values of fwrite 0c4cf018d7 replay: push replay_mutex_lock up the call tree eedffef5df replay: don't destroy mutex at exit a4649842a9 replay: make locking visible outside replay code 1570edbbd5 replay/replay-internal.c: track holding of replay_lock e6d2f97e40 replay/replay.c: bump REPLAY_VERSION again c0d71df05c replay: save prior value of the host clock a7c57184b1 replay: added replay log format description 39eaf489fd replay: fix save/load vm for non-empty queue 980235a32e replay: fixed replay_enable_events a846c03323 replay: fix processing async events 9f1d12928e cpu-exec: fix exception_index handling 1d6e886906 hw/i386/pc: Factor out the superio code e24291717f hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO 1c75546a89 hw/alpha/dp264: Add the ISA DMA controller 8ccab0e5cc hw/isa/superio: Add the SMC FDC37C669 Super I/O 0638def1b5 MAINTAINERS: Split the Alpha TCG/machine section fc68e597c6 MAINTAINERS: Add entries for the VT82C686B Super I/O 354da50497 hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO 66ca3f335d hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init() 112b337ef0 hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init() 547f28856f hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c 048338438b hw/mips/malta: Code movement 898bc44d9f hw/isa/superio: Factor out the IDE code from pc87312.c 649c8ee02e hw/isa/superio: Add a keyboard/mouse controller (8042) 2f0ca2c71c hw/isa/superio: Factor out the floppy disc controller code from pc87312.c 84a2f1940f hw/isa/superio: Factor out the serial code from pc87312.c 744cf074a8 hw/isa/superio: Factor out the parallel code from pc87312.c 3ecb08902c hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO 3ad09fdf2c hw/isa/superio: Add a Super I/O template based on the PC87312 device 06a0adcfd8 hw/isa/pc87312: Use 'unsigned int' for the irq value 5479558c92 hw/isa/pc87312: Use uint16_t for the ISA I/O base address 1ca2ae2991 hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO 25e755167f MAINTAINERS: Fix the PC87312 include path f829b02d47 hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h 5e6c657232 hw/dma/i8257: Rename DMA_init() to i8257_dma_init() 922053d83d hw/isa: Move parallel_hds_isa_init() to hw/char/parallel-isa.c 18e14e69b7 membarrier: add --enable-membarrier 136b6f0343 membarrier: introduce qemu/sys_membarrier.h 7be9740f48 rcu: make memory barriers more explicit 9f4445960c docs: document atomic_load_acquire and atomic_store_release f14149cb0a rcutorture: remove synchronize_rcu from readers 71d22958d8 hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices 5cd7037170 Polish the version strings containing the package version 0a13467c66 hw/i386: make IOMMUs configurable via default-configs/ 4eec1790b5 scsi: support NDOB (no data-out buffer) for WRITE SAME commands a5dd7aaf89 chardev: tcp: let TLS run on chardev context 0058402907 chardev: tcp: postpone async connection setup 189e98e5db chardev: use chardev's gcontext for async connect 6c6f38627f chardev: introduce chr_machine_done hook 498f244334 chardev: allow telnet gsource to switch gcontext eee9ff412a chardev: update net listener gcontext 0fdbf8e1ce chardev: fix handling of EAGAIN for TCP chardev a7967d2420 vl: export machine_init_done 1d2d7c57f1 checkpatch: Exempt long URLs 835403d319 hw: Do not include "sysemu/block-backend.h" if it is not necessary b1502c478e build-sys: make help could have 'modules' target b3b603a323 qemu-doc: Add the paragraph about the