Re: [Qgis-developer] Header files order
On Sun, Apr 21, 2013 at 9:50 AM, Martin Dobias wrote: > On Sat, Apr 20, 2013 at 10:18 AM, Radim Blazek wrote: >> do you agree with that order (least specific -> most specific) extend >> for system etc (each section sorted lexically): >> >> * system headers >> * standard libraries headers >> * qt headers >> * other 3rd party libraries headers >> * qgis headers > > Personally I do not care so much about the order of the sections. I > would say we should just: > 1. #include the corresponding header file first (e.g. for abc.cpp the > first include should be #include "abc.h") to ensure that the header > file does not have some hidden include dependencies > 2. keep each section sorted > > Anyway the least specific -> most specific order makes more sense than > the opposite order. I have modified the manual in this sense. Radim > Martin ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Header files order
On Sat, Apr 20, 2013 at 10:18 AM, Radim Blazek wrote: > do you agree with that order (least specific -> most specific) extend > for system etc (each section sorted lexically): > > * system headers > * standard libraries headers > * qt headers > * other 3rd party libraries headers > * qgis headers Personally I do not care so much about the order of the sections. I would say we should just: 1. #include the corresponding header file first (e.g. for abc.cpp the first include should be #include "abc.h") to ensure that the header file does not have some hidden include dependencies 2. keep each section sorted Anyway the least specific -> most specific order makes more sense than the opposite order. Martin ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
[Qgis-developer] Header files order
I would like to be sure about the right header files order we prefer. Developer manual [1] example is using: * qt headers * qgis headers do you agree with that order (least specific -> most specific) extend for system etc (each section sorted lexically): * system headers * standard libraries headers * qt headers * other 3rd party libraries headers * qgis headers or do most people prefer reverted order (most specific -> least specific): * qgis headers * other 3rd party libraries headers * qt headers * standard libraries headers * system headers The pros for each one may be found in many threads on web. Radim [1] http://hub.qgis.org/wiki/quantum-gis/Developers_Manual ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
