Re: Issue 3467 in reviewboard: Server error when viewing certain posted reviews

2014-07-06 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 3467 by trowb...@gmail.com: Server error when viewing  
certain posted reviews

http://code.google.com/p/reviewboard/issues/detail?id=3467

Fixed in release-2.0.x (f4043f5). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-06 Thread reviewboard

Updates:
Status: Confirmed
Labels: -Type-Defect Type-Enhancement Component-Reviews

Comment #1 on issue 3462 by chip...@gmail.com: Ability to take back a  
ship-it.

http://code.google.com/p/reviewboard/issues/detail?id=3462

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3468 in reviewboard: mimeparse changed its name to python-mimeparse in version 0.1.4

2014-07-06 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3468 by chip...@gmail.com: mimeparse changed its name  
to python-mimeparse in version 0.1.4

http://code.google.com/p/reviewboard/issues/detail?id=3468

This doesn't seem to be the case with the official mimeparse module. I  
don't see it locally when I upgrade, nor do I see any relevant changes in  
their source code.


Are you installing this straight from Arch Linux's package repository? If  
so, it's a problem on their end.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3463 in reviewboard: Problem with Active Directory authentication after update

2014-07-06 Thread reviewboard

Updates:
Status: SetupIssue

Comment #1 on issue 3463 by chip...@gmail.com: Problem with Active  
Directory authentication after update

http://code.google.com/p/reviewboard/issues/detail?id=3463

This generally happens if you install via pip instead of easy_install, or  
if you have some other strange dependency issues due to any manual  
installation/uninstallation of packages out of order. Either way, it's  
always a local configuration or usage issue, rather than a bug in Review  
Board. (If it were a bug anywhere, it'd be in Python Setuptools, but this  
isn't what we've seen in these cases.)


Removing and re-installing the Review Board package should fix this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3468 in reviewboard: mimeparse changed its name to python-mimeparse in version 0.1.4

2014-07-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3468 by michael@googlemail.com: mimeparse changed its name to  
python-mimeparse in version 0.1.4

http://code.google.com/p/reviewboard/issues/detail?id=3468

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.2


What's the URL of the page containing the problem?
https://github.com/reviewboard/reviewboard/blob/master/setup.py#L203


What steps will reproduce the problem?
1. Install Reviewboard and all dependencies
2. run rb-site install

What is the expected output? What do you see instead?
A site should be generated.
Instead, an error is issued, that the package `reviewboard' cannot be found  
as required.


What operating system are you using? What browser?
Arch Linux, updated 2014-07-05

Please provide any additional information below.
When python-mimeparse is installed in version 0.1.4 or above, the egg-info  
file is calle python-mimeparse.  If `python-mimeparse' is required or the  
egg-info file is moved from python-mimeparse to mimeparse, rb-site does not  
throw this error any more.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3466 in reviewboard: Diff word wrapping appears to fail in some cases

2014-07-06 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 3309

Comment #2 on issue 3466 by chip...@gmail.com: Diff word wrapping appears  
to fail in some cases

http://code.google.com/p/reviewboard/issues/detail?id=3466

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-07-06 Thread reviewboard


Comment #5 on issue 3309 by chip...@gmail.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

Issue 3466 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3467 in reviewboard: Server error when viewing certain posted reviews

2014-07-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3467 by sourto...@gmail.com: Server error when viewing certain  
posted reviews

http://code.google.com/p/reviewboard/issues/detail?id=3467

What version are you running?

2.0.2

What's the URL of the page containing the problem?

https://git.reviewboard.kde.org/r/112294/
(Please don't visit this excessively, we get an email for each internal  
error Reviewboard encounters)


What steps will reproduce the problem?
1. Post a diff which contains certain characters which the ASCII character  
set cannot encode.


What is the expected output? What do you see instead?

Normal diff view page.

What operating system are you using? What browser?

Issue is a server error. Using Python 2.7.3 on Linux.

Please provide any additional information below.

Relevant part of the backtrace:

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/models.py",  
line 58, in recalculate_line_counts

files = tool.get_parser(self.binary).parse()

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/git.py",  
line 181, in parse

preamble += self.lines[i] + '\n'

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 24:  
ordinal not in range(128)


===

Patching  
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/scmtools/git.py  
as follows appears to fix the issue:


preamble += unicode(self.lines[i], 'utf-8') + '\n'

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.