Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59103/#review174424
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 9, 2017, 5:02 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59103/
> ---
> 
> (Updated May 9, 2017, 5:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20968
> https://issues.apache.org/jira/browse/AMBARI-20968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After "ember-precompile-brunch" package has been changed from "1.5.1" to 
> "0.1.0", ember fails to resolve view templates results in pig and capshed 
> views fails to render. This patch adds custom resolver to fix the issue.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> 
> Diff: https://reviews.apache.org/r/59103/diff/1/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/#review174420
---


Ship it!




- Jayush Luniya


On May 10, 2017, 12:21 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59113/
> ---
> 
> (Updated May 10, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20974
> https://issues.apache.org/jira/browse/AMBARI-20974
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fix to update permissions after installing an mpack
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 167f264b8f 
>   ambari-server/src/test/python/TestMpacks.py ef8194502e 
> 
> 
> Diff: https://reviews.apache.org/r/59113/diff/2/
> 
> 
> Testing
> ---
> 
> Unit Testing:
> Total run:1170
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 02:15 min
> [INFO] Finished at: 2017-05-09T14:30:43-07:00
> [INFO] Final Memory: 94M/1439M
> 
> Functional Testing:
> Install Ambari-2.5.1 using non-root ambari admin user
> Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
> Install HDF-3.0
> ambari-server restart
> Add Nifi and start service.
> Verify that the permissions are set correctly in 
> /var/lib/ambari-server/resources/mpacks, 
> /var/lib/ambari-server/resources/extensions, 
> /var/lib/ambari-server/common-services/NIFI, 
> /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/#review174407
---


Fix it, then Ship it!





ambari-server/src/main/python/ambari_server/setupMpacks.py
Lines 722 (patched)


can we use lowercase


- Alejandro Fernandez


On May 10, 2017, 12:21 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59113/
> ---
> 
> (Updated May 10, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20974
> https://issues.apache.org/jira/browse/AMBARI-20974
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fix to update permissions after installing an mpack
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 167f264b8f 
>   ambari-server/src/test/python/TestMpacks.py ef8194502e 
> 
> 
> Diff: https://reviews.apache.org/r/59113/diff/2/
> 
> 
> Testing
> ---
> 
> Unit Testing:
> Total run:1170
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 02:15 min
> [INFO] Finished at: 2017-05-09T14:30:43-07:00
> [INFO] Final Memory: 94M/1439M
> 
> Functional Testing:
> Install Ambari-2.5.1 using non-root ambari admin user
> Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
> Install HDF-3.0
> ambari-server restart
> Add Nifi and start service.
> Verify that the permissions are set correctly in 
> /var/lib/ambari-server/resources/mpacks, 
> /var/lib/ambari-server/resources/extensions, 
> /var/lib/ambari-server/common-services/NIFI, 
> /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57580: Enhance Kafka Service Check

[Wang Jie]

> On 三月 14, 2017, 9:51 a.m., Dmitro Lisnichenko wrote:
> > Ship It!

Thank you so much for reviewing my patch on reviewboard, and could you commit 
the patch ? Thanks


- Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review168877
---


On 三月 14, 2017, 1:23 a.m., Wang Jie wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> ---
> 
> (Updated 三月 14, 2017, 1:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro 
> Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-20434
> https://issues.apache.org/jira/browse/AMBARI-20434
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Kafka Service Check  will create the kafka topic only if the topic doesn't 
> exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check 
> will not reflect the kafka actual state correctly
> 
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py
>  0f3a417 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml
>  0275358 
> 
> 
> Diff: https://reviews.apache.org/r/57580/diff/1/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Wang Jie
> 
>

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/
---

(Updated May 10, 2017, 12:21 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Alternative patch which filters out only the relevant directories for the 
permissions update and not the complete set contained in 
NR_ADJUST_OWNERSHIP_LIST and NR_CHANGE_OWNERSHIP_LIST


Bugs: AMBARI-20974
https://issues.apache.org/jira/browse/AMBARI-20974


Repository: ambari


Description
---

fix to update permissions after installing an mpack


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/setupMpacks.py 167f264b8f 
  ambari-server/src/test/python/TestMpacks.py ef8194502e 


Diff: https://reviews.apache.org/r/59113/diff/2/

Changes: https://reviews.apache.org/r/59113/diff/1-2/


Testing
---

Unit Testing:
Total run:1170
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 02:15 min
[INFO] Finished at: 2017-05-09T14:30:43-07:00
[INFO] Final Memory: 94M/1439M

Functional Testing:
Install Ambari-2.5.1 using non-root ambari admin user
Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
Install HDF-3.0
ambari-server restart
Add Nifi and start service.
Verify that the permissions are set correctly in 
/var/lib/ambari-server/resources/mpacks, 
/var/lib/ambari-server/resources/extensions, 
/var/lib/ambari-server/common-services/NIFI, 
/var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/#review174399
---


Ship it!




Ship It!

- Sumit Mohanty


On May 9, 2017, 10:33 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59113/
> ---
> 
> (Updated May 9, 2017, 10:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20974
> https://issues.apache.org/jira/browse/AMBARI-20974
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fix to update permissions after installing an mpack
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 04b96f52d2 
>   ambari-server/src/test/python/TestMpacks.py 32db005746 
> 
> 
> Diff: https://reviews.apache.org/r/59113/diff/1/
> 
> 
> Testing
> ---
> 
> Unit Testing:
> Total run:1170
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 02:15 min
> [INFO] Finished at: 2017-05-09T14:30:43-07:00
> [INFO] Final Memory: 94M/1439M
> 
> Functional Testing:
> Install Ambari-2.5.1 using non-root ambari admin user
> Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
> Install HDF-3.0
> ambari-server restart
> Add Nifi and start service.
> Verify that the permissions are set correctly in 
> /var/lib/ambari-server/resources/mpacks, 
> /var/lib/ambari-server/resources/extensions, 
> /var/lib/ambari-server/common-services/NIFI, 
> /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 59115: Add NIFI Admin Toolkit StackFeatures to HDP StackFeatures

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59115/#review174395
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 9, 2017, 10:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59115/
> ---
> 
> (Updated May 9, 2017, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20975
> https://issues.apache.org/jira/browse/AMBARI-20975
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add to HDP stack_features.json
> {
>"name": "admin_toolkit_support",
>"description": "Supports the nifi admin toolkit",
>"min_version": "3.0.0.0"
> },
>  {
>   "name": "tls_toolkit_san",
>   "description": "Support subject alternative name flag",
>   "min_version": "3.0.0.0"
> }
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bbd8bfcb77 
> 
> 
> Diff: https://reviews.apache.org/r/59115/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20974
https://issues.apache.org/jira/browse/AMBARI-20974


Repository: ambari


Description
---

fix to update permissions after installing an mpack


Diffs
-

  ambari-server/src/main/python/ambari_server/setupMpacks.py 04b96f52d2 
  ambari-server/src/test/python/TestMpacks.py 32db005746 


Diff: https://reviews.apache.org/r/59113/diff/1/


Testing
---

Unit Testing:
Total run:1170
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 02:15 min
[INFO] Finished at: 2017-05-09T14:30:43-07:00
[INFO] Final Memory: 94M/1439M

Functional Testing:
Install Ambari-2.5.1 using non-root ambari admin user
Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
Install HDF-3.0
ambari-server restart
Add Nifi and start service.
Verify that the permissions are set correctly in 
/var/lib/ambari-server/resources/mpacks, 
/var/lib/ambari-server/resources/extensions, 
/var/lib/ambari-server/common-services/NIFI, 
/var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

[yao lei]

> On 五月 9, 2017, 3:10 p.m., Robert Levas wrote:
> > Ship It!

Thanks for your review


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/#review174319
---


On 五月 9, 2017, 9:49 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59085/
> ---
> 
> (Updated 五月 9, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.
> 
> 
> Bugs: AMBARI-20961
> https://issues.apache.org/jira/browse/AMBARI-20961
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Create a user named test and assign Service Operator(Administrator) Role to 
> this user.
> 2.Login with this user and open Services -> Hive -> Service Actions, the menu 
> include highlight items : Add Hive Metastore and Add HiveServer2.
> Zookeeper,Hbase and other service also have the above issue.
> 
> Because Service Operator(Administrator) Role don't have 
> HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/service/item.js ac736a6 
> 
> 
> Diff: https://reviews.apache.org/r/59085/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Create five users: test1 ,test2 ,test3 ,test4 ,test5  
> 2.Assign role Cluster User to test1,
>   Service Operator to test2,
>   Service Administrator to test3,
>   Cluster Operator to test4,
>   Cluster Administrator  to test5
> 3.Login with above users in sequence and find items of Service Actions shown 
> as expected
> 
> 
> Thanks,
> 
> yao lei
> 
>

Review Request 59111: Run new heartbeatThread and statusCommand executor instead of old

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59111/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-20916
https://issues.apache.org/jira/browse/AMBARI-20916


Repository: ambari


Description
---

We have these threads running only in scope of UT. Need to start them on
ambari-agent start for so testing with ambari-server can be done.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py ebe9156 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 1f7d576 
  ambari-agent/src/main/python/ambari_agent/main.py 19c92b0 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py c05f350 


Diff: https://reviews.apache.org/r/59111/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59104/#review174358
---


Fix it, then Ship it!




`import io.swagger.*` should follow `import org.*` to satisfy required import 
order (see bunch of checkstyle failures).


ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
Lines 43 (patched)


unused import



ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
Lines 52-54 (original), 54-56 (patched)


Do we need really these constants?



ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java
Lines 25 (patched)


unused import


- Attila Doroszlai


On May 9, 2017, 8:40 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59104/
> ---
> 
> (Updated May 9, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20970
> https://issues.apache.org/jira/browse/AMBARI-20970
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Documented StackssService (except 3 calls that return other services - 
> Swagger can't handle them out of the box)
> - Some inaccuracies on the response schema (e.g. Artifact and Configuration 
> queries use the same response object, so service_name is reported for the 
> stack level API call)
> - subresources are partially covered
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  76d2b70 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
>  7b5f9cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  86bacf1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
>  47515c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  8e87e6f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
>  99c9ce9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java
>  14aab3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  0338ed9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java
>  1901337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  b48fad3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  8e4200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
>  3c65d05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java
>  d0a5206 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java
>  d4bdce8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 353dd86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  c41cd9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java
>  7824933 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
>  a28d149 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
>  3bb8c77 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 
> 840dbf0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 
> 43d2170 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
>  62fbfc1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java 
> b949a12 
>   
> 

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review174360
---


Ship it!




Ship It!

- Robert Nettleton


On May 9, 2017, 9:38 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58990/
> ---
> 
> (Updated May 9, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20872
> https://issues.apache.org/jira/browse/AMBARI-20872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating required properties for services listed in the blueprint can't be 
> accurate as further configurtion can be added in the cluster creation 
> template.
> (Where the configuration is added varies by use cases and usage)
> 
> This patch contains the change that defers this validation till all the 
> configuration is together, namely till the cluster creation template is 
> posted.
> 
> The validation logic is the same as it was before.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  45a8c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
>  146b424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  0e77301 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  0608697 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58990/diff/2/
> 
> 
> Testing
> ---
> 
> Tested successfully on local environment.
> Added unit tests.
> 
> Unit tests - success.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59104/
---

(Updated May 9, 2017, 6:40 p.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

deleted some unused imports


Bugs: AMBARI-20970
https://issues.apache.org/jira/browse/AMBARI-20970


Repository: ambari


Description
---

- Documented StackssService (except 3 calls that return other services - 
Swagger can't handle them out of the box)
- Some inaccuracies on the response schema (e.g. Artifact and Configuration 
queries use the same response object, so service_name is reported for the stack 
level API call)
- subresources are partially covered


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 76d2b70 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
 7b5f9cf 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 86bacf1 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
 47515c9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
 8e87e6f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
 99c9ce9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java
 14aab3b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
 0338ed9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java
 1901337 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 b48fad3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 8e4200d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
 3c65d05 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java
 d0a5206 
  
ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java
 d4bdce8 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
353dd86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 c41cd9a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java 
7824933 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
 a28d149 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
 3bb8c77 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 
840dbf0 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 
43d2170 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
 62fbfc1 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java 
b949a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java 
f7d4187 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 
96d2fc0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
 58fe942 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 
7bd058c 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 
1f38d8e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java
 9e9c068 


Diff: https://reviews.apache.org/r/59104/diff/2/

Changes: https://reviews.apache.org/r/59104/diff/1-2/


Testing
---

All unit tests for ambari-server pass, except ServicePropertiesTest, which 
fails due to AMBARI-20443.


Thanks,

Balázs Bence Sári

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

[Tim Thorpe]

> On May 9, 2017, 5:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
> > Line 351 (original)
> > 
> >
> > How do we capture this dependency only when HA is enabled?

There are several options:

1) We don't.  The UI already has an explicit check for ZOOKEEPER when 
attempting to enable NameNode HA. This is the option I implemented.
2) We could add in a conditional dependency section.


  ZOOKEEPER


3) We could add the conditional dependency section but be more explicit about 
how/when it applies:


  
ZOOKEEPER

  
hdfs-site
dfs.nameservices
  

  


4) We add this into the stack/service advisor code.  Either this could be added 
by using the information from 3 above or by hard coding it.  By hard coding it, 
I mean that during configuration validation we'd check to see if the 
dfs.nameservices exists and if so whether zookeeper is installed.

Mostly I opened this JIRA and review board to get opinions on the issue and 
possible solutions.

As a side note, I just attempted to add YARN to my HDFS only cluster and 
noticed that there were 2 configuration issues because 
yarn.resourcemanager.zk-address and hadoop.registry.zk.quorum are both blank.  
Both of these settings should be fine so long as 
yarn.resourcemanager.ha.enabled and hadoop.registry.rm.enabled respectively are 
set to false.  YARN doesn't specify a dependency on ZOOKEEPER because it has a 
dependency on HDFS and relies on HDFS's dependency on ZOOKEEPER.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review174341
---


On May 9, 2017, 2:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59095/
> ---
> 
> (Updated May 9, 2017, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20967
> https://issues.apache.org/jira/browse/AMBARI-20967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS has a static dependency on Zookeeper even though it is only needed when 
> NameNode HA is enabled. The check for Zookeeper should be done before 
> enabling HA rather than enforcing it at installation time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 3026938 
> 
> 
> Diff: https://reviews.apache.org/r/59095/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Manual testing - installed HDFS only cluster and attempted to enable NameNode 
> HA.  This is prevented with the same error you'd see if ZooKeeper was enabled 
> but you had fewer than 3 ZooKeeper servers configured.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59104/#review174348
---


Ship it!




Ship It!

- Jaimin Jetly


On May 9, 2017, 5:50 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59104/
> ---
> 
> (Updated May 9, 2017, 5:50 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Documented StackssService (except 3 calls that return other services - 
> Swagger can't handle them out of the box)
> - Some inaccuracies on the response schema (e.g. Artifact and Configuration 
> queries use the same response object, so service_name is reported for the 
> stack level API call)
> - subresources are partially covered
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  76d2b70 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
>  7b5f9cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  86bacf1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
>  47515c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  8e87e6f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
>  99c9ce9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java
>  14aab3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  0338ed9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java
>  1901337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  b48fad3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  8e4200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
>  3c65d05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java
>  d0a5206 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java
>  d4bdce8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 353dd86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  c41cd9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java
>  7824933 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
>  a28d149 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
>  3bb8c77 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 
> 840dbf0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 
> 43d2170 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
>  62fbfc1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java 
> b949a12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java
>  f7d4187 
>   ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 
> 96d2fc0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
>  58fe942 
>   ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 
> 7bd058c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 
> 1f38d8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java
>  9e9c068 
> 
> 
> Diff: https://reviews.apache.org/r/59104/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests for ambari-server pass, except ServicePropertiesTest, which 
> fails due to AMBARI-20443.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 59104: Integrate StackService resource and it's subresources with swagger

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59104/
---

Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Repository: ambari


Description
---

- Documented StackssService (except 3 calls that return other services - 
Swagger can't handle them out of the box)
- Some inaccuracies on the response schema (e.g. Artifact and Configuration 
queries use the same response object, so service_name is reported for the stack 
level API call)
- subresources are partially covered


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 76d2b70 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
 7b5f9cf 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 86bacf1 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
 47515c9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
 8e87e6f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
 99c9ce9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java
 14aab3b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
 0338ed9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java
 1901337 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 b48fad3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 8e4200d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
 3c65d05 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java
 d0a5206 
  
ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java
 d4bdce8 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
353dd86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 c41cd9a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java 
7824933 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
 a28d149 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
 3bb8c77 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 
840dbf0 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 
43d2170 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
 62fbfc1 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java 
b949a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java 
f7d4187 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 
96d2fc0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
 58fe942 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 
7bd058c 
  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 
1f38d8e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java
 9e9c068 


Diff: https://reviews.apache.org/r/59104/diff/1/


Testing
---

All unit tests for ambari-server pass, except ServicePropertiesTest, which 
fails due to AMBARI-20443.


Thanks,

Balázs Bence Sári

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review174341
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
Line 351 (original)


How do we capture this dependency only when HA is enabled?


- Alejandro Fernandez


On May 9, 2017, 2:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59095/
> ---
> 
> (Updated May 9, 2017, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20967
> https://issues.apache.org/jira/browse/AMBARI-20967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS has a static dependency on Zookeeper even though it is only needed when 
> NameNode HA is enabled. The check for Zookeeper should be done before 
> enabling HA rather than enforcing it at installation time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 3026938 
> 
> 
> Diff: https://reviews.apache.org/r/59095/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Manual testing - installed HDFS only cluster and attempted to enable NameNode 
> HA.  This is prevented with the same error you'd see if ZooKeeper was enabled 
> but you had fewer than 3 ZooKeeper servers configured.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59103/#review174340
---


Ship it!




Ship It!

- Gaurav Nagar


On May 9, 2017, 5:02 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59103/
> ---
> 
> (Updated May 9, 2017, 5:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20968
> https://issues.apache.org/jira/browse/AMBARI-20968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After "ember-precompile-brunch" package has been changed from "1.5.1" to 
> "0.1.0", ember fails to resolve view templates results in pig and capshed 
> views fails to render. This patch adds custom resolver to fix the issue.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> 
> Diff: https://reviews.apache.org/r/59103/diff/1/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59103/#review174339
---


Ship it!




Ship It!

- venkat sairam


On May 9, 2017, 5:02 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59103/
> ---
> 
> (Updated May 9, 2017, 5:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20968
> https://issues.apache.org/jira/browse/AMBARI-20968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After "ember-precompile-brunch" package has been changed from "1.5.1" to 
> "0.1.0", ember fails to resolve view templates results in pig and capshed 
> views fails to render. This patch adds custom resolver to fix the issue.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> 
> Diff: https://reviews.apache.org/r/59103/diff/1/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59060/
---

(Updated May 9, 2017, 1:04 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
Lisnichenko, and Nate Cole.


Bugs: AMBARI-20958
https://issues.apache.org/jira/browse/AMBARI-20958


Repository: ambari


Description
---

The {{host_version}} table must allow for multiple {{CURRENT}} versions. 
Finalization must be allowed to occur when not all hosts are targeted for 
upgrade. 

During a {{PATCH}} or {{SERVICE}} upgrade, finalization will either fail or be 
incorrect based on the topology of the cluster. In cases where the upgraded 
service has components on every host, the {{host_version}} table is moved 
incorrectly to reflect the stack of the upgraded component. 

h6. Topology (HDP 2.4.2.0-236)
- c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
- c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
- c6403 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor

h6. {{SERVICE}} upgrade from to HDP-2.5.4.0-121 for {{STORM}} only:

{noformat}
Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
Finalizing the upgraded state of host components in 3 host(s).
Finalizing the version for 3 host(s).
Finalizing the version for cluster c1.
Creating upgrade history.
Upgrade was successful!
{noformat}

{code}
ambari=# SELECT host_version.host_id, repo_version.version, state FROM 
host_version, repo_version WHERE host_version.repo_version_id = 
repo_version.repo_version_id ORDER BY version, host_id;
 host_id |   version   |   state
-+-+---
   1 | 2.4.2.0-236 | INSTALLED
   2 | 2.4.2.0-236 | INSTALLED
   3 | 2.4.2.0-236 | INSTALLED
   1 | 2.5.4.0-121 | CURRENT
   2 | 2.5.4.0-121 | CURRENT
   3 | 2.5.4.0-121 | CURRENT
(6 rows)
{code}

In the event that {{STORM}} is not installed on all hosts, finalization fails:
h6. Topology (HDP 2.4.2.0-236)
- c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
- c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
- c6403 - ZooKeeper Server, ZooKeeper Client

{noformat}
Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
The following 1 host(s) have not been upgraded to version 2.5.4.0-121. Please 
install and upgrade the Stack Version on those hosts and try again.
Hosts: c6403.ambari.apache.org
{noformat}


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 fd52a3f 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 33c622f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
 1bcca60 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
 6174912 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
 3871b67 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
 9be30a3 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 f5d669e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
 68124fc 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a4cc757 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
 22f2e73 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
88c5a59 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
 b7f8d29 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
f1bd900 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 21c275b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 056959e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java
 75d5fa6 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c2a9239 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 48d2c35 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 26201fc 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 156fc08 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 979ea44 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 08c71ff 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d5b2d46 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 6471988 


Diff: https://reviews.apache.org/r/59060/diff/2/

Changes: 

Review Request 59103: Pig and CapSched views are not loading in 2.4.3

[Akhil PB]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59103/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and venkat sairam.


Bugs: AMBARI-20968
https://issues.apache.org/jira/browse/AMBARI-20968


Repository: ambari


Description
---

After "ember-precompile-brunch" package has been changed from "1.5.1" to 
"0.1.0", ember fails to resolve view templates results in pig and capshed views 
fails to render. This patch adds custom resolver to fix the issue.


Diffs
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
  contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 


Diff: https://reviews.apache.org/r/59103/diff/1/


Testing
---

Manual unit testing


Thanks,

Akhil PB

Re: Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59102/#review174338
---


Ship it!




Ship It!

- Sebastian Toader


On May 9, 2017, 6:38 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59102/
> ---
> 
> (Updated May 9, 2017, 6:38 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20938
> https://issues.apache.org/jira/browse/AMBARI-20938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LDAPS connections to an Active Directory when enabling Kerberos should 
> validate the server's SSL certificate.  The current implementation skips 
> validation checks to help avoid SSL issues; however this is not secure. Also 
> the _trusting_ SSL connection may not support the more secure SSL protocols 
> when Java 1.7 is used. For example `TLSv1.2`
> 
> A flag in the `ambari.properties` file 
> (`kerberos.operation.verify.kdc.trust`) should be available to allow for the 
> user to select either a _trusting_ SSL connection or a validating 
> (non-trusting) SSL connection to be used.  The default should be to use a 
> (non-trusting) SSL connection.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties b8b645d7be 
>   ambari-server/docs/configuration/index.md ff9ce54b69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f7f6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  6687942b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryNonTrusting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryTrusting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
>  cd19174431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosKDCSSLConnectionException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/TrustingSSLSocketFactory.java
>  52b3703fcb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
>  603f744352 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 2e41e3d774 
>   ambari-web/app/messages.js 8f8d981af7 
> 
> 
> Diff: https://reviews.apache.org/r/59102/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested using Java 1.7 and Java 1.8 using both trusing and 
> non-trusting SSL sockets to ensure expected behavior.
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:12 min
> [INFO] Finished at: 2017-05-09T12:37:05-04:00
> [INFO] Final Memory: 76M/582M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59102/
---

(Updated May 9, 2017, 12:38 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20938
https://issues.apache.org/jira/browse/AMBARI-20938


Repository: ambari


Description
---

LDAPS connections to an Active Directory when enabling Kerberos should validate 
the server's SSL certificate.  The current implementation skips validation 
checks to help avoid SSL issues; however this is not secure. Also the 
_trusting_ SSL connection may not support the more secure SSL protocols when 
Java 1.7 is used. For example `TLSv1.2`

A flag in the `ambari.properties` file (`kerberos.operation.verify.kdc.trust`) 
should be available to allow for the user to select either a _trusting_ SSL 
connection or a validating (non-trusting) SSL connection to be used.  The 
default should be to use a (non-trusting) SSL connection.


Diffs
-

  ambari-server/conf/unix/ambari.properties b8b645d7be 
  ambari-server/docs/configuration/index.md ff9ce54b69 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 114046f7f6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 6687942b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryNonTrusting.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryTrusting.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
 cd19174431 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosKDCSSLConnectionException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/TrustingSSLSocketFactory.java
 52b3703fcb 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
 603f744352 
  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774 
  ambari-web/app/messages.js 8f8d981af7 


Diff: https://reviews.apache.org/r/59102/diff/1/


Testing (updated)
---

Manually tested using Java 1.7 and Java 1.8 using both trusing and non-trusting 
SSL sockets to ensure expected behavior.

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:12 min
[INFO] Finished at: 2017-05-09T12:37:05-04:00
[INFO] Final Memory: 76M/582M
[INFO] 
```

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

[Jonathan Hurley]

> On May 9, 2017, 12:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
> > Line 112 (original), 104 (patched)
> > 
> >
> > nit: formatting :)

If I had a nickel every time you pointed out my extra spaces... It's a hard 
habit to break :)


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59060/#review174333
---


On May 8, 2017, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59060/
> ---
> 
> (Updated May 8, 2017, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-20958
> https://issues.apache.org/jira/browse/AMBARI-20958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{host_version}} table must allow for multiple {{CURRENT}} versions. 
> Finalization must be allowed to occur when not all hosts are targeted for 
> upgrade. 
> 
> During a {{PATCH}} or {{SERVICE}} upgrade, finalization will either fail or 
> be incorrect based on the topology of the cluster. In cases where the 
> upgraded service has components on every host, the {{host_version}} table is 
> moved incorrectly to reflect the stack of the upgraded component. 
> 
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> 
> h6. {{SERVICE}} upgrade from to HDP-2.5.4.0-121 for {{STORM}} only:
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> Finalizing the upgraded state of host components in 3 host(s).
> Finalizing the version for 3 host(s).
> Finalizing the version for cluster c1.
> Creating upgrade history.
> Upgrade was successful!
> {noformat}
> 
> {code}
> ambari=# SELECT host_version.host_id, repo_version.version, state FROM 
> host_version, repo_version WHERE host_version.repo_version_id = 
> repo_version.repo_version_id ORDER BY version, host_id;
>  host_id |   version   |   state
> -+-+---
>1 | 2.4.2.0-236 | INSTALLED
>2 | 2.4.2.0-236 | INSTALLED
>3 | 2.4.2.0-236 | INSTALLED
>1 | 2.5.4.0-121 | CURRENT
>2 | 2.5.4.0-121 | CURRENT
>3 | 2.5.4.0-121 | CURRENT
> (6 rows)
> {code}
> 
> In the event that {{STORM}} is not installed on all hosts, finalization fails:
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> The following 1 host(s) have not been upgraded to version 2.5.4.0-121. Please 
> install and upgrade the Stack Version on those hosts and try again.
> Hosts: c6403.ambari.apache.org
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  fd52a3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  33c622f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
>  1bcca60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  6174912 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  3871b67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  9be30a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  f5d669e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a4cc757 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 88c5a59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
>  b7f8d29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  21c275b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  056959e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java
>  75d5fa6 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c2a9239 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 48d2c35 
> 

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

[Jonathan Hurley]

> On May 9, 2017, 12:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Line 244 (original), 244 (patched)
> > 
> >
> > Why is state part of the uniqueness? You can't have one host with 2 of 
> > the same repo id.
> > 
> > can't have:
> > host_version1 -> repo1 'INSTALLED'
> > host_version1 -> repo1 'CURRENT'
> > 
> > sure, but uniqueness is satisfied via host_id/repo_id
> > host_version1 -> repo1 'INSTALLED'
> > host_version1 -> repo2 'CURRENT'

H - you know, I totally agree and have no clue why I changed this :)

I think my mind thought "CURRENT" is no longer required to be for 1 repo ... 
but that's a constraint in data not in relationships. I needs to be taken care 
of in business logic.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59060/#review174333
---


On May 8, 2017, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59060/
> ---
> 
> (Updated May 8, 2017, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-20958
> https://issues.apache.org/jira/browse/AMBARI-20958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{host_version}} table must allow for multiple {{CURRENT}} versions. 
> Finalization must be allowed to occur when not all hosts are targeted for 
> upgrade. 
> 
> During a {{PATCH}} or {{SERVICE}} upgrade, finalization will either fail or 
> be incorrect based on the topology of the cluster. In cases where the 
> upgraded service has components on every host, the {{host_version}} table is 
> moved incorrectly to reflect the stack of the upgraded component. 
> 
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> 
> h6. {{SERVICE}} upgrade from to HDP-2.5.4.0-121 for {{STORM}} only:
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> Finalizing the upgraded state of host components in 3 host(s).
> Finalizing the version for 3 host(s).
> Finalizing the version for cluster c1.
> Creating upgrade history.
> Upgrade was successful!
> {noformat}
> 
> {code}
> ambari=# SELECT host_version.host_id, repo_version.version, state FROM 
> host_version, repo_version WHERE host_version.repo_version_id = 
> repo_version.repo_version_id ORDER BY version, host_id;
>  host_id |   version   |   state
> -+-+---
>1 | 2.4.2.0-236 | INSTALLED
>2 | 2.4.2.0-236 | INSTALLED
>3 | 2.4.2.0-236 | INSTALLED
>1 | 2.5.4.0-121 | CURRENT
>2 | 2.5.4.0-121 | CURRENT
>3 | 2.5.4.0-121 | CURRENT
> (6 rows)
> {code}
> 
> In the event that {{STORM}} is not installed on all hosts, finalization fails:
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> The following 1 host(s) have not been upgraded to version 2.5.4.0-121. Please 
> install and upgrade the Stack Version on those hosts and try again.
> Hosts: c6403.ambari.apache.org
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  fd52a3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  33c622f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
>  1bcca60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  6174912 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  3871b67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  9be30a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  f5d669e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a4cc757 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 88c5a59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
>  b7f8d29 
>   
> 

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59060/#review174333
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
Line 112 (original), 104 (patched)


nit: formatting :)



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Line 244 (original), 244 (patched)


Why is state part of the uniqueness? You can't have one host with 2 of the 
same repo id.

can't have:
host_version1 -> repo1 'INSTALLED'
host_version1 -> repo1 'CURRENT'

sure, but uniqueness is satisfied via host_id/repo_id
host_version1 -> repo1 'INSTALLED'
host_version1 -> repo2 'CURRENT'


- Nate Cole


On May 8, 2017, 2:50 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59060/
> ---
> 
> (Updated May 8, 2017, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-20958
> https://issues.apache.org/jira/browse/AMBARI-20958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{host_version}} table must allow for multiple {{CURRENT}} versions. 
> Finalization must be allowed to occur when not all hosts are targeted for 
> upgrade. 
> 
> During a {{PATCH}} or {{SERVICE}} upgrade, finalization will either fail or 
> be incorrect based on the topology of the cluster. In cases where the 
> upgraded service has components on every host, the {{host_version}} table is 
> moved incorrectly to reflect the stack of the upgraded component. 
> 
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> 
> h6. {{SERVICE}} upgrade from to HDP-2.5.4.0-121 for {{STORM}} only:
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> Finalizing the upgraded state of host components in 3 host(s).
> Finalizing the version for 3 host(s).
> Finalizing the version for cluster c1.
> Creating upgrade history.
> Upgrade was successful!
> {noformat}
> 
> {code}
> ambari=# SELECT host_version.host_id, repo_version.version, state FROM 
> host_version, repo_version WHERE host_version.repo_version_id = 
> repo_version.repo_version_id ORDER BY version, host_id;
>  host_id |   version   |   state
> -+-+---
>1 | 2.4.2.0-236 | INSTALLED
>2 | 2.4.2.0-236 | INSTALLED
>3 | 2.4.2.0-236 | INSTALLED
>1 | 2.5.4.0-121 | CURRENT
>2 | 2.5.4.0-121 | CURRENT
>3 | 2.5.4.0-121 | CURRENT
> (6 rows)
> {code}
> 
> In the event that {{STORM}} is not installed on all hosts, finalization fails:
> h6. Topology (HDP 2.4.2.0-236)
> - c6401 - ZooKeeper Server, ZooKeeper Client, Storm Nimbus
> - c6402 - ZooKeeper Server, ZooKeeper Client, Storm Supervisor
> - c6403 - ZooKeeper Server, ZooKeeper Client
> 
> {noformat}
> Begin finalizing the upgrade of cluster c1 to version 2.5.4.0-121
> The following 1 host(s) have not been upgraded to version 2.5.4.0-121. Please 
> install and upgrade the Stack Version on those hosts and try again.
> Hosts: c6403.ambari.apache.org
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  fd52a3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  33c622f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
>  1bcca60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  6174912 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  3871b67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  9be30a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  f5d669e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a4cc757 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 88c5a59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
>  b7f8d29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  21c275b 
>   
> 

Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59102/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20938
https://issues.apache.org/jira/browse/AMBARI-20938


Repository: ambari


Description
---

LDAPS connections to an Active Directory when enabling Kerberos should validate 
the server's SSL certificate.  The current implementation skips validation 
checks to help avoid SSL issues; however this is not secure. Also the 
_trusting_ SSL connection may not support the more secure SSL protocols when 
Java 1.7 is used. For example `TLSv1.2`

A flag in the `ambari.properties` file (`kerberos.operation.verify.kdc.trust`) 
should be available to allow for the user to select either a _trusting_ SSL 
connection or a validating (non-trusting) SSL connection to be used.  The 
default should be to use a (non-trusting) SSL connection.


Diffs
-

  ambari-server/conf/unix/ambari.properties b8b645d7be 
  ambari-server/docs/configuration/index.md ff9ce54b69 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 114046f7f6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 6687942b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryNonTrusting.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/InternalSSLSocketFactoryTrusting.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
 cd19174431 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosKDCSSLConnectionException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/TrustingSSLSocketFactory.java
 52b3703fcb 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
 603f744352 
  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774 
  ambari-web/app/messages.js 8f8d981af7 


Diff: https://reviews.apache.org/r/59102/diff/1/


Testing
---

Manually tested using Java 1.7 and Java 1.8 using both trusing and non-trusting 
SSL sockets to ensure expected behavior.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 59066: Remove cluster_version use

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59066/#review174332
---


Ship it!




Ship It!

- Jonathan Hurley


On May 8, 2017, 5:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59066/
> ---
> 
> (Updated May 8, 2017, 5:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20957
> https://issues.apache.org/jira/browse/AMBARI-20957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch and Service upgrades no longer use cluster_version to track a 
> repository for upgrade purposes.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/Experimental.java 
> f51991c8c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  26e5be8216 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  63eb660e57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  707c75681a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  314d1a7341 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  2c20762194 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  2200a45306 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  835d607275 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  1d43093de2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e2bd50f25a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  6687942b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  fd52a3f8b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  c24410788f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  71b9b6bb9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  d2f3f8d7e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  c611037c40 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b49b66eea8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
>  3fda1603f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  b4ddf09027 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  33c622f08b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
>  1bcca60911 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  3871b67e82 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  527fd7a009 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java
>  f1867b47e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  9be30a359f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  f5d669e4f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  6b89c02c9b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a4cc757346 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> 1380f933c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  29af6a8716 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 88c5a59955 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  21c275b0b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  99bc781b78 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java
>  584ce9884f 
>   
> 

Re: Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/#review174319
---


Ship it!




Ship It!

- Robert Levas


On May 9, 2017, 5:49 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59085/
> ---
> 
> (Updated May 9, 2017, 5:49 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.
> 
> 
> Bugs: AMBARI-20961
> https://issues.apache.org/jira/browse/AMBARI-20961
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Create a user named test and assign Service Operator(Administrator) Role to 
> this user.
> 2.Login with this user and open Services -> Hive -> Service Actions, the menu 
> include highlight items : Add Hive Metastore and Add HiveServer2.
> Zookeeper,Hbase and other service also have the above issue.
> 
> Because Service Operator(Administrator) Role don't have 
> HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/service/item.js ac736a6 
> 
> 
> Diff: https://reviews.apache.org/r/59085/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Create five users: test1 ,test2 ,test3 ,test4 ,test5  
> 2.Assign role Cluster User to test1,
>   Service Operator to test2,
>   Service Administrator to test3,
>   Cluster Operator to test4,
>   Cluster Administrator  to test5
> 3.Login with above users in sequence and find items of Service Actions shown 
> as expected
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review174316
---


Ship it!




Ship It!

- Robert Levas


On May 9, 2017, 5:38 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58990/
> ---
> 
> (Updated May 9, 2017, 5:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20872
> https://issues.apache.org/jira/browse/AMBARI-20872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating required properties for services listed in the blueprint can't be 
> accurate as further configurtion can be added in the cluster creation 
> template.
> (Where the configuration is added varies by use cases and usage)
> 
> This patch contains the change that defers this validation till all the 
> configuration is together, namely till the cluster creation template is 
> posted.
> 
> The validation logic is the same as it was before.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  45a8c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
>  146b424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  0e77301 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  0608697 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58990/diff/2/
> 
> 
> Testing
> ---
> 
> Tested successfully on local environment.
> Added unit tests.
> 
> Unit tests - success.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 58845: AMBARI-20891 - Allow extensions to auto-link with supported stack versions

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review174308
---


Ship it!




Ship It!

- Jonathan Hurley


On May 5, 2017, 2:30 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58845/
> ---
> 
> (Updated May 5, 2017, 2:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-20891
> https://issues.apache.org/jira/browse/AMBARI-20891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It would possible to link extensions to supported stack versions while 
> parsing the stacks, extensions and common-services directories.
> 
> This would allow extensions to avoid making rest API calls to set up the link.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
>  3df1cd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
>  12b3ce0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java
>  ce92ecf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 20e28fc 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> d3ad351 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java 
> 656a8ce 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 353dd86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java
>  77a7250 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
>  4e20c2b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  9900eb5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  ca24cd9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMock.java
>  0fe1573 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  0a0404a 
>   ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c 
>   ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c 
>   ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58845/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
> 
> mvn clean test 
> 

Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/
---

Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-20967
https://issues.apache.org/jira/browse/AMBARI-20967


Repository: ambari


Description
---

HDFS has a static dependency on Zookeeper even though it is only needed when 
NameNode HA is enabled. The check for Zookeeper should be done before enabling 
HA rather than enforcing it at installation time.


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
3026938 


Diff: https://reviews.apache.org/r/59095/diff/1/


Testing
---

mvn clean test

Manual testing - installed HDFS only cluster and attempted to enable NameNode 
HA.  This is prevented with the same error you'd see if ZooKeeper was enabled 
but you had fewer than 3 ZooKeeper servers configured.


Thanks,

Tim Thorpe

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review174307
---


Ship it!




Ship It!

- Jonathan Hurley


On May 3, 2017, 4:18 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 3, 2017, 4:18 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, MS SQL Server, and 
> Derby. 
> _I have no way to test creating Oracle and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
---

(Updated May 9, 2017, 2:30 p.m.)


Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma 
Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673


Repository: ambari


Description
---

Now when we have only one reducer, the label for aort/partition will be 
displayed as partition.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
d0a3e0b 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 9dbbb00 


Diff: https://reviews.apache.org/r/58179/diff/2/

Changes: https://reviews.apache.org/r/58179/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/#review174306
---


Ship it!




Ship It!

- belliraj hb


On May 9, 2017, 10:54 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58179/
> ---
> 
> (Updated May 9, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20673
> https://issues.apache.org/jira/browse/AMBARI-20673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Now when we have only one reducer, the label for aort/partition will be 
> displayed as partition.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  1cfcb15 
> 
> 
> Diff: https://reviews.apache.org/r/58179/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> File Attachments
> 
> 
> This patch contains code which should go along with other patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 59066: Remove cluster_version use

[Nate Cole]

> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
> > Line 72 (original), 70 (patched)
> > 
> >
> > I know that we have a parallel patch to this for host versions right 
> > now, but do we have to set soemething else here as well, like am 
> > INSTALLED_FAILED for the repository for the host version?

That is done in the for-loop above this one in same file


> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> > Lines 509 (patched)
> > 
> >
> > Should we call this desired_version instead? Something that I've been 
> > wondering about is if we need a current version for all 
> > services/components. So far we've gotten away without it.

Perhaps - this was the name that is used in python, and that is not this patch. 
 I only added this constant instead of hard-coded strings in multiple places.  
We have a jira already to send all versions of all services in the command 
json, so I'm hoping this will go away.


> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 2913-2918 (patched)
> > 
> >
> > I don't think these NULLs can ever happen since we have a non-NULL 
> > constraint in the DB. I see them in a bunch of spots. I'm not against it, 
> > but it does create more clutter.

The component is nullable according to the code, but the service is NOT 
nullable.  Will update the logic here.


> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
> > Lines 198-200 (patched)
> > 
> >
> > You gotta use that nifty new "notes" field in the Experimental 
> > annotation for this too :)

Done :)


> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> > Lines 528-531 (original), 528 (patched)
> > 
> >
> > This indirectly also did some stuff with host_versions. Just checking 
> > there's not something we need to do here still.

That I'm not sure; I believe the calculation work you've started will address 
this.


> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
> > Lines 401-417 (original)
> > 
> >
> > Should this instead be across host versions for the repo now?

I was hoping the cascade on entities would solve this problem, but I see the 
point.  Will update.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59066/#review174295
---


On May 8, 2017, 5:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59066/
> ---
> 
> (Updated May 8, 2017, 5:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20957
> https://issues.apache.org/jira/browse/AMBARI-20957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch and Service upgrades no longer use cluster_version to track a 
> repository for upgrade purposes.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/Experimental.java 
> f51991c8c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  26e5be8216 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  63eb660e57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  707c75681a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  314d1a7341 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  2c20762194 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  2200a45306 
>   
> 

Re: Review Request 59066: Remove cluster_version use

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59066/#review174295
---




ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
Line 72 (original), 70 (patched)


I know that we have a parallel patch to this for host versions right now, 
but do we have to set soemething else here as well, like am INSTALLED_FAILED 
for the repository for the host version?



ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
Lines 509 (patched)


Should we call this desired_version instead? Something that I've been 
wondering about is if we need a current version for all services/components. So 
far we've gotten away without it.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Lines 2913-2918 (patched)


I don't think these NULLs can ever happen since we have a non-NULL 
constraint in the DB. I see them in a bunch of spots. I'm not against it, but 
it does create more clutter.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Lines 198-200 (patched)


You gotta use that nifty new "notes" field in the Experimental annotation 
for this too :)



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
Lines 528-531 (original), 528 (patched)


This indirectly also did some stuff with host_versions. Just checking 
there's not something we need to do here still.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
Line 492 (original)


Same as above - do we need to do stuff with host versions at all here?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
Lines 401-417 (original)


Should this instead be across host versions for the repo now?


- Jonathan Hurley


On May 8, 2017, 5:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59066/
> ---
> 
> (Updated May 8, 2017, 5:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20957
> https://issues.apache.org/jira/browse/AMBARI-20957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch and Service upgrades no longer use cluster_version to track a 
> repository for upgrade purposes.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/Experimental.java 
> f51991c8c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  26e5be8216 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  63eb660e57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  707c75681a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  314d1a7341 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  2c20762194 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  2200a45306 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  835d607275 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  1d43093de2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e2bd50f25a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  6687942b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  fd52a3f8b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  c24410788f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  71b9b6bb9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  d2f3f8d7e1 
>   
> 

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174291
---


Ship it!




Ship It!

- Sebastian Toader


On May 9, 2017, 11:59 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59051/
> ---
> 
> (Updated May 9, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20955
> https://issues.apache.org/jira/browse/AMBARI-20955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Integrate selenium with log search it framework.
> Tests can be run separately for ui and backend. Currently it requires x11 
> forwarding to see the tests itself. (later headless will be added). Also im 
> using localhost as docker hosts right now, which means it currenty works with 
> docker-for-mac or on linux system with an installed docker
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 5c41fcd 
>   ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
>  cb72376 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  32e8cba 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java
>  45455bf 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
>  ce6b9cb 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
>  c502cc4 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story
>  cfaa359 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
>  388e624 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
>  PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile 6e8ea3e 
>   ambari-logsearch/docker/bin/start.sh 1efc85c 
>   ambari-logsearch/docker/logsearch-docker.sh eab850e 
> 
> 
> Diff: https://reviews.apache.org/r/59051/diff/2/
> 
> 
> Testing
> ---
> 
> ran with -Dselenium-tests and with -Dbackend-tests as well
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:36 min
> [INFO] Finished at: 2017-05-08T16:27:44+02:00
> [INFO] Final Memory: 51M/499M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/#review174290
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 9, 2017, 10:07 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59087/
> ---
> 
> (Updated May 9, 2017, 10:07 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20962
> https://issues.apache.org/jira/browse/AMBARI-20962
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> made fileName as path param instead of query param. Now downloaded file's 
> name preserves unicode characters.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  5fa96bb0a8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  8250dbbd84 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  f2e4ee9b6c 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac 
> 
> 
> Diff: https://reviews.apache.org/r/59087/diff/1/
> 
> 
> Testing
> ---
> 
> Done testing on various browsers manually.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
---

(Updated May 9, 2017, 10:54 a.m.)


Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma 
Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673


Repository: ambari


Description
---

Now when we have only one reducer, the label for aort/partition will be 
displayed as partition.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
1cfcb15 


Diff: https://reviews.apache.org/r/58179/diff/1/


Testing
---

Manual testing done


File Attachments (updated)


This patch contains code which should go along with other patch
  
https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch


Thanks,

venkat sairam

Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/#review174286
---


Ship it!




Ship It!

- Gaurav Nagar


On May 9, 2017, 10:07 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59087/
> ---
> 
> (Updated May 9, 2017, 10:07 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20962
> https://issues.apache.org/jira/browse/AMBARI-20962
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> made fileName as path param instead of query param. Now downloaded file's 
> name preserves unicode characters.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
>  5fa96bb0a8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  8250dbbd84 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  f2e4ee9b6c 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac 
> 
> 
> Diff: https://reviews.apache.org/r/59087/diff/1/
> 
> 
> Testing
> ---
> 
> Done testing on various browsers manually.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59087/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20962
https://issues.apache.org/jira/browse/AMBARI-20962


Repository: ambari


Description
---

made fileName as path param instead of query param. Now downloaded file's name 
preserves unicode characters.


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java
 5fa96bb0a8 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 
8250dbbd84 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
 f2e4ee9b6c 
  contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac 


Diff: https://reviews.apache.org/r/59087/diff/1/


Testing
---

Done testing on various browsers manually.


Thanks,

Nitiraj Rathore

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/
---

(Updated May 9, 2017, 9:59 a.m.)


Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, and Sebastian Toader.


Changes
---

remove unnecessary docker initialization


Bugs: AMBARI-20955
https://issues.apache.org/jira/browse/AMBARI-20955


Repository: ambari


Description
---

Integrate selenium with log search it framework.
Tests can be run separately for ui and backend. Currently it requires x11 
forwarding to see the tests itself. (later headless will be added). Also im 
using localhost as docker hosts right now, which means it currenty works with 
docker-for-mac or on linux system with an installed docker


Diffs (updated)
-

  ambari-logsearch/README.md 5c41fcd 
  ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
 cb72376 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
 32e8cba 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java
 45455bf 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
 ce6b9cb 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
 c502cc4 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story
 cfaa359 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
 388e624 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
 PRE-CREATION 
  ambari-logsearch/docker/Dockerfile 6e8ea3e 
  ambari-logsearch/docker/bin/start.sh 1efc85c 
  ambari-logsearch/docker/logsearch-docker.sh eab850e 


Diff: https://reviews.apache.org/r/59051/diff/2/

Changes: https://reviews.apache.org/r/59051/diff/1-2/


Testing
---

ran with -Dselenium-tests and with -Dbackend-tests as well
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-05-08T16:27:44+02:00
[INFO] Final Memory: 51M/499M
[INFO] 


Thanks,

Oliver Szabo

Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

[yao lei]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/
---

Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.


Bugs: AMBARI-20961
https://issues.apache.org/jira/browse/AMBARI-20961


Repository: ambari


Description
---

Steps to reproduce:
1.Create a user named test and assign Service Operator(Administrator) Role to 
this user.
2.Login with this user and open Services -> Hive -> Service Actions, the menu 
include highlight items : Add Hive Metastore and Add HiveServer2.
Zookeeper,Hbase and other service also have the above issue.

Because Service Operator(Administrator) Role don't have 
HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons


Diffs
-

  ambari-web/app/views/main/service/item.js ac736a6 


Diff: https://reviews.apache.org/r/59085/diff/1/


Testing
---

1.Create five users: test1 ,test2 ,test3 ,test4 ,test5  
2.Assign role Cluster User to test1?
  Service Operator to test2?
  Service Administrator to test3?
  Cluster Operator to test4?
  Cluster Administrator  to test5
3.Login with above users in sequence and find items of Service Actions shown as 
expected


Thanks,

yao lei

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/
---

(Updated May 9, 2017, 9:38 a.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sandor Magyari.


Bugs: AMBARI-20872
https://issues.apache.org/jira/browse/AMBARI-20872


Repository: ambari


Description (updated)
---

Validating required properties for services listed in the blueprint can't be 
accurate as further configurtion can be added in the cluster creation template.
(Where the configuration is added varies by use cases and usage)

This patch contains the change that defers this validation till all the 
configuration is together, namely till the cluster creation template is posted.

The validation logic is the same as it was before.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 45a8c5c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
 146b424 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 0e77301 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 0608697 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58990/diff/2/


Testing (updated)
---

Tested successfully on local environment.
Added unit tests.

Unit tests - success.


Thanks,

Laszlo Puskas

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Laszlo Puskas]

> On May 4, 2017, 2:21 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
> > Lines 38 (patched)
> > 
> >
> > Aren' there some password properities that are required when installing 
> > a service? If so, shouldn't the existance of the property be tested?  Being 
> > that the fill set of configs is used when validating, I would expect that a 
> > required password property would have been set in the Cluster Creation 
> > Template.

Password properties were ignored previously, that's why i left it this way. (I 
didn't want to change anything in the logic)


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review173901
---


On May 9, 2017, 8:57 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58990/
> ---
> 
> (Updated May 9, 2017, 8:57 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20872
> https://issues.apache.org/jira/browse/AMBARI-20872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating required properties for services listed in the blueprint can't be 
> accurate as further configurtion can be added in the cluster creation 
> template.
> (Where the configuration is added varies by use cases and usage)
> 
> This patch contains the change that defers this validation till all the 
> configuration is together, namely till the cluster creation template is 
> posted.
> The validation logic is the same as it was before (provided config entries 
> are checked against those marked as required in the stack) the way the 
> properties are collected has slightly changed:
> 
> - before the properties were retrieved by traversing hostgroups
> - in the current implementation required properties are retrieved by 
> traversing the services listed in the blueprint
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  45a8c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
>  146b424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  0e77301 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  0608697 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58990/diff/2/
> 
> 
> Testing
> ---
> 
> Tested successfully on local environment.
> Added unit tests.
> 
> Unit tests running ...
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/
---

(Updated May 9, 2017, 8:57 a.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
and Sandor Magyari.


Bugs: AMBARI-20872
https://issues.apache.org/jira/browse/AMBARI-20872


Repository: ambari


Description
---

Validating required properties for services listed in the blueprint can't be 
accurate as further configurtion can be added in the cluster creation template.
(Where the configuration is added varies by use cases and usage)

This patch contains the change that defers this validation till all the 
configuration is together, namely till the cluster creation template is posted.
The validation logic is the same as it was before (provided config entries are 
checked against those marked as required in the stack) the way the properties 
are collected has slightly changed:

- before the properties were retrieved by traversing hostgroups
- in the current implementation required properties are retrieved by traversing 
the services listed in the blueprint


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 45a8c5c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
 146b424 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 0e77301 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 0608697 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58990/diff/2/

Changes: https://reviews.apache.org/r/58990/diff/1-2/


Testing
---

Tested successfully on local environment.
Added unit tests.

Unit tests running ...


Thanks,

Laszlo Puskas

Re: Review Request 59059: Runtime filtering is not rendering properly

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59059/#review174279
---


Ship it!




Ship It!

- venkat sairam


On May 8, 2017, 6:18 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59059/
> ---
> 
> (Updated May 8, 2017, 6:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20519
> https://issues.apache.org/jira/browse/AMBARI-20519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Accomodate JSON interface changes.
> - fix arrow position for bloom filter queries.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  1a6d4b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  c880614 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  57fff1e 
> 
> 
> Diff: https://reviews.apache.org/r/59059/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>