Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52102/#review149764
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Sept. 21, 2016, 12:04 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52102/
> ---
> 
> (Updated Sept. 21, 2016, 12:04 a.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-15059
> https://issues.apache.org/jira/browse/AMBARI-15059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add extra handling logic for navigating out and save button.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js
>  582b68b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html
>  ee5d860 
> 
> Diff: https://reviews.apache.org/r/52102/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52102/
---

(Updated Sept. 21, 2016, 12:04 a.m.)


Review request for Ambari and Zhe (Joe) Wang.


Changes
---

remove IDE related indentation


Bugs: AMBARI-15059
https://issues.apache.org/jira/browse/AMBARI-15059


Repository: ambari


Description
---

Add extra handling logic for navigating out and save button.


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js
 582b68b 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html
 ee5d860 

Diff: https://reviews.apache.org/r/52102/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 secs)


Thanks,

Richard Zang

Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52102/#review149757
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js
 (line 24)


Indent?


- Zhe (Joe) Wang


On Sept. 20, 2016, 10:59 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52102/
> ---
> 
> (Updated Sept. 20, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-15059
> https://issues.apache.org/jira/browse/AMBARI-15059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add extra handling logic for navigating out and save button.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js
>  582b68b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html
>  ee5d860 
> 
> Diff: https://reviews.apache.org/r/52102/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>