Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-19 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/#review129656
---


Ship it!




Ship It!

- Swapan Shridhar


On April 19, 2016, 11:51 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46351/
> ---
> 
> (Updated April 19, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15955
> https://issues.apache.org/jira/browse/AMBARI-15955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive should also create a conf.server folder (similar to 
> Hive Server Batch), in order to distinguish the configs used by the server 
> and client.
> 
> Further, when it starts the LLAP App on slider, it can specify which folder 
> to unpack it it,
> E.g., 
> ```
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> -slider-am-container-mb {size} --loglevel INFO --output {directory}
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  38e4fb4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2ee491 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9cfd41f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  33e8e47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  92e67c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9bee786 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  feca9f1 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941e762 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json f9c31dc 
> 
> Diff: https://reviews.apache.org/r/46351/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster by installing Hive Server Interactive with LLAP, and 
> then restarting HSI and LLAP.
> 
> Python unit tests passed.
> --
> Total run:966
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/#review129465
---


Fix it, then Ship it!




Fix it and Ship It.


ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 


White spaces



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 (line 97)


White spaces


- Swapan Shridhar


On April 18, 2016, 11:24 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46351/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15955
> https://issues.apache.org/jira/browse/AMBARI-15955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive should also create a conf.server folder (similar to 
> Hive Server Batch), in order to distinguish the configs used by the server 
> and client.
> 
> Further, when it starts the LLAP App on slider, it can specify which folder 
> to unpack it it,
> E.g., 
> ```
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> -slider-am-container-mb {size} --loglevel INFO --output {directory}
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2ee491 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9cfd41f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  33e8e47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  92e67c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1205202 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  feca9f1 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
> 
> Diff: https://reviews.apache.org/r/46351/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster by installing Hive Server Interactive with LLAP, and 
> then restarting HSI and LLAP.
> 
> Python unit tests passed.
> --
> Total run:966
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/#review129447
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 (line 390)


Generalized this since canbe used by both Hive Server Batch and Interactive.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 204)


Unpack using a unique directory name.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 312)


This allows generating the conf.server dir with the configs inside of it.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 (line 114)


Write server configs to correct folder.


- Alejandro Fernandez


On April 18, 2016, 11:24 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46351/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15955
> https://issues.apache.org/jira/browse/AMBARI-15955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive should also create a conf.server folder (similar to 
> Hive Server Batch), in order to distinguish the configs used by the server 
> and client.
> 
> Further, when it starts the LLAP App on slider, it can specify which folder 
> to unpack it it,
> E.g., 
> ```
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> -slider-am-container-mb {size} --loglevel INFO --output {directory}
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2ee491 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9cfd41f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  33e8e47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  92e67c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1205202 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  feca9f1 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
> 
> Diff: https://reviews.apache.org/r/46351/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster by installing Hive Server Interactive with LLAP, and 
> then restarting HSI and LLAP.
> 
> Python unit tests passed.
> --
> Total run:966
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/
---

Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.


Bugs: AMBARI-15955
https://issues.apache.org/jira/browse/AMBARI-15955


Repository: ambari


Description
---

Hive Server Interactive should also create a conf.server folder (similar to 
Hive Server Batch), in order to distinguish the configs used by the server and 
client.

Further, when it starts the LLAP App on slider, it can specify which folder to 
unpack it it,
E.g., 
```
/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
-slider-am-container-mb {size} --loglevel INFO --output {directory}
```


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 a2ee491 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 9cfd41f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 8adff0a 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 9d011a0 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 33e8e47 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 92e67c7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 1205202 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 feca9f1 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ac4f6fc 

Diff: https://reviews.apache.org/r/46351/diff/


Testing
---

Verified on live cluster by installing Hive Server Interactive with LLAP, and 
then restarting HSI and LLAP.

Python unit tests passed.
--
Total run:966
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez