date:20161017


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review152992
---



This patch does not apply cleanly against master (ac8b802), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 17, 2016, 11:35 p.m., Pradyumna Kaushik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> ---
> 
> (Updated Oct. 17, 2016, 11:35 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 
> c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> f783e7ff220573915524a1efc27141193d19fa6c 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 
> 5d319557057e27fd5fc6d3e553e9ca9139399c50 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
> d390c07522d22e43d79ce4370985f3643ef021ca 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 
> 9e3573252cf37153180b1fc5ab9150bab0299c99 
>   src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> d9b3cc672f42c50b2a2a142733d26c0725bbc864 
> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint



> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144
> > 
> >
> > This split looks kind of magic. What does it do?
> 
> Pradyumna Kaushik wrote:
> Joiner.on(...) would return a comma separated string of reasons. I need 
> to convert that to a List. I am splitting the comma separated string 
> (returned by Joiner.on(...)) with  comma  number of spaces after> so that I end up with a String[] of reasons. I pass 
> this String[] of reasons to Arrays.asList(...) to generate a List.
> 
> I will comment that line of code so that it is understandable as to what 
> I am doing.
> 
> Pradyumna Kaushik wrote:
> I can just make NearestFit#getPendingReasons() return Map String[]> instead of Map. This way, I won't need 
> to convert String[] into List using Arrays.asList(...). Please let me 
> know which would be better.

Just posted the changes mentioned above for review.


- Pradyumna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review152852
---


On Oct. 17, 2016, 11:35 p.m., Pradyumna Kaushik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> ---
> 
> (Updated Oct. 17, 2016, 11:35 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 
> c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> f783e7ff220573915524a1efc27141193d19fa6c 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 
> 5d319557057e27fd5fc6d3e553e9ca9139399c50 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
> d390c07522d22e43d79ce4370985f3643ef021ca 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 
> 9e3573252cf37153180b1fc5ab9150bab0299c99 
>   src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> d9b3cc672f42c50b2a2a142733d26c0725bbc864 
> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/
---

(Updated Oct. 17, 2016, 11:35 p.m.)


Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Added the 'reason' to the /pendingTasks endpoint


Diffs (updated)
-

  config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
  src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 
c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
f783e7ff220573915524a1efc27141193d19fa6c 
  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 
5d319557057e27fd5fc6d3e553e9ca9139399c50 
  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
d390c07522d22e43d79ce4370985f3643ef021ca 
  src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 
9e3573252cf37153180b1fc5ab9150bab0299c99 
  src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
d9b3cc672f42c50b2a2a142733d26c0725bbc864 

Diff: https://reviews.apache.org/r/51993/diff/


Testing
---

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Pradyumna Kaushik

Re: Review Request 52957: Handle the case where content type header is null.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52957/#review152979
---



Master (ac8b802) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 17, 2016, 10:38 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52957/
> ---
> 
> (Updated Oct. 17, 2016, 10:38 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1795
> https://issues.apache.org/jira/browse/AURORA-1795
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Per the 
> [documentation](http://docs.oracle.com/javaee/7/api/javax/servlet/ServletRequestWrapper.html#getContentType--)
>  `getContentType` can return `null`. This now handles that case gracefully.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
> 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 
> 
> Diff: https://reviews.apache.org/r/52957/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 52957: Handle the case where content type header is null.

2016-10-17 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52957/
---

Review request for Aurora and Stephan Erb.


Bugs: AURORA-1795
https://issues.apache.org/jira/browse/AURORA-1795


Repository: aurora


Description
---

Per the 
[documentation](http://docs.oracle.com/javaee/7/api/javax/servlet/ServletRequestWrapper.html#getContentType--)
 `getContentType` can return `null`. This now handles that case gracefully.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 

Diff: https://reviews.apache.org/r/52957/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 52821: Fix the -enable_revocable_ram flag


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/#review152972
---



Master (ac8b802) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 17, 2016, 9:52 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52821/
> ---
> 
> (Updated Oct. 17, 2016, 9:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1794
> https://issues.apache.org/jira/browse/AURORA-1794
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The mentioned flag has been introduced in 
> https://reviews.apache.org/r/51807/. Unfortunately, as detailed in the bug 
> report, my testing was not thorough enough. 
> 
> Problem description:
> 
> * The flag is used the `ResourceType` enum constructor. This implies the flag 
> value needs to be available during class loading.
> * Values supplied via the scheduler command line are only set at runtime, 
> right at the beginning `main` [1].
> * Luckily, there is a check in our arg parsing library that warns if a value 
> is changed after it has already been read. In other words: We get an 
> exception if we change the flag, because it has already been read during 
> class loading.
> 
> This patch corrects this issue by treating the arguments as a supplier which 
> can be read lazily at runtime. The patch also extends the existing e2e test 
> for revocable resources to also consider RAM.
> 
> [1] 
> https://github.com/apache/aurora/blob/b417be38fe1fcae6b85f7e91cea961ab272adf3f/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java#L197
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 368f91720e9c8f84e139538a020da577e637851b 
>   commons-args/src/main/java/org/apache/aurora/common/args/Arg.java 
> 8e915c6233428ca35d3ee11ea8d7b7c008a88568 
>   examples/vagrant/mesos_config/etc_mesos-slave/modules 
> 4352bcad8022e9a82fe1e13744a02d1105e52fe9 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4d1f0c6a53e995f845512b64b4f78e0a5a72 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java 
> c49fd06cd11f4269b5c0b25014d22707c513fa5d 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> e1a5dcef726f021df89bccb7e81e63fe60336009 
> 
> Diff: https://reviews.apache.org/r/52821/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52821: Fix the -enable_revocable_ram flag


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/#review152964
---



This patch does not apply cleanly against master (ac8b802), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 17, 2016, 9:24 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52821/
> ---
> 
> (Updated Oct. 17, 2016, 9:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1794
> https://issues.apache.org/jira/browse/AURORA-1794
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The mentioned flag has been introduced in 
> https://reviews.apache.org/r/51807/. Unfortunately, as detailed in the bug 
> report, my testing was not thorough enough. 
> 
> Problem description:
> 
> * The flag is used the `ResourceType` enum constructor. This implies the flag 
> value needs to be available during class loading.
> * Values supplied via the scheduler command line are only set at runtime, 
> right at the beginning `main` [1].
> * Luckily, there is a check in our arg parsing library that warns if a value 
> is changed after it has already been read. In other words: We get an 
> exception if we change the flag, because it has already been read during 
> class loading.
> 
> This patch corrects this issue by treating the arguments as a supplier which 
> can be read lazily at runtime. The patch also extends the existing e2e test 
> for revocable resources to also consider RAM.
> 
> [1] 
> https://github.com/apache/aurora/blob/b417be38fe1fcae6b85f7e91cea961ab272adf3f/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java#L197
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 
>   commons-args/src/main/java/org/apache/aurora/common/args/Arg.java 
> 8e915c6233428ca35d3ee11ea8d7b7c008a88568 
>   examples/vagrant/mesos_config/etc_mesos-slave/modules 
> 4352bcad8022e9a82fe1e13744a02d1105e52fe9 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4d1f0c6a53e995f845512b64b4f78e0a5a72 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java 
> c49fd06cd11f4269b5c0b25014d22707c513fa5d 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> e1a5dcef726f021df89bccb7e81e63fe60336009 
> 
> Diff: https://reviews.apache.org/r/52821/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52821: Fix the -enable_revocable_ram flag

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/
---

(Updated Oct. 17, 2016, 11:24 p.m.)

Review request for Aurora, Joshua Cohen and Zameer Manji.

Changes
---

Rename FALSE_SUPPLIER to NOT_REVOCABLE.

Bugs: AURORA-1794
https://issues.apache.org/jira/browse/AURORA-1794

Repository: aurora

Description
---

The mentioned flag has been introduced in https://reviews.apache.org/r/51807/.
Unfortunately, as detailed in the bug report, my testing was not thorough
enough.

Problem description:

* The flag is used the `ResourceType` enum constructor. This implies the flag
value needs to be available during class loading.
* Values supplied via the scheduler command line are only set at runtime, right
at the beginning `main` [1].
* Luckily, there is a check in our arg parsing library that warns if a value is
changed after it has already been read. In other words: We get an exception if
we change the flag, because it has already been read during class loading.

This patch corrects this issue by treating the arguments as a supplier which
can be read lazily at runtime. The patch also extends the existing e2e test for
revocable resources to also consider RAM.

[1]
https://github.com/apache/aurora/blob/b417be38fe1fcae6b85f7e91cea961ab272adf3f/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java#L197

Diffs (updated)
-

RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273
commons-args/src/main/java/org/apache/aurora/common/args/Arg.java
8e915c6233428ca35d3ee11ea8d7b7c008a88568
examples/vagrant/mesos_config/etc_mesos-slave/modules
4352bcad8022e9a82fe1e13744a02d1105e52fe9
examples/vagrant/upstart/aurora-scheduler.conf
4d1f0c6a53e995f845512b64b4f78e0a5a72
src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java
c49fd06cd11f4269b5c0b25014d22707c513fa5d
src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java
e1a5dcef726f021df89bccb7e81e63fe60336009

Diff: https://reviews.apache.org/r/52821/diff/

Testing
---

./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Thanks,

Stephan Erb

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint



> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144
> > 
> >
> > This split looks kind of magic. What does it do?
> 
> Pradyumna Kaushik wrote:
> Joiner.on(...) would return a comma separated string of reasons. I need 
> to convert that to a List. I am splitting the comma separated string 
> (returned by Joiner.on(...)) with  comma  number of spaces after> so that I end up with a String[] of reasons. I pass 
> this String[] of reasons to Arrays.asList(...) to generate a List.
> 
> I will comment that line of code so that it is understandable as to what 
> I am doing.

I can just make NearestFit#getPendingReasons() return Map instead of Map. This way, I won't need to 
convert String[] into List using Arrays.asList(...). Please let me know 
which would be better.


- Pradyumna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review152852
---


On Oct. 15, 2016, 6:56 p.m., Pradyumna Kaushik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> ---
> 
> (Updated Oct. 15, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 
> c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> f783e7ff220573915524a1efc27141193d19fa6c 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 
> 5d319557057e27fd5fc6d3e553e9ca9139399c50 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
> d390c07522d22e43d79ce4370985f3643ef021ca 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 
> 9e3573252cf37153180b1fc5ab9150bab0299c99 
>   src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> d9b3cc672f42c50b2a2a142733d26c0725bbc864 
> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint



> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144
> > 
> >
> > This split looks kind of magic. What does it do?

Joiner.on(...) would return a comma separated string of reasons. I need to 
convert that to a List. I am splitting the comma separated string 
(returned by Joiner.on(...)) with  comma  so that I end up with a String[] of reasons. I pass 
this String[] of reasons to Arrays.asList(...) to generate a List.

I will comment that line of code so that it is understandable as to what I am 
doing.


> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java, lines 
> > 67-70
> > 
> >
> > I am not sure if I understand this code correctly. How does this ensure 
> > we attatch the `reason` to the correct taskgroup in the json.

In NearestFit#getPendingReasons(...) I am using a LinkedHashMap<> to maintain 
insertion order and filling it in the order of items in taskGroups.getGroups().
So, the order in which the reasons are filled in, is the same as the order of 
items in taskGroups.getGroups().
This is why I can be sure that the reason would correspond to the correct 
pendingtask.

I can make a small change, where I am picking the value corresponding to the 
right key. In fact it would be much more clearer that way.


- Pradyumna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review152852
---


On Oct. 15, 2016, 6:56 p.m., Pradyumna Kaushik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> ---
> 
> (Updated Oct. 15, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 
> c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> f783e7ff220573915524a1efc27141193d19fa6c 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 
> 5d319557057e27fd5fc6d3e553e9ca9139399c50 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
> d390c07522d22e43d79ce4370985f3643ef021ca 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 
> 9e3573252cf37153180b1fc5ab9150bab0299c99 
>   src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> d9b3cc672f42c50b2a2a142733d26c0725bbc864 
> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-17 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/#review152917
---


Ship it!




Ship It!

- Zameer Manji


On Oct. 13, 2016, 2:27 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52821/
> ---
> 
> (Updated Oct. 13, 2016, 2:27 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1794
> https://issues.apache.org/jira/browse/AURORA-1794
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The mentioned flag has been introduced in 
> https://reviews.apache.org/r/51807/. Unfortunately, as detailed in the bug 
> report, my testing was not thorough enough. 
> 
> Problem description:
> 
> * The flag is used the `ResourceType` enum constructor. This implies the flag 
> value needs to be available during class loading.
> * Values supplied via the scheduler command line are only set at runtime, 
> right at the beginning `main` [1].
> * Luckily, there is a check in our arg parsing library that warns if a value 
> is changed after it has already been read. In other words: We get an 
> exception if we change the flag, because it has already been read during 
> class loading.
> 
> This patch corrects this issue by treating the arguments as a supplier which 
> can be read lazily at runtime. The patch also extends the existing e2e test 
> for revocable resources to also consider RAM.
> 
> [1] 
> https://github.com/apache/aurora/blob/b417be38fe1fcae6b85f7e91cea961ab272adf3f/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java#L197
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 
>   commons-args/src/main/java/org/apache/aurora/common/args/Arg.java 
> 8e915c6233428ca35d3ee11ea8d7b7c008a88568 
>   examples/vagrant/mesos_config/etc_mesos-slave/modules 
> 4352bcad8022e9a82fe1e13744a02d1105e52fe9 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4d1f0c6a53e995f845512b64b4f78e0a5a72 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java 
> c49fd06cd11f4269b5c0b25014d22707c513fa5d 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> e1a5dcef726f021df89bccb7e81e63fe60336009 
> 
> Diff: https://reviews.apache.org/r/52821/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.

2016-10-17 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52915/#review152894
---


Ship it!




Ship It!

- Joshua Cohen


On Oct. 15, 2016, 10:42 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52915/
> ---
> 
> (Updated Oct. 15, 2016, 10:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This gets rid of an impossible to work around warning emitted by every
> pants invocation and prepares for consuming an upcoming pants change
> that will allow Aurora to use the thrift binary selected by
> `build-support/thrift/thriftw` consistently everywhere.
> 
> Release notes are here:
>   http://www.pantsbuild.org/notes-master.html
> 
>  pants.ini | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> 
> Diffs
> -
> 
>   pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c 
> 
> Diff: https://reviews.apache.org/r/52915/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./build-support/python/make-pycharm-virtualenv
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152893
---


Ship it!




Ship It!

- John Sirois


On Oct. 16, 2016, 5:04 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52921/
> ---
> 
> (Updated Oct. 16, 2016, 5:04 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> as well. Details: https://github.com/apache/thrift/pull/1106
> 
> Example of a generated equals method (in ITaskConfig):
> 
> @Override
> public boolean equals(Object o) {
>   if (this == o) {
> return true;
>   }
>   if (!(o instanceof ITaskConfig)) {
> return false;
>   }
>   ITaskConfig other = (ITaskConfig) o;
>   return Objects.equals(job, other.job)
>   && Objects.equals(owner, other.owner)
>   && Objects.equals(isService, other.isService)
>   && Objects.equals(numCpus, other.numCpus)
>   && Objects.equals(ramMb, other.ramMb)
>   && Objects.equals(diskMb, other.diskMb)
>   && Objects.equals(priority, other.priority)
>   && Objects.equals(maxTaskFailures, other.maxTaskFailures)
>   && Objects.equals(production, other.production)
>   && Objects.equals(tier, other.tier)
>   && Objects.equals(resources, other.resources)
>   && Objects.equals(constraints, other.constraints)
>   && Objects.equals(requestedPorts, other.requestedPorts)
>   && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
>   && Objects.equals(taskLinks, other.taskLinks)
>   && Objects.equals(contactEmail, other.contactEmail)
>   && Objects.equals(executorConfig, other.executorConfig)
>   && Objects.equals(metadata, other.metadata)
>   && Objects.equals(container, other.container);
> }
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> 7c281800b00b973351659ecacd5b7f6e55e46bba 
> 
> Diff: https://reviews.apache.org/r/52921/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread John Sirois



> On Oct. 17, 2016, 9:41 a.m., Joshua Cohen wrote:
> > Should we also add:
> > 
> > if (o == null) {
> >   return false;
> > }
> > 
> > ?
> > 
> > Curious if we're able to see a difference in benchmarks from this change?

It would be a bit of black magic if that were significantly faster than the 
!instanceof check.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152889
---


On Oct. 16, 2016, 5:04 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52921/
> ---
> 
> (Updated Oct. 16, 2016, 5:04 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> as well. Details: https://github.com/apache/thrift/pull/1106
> 
> Example of a generated equals method (in ITaskConfig):
> 
> @Override
> public boolean equals(Object o) {
>   if (this == o) {
> return true;
>   }
>   if (!(o instanceof ITaskConfig)) {
> return false;
>   }
>   ITaskConfig other = (ITaskConfig) o;
>   return Objects.equals(job, other.job)
>   && Objects.equals(owner, other.owner)
>   && Objects.equals(isService, other.isService)
>   && Objects.equals(numCpus, other.numCpus)
>   && Objects.equals(ramMb, other.ramMb)
>   && Objects.equals(diskMb, other.diskMb)
>   && Objects.equals(priority, other.priority)
>   && Objects.equals(maxTaskFailures, other.maxTaskFailures)
>   && Objects.equals(production, other.production)
>   && Objects.equals(tier, other.tier)
>   && Objects.equals(resources, other.resources)
>   && Objects.equals(constraints, other.constraints)
>   && Objects.equals(requestedPorts, other.requestedPorts)
>   && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
>   && Objects.equals(taskLinks, other.taskLinks)
>   && Objects.equals(contactEmail, other.contactEmail)
>   && Objects.equals(executorConfig, other.executorConfig)
>   && Objects.equals(metadata, other.metadata)
>   && Objects.equals(container, other.container);
> }
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> 7c281800b00b973351659ecacd5b7f6e55e46bba 
> 
> Diff: https://reviews.apache.org/r/52921/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152889
---



Should we also add:

if (o == null) {
  return false;
}

?

Curious if we're able to see a difference in benchmarks from this change?

- Joshua Cohen


On Oct. 16, 2016, 11:04 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52921/
> ---
> 
> (Updated Oct. 16, 2016, 11:04 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> as well. Details: https://github.com/apache/thrift/pull/1106
> 
> Example of a generated equals method (in ITaskConfig):
> 
> @Override
> public boolean equals(Object o) {
>   if (this == o) {
> return true;
>   }
>   if (!(o instanceof ITaskConfig)) {
> return false;
>   }
>   ITaskConfig other = (ITaskConfig) o;
>   return Objects.equals(job, other.job)
>   && Objects.equals(owner, other.owner)
>   && Objects.equals(isService, other.isService)
>   && Objects.equals(numCpus, other.numCpus)
>   && Objects.equals(ramMb, other.ramMb)
>   && Objects.equals(diskMb, other.diskMb)
>   && Objects.equals(priority, other.priority)
>   && Objects.equals(maxTaskFailures, other.maxTaskFailures)
>   && Objects.equals(production, other.production)
>   && Objects.equals(tier, other.tier)
>   && Objects.equals(resources, other.resources)
>   && Objects.equals(constraints, other.constraints)
>   && Objects.equals(requestedPorts, other.requestedPorts)
>   && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
>   && Objects.equals(taskLinks, other.taskLinks)
>   && Objects.equals(contactEmail, other.contactEmail)
>   && Objects.equals(executorConfig, other.executorConfig)
>   && Objects.equals(metadata, other.metadata)
>   && Objects.equals(container, other.container);
> }
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> 7c281800b00b973351659ecacd5b7f6e55e46bba 
> 
> Diff: https://reviews.apache.org/r/52921/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52884: Document how to create a custom CLI build


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review152861
---


Ship it!




Master (ac8b802) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 14, 2016, 3:03 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> ---
> 
> (Updated Oct. 14, 2016, 3:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document how to create a custom pex that you can use to put 
> deployment-specific customizations.
> 
> I think the dependency section needs some work, but I'm not an expert on 
> pants and how it resolves dependencies. Currently we just have the forked 
> sources in the same repo, so we can point directly to the OSS build target. I 
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left 
> to the user to make that dependency available in their repo. Can anyone help 
> fill out that section?
> 
> 
> Diffs
> -
> 
>   docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 
> 
> Diff: https://reviews.apache.org/r/52884/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 52588: Enable per task volume mounts via scheduler API



> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java,
> >  lines 246-248
> > 
> >
> > I believe this is not true. Mesos is ignoring the mode, but the volume 
> > is still writable. At least it used to be the case. 
> > 
> > In our setup, we are mounting a writable `/cache` folder into each 
> > container as a spill area that is secured by default linux filesystem 
> > permissions.
> 
> Zameer Manji wrote:
> This was a request from Josh,
> 
> I will let you and Josh fight it out here on what we should do. The code 
> appears to not take into account mode, so I'm not sure if the result is 
> writable or read only mounts.
> 
> Stephan Erb wrote:
> I have verified in Vagrant: The mode is always ignored. Mesos simply 
> performs the mount and the rest is up to normal filesystem permissions, i.e. 
> read-write is possible.
> 
> * I have modified the job `examples/jobs/hello_docker_image.aurora` to 
> begin with a `echo WRITE_WORKED > /cache/maybe-writable`. This jobs uses the 
> role `www-data`
> * Furthermore, I modified the scheduler to launch with `  
> -global_container_mounts=/tmp:/cache:ro` 
> * An `ls -l /tmp` on the agent then shows `-rw-r--r-- 1 www-data  
> www-data367 Oct 11 16:30 maybe-writable`
> 
> Joshua Cohen wrote:
> I guess on further reflection what it is, is that the result is strictly 
> based on the underlying filesystem permissions and not on the mode passed in. 
> Perhaps the right behavior is to just not support mode at all, since 
> regardless of the value passed in it's the underlying permissions that 
> control the behavior.
> 
> Alternately we could update the executor to respect the mode, it's a bit 
> tricky to get right though: https://lwn.net/Articles/281157/.
> 
> Stephan Erb wrote:
> -1 one extending the executor. I'd rather see this addressed by Mesos 
> eventually.
> 
> Zameer Manji wrote:
> Do I remove this check then? Seems like I should

Yeah, I think there are two options: Either you drop the check, or you invert 
it to indicate that only `RW` mounts are supported.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151682
---


On Oct. 7, 2016, 9:19 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52588/
> ---
> 
> (Updated Oct. 7, 2016, 9:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This allows users to specify volume mounts for tasks using the unified
> containerizer if the operator permits them. This is analogous to enabling 
> docker
> parameters per task and using the `--volume` parameter.
> 
> This does not include the needed DSL changes or an e2e test which will be in a
> subsequent diff.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 0c74665f750571ccfdeda5a0b71cccbe169716a7 
>   docs/reference/scheduler-configuration.md 
> e6b19f01ef276962143dabbaeec4fdf980291a28 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 3bd22a0d47cf0793c749b008ccbdf58033c75a11 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  701f79c900e1d5794741475333805d1c12af58dd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 9038c36e4ae05ade273a1c218b7a7e8af218ae39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> acb44984b4aa38bbe1cac8f805754d55dbe39f3a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> e137e57a0b111b9320e6902aa586d7f24e0d5c58 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 151306a567448c45223e90c8a29ac6ecbc9f6653 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  e30c387239e868daedf496dd886df4d8c00f1fc3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
>

Re: Review Request 52884: Document how to create a custom CLI build


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review152857
---



@ReviewBot retry

- Stephan Erb


On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> ---
> 
> (Updated Oct. 14, 2016, 5:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document how to create a custom pex that you can use to put 
> deployment-specific customizations.
> 
> I think the dependency section needs some work, but I'm not an expert on 
> pants and how it resolves dependencies. Currently we just have the forked 
> sources in the same repo, so we can point directly to the OSS build target. I 
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left 
> to the user to make that dependency available in their repo. Can anyone help 
> fill out that section?
> 
> 
> Diffs
> -
> 
>   docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 
> 
> Diff: https://reviews.apache.org/r/52884/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 52884: Document how to create a custom CLI build


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review152858
---


Ship it!




Ship It!

- Stephan Erb


On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> ---
> 
> (Updated Oct. 14, 2016, 5:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document how to create a custom pex that you can use to put 
> deployment-specific customizations.
> 
> I think the dependency section needs some work, but I'm not an expert on 
> pants and how it resolves dependencies. Currently we just have the forked 
> sources in the same repo, so we can point directly to the OSS build target. I 
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left 
> to the user to make that dependency available in their repo. Can anyone help 
> fill out that section?
> 
> 
> Diffs
> -
> 
>   docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 
> 
> Diff: https://reviews.apache.org/r/52884/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review152853
---




docs/features/containers.md (line 120)


Please also mention this field in 
https://github.com/apache/aurora/blob/master/docs/reference/client-cluster-configuration.md



src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (lines 445 - 453)


If I remember our vagrant setup correctly, then:

* images are not downloaded from a registry but fetched from a local folder
* the examples in `docs/features/containers.md` and 
`examples/jobs/hello_docker_engine.aurora` are broken because they try to fetch 
an image from the internet which cannot be found in the local folder with 
Docker images. 

In addition, this code seems to indicate that:

* the registry will only used for the sha lookup 
* the clusters json is modified even though there would be no harm in 
keeping the registry defined all the time

Correct?

Is it possible that the registry acts as a transparent cache so that local 
and remote images can be found? This would help to streamline the issues 
mentioned above.


- Stephan Erb


On Oct. 13, 2016, 6:41 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52479/
> ---
> 
> (Updated Oct. 13, 2016, 6:41 a.m.)
> 
> 
> Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1014
> https://issues.apache.org/jira/browse/AURORA-1014
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Resolve docker tags to concrete identifiers for DockerContainerizer
> 
> Docker tags are mutable and can point to different different images
> at different points in time. This makes a job launched with a Docker
> image to be mutable across restarts of the job. This breaks Aurora's
> guarantee of job immutability (except via job updates).
> 
> This change introduces a binding helper, that resolves docker name:tag
> to a concrete registry/name@digest identifier. Identifying
> docker images via a content-addressable digest is available via the
> Docker Registry v2, that is a prerequisite for this feature.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 2fb6f4c76c0da9f7958f9b161e701eb894125481 
>   RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 
>   build-support/packer/build.sh f5157a60dcabde3e4cd8f6655f1010771f14b702 
>   docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf 
>   examples/jobs/hello_docker_engine.aurora 
> 3c830e8f99f07732ae985b0aad114c3346888765 
>   src/main/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/client/binding_helpers/__init__.py 
> PRE-CREATION 
>   src/main/python/apache/aurora/client/binding_helpers/docker_helper.py 
> PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/client.py 
> fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
>   src/main/python/apache/aurora/client/docker/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/client/docker/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/client/docker/docker_client.py PRE-CREATION 
>   src/test/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/binding_helpers/__init__.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/binding_helpers/test_docker_helper.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/docker/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/docker/__init__.py PRE-CREATION 
>   src/test/python/apache/aurora/client/docker/test_docker_client.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/config/BUILD 
> 52b60409e1de2f69f181a83720ebe1c649b49166 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c71fb81490863b44827bf090f6e5a6b28da94b93 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 
> 4fa387d5184968e456bf4c8388496f0514454cb1 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> b279b4f679cc6843e99806bcbf57350ba1c9a6e0 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> c93be9b4b4c76186445ae13eb9424bbf9de9b202 
> 
> Diff: https://reviews.apache.org/r/52479/diff/
> 
> 
> Testing
> ---
> 
> build-support/jenkins/build.sh
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint