Re: Review Request 51107: Thrift API change to support instance-specific task config in JobConfiguration

2016-08-15 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51107/#review145805
---



-1 to this change. Please, see here for reasons behind it: 
http://markmail.org/message/d4j6lkncqkua5a23

- Maxim Khutornenko


On Aug. 15, 2016, 9:11 p.m., Min Cai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51107/
> ---
> 
> (Updated Aug. 15, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implement instance-specific task config in JobConfiguration
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> b799cce665c99ee20fba84a9ddcb5a895ff5685e 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  264cb7cb38809a3a37b13b76e93f423ec03fbacc 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> c07551e94f9221b5b21c5dc9715e82caa290c2e8 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> d395104af84477b03649ddd65276fbd1dc1e9210 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> ffa9481fa4d2f5e1cf74f5819b398e3cb74f1010 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b534abf95bab6e1657e3ef993cf34c0d6ec460be 
>   
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
> 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6 
> 
> Diff: https://reviews.apache.org/r/51107/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Min Cai
> 
>



Re: Review Request 51107: Thrift API change to support instance-specific task config in JobConfiguration

2016-08-15 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51107/#review145804
---



Master (a4fdf28) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java:29:
 error: Wrong order for 
'org.apache.aurora.scheduler.storage.entities.IInstanceTaskConfig' import. 
Order should be: java, javax, scala, com, net, org. Each group should 
be separated by a single blank line.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java:153:
 error: Line is longer than 100 characters (found 101).
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/StateManager.java:23:
 error: Wrong order for 'org.apache.aurora.gen.InstanceTaskConfig' import. 
Order should be: java, javax, scala, com, net, org. Each group should 
be separated by a single blank line.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/StateManager.java:23:8:
 error: Unused import - org.apache.aurora.gen.InstanceTaskConfig.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java:38:
 error: Wrong order for 'com.google.common.collect.RangeMap' import. Order 
should be: java, javax, scala, com, net, org. Each group should be 
separated by a single blank line.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java:41:8:
 error: Unused import - org.apache.aurora.gen.InstanceTaskConfig.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java:42:
 error: Wrong order for 'org.apache.aurora.gen.AssignedTask' import. Order 
should be: java, javax, scala, com, net, org. Each group should be 
separated by a single blank line.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:37:8:
 error: Unused import - com.google.common.collect.RangeMap.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 36.898 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 15, 2016, 9:11 p.m., Min Cai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51107/
> ---
> 
> (Updated Aug. 15, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implement instance-specific task config in JobConfiguration
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> b799cce665c99ee20fba84a9ddcb5a895ff5685e 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  264cb7cb38809a3a37b13b76e93f423ec03fbacc 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> c07551e94f9221b5b21c5dc9715e82caa290c2e8 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> d395104af84477b03649ddd65276fbd1dc1e9210 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> ffa9481fa4d2f5e1cf74f5819b398e3cb74f1010 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b534abf95bab6e1657e3ef993cf34c0d6ec460be 
>   
>