Re: Review Request 54567: Fixup prepare_binary.sh to work under modern bash.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/#review158639 --- Ship it! Master (dd86d2f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 9, 2016, 3:58 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54567/ > --- > > (Updated Dec. 9, 2016, 3:58 a.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Previously pushd/popd were used and these emit data to stdout muddying > pants output and breaking setup of the thrift serve dir structure. > > build-support/thrift/prepare_binary.sh | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > > Diffs > - > > build-support/thrift/prepare_binary.sh > e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c > > Diff: https://reviews.apache.org/r/54567/diff/ > > > Testing > --- > > Reproduced the current master CI failure before this change on my linux > machine. > Fixed with this change. > > > Thanks, > > John Sirois > >
Re: Review Request 54567: Fixup prepare_binary.sh to work under modern bash.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/#review158638 --- Ship it! Ship It! - Joshua Cohen On Dec. 9, 2016, 3:58 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54567/ > --- > > (Updated Dec. 9, 2016, 3:58 a.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Previously pushd/popd were used and these emit data to stdout muddying > pants output and breaking setup of the thrift serve dir structure. > > build-support/thrift/prepare_binary.sh | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > > Diffs > - > > build-support/thrift/prepare_binary.sh > e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c > > Diff: https://reviews.apache.org/r/54567/diff/ > > > Testing > --- > > Reproduced the current master CI failure before this change on my linux > machine. > Fixed with this change. > > > Thanks, > > John Sirois > >
Review Request 54567: Fixup prepare_binary.sh to work under modern bash.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54567/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --- Previously pushd/popd were used and these emit data to stdout muddying pants output and breaking setup of the thrift serve dir structure. build-support/thrift/prepare_binary.sh | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Diffs - build-support/thrift/prepare_binary.sh e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c Diff: https://reviews.apache.org/r/54567/diff/ Testing --- Reproduced the current master CI failure before this change on my linux machine. Fixed with this change. Thanks, John Sirois