Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

2017-12-03 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64284/#review192646
---


Ship it!




Ship It!

- Bill Farner


On Dec. 3, 2017, 5:20 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64284/
> ---
> 
> (Updated Dec. 3, 2017, 5:20 a.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
> 
> 
> Bugs: AURORA-1901
> https://issues.apache.org/jira/browse/AURORA-1901
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Expose thrift workload stats on pruneTasks() invocations
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a519b0728b02b5ccdaaa5566566aae4691f07ffa 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  883738446a093e464630d06f1241832129165fcc 
> 
> 
> Diff: https://reviews.apache.org/r/64284/diff/1/
> 
> 
> Testing
> ---
> 
> curl 192.168.33.7:8081/vars | grep thrift_workload_pruneTasks
>   % Total% Received % Xferd  Average Speed   TimeTime Time  
> Current
>  Dload  Upload   Total   SpentLeft  Speed
> 100 260530 260530 0  4074k  0 --:--:-- --:--:-- --:--:-- 4240k
> thrift_workload_pruneTasks 0
> 
> 
> Thanks,
> 
> Jing Chen
> 
>



Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

2017-12-03 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64284/#review192645
---


Ship it!




Ship It!

- Stephan Erb


On Dez. 3, 2017, 2:20 nachm., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64284/
> ---
> 
> (Updated Dez. 3, 2017, 2:20 nachm.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
> 
> 
> Bugs: AURORA-1901
> https://issues.apache.org/jira/browse/AURORA-1901
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Expose thrift workload stats on pruneTasks() invocations
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a519b0728b02b5ccdaaa5566566aae4691f07ffa 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  883738446a093e464630d06f1241832129165fcc 
> 
> 
> Diff: https://reviews.apache.org/r/64284/diff/1/
> 
> 
> Testing
> ---
> 
> curl 192.168.33.7:8081/vars | grep thrift_workload_pruneTasks
>   % Total% Received % Xferd  Average Speed   TimeTime Time  
> Current
>  Dload  Upload   Total   SpentLeft  Speed
> 100 260530 260530 0  4074k  0 --:--:-- --:--:-- --:--:-- 4240k
> thrift_workload_pruneTasks 0
> 
> 
> Thanks,
> 
> Jing Chen
> 
>



Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

2017-12-03 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64284/#review192644
---


Ship it!




Master (cea43db) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 3, 2017, 1:20 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64284/
> ---
> 
> (Updated Dec. 3, 2017, 1:20 p.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
> 
> 
> Bugs: AURORA-1901
> https://issues.apache.org/jira/browse/AURORA-1901
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Expose thrift workload stats on pruneTasks() invocations
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a519b0728b02b5ccdaaa5566566aae4691f07ffa 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  883738446a093e464630d06f1241832129165fcc 
> 
> 
> Diff: https://reviews.apache.org/r/64284/diff/1/
> 
> 
> Testing
> ---
> 
> curl 192.168.33.7:8081/vars | grep thrift_workload_pruneTasks
>   % Total% Received % Xferd  Average Speed   TimeTime Time  
> Current
>  Dload  Upload   Total   SpentLeft  Speed
> 100 260530 260530 0  4074k  0 --:--:-- --:--:-- --:--:-- 4240k
> thrift_workload_pruneTasks 0
> 
> 
> Thanks,
> 
> Jing Chen
> 
>



Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

2017-12-03 Thread Jing Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64284/
---

Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.


Bugs: AURORA-1901
https://issues.apache.org/jira/browse/AURORA-1901


Repository: aurora


Description
---

Expose thrift workload stats on pruneTasks() invocations


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
a519b0728b02b5ccdaaa5566566aae4691f07ffa 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 883738446a093e464630d06f1241832129165fcc 


Diff: https://reviews.apache.org/r/64284/diff/1/


Testing
---

curl 192.168.33.7:8081/vars | grep thrift_workload_pruneTasks
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100 260530 260530 0  4074k  0 --:--:-- --:--:-- --:--:-- 4240k
thrift_workload_pruneTasks 0


Thanks,

Jing Chen