[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. java: fix a mistaken reference-equality check for BigDecimal predicates KuduPredicate used == instead of .equals() to check whether a supplied value was equal to the maximum value for the specified decimal type. This could result in too-conservative pruning. Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Reviewed-on: http://gerrit.cloudera.org:8080/10203 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Gerrit-Change-Number: 10203 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Patch Set 2: Verified+1 Code-Review+2 Porting forward +2 -- To view, visit http://gerrit.cloudera.org:8080/10203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Gerrit-Change-Number: 10203 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 26 Apr 2018 22:22:18 + Gerrit-HasComments: No
[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates
Todd Lipcon has removed a vote on this change. Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Gerrit-Change-Number: 10203 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10203 ) Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Gerrit-Change-Number: 10203 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 26 Apr 2018 14:46:29 + Gerrit-HasComments: No
[kudu-CR] java: fix a mistaken reference-equality check for BigDecimal predicates
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10203 to review the following change. Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates .. java: fix a mistaken reference-equality check for BigDecimal predicates KuduPredicate used == instead of .equals() to check whether a supplied value was equal to the maximum value for the specified decimal type. This could result in too-conservative pruning. Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/10203/1 -- To view, visit http://gerrit.cloudera.org:8080/10203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93 Gerrit-Change-Number: 10203 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke