[kudu-CR] java: make all enum members immutable
Todd Lipcon has removed a vote on this change. Change subject: java: make all enum members immutable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: make all enum members immutable
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 26 Apr 2018 22:18:59 + Gerrit-HasComments: No
[kudu-CR] java: make all enum members immutable
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. java: make all enum members immutable This fixes instances of the ImmutableEnumChecker[1] error-prone check. This should be a non-functional change. [1] https://github.com/google/error-prone/blob/master/docs/bugpattern/ImmutableEnumChecker.md Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Reviewed-on: http://gerrit.cloudera.org:8080/10195 Reviewed-by: Grant Henke Tested-by: Todd Lipcon --- M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java M java/kudu-client/src/main/java/org/apache/kudu/Type.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java 8 files changed, 11 insertions(+), 11 deletions(-) Approvals: Grant Henke: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] java: make all enum members immutable
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 26 Apr 2018 17:42:25 + Gerrit-HasComments: No
[kudu-CR] java: make all enum members immutable
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10195 ) Change subject: java: make all enum members immutable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 26 Apr 2018 14:30:19 + Gerrit-HasComments: No
[kudu-CR] java: make all enum members immutable
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10195 to review the following change. Change subject: java: make all enum members immutable .. java: make all enum members immutable This fixes instances of the ImmutableEnumChecker[1] error-prone check. This should be a non-functional change. [1] https://github.com/google/error-prone/blob/master/docs/bugpattern/ImmutableEnumChecker.md Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d --- M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java M java/kudu-client/src/main/java/org/apache/kudu/Type.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java 8 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/10195/1 -- To view, visit http://gerrit.cloudera.org:8080/10195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia02dce78d6084e73ec4e5beb2e22aea2c206141d Gerrit-Change-Number: 10195 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke