[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-09-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage collocating
Kudu tablet servers other tablet servers on the same node.  Also,
fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Reviewed-on: http://gerrit.cloudera.org:8080/12997
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M docs/administration.adoc
1 file changed, 30 insertions(+), 18 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-09-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 03 Sep 2019 20:56:10 +
Gerrit-HasComments: No


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-09-03 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Alex Rodoni, Kudu Jenkins, Mitch Barnett, Adar Dembo, 

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12997

to look at the new patch set (#6).

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage collocating
Kudu tablet servers other tablet servers on the same node.  Also,
fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 30 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/6
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

> What is the status of this? Is this abandoned?

Whoops, it seems I forgot to revv it last time.  I updated the wording to 
discourage the master-tserver collocation.


--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 15 Aug 2019 17:09:28 +
Gerrit-HasComments: No


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-08-15 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Alex Rodoni, Kudu Jenkins, Mitch Barnett, Adar Dembo, 

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12997

to look at the new patch set (#5).

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage
collocating of Kudu tablet servers with masters and
other tablet servers.  Also, fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/5
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-08-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

What is the status of this? Is this abandoned?


--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Sat, 10 Aug 2019 01:01:25 +
Gerrit-HasComments: No


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
Interesting. Okay. I am onboard with this change. 

> What do you think of turning this recommendation to avoid master/tserver 
> collocation into a security-hardening point

I do prefer this style though. Given the security risk is theoretical.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 17 Apr 2019 21:03:22 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
> Ah, I take that note about Master and Tablet Server roles in CM back -- as
However, there is this role allocation recommendations: 
https://www.cloudera.com/documentation/enterprise/5/latest/topics/cm_ig_host_allocations.html



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:40:14 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

> Patch Set 4:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
> If I my understanding is correct, most of the tserver's code is not exposed
Ah, I take that note about Master and Tablet Server roles in CM back -- as it 
turned out, there isn't any restriction on collocating those, actually.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:32:56 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
> Given the tserver and master share a large amount of code and dependencies,
If I my understanding is correct, most of the tserver's code is not exposed via 
RPC-endpoints in master, so if there is a vulnerability in that tserver piece, 
Kudu masters will not be affected by that.

Do you have data-backed evidence that people tend to collocate masters and 
tservers on a single node?  I doubt that's the prevailing pattern of Kudu 
deploymen today, since at least the major commercial orchestration tool that 
manages Kudu clusters I know of (i.e. Cloudera Manager) doesn't tend to 
collocate Kudu master and tablet server roles on a single machine.

I agree that security-related restrictions like this might spook some users 
from using Kudu and hinder the adoption of the project some how, especially 
given the fact that at this point it's all about some hypothetical security 
vulnerabilities.

What do you think of turning this recommendation to avoid master/tserver 
collocation into a security-hardening point?  Or you think it's better to 
remove this piece at all from this document?



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:54:54 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
> Both kudu-master and kudu-tserver currently runs under 'kudu' OS user.  Kud
Given the tserver and master share a large amount of code and dependencies, I 
suspect most, if not all, vulnerabilities found in the tserver would also apply 
to the master server.

I think we could suggest placing masters on a separate node as an option to 
reduce this risk, but I worry about  making it our default recommendation not 
to colocate masters and tservers. I am pretty sure this is the most common 
deployment today. For users deploying on physical machines, they would need 3 
extra physical nodes with very little load/utilization.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 15 Apr 2019 14:03:55 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: surface area for attacks using tablet servers' security 
vulnerabilities, if any.
> To me, this makes it sound like there are known vulnerabilities, even thoug
Both kudu-master and kudu-tserver currently runs under 'kudu' OS user.  Kudu 
masters store sensitive crypto information under their data directories.  
Meanwhile, kudu-tserver processes does not store or have anything like that in 
their address space ever.  Once a vulnerability (at this point theoretical) 
discovered in kudu-tserver that allows for access to local filesystem, the 
sensitive data from master can be stolen.  Having private keys and CA cert, an 
impostor could have access to any data in the Kudu cluster, forging authn and 
authz tokens, etc.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Sun, 14 Apr 2019 18:11:21 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/4/docs/administration.adoc@821
PS4, Line 821: unrelated workloads against the cluster when the newly added 
tablet server
To me, this makes it sound like there are known vulnerabilities, even though it 
says "if any" afterwords.

I am not sure I buy into this recommendation. Maybe I need more context. Why 
does being co-located matter in relation to theoretical vulnerabilities? 
Assuming we don't know what the vulnerability is, we can't say being co-located 
or separate matters.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Sun, 14 Apr 2019 17:23:13 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

PS1:
> I meant, I remember some timeout issues when I was creating tables using 'k
Hmm, maybe a reasonable middle ground would be to condition the discouragement 
on the cluster being a production cluster? That is, continue to allow 
colocation of masters/tservers for POCs and other toy clusters, while 
discouraging it in cases where the amount of load (and the expectations) are 
higher?



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:55:28 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Mitch Barnett, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12997

to look at the new patch set (#4).

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage
collocating of Kudu tablet servers with masters and
other tablet servers.  Also, fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 31 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/4
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

PS1: 
> I meant, I remember some timeout issues when I was creating tables using 'k
I agree that the setup with 200 tablet servers is non-typical (high number of 
tablet servers allows for higher limit on the "max tablets at table create 
time" threshold, so eventually masters can be hit hard with IO, as in my load 
testing experiment).

I removed the mention about the first argument.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:54:50 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Mitch Barnett, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12997

to look at the new patch set (#3).

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage
collocating of Kudu tablet servers with masters and
other tablet servers.  Also, fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/3
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

PS1:
> The first argument is hypothetical, right: I was thinking about IO load pla
I meant, I remember some timeout issues when I was creating tables using 'kudu 
perf loadgen' while doing load testing against the load cluster some time ago 
(I created tablets wit huge number of partitions).  And I thought that adding 
some extra IO on top would be even harder to sustain without timeouts.


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@812
PS1, Line 812: so
> replace with 'so'
Done


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@814
PS1, Line 814: increases the likelihood of tablet unav
> "increases the likelihood of tablet unavailability"
Done


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@820
PS1, Line 820: Avoid pla
> replace with so
Done


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@822
PS1, Line 822: tab
> replace with 'a'
Done



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:43:32 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

PS1:
> The first argument is hypothetical, right: I was thinking about IO load pla
Table creation operations are few and far between, and even then there's an 
upper bound on the amount of load they can place on a master (due to the "max 
tablets at table create time" guardrail). Unless we have evidence suggesting 
that this is a real problem, I'd prefer we didn't discourage colocation of a 
master and a tserver belonging to the same cluster.

I do agree with the rest of the discouragement, though.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:38:05 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

PS1:
> Regarding colocating masters+tservers belonging to the same cluster, I'm no
The first argument is hypothetical, right: I was thinking about IO load placed 
at masters during creation of tablets (so, DDL operations) and thought about 
what would happen if that coincides with some concurrent load of doing DML that 
puts a lot of IO on a tablet server, especially if they share the same set of 
drives and controllers.


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@812
PS1, Line 812: Avoid placing multiple tablet servers on a single node. Doing 
otherwise
> Nit: "on a single node" instead of "at a single node"
Done


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@819
PS1, Line 819: Avoid placing tablet servers on Kudu masters nodes. Doing
> Avoid placing tablet servers on Kudu master nodes.
Done



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:32:47 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Mitch Barnett, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12997

to look at the new patch set (#2).

Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage
collocating of Kudu tablet servers with masters and
other tablet servers.  Also, fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 34 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/2
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12997 )

Change subject: [docs] updated docs w.r.t. collocation practices
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@812
PS1, Line 812: Avoid placing multiple tablet servers at a single node. Doing 
otherwise
Nit: "on a single node" instead of "at a single node"


http://gerrit.cloudera.org:8080/#/c/12997/1/docs/administration.adoc@819
PS1, Line 819: Avoid placing tablet servers at Kudu masters nodes. Doing
Avoid placing tablet servers on Kudu master nodes.



--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 11 Apr 2019 22:03:59 +
Gerrit-HasComments: Yes


[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12997


Change subject: [docs] updated docs w.r.t. collocation practices
..

[docs] updated docs w.r.t. collocation practices

The administration.adoc has been updated to discourage
collocating of Kudu tablet servers with masters and
other tablet servers.  Also, fixed few misprints.

Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
---
M docs/administration.adoc
1 file changed, 32 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/12997/1
--
To view, visit http://gerrit.cloudera.org:8080/12997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88a38117751cfa436c1fd95598274fb8f01f04ea
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin