Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review118099 --- Ship it! Ship It! - Jie Yu On Jan. 22, 2016, 5:36 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42157/ > --- > > (Updated Jan. 22, 2016, 5:36 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > This change will enable ProvisionerAppcTest suite to reuse common code like > test image creation. > > > Diffs > - > > src/tests/containerizer/provisioner_appc_tests.cpp > e3d08d9e49df93d5290099c8bfd917f60c93e51b > > Diff: https://reviews.apache.org/r/42157/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Feb. 6, 2016, 1:35 a.m.) Review request for mesos and Jie Yu. Changes --- rebased. Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp 012dba4e24b9a94dc8da0d329baf4bec2d33ffca Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Feb. 6, 2016, 1:38 a.m.) Review request for mesos and Jie Yu. Changes --- updated bug#. Bugs: MESOS-4333 https://issues.apache.org/jira/browse/MESOS-4333 Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 012dba4e24b9a94dc8da0d329baf4bec2d33ffca Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Jan. 22, 2016, 5:36 p.m.) Review request for mesos and Jie Yu. Changes --- rebased Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp e3d08d9e49df93d5290099c8bfd917f60c93e51b Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Jan. 22, 2016, 6:48 a.m.) Review request for mesos and Jie Yu. Changes --- rebased Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp e3d08d9e49df93d5290099c8bfd917f60c93e51b Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review113880 --- Bad patch! Reviews applied: [41958, 41959] Failed command: ./support/apply-review.sh -n -r 41959 Error: 2016-01-12 00:36:40 URL:https://reviews.apache.org/r/41959/diff/raw/ [2479/2479] -> "41959.patch" [1] error: patch failed: src/uri/fetcher.cpp:43 error: src/uri/fetcher.cpp: patch does not apply - Mesos ReviewBot On Jan. 11, 2016, 8:02 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42157/ > --- > > (Updated Jan. 11, 2016, 8:02 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > This change will enable ProvisionerAppcTest suite to reuse common code like > test image creation. > > > Diffs > - > > src/tests/containerizer/provisioner_appc_tests.cpp > 98d5a46149ef63cedcbf4915b5b6e9842ac67dbb > > Diff: https://reviews.apache.org/r/42157/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Jan. 12, 2016, 12:42 a.m.) Review request for mesos and Jie Yu. Changes --- rebased with master. Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp 98d5a46149ef63cedcbf4915b5b6e9842ac67dbb Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review113925 --- Bad patch! Reviews applied: [41958, 41959] Failed command: ./support/apply-review.sh -n -r 41959 Error: 2016-01-12 03:53:13 URL:https://reviews.apache.org/r/41959/diff/raw/ [2479/2479] -> "41959.patch" [1] error: patch failed: src/uri/fetcher.cpp:43 error: src/uri/fetcher.cpp: patch does not apply - Mesos ReviewBot On Jan. 12, 2016, 12:42 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42157/ > --- > > (Updated Jan. 12, 2016, 12:42 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > This change will enable ProvisionerAppcTest suite to reuse common code like > test image creation. > > > Diffs > - > > src/tests/containerizer/provisioner_appc_tests.cpp > 98d5a46149ef63cedcbf4915b5b6e9842ac67dbb > > Diff: https://reviews.apache.org/r/42157/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- This change will enable ProvisionerAppcTest suite to reuse common code like test image creation. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 98d5a46149ef63cedcbf4915b5b6e9842ac67dbb Diff: https://reviews.apache.org/r/42157/diff/ Testing --- make check. Thanks, Jojy Varghese
