Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-20 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review138624
---


Ship it!




Ship It!

- Jie Yu


On June 19, 2016, 2:10 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated June 19, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp 69828ae43c2e5432aaa27cae3dc683cd90f10db9 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review138527
---




docs/container-image.md (line 310)


s/But some/Some

Another comment is not sure if we can merge this section to section 2?


- Guangya Liu


On 六月 19, 2016, 2:10 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated 六月 19, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp 69828ae43c2e5432aaa27cae3dc683cd90f10db9 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review138470
---



Patch looks great!

Reviews applied: [48773]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 19, 2016, 2:10 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated June 19, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp 69828ae43c2e5432aaa27cae3dc683cd90f10db9 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/
---

(Updated June 19, 2016, 2:10 p.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Adress review comments.


Bugs: MESOS-5549
https://issues.apache.org/jira/browse/MESOS-5549


Repository: mesos


Description
---

Added docs on aufs provisioning backend.


Diffs (updated)
-

  docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
  src/slave/flags.cpp 69828ae43c2e5432aaa27cae3dc683cd90f10db9 

Diff: https://reviews.apache.org/r/48773/diff/


Testing
---


Thanks,

Shuai Lin

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin 


> On June 16, 2016, 6:22 a.m., Guangya Liu wrote:
> > docs/container-image.md, line 305
> > 
> >
> > Community link here?

Emm, I don't think it's necessary. The paragraph is copied from the docker aufs 
driver documents.


> On June 16, 2016, 6:22 a.m., Guangya Liu wrote:
> > docs/container-image.md, line 307
> > 
> >
> > Can you clarify which linux distribution do not support AUFS instead of 
> > "some Linux distributions"?

The same as above.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review137925
---


On June 16, 2016, 5:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated June 16, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp ce2aa336f779ee6746d5f62136251af2c7191f9d 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review137994
---



Patch looks great!

Reviews applied: [48773]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 5:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated June 16, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp ce2aa336f779ee6746d5f62136251af2c7191f9d 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-15 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/#review137925
---




docs/container-image.md (line 302)


I think it is better add sth clarify why we want to add AUFS for unified 
container, you can get some idea from the JIRA ticket.

Such as following:

The reason AUFS was introduced is because overlay fs support hasn't been 
merged until kernel 3.18 and Docker's default storage backend for ubuntu 14.04 
is AUFS. 

Like overlayfs, AUFS is also a unioned file system (unlike copy backend 
which is not space efficient), which is very
stable, has a lot of real-world deployments, and has strong community 
support.



docs/container-image.md (line 305)


Community link here?



docs/container-image.md (line 307)


Can you clarify which linux distribution do not support AUFS instead of 
"some Linux distributions"?



docs/container-image.md (line 310)


s/overlayfs/AUFS


- Guangya Liu


On 六月 16, 2016, 5:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48773/
> ---
> 
> (Updated 六月 16, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5549
> https://issues.apache.org/jira/browse/MESOS-5549
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs on aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
>   src/slave/flags.cpp ce2aa336f779ee6746d5f62136251af2c7191f9d 
> 
> Diff: https://reviews.apache.org/r/48773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 48773: Added docs on aufs provisioning backend.

2016-06-15 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48773/
---

Review request for mesos, Guangya Liu and Jie Yu.


Bugs: MESOS-5549
https://issues.apache.org/jira/browse/MESOS-5549


Repository: mesos


Description
---

Added docs on aufs provisioning backend.


Diffs
-

  docs/container-image.md 50a0fa799d7a179f3124e61619e28ffb3845d531 
  src/slave/flags.cpp ce2aa336f779ee6746d5f62136251af2c7191f9d 

Diff: https://reviews.apache.org/r/48773/diff/


Testing
---


Thanks,

Shuai Lin