Re: Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57282/ --- (Updated March 4, 2017, 9:37 a.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description (updated) --- We used to only send `UpdateFrameworkMessage` to connected frameworks because it only included `PID`s. However, since now it also includes updates to the `FrameworkInfo`, we choose to lift this optimization and send it to all agents for (dis)connected frameworks. This is resolving https://reviews.apache.org/r/57110/#comment239045. Diffs - src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 Diff: https://reviews.apache.org/r/57282/diff/1/ Testing --- Thanks, Michael Park
Re: Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57282/#review167921 --- Ship it! In the summary / description: "to frameworks" -> "to agents for (dis)connected frameworks" - Benjamin Mahler On March 3, 2017, 9:47 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57282/ > --- > > (Updated March 3, 2017, 9:47 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > We used to only send `UpdateFrameworkMessage` to connected frameworks > because it only included `PID`s. However, since now it also includes > updates to the `FrameworkInfo`, we choose to lift this optimization and > send it to all frameworks. > > This is resolving https://reviews.apache.org/r/57110/#comment239045. > > > Diffs > - > > src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 > > > Diff: https://reviews.apache.org/r/57282/diff/1/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Re: Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57282/ --- (Updated March 3, 2017, 1:47 p.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description --- We used to only send `UpdateFrameworkMessage` to connected frameworks because it only included `PID`s. However, since now it also includes updates to the `FrameworkInfo`, we choose to lift this optimization and send it to all frameworks. This is resolving https://reviews.apache.org/r/57110/#comment239045. Diffs - src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 Diff: https://reviews.apache.org/r/57282/diff/1/ Testing --- Thanks, Michael Park
Re: Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57282/#review167822 --- Patch looks great! Reviews applied: [57282] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 3, 2017, 12:01 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57282/ > --- > > (Updated March 3, 2017, 12:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > We used to only send `UpdateFrameworkMessage` to connected frameworks > because it only included `PID`s. However, since now it also includes > updates to the `FrameworkInfo`, we choose to lift this optimization and > send it to all frameworks. > > This is resolving https://reviews.apache.org/r/57110/#comment239045. > > > Diffs > - > > src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 > > > Diff: https://reviews.apache.org/r/57282/diff/1/ > > > Testing > --- > > > Thanks, > > Michael Park > >
Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57282/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- We used to only send `UpdateFrameworkMessage` to connected frameworks because it only included `PID`s. However, since now it also includes updates to the `FrameworkInfo`, we choose to lift this optimization and send it to all frameworks. This is resolving https://reviews.apache.org/r/57110/#comment239045. Diffs - src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 Diff: https://reviews.apache.org/r/57282/diff/1/ Testing --- Thanks, Michael Park
