Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Changes --- Rebased. Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description --- This adds the necessary and expected default paths to the default `PATH` value represented by this function. Especially needed was the `WindowsPowerShell` folder so that tasks using PowerShell can run. Diffs (updated) - 3rdparty/stout/include/stout/windows/os.hpp a24bad9ff1064574827466342530317ba06d3ffd Diff: https://reviews.apache.org/r/63814/diff/3/ Changes: https://reviews.apache.org/r/63814/diff/2-3/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/ --- (Updated Nov. 28, 2017, 4:09 p.m.) Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Changes --- clang-format Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description --- This adds the necessary and expected default paths to the default `PATH` value represented by this function. Especially needed was the `WindowsPowerShell` folder so that tasks using PowerShell can run. Diffs (updated) - 3rdparty/stout/include/stout/windows/os.hpp a24bad9ff1064574827466342530317ba06d3ffd Diff: https://reviews.apache.org/r/63814/diff/2/ Changes: https://reviews.apache.org/r/63814/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/#review191986 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63814/ > --- > > (Updated Nov. 14, 2017, 11:16 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6816 > https://issues.apache.org/jira/browse/MESOS-6816 > > > Repository: mesos > > > Description > --- > > This adds the necessary and expected default paths to the default `PATH` > value represented by this function. Especially needed was the > `WindowsPowerShell` folder so that tasks using PowerShell can run. > > > Diffs > - > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63814/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/#review191098 --- Ship it! - John Kordich On Nov. 14, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63814/ > --- > > (Updated Nov. 14, 2017, 11:16 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6816 > https://issues.apache.org/jira/browse/MESOS-6816 > > > Repository: mesos > > > Description > --- > > This adds the necessary and expected default paths to the default `PATH` > value represented by this function. Especially needed was the > `WindowsPowerShell` folder so that tasks using PowerShell can run. > > > Diffs > - > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63814/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 63814: Windows: Fixed `os::host_default_path()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/ --- Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description --- This adds the necessary and expected default paths to the default `PATH` value represented by this function. Especially needed was the `WindowsPowerShell` folder so that tasks using PowerShell can run. Diffs - 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 Diff: https://reviews.apache.org/r/63814/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer