Re: CVS commit: src/sys/arch/x86/x86
Hi, Hmm, but TSC drift is still observed on recent (high clock) CPUs. I will have researched and fix later. On 2020/04/03 12:05, Kengo NAKAHARA wrote: Module Name:src Committed By: knakahara Date: Fri Apr 3 03:05:39 UTC 2020 Modified Files: src/sys/arch/x86/x86: tsc.c Log Message: Fix TSC drift is observed almost every time wrongly. Ths "TSC drift" in tsc_tc_init() means the cpu_cc_skew delta between first measurement (in cpu_start_secondary) and second measurement (in cpu_boot_secondary), that is, the TSC drift is expected to be almost zero. However, the second measument in current implementation is added extra cpu_cc_skew accidentally, so current delta value means almost cpu_cc_skew wrongly. tsc_sync_bp and tsc_sync_ap should use rdtsc() to get raw values. Advised by nonaka@n.o, thanks. To generate a diff of this commit: cvs rdiff -u -r1.38 -r1.39 src/sys/arch/x86/x86/tsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- // Internet Initiative Japan Inc. Device Engineering Section, Product Development Department, Product Division, Technology Unit Kengo NAKAHARA
Re: CVS commit: src/usr.bin/kdump
On 02.04.2020 23:35, Christos Zoulas wrote: > Ah debugging remnants. I'll remove it. Can you look at PR/55128? > OK! > static inline union savefpu * > fpu_lwp_area(struct lwp *l) > { > struct pcb *pcb = lwp_getpcb(l); > union savefpu *area = &pcb->pcb_savefpu; > > KASSERT((l->l_flag & LW_SYSTEM) == 0); > if (l == curlwp) { > fpu_save(); > } > KASSERT(!(l->l_md.md_flags & MDL_FPU_IN_CPU)); <- this will fire if > the debugger calls it with l != curlew and it uses cpu > > return area; > } > > >> On Apr 2, 2020, at 5:31 PM, Kamil Rytarowski wrote: >> >> On 02.04.2020 19:40, Christos Zoulas wrote: >>> +set -x >>> +AWK=gawk >>> + >> >> gawk? >
Re: CVS commit: src/usr.bin/kdump
Ah debugging remnants. I'll remove it. Can you look at PR/55128? static inline union savefpu * fpu_lwp_area(struct lwp *l) { struct pcb *pcb = lwp_getpcb(l); union savefpu *area = &pcb->pcb_savefpu; KASSERT((l->l_flag & LW_SYSTEM) == 0); if (l == curlwp) { fpu_save(); } KASSERT(!(l->l_md.md_flags & MDL_FPU_IN_CPU)); <- this will fire if the debugger calls it with l != curlew and it uses cpu return area; } > On Apr 2, 2020, at 5:31 PM, Kamil Rytarowski wrote: > > On 02.04.2020 19:40, Christos Zoulas wrote: >> +set -x >> +AWK=gawk >> + > > gawk? signature.asc Description: Message signed with OpenPGP
Re: CVS commit: src/usr.bin/kdump
On 02.04.2020 19:40, Christos Zoulas wrote: > +set -x > +AWK=gawk > + gawk?
Re: CVS commit: src/sys/dev/usb
On Thu, Apr 2, 2020 at 8:37 PM Nick Hudson wrote: > > Module Name:src > Committed By: skrll > Date: Thu Apr 2 11:37:23 UTC 2020 > > Modified Files: > src/sys/dev/usb: xhci.c xhcivar.h > > Log Message: > Reduce the memory footprint by allocating a ring per endpoint/pipe on > pipe open. > > From sc.dying on tech-kern Thank you for applying the patch.