[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Project changed: unity8 => unity8 (Ubuntu) ** Changed in: unity8 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: unity8 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Tags added: nm-touch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Branch linked: lp:~ci-train-bot/dbus-cpp/dbus-cpp-ubuntu-yakkety- landing-028 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Branch linked: lp:~ci-train-bot/dbus-cpp/dbus-cpp-ubuntu-yakkety- landing-072 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
This bug was fixed in the package qtbase-opensource-src - 5.5.1+dfsg- 13ubuntu2 --- qtbase-opensource-src (5.5.1+dfsg-13ubuntu2) xenial; urgency=medium * Forward-port networking fixes from 5.4 series: - net-bearer-nm-disconnect-ap-signals7.patch (LP: #1480877) - qnam-ubuntu-fix6.patch (LP: #1528886) - xenial would potentially now have fixes for (LP: #1506015) (LP: #1507769) (LP: #1533508) -- Timo Jyrinki Tue, 09 Feb 2016 08:19:43 + ** Changed in: qtbase-opensource-src (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: dbus-cpp (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: qtbase-opensource-src (Ubuntu) Status: Fix Committed => Fix Released ** Changed in: qtbase-opensource-src (Ubuntu) Status: Fix Released => Fix Committed ** Also affects: qtbase-opensource-src (Ubuntu RTM) Importance: Undecided Status: New ** Changed in: qtbase-opensource-src (Ubuntu RTM) Status: New => Fix Released ** Changed in: qtbase-opensource-src (Ubuntu RTM) Assignee: (unassigned) => Tony Espy (awe) ** Changed in: qtbase-opensource-src (Ubuntu RTM) Importance: Undecided => High ** Changed in: qtbase-opensource-src (Ubuntu) Status: Fix Committed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Patch signals7 (with just the system settings crash fixed) building now in the PPA. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Selene Just wanted to confirm that we don't need any more investigation re: your comment #131 ( I think that may be the largest comment # I've seen in a LP bug ), as your latest update to bug #1524133 indicated that you'd isolated the problem to a SIM with an expired data plan? @Timo We should probably close this bug out when OTA8.5 is released, and then push another update to the PPA that contains the updated patch with the desktop crash fix ( bug #1523975 ). I've attached yet another of the version of the patch which just includes the additional wiredDevice NULL check from Lorn's latest patch. @Lorn Thanks again for all the help. Again, once the OTA8.5 update has been released, we can focus on transitioning to the connectivity API based bearer plugin for our next update. ** Patch added: "yet another update to our bearer-mgmt networkmanager patch" https://bugs.launchpad.net/ubuntu-rtm/+source/dbus-cpp/+bug/1480877/+attachment/4533428/+files/net-bearer-nm-disconnect-ap-signals7.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
FWIW, I see the weird new behavior on every test with wifi enabled, even when the screen is on and the phone is actively doing something. For example, while playing music: http://people.canonical.com/~platform-qa/power- results/2015-12-08_09:19:36-krillin-196-power_usage_music/graph.png ... versus how it looked before: http://people.canonical.com/~platform-qa/power- results/2015-12-08_04:50:02-krillin-195-power_usage_music/graph.png But in flight mode, both graphs are a flat line barely above zero: http://people.canonical.com/~platform-qa/power- results/2015-12-08_11:07:01-krillin-196-power_usage_flight_mode_on/graph.png So, it's not just while sleeping; it's any time wifi is enabled. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
tvoss: The raw data is available. Simply remove "graph.png" from the URL and it'll give you a directory with all sorts of logs. The green-shaded section is the active measurement period used for statistics. The red-shaded portions indicate where USB was connected. Everything else is unplugged. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
fyi: requestUpdate is called by the qnetworkconfigurationmanager, when updateConfigurations() gets called. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Tony 1) requestUpdate() should be left in, as the backend needs to tell other parts when the update request has been completed. I have tested this, so it does compile. In further testing, it does not look like any clients are requesting updates, so the increased power consumption is coming from somewhere else. 2) The crash is because of dead code, and included change is just a quick fix. Proper fix is to go through this and remove the rest of the dead and unneeded code. 3) If you want this delta as small as possible, it is safe to remove this from the patch and only include #2. There is more dead code in there now that it only relies on settings and active connections, which I will remove in a different patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
So the latest changes in Lorn's signals6 patch can be summarized as: 1) remove QNetworkManagerEngine::requestUpdate (), which is a public method which can trigger a WiFi scan request to NM. This method doesn't appear to be called internally by the bearer plugin, so if we think extra WiFi scans are the culprit, there must have been an change to one of our Qt applications which is calling this method. Also as this method wasn't added in the original patch, it's presence can't really be considered a regression. Has anyone attempted to determine if we *are* scanning more often? This could be done manually by running wpa_cli ( as root ), and watching for the frequency of scan events output. It can also be accomplished by looking at the wpa_suppl and/or NM log messages in syslog. And finally, you could also just monitor DBus looking for ScanDone signals from NM. NOTE - I'm pretty sure this patch won't compile unless this method is also removed from qnetworkmanagerengine.h too, but I haven't tried to build it myself... 2) check that wiredDevice pointer is valid before using it to call a method This is the crasher fix when USS/Qt from the PPA gets installed on a desktop. Looks fine to me. 3) remove most of the logic from the engine's parseConnection() method. This method takes a connection path, and creates a private configuration object, and then based upon the underlying device type, may modify the private configuration instance in a device-specific way before returning it to the caller. The device-specific logic in some cases could have side-effects, such as modifying the global accessPointConfigurations hash table and/or the configuredAccessPoint map. Again, this chnage looks reasonable to remove, however I don't see how it could have any impact on power. This code only runs during initialization where all existing system connections are loaded, and whenever a new system connection is added ( ie. a user connects to a new AP or APN ). I'm not sure whether we want to include this the last change if we want to keep the delta as small as possible? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The interdiff from signals5 to signals6: http://paste.ubuntu.com/13858649/ - removal of code and one-liner to fix the system-settings. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
qtbase 5.4.1+dfsg-2ubuntu11~vivid2 is ready for testing at https://requests.ci-train.ubuntu.com/#/ticket/761 with Lorn's net- bearer-nm-disconnect-ap-signals6.patch from bug #1480877 that includes a fix for both u-s-s crasher bug #1523975 and a potential fix to too many wifi scanning updates bug #1524133. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Thanks for the graphs. One thing that stands out is the time that the system stays active when occasionally waking up from deep sleep (right hand side of the graph). Do you have the raw data producing those graphs handy? Thanks, Thomas On Wed, Dec 9, 2015 at 1:23 AM, Selene Scriven wrote: > Is it possible that this fix might cause a phone to wake up more often, > or to stay awake longer? I'm seeing weird idle power behavior ever > since this fix landed in krillin rc-proposed 196. > > Before: ~9 mA > http://people.canonical.com/~platform-qa/power-results/2015-12-08_03:19:30-krillin-195-power_usage_idle/graph.png > > After: ~35 mA > http://people.canonical.com/~platform-qa/power-results/2015-12-08_07:36:16-krillin-196-power_usage_idle/graph.png > > Here's the commit log for 196: > > http://people.canonical.com/~lzemczak/landing-team/ubuntu-touch/rc- > proposed/196.commitlog > > Arale results look fine. I don't know why krillin is different, but I'm > only seeing this behavior on krillin when wifi is connected... and this > bug fix is a likely suspect. I don't see additional forks or crashes in > the test logs, which suggests the issue is probably caused by a long- > running process. > > -- > You received this bug notification because you are a bug assignee. > https://bugs.launchpad.net/bugs/1480877 > > Title: > Access points' "PropertiesChanged" dbus signals freeze UI on mobile > devices > > Status in Canonical System Image: > Fix Committed > Status in Unity 8: > New > Status in dbus-cpp package in Ubuntu: > In Progress > Status in network-manager package in Ubuntu: > Incomplete > Status in qtbase-opensource-src package in Ubuntu: > Fix Committed > Status in dbus-cpp package in Ubuntu RTM: > Fix Released > Status in location-service package in Ubuntu RTM: > Fix Released > Status in network-manager package in Ubuntu RTM: > Incomplete > > Bug description: > Krillin, rc-proposed, r83 > > > DESCRIPTION: > I've been trying to track down the cause of the occasional UI freezes on my > Krillin device, and I noticed that whenever the UI freezes for 2-4 seconds, I > get a burst of "PropertiesChanged" signals in dbus-monitor > > Here's a log of what's shown in dbus-monitor: > http://pastebin.ubuntu.com/11992322/ > > I'd guess the problem is in the code that actually catches the signals > and acts accordingly. > > HOW TO REPRODUCE: > 1) Move to a place where many wifi hotspots are available > 2) Connect the device via USB and run "phablet-shell" and then > "dbus-monitor" > 3) Use the device while keeping an eye on dbus-monitor output > > To manage notifications about this bug go to: > https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
patch #6 fixes crash in system-settings (#1523975) and removes wifi scanning updates, which could potentially drain the battery (#1524133) ** Patch added: "net-bearer-nm-disconnect-ap-signals6.patch" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4531735/+files/net-bearer-nm-disconnect-ap-signals6.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I created bug 1524133 to track the issues I'm seeing. I don't know if it's related to this bug, but so far it looks probable. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Is it possible that this fix might cause a phone to wake up more often, or to stay awake longer? I'm seeing weird idle power behavior ever since this fix landed in krillin rc-proposed 196. Before: ~9 mA http://people.canonical.com/~platform-qa/power-results/2015-12-08_03:19:30-krillin-195-power_usage_idle/graph.png After: ~35 mA http://people.canonical.com/~platform-qa/power-results/2015-12-08_07:36:16-krillin-196-power_usage_idle/graph.png Here's the commit log for 196: http://people.canonical.com/~lzemczak/landing-team/ubuntu-touch/rc- proposed/196.commitlog Arale results look fine. I don't know why krillin is different, but I'm only seeing this behavior on krillin when wifi is connected... and this bug fix is a likely suspect. I don't see additional forks or crashes in the test logs, which suggests the issue is probably caused by a long- running process. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Just a quick update to mention that the change to the NM bearer plugin seems to have caused a regression when qtbase is installed from the PPA onto a desktop ( for UI development work ). To reproduce, the overlay PPA needs to be added as a software source, then ubuntu-system-settings installed/upgraded ( which pulls in qtbase ). See bug #1523975 for details. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: canonical-devices-system-image Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
This bug was fixed in the package dbus-cpp 4.3.0+15.04.20151126-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable- phone-overlay --- dbus-cpp (4.3.0+15.04.20151126-0ubuntu1) vivid; urgency=medium [ CI Train Bot ] * New rebuild forced. [ Thomas Voß ] * Ensure that Signal with non-void argument types correctly narrow their match rules. (LP: #1480877) -- Thomas Voß Thu, 26 Nov 2015 07:31:37 + ** Changed in: dbus-cpp (Ubuntu RTM) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
This bug was fixed in the package location-service 2.1+15.04.20151202.1-0ubuntu1 in https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/stable-phone-overlay --- location-service (2.1+15.04.20151202.1-0ubuntu1) vivid; urgency=medium * Ensure that event connections are cleaned up on destruction. (LP: #1480877) -- Thomas Voß Wed, 02 Dec 2015 12:12:21 + ** Changed in: location-service (Ubuntu RTM) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The associated version for the dbus-cpp in silo-026 is: 4.3.0+15.04.20151126-0ubuntu1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The fix has landed in silo-026, as part of location-services version: 2.1+15.04.20151202.1-0ubuntu1 ** Changed in: location-service (Ubuntu RTM) Status: In Progress => Fix Committed ** No longer affects: sync-monitor (Ubuntu RTM) ** No longer affects: maliit-framework (Ubuntu RTM) ** No longer affects: indicator-network (Ubuntu) ** No longer affects: buteo-syncfw (Ubuntu RTM) ** Also affects: dbus-cpp (Ubuntu RTM) Importance: Undecided Status: New ** Changed in: dbus-cpp (Ubuntu RTM) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The latest version of the patch is now in a silo-026, included as part of a new qtbase version 5.4.1+dfsg-2ubuntu11~vivid1. ** Changed in: qtbase-opensource-src (Ubuntu) Status: In Progress => Fix Committed ** Changed in: sync-monitor (Ubuntu RTM) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: canonical-devices-system-image Milestone: ww02-2016 => ww50-2015 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Timo As previously mentioned, I'd like to get this change out as a hot-fix, and then do proper evaluation of the new connectivity API based plugin with the goal to land it as part of OTA9. @Lorn I'll take a look at that the line you mentioned, however we need to draw the line at some point and re-focus on the replacement plugin as mentioned above. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Not related to the bug at hand directly, but applying the signals5.patch on top of Qt 5.5.1 caused a crash to always happen on Unity8 startup: /usr/bin/unity8:11:/usr/lib/arm-linux-gnueabihf/qt5/plugins/bearer/libqnmbearer.so+7c7c:/usr/lib/arm-linux-gnueabihf/libQt5Core.so.5.5.1+1e4f5a:[stack..3416]+7fd8b8 So my suggestion is to ship whatever needed for 5.4 quickly but have the longer term goal of shipping connectivity-api bearer so that the 5.5/xenial will wait for that (unless someone wants to look at the 5.5 specific problem with this current patch). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Tony I suppose that if statement in QNetworkManagerEngine::requestUpdate() could also be removed, leaving the last line only, since we do not do anything with uknown AP's -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Ver 5 in 026 now too (still building), together with the gles counterpart packagae. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Note, I've also pushed a new version based on your latest patch to my PPA if anyone's interested in testing before it lands in silo-026: https://launchpad.net/~awe/+archive/ubuntu/ppa -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Lorn Thanks for the update. I usually do all my testing on rc-proposed, as it's latest and greatest. I wasn't aware of the "ubuntu-developer" channel. I've tested on rc- proposed/bq-aquaris.en ( #188 ) with the full set of packages from silo-026, and everything seemed good to me. Thar said, I've reviewed your latest changes and they look good to me. Not creating QNetworkManagerInterfaceDevice and DeviceWireless instances definitely gets rid of the a bunch more DBus signal match rules, and unneeded DBus calls. DeviceWireless is still generates PropertiesChanged signals every time a scan finishes... With this code removed, the plugin operates soley on active and system connection updates. Regarding the device adds for 'rmnet' devices on mako, in theory these should've only been happening at start-up time and/or whenever flight- mode is turned off. Anyways, I'm +1 for including your latest revision of the patch. Thanks again for your help! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Tony, currently I am on stable/ubuntu-developer. Previously I was testing on stable/ubuntu. I was on rc-proposed for quite a while, but it seemed to have only a few scopes, and not the twitter scope which I wanted to try out. My updated patch removes actions on device added and removed calls. Most of these were rmnet related (which appears to not be managed by nm anyway), and relies on active connection and settings changes. I haven't tested it in regards to hotspot or bluetooth tethering. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The version 4 of the patch (from comment #104) is in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-026 at the moment. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Lorn Can you add some details regarding what image channel you actually used and device for testing? rc-proposed is probably the best base for you to use. The "GetAll" behavior you're describing is similar to what I was seeing with the AccessPoint objects. The code would see a "PropertiesChanged" signal for an access point, and directly issue a blocking "GetAll" call. This should only be done at initial object creation. Once initialized, the properties can be monitored directly via "PropertiesChanged" signals and the included payload. I imagine this is probably what you've done with your patch. I'll review your updates, and confer with some others to see if we defer your additional changes to OTA9, or try to get them in as part of a proposed hot-fix. Thanks again for your help! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I changed my phones image channel, tested (with a few specific test apps I have for QNAM & friends) that new patch and didn't see any thing too wrong. Although I am seeing heaps of GetAll calls that do not need to happen (even for non nm managed interfaces - rmnet). Attached patch simplifies/optimizes more. Reduces the number of blocking calls from about 50 to ~4 when default route changes. ** Patch added: "net-bearer-nm-disconnect-ap-signals5.patch" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4525013/+files/net-bearer-nm-disconnect-ap-signals5.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's my updated patch, the only difference is that it includes a DBusConnection disconnect() call in the destructor for QNetworkManagerInterfaceDeviceModem(), which I'd punted on for expediency while testing earlier this week. If doesn't include the IPv6 related fix, as this was fixed in NM already. Our plan is to get this into silo-026 ASAP for testing as a potential hotfix along with the location-services match rules fixes. ** Patch added: "net-bearer-nm-disconnect-ap-signals4.patch" https://bugs.launchpad.net/ubuntu-rtm/+source/location-service/+bug/1480877/+attachment/4524946/+files/net-bearer-nm-disconnect-ap-signals4.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Tony, small stutters when transitioning from wifi to mobile. I don't see stutters when scanning anymore. And the stutters I do see when transitioning from wifi to mobile seem better (presumably because less dbus signal watchers are registered now for all the traffic that happens on a switch?). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Mike Small stutters when transitioning from mobile to WiFi or visa versa, or stutters when scanning. The fixes to location-services and Qt both are applicable to the latter case only... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's a followup on living with silo 26 (pre-comment 97, so an earlier version, but I doubt it matters for testing?) and Tony's libqt5network5. I tested this morning (so a full day of the phone living on this code) and it was slightly worse -- small stutters instead of tiny ones. But still a vast improvement on what it was before these changes. I assume the degradation was due to other actors on the phone leaking signal watches. Or just random chance. But I still love the changes. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Lorn Did you see this recently? If so, what device and image? As I mentioned, the mobile connection on touch doesn't support IPv6 connections.There was a bug in NM that falsely reported that a default IPv6 route was available, but this was fixed awhile back. Please see bug #1444162 for details. Perhaps this is what you were seeing? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Tony I noticed this on touch. The problem was that the ConnectionActive was returning true for mobile data ipv6 default route when wifi had the actual default route, so it would never get updated when wifi became default. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Lorn Thanks for the updated patch. The only significant difference besides the DeviceModem destructor fix was the change you mentioned about default routes. Is there a touch- specific bug that this fixes? On our system, the modem connection will never be IPv6, whereas it is possible to get a IPv6 connection for WiFi. Perhaps we keep this separate? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Silo 26 is now complete. On Mon, Nov 23, 2015 at 4:47 PM, Thomas Voß wrote: > Quick update on silo 26: I'm rebuilding location-service to account > for a recent landing. > The one blocking issue is mediascanner2, which requires a rebuild, > too. It is however enabled for dual-landing > to both vivid and xenial, and we cannot easily do a vivid+o landing > with it right now. I'm working on the resolving that issue, > but it will likely take a day or two to complete. > > On Mon, Nov 23, 2015 at 3:49 PM, Michael Terry > wrote: >> I tested silo 26 + libqt5network5 from Tony's PPA and did my normal >> routine of walking out of range of my home network. >> >> It seems much better. dbus-daemon CPU usage is down (only ~30% for a >> few seconds after initial switch to 3G and ~15% during scans after). >> >> But more importantly, stuttering is much better. Only a couple tiny >> stutters on initial switch. And none during scans. I'm +100 on trying >> to land this. >> >> (My test was on a relatively-recently-rebooted phone, so maybe not the >> ideal test. I'll try again later after a while of uptime to double >> confirm the results, but this looks good. If I don't post again, assume >> it worked great.) >> >> -- >> You received this bug notification because you are a bug assignee. >> https://bugs.launchpad.net/bugs/1480877 >> >> Title: >> Access points' "PropertiesChanged" dbus signals freeze UI on mobile >> devices >> >> Status in Canonical System Image: >> Confirmed >> Status in Unity 8: >> New >> Status in dbus-cpp package in Ubuntu: >> In Progress >> Status in indicator-network package in Ubuntu: >> Incomplete >> Status in network-manager package in Ubuntu: >> Incomplete >> Status in qtbase-opensource-src package in Ubuntu: >> In Progress >> Status in buteo-syncfw package in Ubuntu RTM: >> New >> Status in location-service package in Ubuntu RTM: >> In Progress >> Status in maliit-framework package in Ubuntu RTM: >> New >> Status in network-manager package in Ubuntu RTM: >> Incomplete >> Status in sync-monitor package in Ubuntu RTM: >> New >> >> Bug description: >> Krillin, rc-proposed, r83 >> >> >> DESCRIPTION: >> I've been trying to track down the cause of the occasional UI freezes on >> my Krillin device, and I noticed that whenever the UI freezes for 2-4 >> seconds, I get a burst of "PropertiesChanged" signals in dbus-monitor >> >> Here's a log of what's shown in dbus-monitor: >> http://pastebin.ubuntu.com/11992322/ >> >> I'd guess the problem is in the code that actually catches the signals >> and acts accordingly. >> >> HOW TO REPRODUCE: >> 1) Move to a place where many wifi hotspots are available >> 2) Connect the device via USB and run "phablet-shell" and then >> "dbus-monitor" >> 3) Use the device while keeping an eye on dbus-monitor output >> >> To manage notifications about this bug go to: >> https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Quick update on silo 26: I'm rebuilding location-service to account for a recent landing. The one blocking issue is mediascanner2, which requires a rebuild, too. It is however enabled for dual-landing to both vivid and xenial, and we cannot easily do a vivid+o landing with it right now. I'm working on the resolving that issue, but it will likely take a day or two to complete. On Mon, Nov 23, 2015 at 3:49 PM, Michael Terry wrote: > I tested silo 26 + libqt5network5 from Tony's PPA and did my normal > routine of walking out of range of my home network. > > It seems much better. dbus-daemon CPU usage is down (only ~30% for a > few seconds after initial switch to 3G and ~15% during scans after). > > But more importantly, stuttering is much better. Only a couple tiny > stutters on initial switch. And none during scans. I'm +100 on trying > to land this. > > (My test was on a relatively-recently-rebooted phone, so maybe not the > ideal test. I'll try again later after a while of uptime to double > confirm the results, but this looks good. If I don't post again, assume > it worked great.) > > -- > You received this bug notification because you are a bug assignee. > https://bugs.launchpad.net/bugs/1480877 > > Title: > Access points' "PropertiesChanged" dbus signals freeze UI on mobile > devices > > Status in Canonical System Image: > Confirmed > Status in Unity 8: > New > Status in dbus-cpp package in Ubuntu: > In Progress > Status in indicator-network package in Ubuntu: > Incomplete > Status in network-manager package in Ubuntu: > Incomplete > Status in qtbase-opensource-src package in Ubuntu: > In Progress > Status in buteo-syncfw package in Ubuntu RTM: > New > Status in location-service package in Ubuntu RTM: > In Progress > Status in maliit-framework package in Ubuntu RTM: > New > Status in network-manager package in Ubuntu RTM: > Incomplete > Status in sync-monitor package in Ubuntu RTM: > New > > Bug description: > Krillin, rc-proposed, r83 > > > DESCRIPTION: > I've been trying to track down the cause of the occasional UI freezes on my > Krillin device, and I noticed that whenever the UI freezes for 2-4 seconds, I > get a burst of "PropertiesChanged" signals in dbus-monitor > > Here's a log of what's shown in dbus-monitor: > http://pastebin.ubuntu.com/11992322/ > > I'd guess the problem is in the code that actually catches the signals > and acts accordingly. > > HOW TO REPRODUCE: > 1) Move to a place where many wifi hotspots are available > 2) Connect the device via USB and run "phablet-shell" and then > "dbus-monitor" > 3) Use the device while keeping an eye on dbus-monitor output > > To manage notifications about this bug go to: > https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I tested silo 26 + libqt5network5 from Tony's PPA and did my normal routine of walking out of range of my home network. It seems much better. dbus-daemon CPU usage is down (only ~30% for a few seconds after initial switch to 3G and ~15% during scans after). But more importantly, stuttering is much better. Only a couple tiny stutters on initial switch. And none during scans. I'm +100 on trying to land this. (My test was on a relatively-recently-rebooted phone, so maybe not the ideal test. I'll try again later after a while of uptime to double confirm the results, but this looks good. If I don't post again, assume it worked great.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I agree, since nothing controls the connections through QtBearer (and the platform doesn't want that), and AP lists are not allowed in contained apps, it makes sense to simply remove them. I've fixed up that patch in regards to d'tor disconnects, removed some redundant code. And since it was a small change, I fixed up the defaultConfiguration code that would not correctly detect when the default route changed from mobile to wifi, thus possibly allowing network requests to go through expensive mobile data when wifi is available. ** Patch added: "net-beaerer-nm-disconnect-ap-signals3.patch" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4523931/+files/net-beaerer-nm-disconnect-ap-signals3.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's a new version of the patch with all the access-point related signals removed. It makes no sense for any of this logic to be present in our system, as none of our code attempts to control the network configuration via Bearer Mgmt. With this patch, the plugin will never receive any NM access-point related signals, and therefore it'll never populate it's access point list. Also, as pointed out in other comments, the bearer plugin includes blocking DBus calls that are made in response to every single 'PropertiesChanged' signal sent for an access point, which causes a ripple of DBus traffic every time a scan occurs. @Lorn, if you could look over my patch, I'd appreciate it. It'd be also nice to get some testing from @faenil and @mterry before we push forward with landing plans.I've confirmed that the CPU spikes in the dbus daemon go away completely with the changes. That said, it'd be good to get some independent results. Until we have a silo prep'd for Qt, you can just install the libqt5network5_5.4.1+dfsg-2ubuntu10~awe16_armhf.deb from my PPA: https://launchpad.net/~awe/+archive/ubuntu/ppa/+packages You also probably want to install dbus-cpp and location-services from: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-026 The status of the location-service silo says it needs a rebuild, but the packages in the PPA should be OK for testing. If you have any questions, ask before you install anything. ** Patch added: "New version of QtBase network bearer plugin" https://bugs.launchpad.net/ubuntu-rtm/+source/location-service/+bug/1480877/+attachment/4523258/+files/net-bearer-nm-disconnect-ap-signals2.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: qtbase-opensource-src (Ubuntu) Assignee: (unassigned) => Tony Espy (awe) ** Changed in: qtbase-opensource-src (Ubuntu) Importance: Undecided => High ** Changed in: qtbase-opensource-src (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I grabbed your patch and incorporated most of it into my latest patch ( I left out a few of the disconnect calls for some of the other NM interfaces not directly involved in the match rules problem ), however it failed to build... While trying to just pull in the pieces and resolve the conflicts with the additional debug statements I'd added, I managed to remove the wrong function declaration in qnetworkmanagerservice.h. I removed path() from QNetworkManagerInterface instead of QNetworkMangerInterfaceDeviceWireless.I've refreshed the patch and re-pushed to my PPA. Let's hope it builds this time. ** Patch added: "net-bearer-nm-disconnect-ap-signals.patch" https://bugs.launchpad.net/ubuntu-rtm/+source/location-service/+bug/1480877/+attachment/4522331/+files/net-bearer-nm-disconnect-ap-signals.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Sorry, thought I'd include more. 2nd patch that obsoletes my previous patch includes disconnecting from system dbus when objects get deleted. ** Patch added: "nmbearer-fix-duplicates2.diff" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4521679/+files/nmbearer-fix-duplicates2.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
This patch fixes duplicate entries of access points. Which contributes to but may not totally fix this bug. ** Patch added: "nmbearer-fix-duplicates.diff" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4521638/+files/nmbearer-fix-duplicates.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
You are correct in that GetAll gets called twice for each accesspoint. I can see that by adding qDebug's and disable/enable wifi -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
nmRegistered will only get called from the connection signal/slot when networkmanager daemon if and when gets registered on the dbus. If it is already registered, it will get called from that invokeMethod. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Note, QNetworkManagerEngine::setupConfigurations() is also suspect as it can get called from a couple of places and has a loops over the current devices and calls deviceAdded(). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Some more details: - the version of the qtbase package in touch atm is: 5.4.1+dfsg- 2ubuntu10 - I checked and didn't see significant differences in the networkmanager bearer plugin when comparing against 5.5.1, and 5.6. - That said, there's been quite a few changes in the QDBus code, specifically qdbusintegrator.cpp. Some of the changes include modifications to the signal connect/disconnect code. - After some further instrumentation, I *think* I've located the bug. I added more debug logging to the QDBus code, so I see when match rules are added and removed, and when the corresponding connect/disconnect calls are made. What I see is that the bearer plugin is calling DBusConnection::connect() for each AccessPoint object that's added. This results in a single match rule being added, however I see a second call to DBusConnection::connect() for the same object path, which cause the ref count to incremented. When the AccessPoint is removed, disconnect() only gets called once, the ref count is decremented, and the match rule lives on. - I originally thought this was due to the fact that QNetworkManagerEngine::nmRegistered() calls managerInterface->setConnections(), but at a closer the look the former is registering for Qt signals, while the latter registers for the associated DBus signals. - Looking at the constructor of the plugin engine, QNetworkManagerEngine, it connects the serviceRegistered Qt signal to the method nmEnabled(). At the end of the same function, it checks if the service (NM) has already been registered, and if so invokes nmRegistered again via invokeMethod ( that's some Voodoo I don't quite grok ). Looking at the nmRegistered() function, it has a guard which looks like it was copied from ofonoRegisted() as it guards against ofonoManager != NULL, not managerInterface ( which is what gets created in nmRegistered ). I'll add a bit more logging to confirm, but pretty sure this is the cause of the extra match refs, as if nmRegistered() is called twice, it'll cause connect() to be called for AccessPoint objects twice. - I also see twice as many "GetAll" method calls sent for each access point, although I haven't dug into why this is so yet... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Actually, the only time Qt's QNetworkManagerInterfaceAccessPoint does a GetAll is in the QNetworkManagerInterfaceAccessPoint c'tor. But that is in the upstream version. And the current ubuntu version (at least the one I am seeing) does not do GetAll at all. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
hmmm... I just noticed/remembered that upstream Qt networkmanager plugin has been updated, which should perform a bit better as it has had some refactoring/rewriting done. It is slightly more sane. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
And some more details, by adding 'env QDBUS_DEBUG=1' to the unity8 upstart job, I'm getting a lot more detail without having to further modify the code. I'm seeing "Adding rule" log statements produced by QDBusConnectionPrivate, but no corresponding "Removing rule" logs, so sounds like my previous theory is on track ( ie. that reference counting may be the cause ). That said, I'll need to add some more logging and rebuild... Also, while examining the DBus log, it looks like every time the plugin sees a 'PropertiesChanged' message from the AccessPoint, it calls "GetAll", which is pointless as all the changed properties are transmitted with the signal... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Just a quick update on my debugging. I've verified that the NM bearer plugin's qnetworkmanagerengine class is receiving the 'AccessPointRemoved', is matching them correctly in it's saved list, and is called delete on the QNetworkManagerInterfaceAccessPoint instance. The associated destructor is called, and my new disconnect() method is called, which succeeds. All that aside, the rules are still piling up, so something else is wrong. I took a quick look at the DBusConnection code, and it looks like the signal matches are reference counted, so it's possible that the count is never reaching zero, so the rule isn't actually released... ( see qdbusconnection.cpp and qdbusintegrator.cpp ). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I've extracted Lorn's connectivity-api draft commit and made it self- compiling: https://code.launchpad.net/~timo-jyrinki/+junk/connectivity-api-bearer You can either compile it yourself on the device or get this build for vivid/rc-proposed: https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/landing-059/+build/8313308/+files/libqt5network5-connectivityapibearer_0.0.1 %7Eunreleased-0ubuntu1%7Evivid1%7Etest1_armhf.deb It seems not to crash at least on device, but I don't know how to test it further. To test it: 1. Install the .deb 2. Remove/move the three other bearers from /usr/lib/arm-linux-gnueabihf/qt5/plugins/bearer away so that only libqubuntubearer.so is left 3. Reboot There'd now be also the new upstream method of QT_EXCLUDE_GENERIC_BEARER=1 that will be in Ubuntu's Qt 5.5 packages, but then I do not how it would be selected if NM or Ubuntu backend is used - if we get connectivity-api bearer working well enough, we should be able to specify it explicitly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The generic bearer plugin is brain dead, especially when it comes to knowing when it's actually connected or not. Although connectivity-api also suffers from blocking dbus calls, I feel the connectivity-api backend is the right way to go for bearer & QNAM right now. In the least, it will lessen the stress on dbus, as ideally, there should be only one Qt entity getting network-manager properties through dbus on a system. At least the blocking calls will be off loaded from everybody and their brother that happens to use QNAM knowingly or blindly. I am not yet familiar with who originally starts connectivity-api and when things start accessing QNAM at startup, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: location-service (Ubuntu RTM) Status: Triaged => In Progress ** Changed in: location-service (Ubuntu RTM) Assignee: Scott Sweeny (ssweeny) => Thomas Voß (thomas-voss) ** Branch linked: lp:~thomas-voss/location-service/fix-match-rule-leak ** Also affects: dbus-cpp (Ubuntu) Importance: Undecided Status: New ** Changed in: dbus-cpp (Ubuntu) Importance: Undecided => High ** Changed in: dbus-cpp (Ubuntu) Status: New => In Progress ** Changed in: dbus-cpp (Ubuntu) Assignee: (unassigned) => Thomas Voß (thomas-voss) ** Branch linked: lp:~thomas-voss/dbus-cpp/fix-signal-subscriptions -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
We need only a subset of the NM bearer features so it would be ok to replace or patch to limit its behavior. What we need is existing QNAM instances to not fall dead if user is on 3G + wifi and then disables wifi, or alternatively if on 3G and wifi gets enabled the connections should migrate to wifi. I don't know if connectivity-api currently has what would be needed for the bearer. We do not need network controlling in bearer since indicator-network handles that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
That's right, any time QNAM is used it uses the Qt Bearer backend (unless Qt is configure without bearer). In the case of the network- manager backend, it calls the blocking dbus calls to get list of services, and then for every service to get that services properties. Even for local file:// access, even though the bearer is not even used for local file access, thanks to QNAM private c'tor. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
re comment #68 and maliit access networking, from Albert on bug #1515712 > We should figure out why we are even doing any network stuff at all, as we probably shouldn't be. It comes from the fact that QtMultimedia uses network transparent methods to load urls used for audio playing, so even if in the keyboard we're using a local sound for audio feedback, QtMultimedia ends up bringing up the network backend because it uses those network transparent methods. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Lorn I don't think the blocking DBus calls are the culprit per se, although I did see a few while looking at the NM backend. The simple issue is that NM removes AccessPoint DBus objects on a regular basis, the the signal watches for these objects are not being released... I'd see your new plugin, but I guess there needs to be more discussion regarding whether or not we can replace the NM backend. @Timo seemed to have some reservations about this ( at least for the vivid-phone-overlay ). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
You might be running into those dbus blocking calls in the network-manager bearer backend. The networkmanager bearer plugin currently is using a few blocking dbus calls to get properties and such. see this abandoned change here: https://codereview.qt-project.org/#/c/98090/ This change was abandoned as QNAM is synchronous in nature, and expects defaultConfiguration to be ready right away. I have written a simple bearer backend plugin based on the connectivity-api that might be used instead. This has one static configuration that it used. https://codereview.qt-project.org/#/c/140752/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
The attachment "Initial attempt to patch QNetworkSession to fix match rules leak" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's a first attempt at a patch, which unfortunately doesn't seem to work... The general idea is when an AccessPointRemoved signal is received, we need to ensure that the associated DBus watch is removed. According to the QDbus documentation, DBusConnection::disconnect() should do this. I unfortunately didn't add any debug logging, so will have to take another stab on Monday ( unless someone else can take a look ). ** Patch added: "Initial attempt to patch QNetworkSession to fix match rules leak" https://bugs.launchpad.net/ubuntu-rtm/+source/sync-monitor/+bug/1480877/+attachment/4518542/+files/net-bearer-nm-disconnect-ap-signals.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Timo Thanks for the update. I commented on bug #1404188 regarding this bug. I agree with you that moving to a new backend for the vivid-overlay PPA is risky. That said, if we keep the networkmanager bug backend, this bug really needs to be fixed. What you say about the networkmanager backend is true, as NM is the controller of our networking, so querying it makes sense if you want to know whether we're on 3g or WiFi. That said, the connectivity API was originally designed to do the same thing, although it was never actually "published" as an API that could be used by the rest of the system. It was designed for this, however the team never finished the work, so AFAIK to date, it's only been used by indicator-network. In *theory*, it should be possible to query the same exact information from a connectivity-API based backend. It would give far less control however actually permitting changes to the network configuration and/or what interface was activated. I think that's OK, as we delegate all of that to indicator-network. We have no concept of a network-admin capability that can be granted to apps ( again AFAIK ). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qtbase-opensource-src (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
In parallel there has been some discussions on bug #1404188 about dropping the usage of network manager backend, even though unlikely in vivid-overlay unless seen as a bullet proof option. If you want to try out how that would look like, install the silo 032 on rc-proposed but _without_ upgrading the ubuntu-touch-session there. Or if you upgrade ubuntu-touch-session, just move /etc/profile.d/qt_networkmanager_bearer.sh away and reboot. The silo includes also some networking bug fixes besides making the bearer selectable but that's not relevant to this bug. The reason for keeping network manager bearer has been that with that Qt knows about switching between 3G and WiFi. If you use only generic plugin, have both wifi and 3g enabled and disable wifi, QNAM:s fall dead. Or if you use 3G only and enable wifi, 3G might be continued to be used. If those problems could be resolved on lower levels for example (or if they already are, the NM bearer enabling was done over a year ago), we could switch to the generic plugin. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qtbase-opensource-src (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Package changed: unity8 (Ubuntu RTM) => qtbase-opensource-src (Ubuntu) ** Also affects: unity8 Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: location-service (Ubuntu RTM) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
I just added tasks for the packages mentioned in comment #65. Some things learned today: - the sub-component of QNetwork that's most likely the cause is called Bearer Management. One of it's classes, QNetworkSession includes a plugin for NetworkManager which creates listeners for new AccessPoint DBus objects. - msyncd ( part of buteo-syncfw ) includes it's own internal NetworkManager class ( dated from 2010 ) which in turn uses QNetworkSession. - unity8 appears to use QNetworkAccessManager, which uses QNetworkSession. - sync-monitor uses QNetworkConfigurationManager, which is also part of Bearer Management, and most likely causes a QNetworkSession to be instantiated. - maliit-framework is the only puzzle, as it doesn't seem to have any network code. It does use QGuiApplication however, which might in turn hook into the network code. - the bulk of the code involved on the Qt side can be found in the qtbase-opensource-base source package. - I'm no expert in QtDBus, but from what I can tell, to listen to a DBus signal ( which causes a match rule to be created ), you need to call connect on an instance of a DBusConnection, similar to what you'd do with a native Qt signal and slot. Conversely, to remove a signal watch, you need to call the disconnect() function. - The connect to for a new new AccessPoint object can be found in src/plugins/bearer/networkmanager/networkmanagerservice.cpp in the funcion QNetworkManagerInterfaceAccessPoint::QNetworkManagerInterfaceAccessPoint(). - I don't see any corresponding cleanup code when an access point is removed ( ie. there's no disconnect() call made to the bus ) That's all I have for now... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Also affects: buteo-syncfw (Ubuntu) Importance: Undecided Status: New ** No longer affects: buteo-syncfw (Ubuntu) ** Also affects: buteo-syncfw (Ubuntu RTM) Importance: Undecided Status: New ** Also affects: unity8 (Ubuntu RTM) Importance: Undecided Status: New ** Also affects: maliit-framework (Ubuntu RTM) Importance: Undecided Status: New ** Also affects: sync-monitor (Ubuntu RTM) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's a script that calls dbus-monitor with the correct match rules in order to catch AccessPointAdded and Removed signals, as well as PropertiesChanged signals for the Device.Wireless 'AccessPoints' property. ** Attachment added: "monitor-aps.sh" https://bugs.launchpad.net/ubuntu-rtm/+source/location-service/+bug/1480877/+attachment/4517317/+files/monitor-aps.sh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@taiebot65 I don't think this is related to bug #1462664. This is specifically related to the number of processes watching individual network-manager access point objects, and the fact that these processes leak match rules, so they continue to add match rules to dbus for new access points, but never cleanup the old rules for access points that disappear. Also, per an earlier comment, as a vivid fix related to the ubuntu-software-center relaxed the per process dbus match limits to 5000 ( from 512 ), when all of these processes max out, the total is something like 40k rules that DBus has to match for every incoming message on the bus. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Pat We might want to hotfix this once we come to fully understand it( and I think we're getting close ). While working with tvoss a fixes to location-services, we realized that by default, the get-all-match.py script only outputs warnings. While reviewing a test run from tvoss, I didn't see any rules at all for posclientd or slpgwd, as he'd fixed the warnings. As I wanted to check whether or not the leak was still there, I realized I needed to specify "--all" with the script. This revealed a whole other group of processes that also were monitoring AccessPoint signals. I hadn't noticed them when first running the script, as I was just looking at the default warnings output, and these other processes appear to have specified the rules cleanly. It also appears that these processes are also leaking match rules for the AccessPoint signals as well. In addition to posclientd, and slpgwd ( tvoss has removed the watches for ubuntu-location-servicesd ) the following processes are involved: - msyncd ( part of bueto-syncfw ) - unity8 - unity8-dash - sync-monitor - maliit-server So, when fully maxed out, these too can reach 5k match rules each ( that's 25k for the five of them ). I just verified that they're all north of 1000 match rules on my krillin just now. This explains why after killing the location-service processes, we still were seeing a brief hiccup every time a WiFi scan occurs. I also noticed that mission-control-5 listed five AccessPoint match rules only, so that while it's listening, it's not leaking... All of the above processes except mission-control-5 use QtNetworkSession, whereas mission-control-5 uses nm-glib directly. I've also verified on krillin that AccessPointAdded and Removed signals are being generated when scan occur, and they seem to make sense. One or more of each signals are received, then a PropertiesChanged signal is fired for the AccessPoints property itself, with the changes indicated by the signals now applied. As it appears none of the AcessPoints are ever being removed from these match rules, my guess is that this is a bug in QNetworkSession vs. NM. I've monitored NM and when scanning occurs, APs are continually added/removed. The list can grow or shrink by 3-10 APs at a time. Of course this doesn't absolutely verify that the signals were sent or received. I'll attach a script which uses dbus-monitor to watch just the signals sent to the Device.Wireless interface, which should result in just monitoring AccessPointAdded/Removed and the associated PropertiesChanged for the AccessPoints property. Finally, we urgently need to fix the remaining leaks, but we also probably need to have someone determine whether there's any way to get rid of these rules completely. Does maliit-server really need to see 'LastSeen' property changes from individual access points??? Do any of these processes? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: canonical-devices-system-image Milestone: ww46-2015 => ww02-2016 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here my feedback from installing silo 10 as per bug #1462664. I have been walking to town today and did not notice any lag for the time i was in town. Normally i am experiencing some hangs of more than 1 min before i can get a working phone. Today i checked repeatedly my phone and it did wake up like a normal phone it would be nice if someone could confirm this behaviour. I did get though a lot of dialog menu as per https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1508563. This is less problematic than missing phone calls because the phone is slow as hell because of this bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
If it is linked to #1462664 Looks like it could be fixed I will try upgrading my system following the fix proposed in the bug and see if it solves the problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@Michael Thanks again for your help with testing this. 1) When the phone disconnects from an AP, the scan interval drops to it's lowest possible interval ( 20s ), as the goal is re-connecting as quick as possible. It'll eventually drift back to ~60s. 2) I also get the very brief <= 1s stutter when a WiFi scan occurs. I mention this in comment #57. If you look at the output of the dbus get-all-match rules script on mako ( comment #55 ), there are many other processes that are attached to the system bus and have specified less-than-optimal DBus match rules. We should indeed try to work through each project. That *said*, right now I think we should fix the obvious location- service issues which can cause the UI to lockup for close to 5-6s. That needs to be job one. I added a location-services task ( assigned to Scott on my team ) to track. That said, I don't propose we add tasks to this bug for every other project listed in the dbus match rule output... First, we should review with the product team if they're OK with closing out this bug once the location services fix(es) have landed. As for when you see the problem, again it really depends on what the scan interval is. If you're connected to an AP, it's ~2m, so you might not notice the <=1s stutter when it happens. If the iterval is 15s ( ie. when location-services is in control of scanning ), it's *much* more noticeable. My krillin right now is max'd out at 5k rules per loc daemon. The UI hangs for 4-5s each time a scan occurs, the frequency is per the above conditions... It's really bad when it gets to this point. So, the fixes I think we need asap are: - fix location-services scanning behavior ( when is it supposed to be turned on, and when is it shut off? seems broken atm ) - fix location-service match rules ( duplicate, and leaks; really only need one rule for all AccessPoint objects ) It also would be nice to understand why the same DBus traffic needs to be monitored by all three processes ( see comment #52 for more on this ). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Changed in: location-service (Ubuntu RTM) Assignee: (unassigned) => Scott Sweeny (ssweeny) ** Changed in: location-service (Ubuntu RTM) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Here's some test results from me. tl;dr stopping location services helps a lot, but still tiny UI stuttering. My routine is to leave my apartment and walk down the street. This means I go from wifi to 3G. What happens on current images is: 1) As my phone notices that I'm out of wifi range, it freaks out. This is when the UI stutters (and high dbus CPU). This can last up to a minute, making the phone nigh unusable for the duration. The indicator switches to 3G only after all the stuttering stops (making me think it's finally caught up to all the dbus traffic that's been trying to get through the loaded dbus). 2) Every so often after this (15 or 30 seconds maybe?), I get a very brief, maybe 1s, UI stutter. Presumably this is during wifi scans. It goes away if I turn off wifi completely. I don't see either of those issues when I'm on wifi. It's only going to 3G and staying on 3G that cause the problems. Again, everything points to wifi scans triggering it. So that's the normal routine. Today I tried that routine once to confirm it was still happening. Then turned off the three services per comment 56. And did my routine again. This time the switch to 3G happened faster. I still saw some stuttering during the transition. Maybe three short bursts of stutter in quick succession. But all over in a matter of seconds, versus the minute before. And I still saw the regular-interval 1s stutter during normal scans. But disabling locations was a huge help. And makes this bug go from a show-stopper to merely a regular annoyance. Shall we spin off a bug for the location folks to clean up their dbus usage? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
@awe: great progress! well done! :) I took a few videos to demonstrate the problem on my device KRILLIN, RC-PROPOSED, R163 network-manager 0.9.10.0-4ubuntu15.1.8 wpa-supplicant It was really easy to shoot videos at the right time because the problem happens exactly every 2 mins (which is the scanning interval Tony reported above) DISCLAIMER: The problem can actually get worse than what the first video shows (if I wait one or two days more) NO SERVICES DISABLED https://www.youtube.com/watch?v=UvGoX4Nh9oo SLPGWD DISABLED https://www.youtube.com/watch?v=-Vhd0eS5Af4 SLPGWD POSCLIENTD DISABLED https://www.youtube.com/watch?v=bTPiT2-LP2Y SLPGWD POSCLIENTD LOCATION-SERVICE DISABLED https://www.youtube.com/watch?v=V4SXNfJ9SqM Then I looked for more location/here related services in the system, and I disabled them as well SLPGWD POSCLIENTD LOCATION-SERVICE INDICATOR-LOCATION DISABLED https://www.youtube.com/watch?v=2QuED_1UzEw SLPGWD POSCLIENTD LOCATION-SERVICE INDICATOR-LOCATION LOCATION-SERVICE-TRUST-STORED DISABLED https://www.youtube.com/watch?v=9QgssDKDu1Q As can be seen from the videos, disabling SLPGWD is the change that made most of the difference, disabling POSCLIENTD also improved the situation a bit. Disabling the rest of the services brought very little to no advantage, as far as I can tell. However, as Tony was correctly saying, even after disabling everything, there's still a 1sec freeze every time a WiFi scan happens...and that can be quite annoying, especially when the scanning interval is much shorter than 2 mins. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Re: the xenial version of dbus, you need to be careful as although I was able to get it to run on a krillin, it prevented the UI from coming up on mako. This is why I backported the changes and pushed to my PPA ( 1.8.12-1ubuntu5~awe3 ). https://launchpad.net/~awe/+archive/ubuntu/ppa @Andrea I'd appreciate if you could test too. Note, to be able to verify the current number of match rules, you'd need to install dbus from my PPA. Your other choice is stopping the three location service jobs per comment #56, although this obviously will cause you to lose location services for the duration of your testing. Unfortunately, there's no way around this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
> I also began to see the Shutdown menu displayed every so often when > I let the screen go off, and then woke via the power button. That specific behavior is bug 1508563, whose fix just landed and will be in the next rc-proposed. It happened if unity8 was too being too slow (because the system was loaded). That is all great news! I will confirm today in my neighborhood and jump for joy if no UI freezes occur (I had tried those steps before but was watching CPU, where spikes still happened -- which I guess is the "slightest tick" you saw in the UI -- when a scan occurs). I'll note that xenial has dbus 1.10, so it should have GetAllMatches if anyone wants to try Tony's scripts without actually patching dbus. Just install devel-proposed instead of rc-proposed. Of course, that will change a lot of other things on your system. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
So re-testing with krillin ( rc-proposed, #162 ). Confirmed that using a patched version of dbus 1.8, the match rule limits aren't enforced, so each of the loc processes slowly grows its number of match rules till they cap out at 5000 each. So, WiFi enabled & connected, with the HERE app running *or* the Nearby or Today scopes currently selected. The scan interval of the phone is controlled by time in a particular state. If "disconnected", the scan interval starts low, and eventually tops out at ~60s. Likewise, if "connected" ( to an AP ), it'll top out at 2m. What's odd, is how location-services seems to be influencing scanning. If I bring the HERE app, or the Today or Nearby scopes to the foreground, the phone starts to do WiFi scans every 15s. If I bring another app to the foreground, this behavior stops, most of the time. I've able to get the phone into a state where the interval stays at 15s, no matter what app/scope is visible. Perhaps the location-service is losing state? Confirming scan interval is a matter or running wpa_cli and watching the events output as scan occur. Note, to mimic normal usage, I usually start fix or six apps ( camera, system settings, clock, term, messages, music ). Also, my confirmation of whether or not the the bug is occurring is *not* based on top, it's based on observation of the UI. I see UI freezes that occur in sync with WiFi scans, that can last anywhere from 1-6s when: - using the switcher, animation ( horizontal or vertical ) freezes - edges stop responding - app scrolling freezes I also began to see the Shutdown menu displayed every so often when I let the screen go off, and then woke via the power button. Freezes start at around 1s when the match rules for the loc services hits ~1000. As the match rules continue to increase, the lockups do seem to last a bit longer over time. When they've maxed out, the lockups might be as long as 3-5s. When I disabled WiFi, the UI freezes disappeared. This also reset the counts... so I let the phone run overnight and the counts rose back up again, and the freezes returned. Note, overnight all of the running apps appear to have been killed. Finally, I left WiFi on, but instead stopped the location services process per comment #56. At this point the freezes go away almost completely ( note by disabling location services, the scan interval goes back up to 60s ). I say *almost* go away as there's still the slightest tick whenever a scan occurs, but it's orders of magnitude smaller than when the rule counts have been max'd out. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
FYI, to prevent those three processes from respawning, do: sudo stop ubuntu-location-provider-here-slpgwd sudo stop ubuntu-location-provider-here-posclientd sudo stop ubuntu-location-service -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
** Also affects: location-service (Ubuntu RTM) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
Forgot to add the output of the system match rules for mako. Note at the time this was run both slpgwd and posclientd both have 616 match rules. It looks like stopping the location service ( via upstart or the indicator ) may have cleared the rules for ubuntu-location-servicesd. ** Attachment added: "log file of system match rules from mako" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877/+attachment/4512716/+files/mako-sys-watch-rules.out -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
One of the frustrating parts about this bug is the incomplete description, and the fact that it's been nigh impossible to nail down a set of concrete steps to reproduce... Also, the bug description contends that NM 'PropertiesChanged' signals are causing the UI freezes, however we have no idea why... We haven't been thinking enough about what's listening for the signals. "If a tree falls in the woods and nobody hears it?" The more listeners for a particular DBus message, the more work the daemon has to due ( and the more context switches involved ). Also, Mike Terry had mentioned in one of this comments that he'd seen the dbus daemon was spending most of it's time in it's match rules logic. Turns out that a new method had been added by upstream to the dbus Stats interface called 'GetAllMatchRules'. I'd been interested in this, for awhile, but finally got time to work on it. Two other points before I dive into the match rules: As of the latest rc-proposed for krillin ( # ), when the WiFi is enabled and the HERE app, Nearby scope, or Today scope are displayed, the location services increases the rate of WiFi scanning to once every 12-15s ( usually it's around 2m if connected to an AP ). When I decided to look at the incoming traffic to NM, I noticed that everytime a scan occurs, three different processes all seem to query the same set of NM AccessPoint objects. The clients all use 'Get' instead of 'GetAll' for the properties, and again it looks like each process is generating the same set of method requests. The processes in question are: - posclientd - slpgwd - ubuntu-location-serviced The amount of traffic isn't a huge impact, but it could be made more efficient. Back to the who's listening to the signals approach... First, I got lucky and was able to run dbus 1.10.0-1ubuntu1 from wily on my krillin on first try. This krillin was freshly flashed to the latest rc-proposed ( #162 ). When I ran the example get-all-match.py script ( see attached ) for the system bus ( use sudo and specify --system ), I was blown away that the same three location services processes previously mentioned above, each had 512 match rules for NM defined! 509 of the 512 were also flagged as warnings as no signal name was specified. It looks like these location processes are adding watches ( sometimes duplicates ) for every single AccessPoint object that ever gets created by NM. It also looks like these watches are never being cleaned up. So... I tried the same experiment on a mako, also freshly flashed ( rc- proposed, #150 ). Turns out I got lucky with krillin, mako didn't like the new dbus, and wouldn't boot into the UI. I had re-flash, then backport the changes to the version in vivid ( 1.8 ). This verions ( ~awe3 ) is available in my PPA: https://launchpad.net/~awe/+archive/ubuntu/ppa When I ran this version on mako, the first thing I noticed was that the match rule counts were much lower at first. As I didn't have apps/scopes to drive the increased WiFi scanning, I triggered extra scans by hand and watched the match rule counts ...and they slowly started to grow! After an hour or so, they actually exceeded 512 rules per process! It turns out the dbus configuration of the system bus in vivid was changed to allow up to *5000* match rules per process. See the attached patch for bug #454093. As I'm wrapping up this comment, each process is just about to hit 1000 rules each ( after 3h of uptime ). I tried toggling WiFi on/off/on, but this doesn't seem to effect the number of match rules involved. Tomorrow, I will try and reproduce the hangs by using the backport version of dbus from my PPA on krillin and let it run all day. One last note, it'd be good to confirm that fully stopping these location service processes makes the problem go away. That said, I wasn't able to find an easy way to get the processes involved to shut down. Disabling from the indicator doesn't do it, and stopping the system upstart job ( 'sudo stop ubuntu-location-service' ) didn't do so either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1480877] Re: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices
This script queries GetAllMatchRules and generates output including warnings about less-optimal DBus match rules. ** Attachment added: "example DBus script for GetAllMatchRules usage" https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+attachment/4512384/+files/get-all-match.py -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1480877 Title: Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs