[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Launchpad Bug Tracker]

This bug was fixed in the package google-apputils-python -
0.4.1-1ubuntu2.16.04.1

---
google-apputils-python (0.4.1-1ubuntu2.16.04.1) xenial; urgency=medium

  * Additional fixes for Python 3. (LP: #1735162)

 -- Andrea Azzarone   Thu, 11 Jan 2018
10:04:59 +

** Changed in: google-apputils-python (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Launchpad Bug Tracker]

This bug was fixed in the package google-apputils-python -
0.4.1-1ubuntu2.17.10.1

---
google-apputils-python (0.4.1-1ubuntu2.17.10.1) artful; urgency=medium

  * Additional fixes for Python 3. (LP: #1735162)

 -- Andrea Azzarone   Thu, 11 Jan 2018
10:04:59 +

** Changed in: google-apputils-python (Ubuntu Artful)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

'python[3] -c "from google.apputils import basetest"' runs properly in
Xeanial too now. Marking as verification-done.

** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

'python3 -c "from google.apputils import basetest"' runs properly in
Artufl now. Marking as verification-done.

** Tags removed: verification-needed-artful
** Tags added: verification-done-artful

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Brian Murray]

Unsubscribing ubuntu-sponsors.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Robie Basak]

Hello Andrea, or anyone else affected,

Accepted google-apputils-python into xenial-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/google-apputils-python/0.4.1-1ubuntu2.16.04.1 in a few hours, and then
in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-xenial to verification-done-xenial. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-xenial. In either case, details of your
testing will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: google-apputils-python (Ubuntu Xenial)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Robie Basak]

Unsubscribing sponsors.

** Changed in: google-apputils-python (Ubuntu Artful)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-artful

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Robie Basak]

SRU review:

The only code changes add Python 3 compatibility. Since python3-google-
apputils shipped in Xenial, the package was broken as shipped and can be
fixed under SRU policy.

The patch being included here (and in Bionic) has yet to be reviewed or
accepted upstream.

I did notice one issue, but it is non-functional as the type of
_STRING_TYPES and _INT_TYPES (whether a tuple or a raw instance of type)
happen not to matter because of how they are used and I have commented
on the pull request upstream.

Please make sure to test both Python 2 and Python 3 functionality during
SRU verification.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Iain Lane]

Uploaded for 17.10 too

** Also affects: google-apputils-python (Ubuntu Artful)
   Importance: Undecided
   Status: New

** Changed in: google-apputils-python (Ubuntu Artful)
   Status: New => In Progress

** Changed in: google-apputils-python (Ubuntu Artful)
 Assignee: (unassigned) => Iain Lane (laney)

** Changed in: google-apputils-python (Ubuntu Artful)
 Assignee: Iain Lane (laney) => Andrea Azzarone (azzar1)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Launchpad Bug Tracker]

This bug was fixed in the package google-apputils-python -
0.4.1-1ubuntu3

---
google-apputils-python (0.4.1-1ubuntu3) bionic; urgency=medium

  * Additional fixes for Python 3. (LP: #1735162)

 -- Andrea Azzarone   Thu, 11 Jan 2018
10:04:59 +

** Changed in: google-apputils-python (Ubuntu)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

@sil2100 confirmed me that this is required.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Iain Lane]

(As in bug #1735160, I'm not sure if I have to fix this in Artful too -
SRU team, please let us know if we should.)

** Changed in: google-apputils-python (Ubuntu Xenial)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Iain Lane]

OK, I uploaded to bionic + xenial, thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

Not needed to fix this bug. Also consider that there is another
python3-fixes.patch which solves other python3 related issue. So there
was no need to take it all.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Iain Lane]

On Tue, Jan 09, 2018 at 03:01:30PM -, Andrea Azzarone wrote:
> Hey laney, thanks for the review. Please find attached the new debdiff
> with requested changes.

Thanks! Looks good in itself - but why did you only take part of that
patch, are the other bits not needed for some reason?

-- 
Iain Lane  [ i...@orangesquash.org.uk ]
Debian Developer   [ la...@debian.org ]
Ubuntu Developer   [ la...@ubuntu.com ]

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

Hey laney, thanks for the review. Please find attached the new debdiff
with requested changes.

** Patch added: "gap.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+attachment/5033566/+files/gap.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Iain Lane]

Hey, thanks for the patch!

Can you explain where the change comes from please? Adding DEP-3 headers
to the patch would be the best way to do this.

** Also affects: google-apputils-python (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Changed in: google-apputils-python (Ubuntu Xenial)
 Assignee: (unassigned) => Andrea Azzarone (azzar1)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1735162] Re: [SRU] Cannot import basetest in python3

[Andrea Azzarone]

** Summary changed:

- Cannot import basetest in python3
+ [SRU] Cannot import basetest in python3

** Description changed:

+ [Impact]
+ We need to get this SRUed in Xenial too as part of 
https://bugs.launchpad.net/xenial-backports/+bug/1735160
+ 
+ [Test Case]
+ 
  To reproduce:
  
  $ python3 -c "from google.apputils import basetest"
  
  It will fail showing something like that:
  
  Traceback (most recent call last):
    File "", line 1, in 
    File "/usr/lib/python3/dist-packages/google/apputils/basetest.py", line 37, 
in 
  import urlparse
  ImportError: No module named 'urlparse'
  
- We need to get this SRUed in Xenial too as part of
- https://bugs.launchpad.net/xenial-backports/+bug/1735160
+ 
+ [Possible Regressions]
+ Please make sure:
+ $ python2 -c "from google.apputils import basetest"
+ 
+ still works

** Description changed:

  [Impact]
  We need to get this SRUed in Xenial too as part of 
https://bugs.launchpad.net/xenial-backports/+bug/1735160
  
  [Test Case]
  
  To reproduce:
  
  $ python3 -c "from google.apputils import basetest"
  
  It will fail showing something like that:
  
  Traceback (most recent call last):
    File "", line 1, in 
    File "/usr/lib/python3/dist-packages/google/apputils/basetest.py", line 37, 
in 
  import urlparse
  ImportError: No module named 'urlparse'
  
- 
- [Possible Regressions]
+ [Regression Potential]
  Please make sure:
  $ python2 -c "from google.apputils import basetest"
  
  still works

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1735162

Title:
  [SRU] Cannot import basetest in python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs