[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
This bug is awaiting verification that the linux- intel-5.13/5.13.0-1010.10 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification- done-focal'. If the problem still exists, change the tag 'verification- needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
This bug was fixed in the package linux - 5.13.0-28.31 --- linux (5.13.0-28.31) impish; urgency=medium * amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot (LP: #1956519) - HID: amd_sfh: Fix potential NULL pointer dereference * impish: ddebs build take too long and times out (LP: #1957810) - [Packaging] enforce xz compression for ddebs * audio mute/ mic mute are not working on a HP machine (LP: #1955691) - ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook * rtw88_8821ce causes freeze (LP: #1927808) - rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE * alsa/sdw: fix the audio sdw codec parsing logic in the acpi table (LP: #1955686) - ALSA: hda: intel-sdw-acpi: harden detection of controller - ALSA: hda: intel-sdw-acpi: go through HDAS ACPI at max depth of 2 * icmp_redirect from selftests fails on F/kvm (unary operator expected) (LP: #1938964) - selftests: icmp_redirect: pass xfail=0 to log_test() * Impish update: upstream stable patchset 2021-12-17 (LP: #1955180) - arm64: zynqmp: Do not duplicate flash partition label property - arm64: zynqmp: Fix serial compatible string - ARM: dts: sunxi: Fix OPPs node name - arm64: dts: allwinner: h5: Fix GPU thermal zone node name - arm64: dts: allwinner: a100: Fix thermal zone node name - staging: wfx: ensure IRQ is ready before enabling it - ARM: dts: NSP: Fix mpcore, mmc node names - scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq() - arm64: dts: rockchip: Disable CDN DP on Pinebook Pro - arm64: dts: hisilicon: fix arm,sp805 compatible string - RDMA/bnxt_re: Check if the vlan is valid before reporting - bus: ti-sysc: Add quirk handling for reinit on context lost - bus: ti-sysc: Use context lost quirk for otg - usb: musb: tusb6010: check return value after calling platform_get_resource() - usb: typec: tipd: Remove WARN_ON in tps6598x_block_read - ARM: dts: ux500: Skomer regulator fixes - staging: rtl8723bs: remove possible deadlock when disconnect (v2) - ARM: BCM53016: Specify switch ports for Meraki MR32 - arm64: dts: qcom: msm8998: Fix CPU/L2 idle state latency and residency - arm64: dts: qcom: ipq6018: Fix qcom,controlled-remotely property - arm64: dts: freescale: fix arm,sp805 compatible string - ASoC: SOF: Intel: hda-dai: fix potential locking issue - clk: imx: imx6ul: Move csi_sel mux to correct base register - ASoC: nau8824: Add DMI quirk mechanism for active-high jack-detect - scsi: advansys: Fix kernel pointer leak - ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec - firmware_loader: fix pre-allocated buf built-in firmware use - ARM: dts: omap: fix gpmc,mux-add-data type - usb: host: ohci-tmio: check return value after calling platform_get_resource() - ARM: dts: ls1021a: move thermal-zones node out of soc/ - ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash - ALSA: ISA: not for M68K - tty: tty_buffer: Fix the softlockup issue in flush_to_ldisc - MIPS: sni: Fix the build - scsi: scsi_debug: Fix out-of-bound read in resp_readcap16() - scsi: scsi_debug: Fix out-of-bound read in resp_report_tgtpgs() - scsi: target: Fix ordered tag handling - scsi: target: Fix alua_tg_pt_gps_count tracking - iio: imu: st_lsm6dsx: Avoid potential array overflow in st_lsm6dsx_set_odr() - powerpc/5200: dts: fix memory node unit name - ARM: dts: qcom: fix memory and mdio nodes naming for RB3011 - ALSA: gus: fix null pointer dereference on pointer block - powerpc/dcr: Use cmplwi instead of 3-argument cmpli - powerpc/8xx: Fix Oops with STRICT_KERNEL_RWX without DEBUG_RODATA_TEST - sh: check return code of request_irq - maple: fix wrong return value of maple_bus_init(). - f2fs: fix up f2fs_lookup tracepoints - f2fs: fix to use WHINT_MODE - sh: fix kconfig unmet dependency warning for FRAME_POINTER - sh: math-emu: drop unused functions - sh: define __BIG_ENDIAN for math-emu - f2fs: compress: disallow disabling compress on non-empty compressed file - f2fs: fix incorrect return value in f2fs_sanity_check_ckpt() - clk: ingenic: Fix bugs with divided dividers - clk/ast2600: Fix soc revision for AHB - clk: qcom: gcc-msm8996: Drop (again) gcc_aggre1_pnoc_ahb_clk - mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set - sched/core: Mitigate race cpus_share_cache()/update_top_cache_domain() - perf/x86/vlbr: Add c->flags to vlbr event constraints - blkcg: Remove extra blkcg_bio_issue_init - tracing/histogram: Do not copy the fixed-size char array field over the field size - perf bpf: Avoid memory leak from perf_env__insert_btf() - perf bench futex: Fix memory leak of perf_cpu_map__new() - perf tests: Remove bash construct from
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Hi Stefan, Yes, this will be brought to Focal's HWE kernel, and will be released at the same time the Impish kernel is released, looking to be the end of the month going by https://kernel.ubuntu.com/ Vadik, Iestyn, thank you very much for verifying the Impish kernel in -proposed. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Just out of curiosity: Is it planned to bring this to Focal too? (since the same problem can be seen in LTS Focal with kernels 5.13). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Same here, problem resolved. Great job, amazing turnaround. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Kleber, works like a charm! Thanks a lot for the bugfix. MINIPC-PN50:~$ uname -ra Linux MINIPC-PN50 5.13.0-28-generic #31-Ubuntu SMP Thu Jan 13 17:41:06 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ** Tags removed: verification-needed-impish ** Tags added: verification-done-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Hello Matthew and everyone else affected by this issue, The Impish kernel had to be re-spun because of a security issue and the kernel team decided to include this fix with the re-spin. Could someone please verify if the kernel mentioned on the previous automated comment fixes the bug? Thank you. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
This bug is awaiting verification that the linux/5.13.0-28.31 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-impish' to 'verification-done-impish'. If the problem still exists, change the tag 'verification-needed-impish' to 'verification-failed-impish'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Hi Vadik, Oliver, Iestyn, The kernel team has reviewed the patches, and we have two acks from Senior kernel team members: https://lists.ubuntu.com/archives/kernel-team/2022-January/127108.html https://lists.ubuntu.com/archives/kernel-team/2022-January/127111.html The patch has now been applied to the Impish kernel git tree: https://lists.ubuntu.com/archives/kernel-team/2022-January/127117.html We are all set, and accepted into the next SRU cycle. I will likely write back around the 7th of Feb, when there is a new kernel in -proposed for you to test and verify. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
** Changed in: linux (Ubuntu Impish) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Thanks a lot Matthew. Alright, no problems at all, I'll stick to .22 kernel for now and will wait for updates. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
Hi Vadik, Thanks for running that test kernel, and its great to hear that it fixes your issue. I have written up a proper SRU template for the bug, and I tidied up the patches and submitted them for SRU to the Ubuntu Kernel team mailing list: https://lists.ubuntu.com/archives/kernel-team/2022-January/127102.html https://lists.ubuntu.com/archives/kernel-team/2022-January/127103.html The next steps are for the kernel team to review the patches. We need two acks from Senior Kernel Team members to be accepted into the next kernel SRU cycle. Once we have two acks, the patch will be applied to the Impish kernel git tree, and built into the next kernel update, and placed into -proposed for verification. When this happens, I will need you to test the kernel in -proposed and again make sure it fixes your issue. If it does, I will mark the Launchpad bug as verified and the kernel will be released to -updates at the end of the cycle. Looking at https://kernel.ubuntu.com/, we see the next patch deadline is the 26th of Jan, hopefully we will get a review by then, the kernel team will build the kernel between 31st Jan and 4th of Feb, and the kernel will be in -proposed between 7th Feb and 18th of Feb, with a release hopefully 21st Feb, give or take a few days if any CVEs turn up. I will keep you informed of each step, and I will write back when its time to test the kernel in -proposed. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1956519 Title: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956519/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1956519] Re: amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot
** Summary changed: - kernel panic after upgrading to kernel 5.13.0-23 + amd_sfh: Null pointer dereference on early device init causes early panic and fails to boot ** Description changed: - After upgrading my son's Asus PN50 with Ubuntu 21.10 to the latest - kernel 5.13.0-23, I am no longer able to boot it normally. Kernel fails - with the panic halfway through the boot process (which got overall - suspiciously slow): + BugLink: https://bugs.launchpad.net/bugs/1956519 - [1.359465] BUG: kernel NULL pointer dereference, address: 000c - [1.359498] #PF: supervisor write access in kernel mode - [1.359519] #PF: error_code(0x0002) - not-present page - [1.359540] PGD 0 P4D 0 - [1.359553] Oops: 0002 [#1] SMP NOPTI - [1.359569] CPU: 0 PID: 175 Comm: systemd-udevd Not tainted 5.13.0-23-generic #23-Ubuntu - [1.359602] Hardware name: ASUSTeK COMPUTER INC. MINIPC PN50/PN50, BIOS 0623 05/13/2021 - [1.359632] RIP: 0010:amd_sfh_hid_client_init+0x47/0x350 [amd_sfh] - [1.359661] Code: 00 53 48 83 ec 20 48 8b 5f 08 48 8b 07 48 8d b3 22 01 00 00 4c 8d b0 c8 00 00 00 e8 23 07 00 00 45 31 c0 31 c9 ba 00 00 20 00 <89> 43 0c 48 8d 83 68 01 00 00 48 8d bb 80 01 00 00 48 c7 c6 20 6d - [1.359729] RSP: 0018:bf71c099f9d8 EFLAGS: 00010246 - [1.359750] RAX: RBX: RCX: - [1.359777] RDX: 0020 RSI: c03cd249 RDI: a680004c - [1.359804] RBP: bf71c099fa20 R08: R09: 0006 - [1.359831] R10: bf71c0d0 R11: 0007 R12: 000fffe0 - [1.359857] R13: 992bc3387cd8 R14: 992bc11560c8 R15: 992bc3387cd8 - [1.359884] FS: 7ff0ec1a48c0() GS:992ebf60() knlGS: - [1.359915] CS: 0010 DS: ES: CR0: 80050033 - [1.359937] CR2: 000c CR3: 000102fd CR4: 00350ef0 - [1.359964] Call Trace: - [1.359976] ? __pci_set_master+0x5f/0xe0 - [1.359997] amd_mp2_pci_probe+0xad/0x160 [amd_sfh] - [1.360021] local_pci_probe+0x48/0x80 - [1.360038] pci_device_probe+0x105/0x1c0 - [1.360056] really_probe+0x24b/0x4c0 - [1.360073] driver_probe_device+0xf0/0x160 - [1.360091] device_driver_attach+0xab/0xb0 - [1.360110] __driver_attach+0xb2/0x140 - [1.360126] ? device_driver_attach+0xb0/0xb0 - [1.360145] bus_for_each_dev+0x7e/0xc0 - [1.360161] driver_attach+0x1e/0x20 - [1.360177] bus_add_driver+0x135/0x1f0 - [1.360194] driver_register+0x95/0xf0 - [1.360210] ? 0xc03d2000 - [1.360225] __pci_register_driver+0x57/0x60 - [1.360242] amd_mp2_pci_driver_init+0x23/0x1000 [amd_sfh] - [1.360266] do_one_initcall+0x48/0x1d0 - [1.360284] ? kmem_cache_alloc_trace+0xfb/0x240 - [1.360306] do_init_module+0x62/0x290 - [1.360323] load_module+0xa8f/0xb10 - [1.360340] __do_sys_finit_module+0xc2/0x120 - [1.360359] __x64_sys_finit_module+0x18/0x20 - [1.360377] do_syscall_64+0x61/0xb0 - [1.361638] ? ksys_mmap_pgoff+0x135/0x260 - [1.362883] ? exit_to_user_mode_prepare+0x37/0xb0 - [1.364121] ? syscall_exit_to_user_mode+0x27/0x50 - [1.365343] ? __x64_sys_mmap+0x33/0x40 - [1.366550] ? do_syscall_64+0x6e/0xb0 - [1.367749] ? do_syscall_64+0x6e/0xb0 - [1.368923] ? do_syscall_64+0x6e/0xb0 - [1.370079] ? syscall_exit_to_user_mode+0x27/0x50 - [1.371227] ? do_syscall_64+0x6e/0xb0 - [1.372359] ? exc_page_fault+0x8f/0x170 - [1.373478] ? asm_exc_page_fault+0x8/0x30 - [1.374584] entry_SYSCALL_64_after_hwframe+0x44/0xae - [1.375684] RIP: 0033:0x7ff0ec73a94d - [1.376767] Code: 5b 41 5c c3 66 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b3 64 0f 00 f7 d8 64 89 01 48 - [1.377926] RSP: 002b:7ffd00724ba8 EFLAGS: 0246 ORIG_RAX: 0139 - [1.379076] RAX: ffda RBX: 55e130084390 RCX: 7ff0ec73a94d - [1.380225] RDX: RSI: 7ff0ec8ca3fe RDI: 0005 - [1.381363] RBP: 0002 R08: R09: - [1.382488] R10: 0005 R11: 0246 R12: 7ff0ec8ca3fe - [1.383598] R13: 55e130083370 R14: 55e130084480 R15: 55e130086cb0 - [1.384698] Modules linked in: ahci(+) libahci i2c_piix4(+) r8169(+) amd_sfh(+) i2c_hid_acpi realtek i2c_hid xhci_pci(+) xhci_pci_renesas wmi(+) video(+) fjes(+) hid - [1.385841] CR2: 000c - [1.386955] ---[ end trace b2ebcacf74b788da ]--- - [1.388064] RIP: 0010:amd_sfh_hid_client_init+0x47/0x350 [amd_sfh] - [1.389176] Code: 00 53 48 83 ec 20 48 8b 5f 08 48 8b 07 48 8d b3 22 01 00 00 4c 8d b0 c8 00 00 00 e8 23 07 00 00 45 31 c0 31 c9 ba 00 00 20 00 <89> 43 0c 48 8d 83 68 01 00 00 48 8d bb 80 01 00 00 48 c7 c6 20 6d
