Re: [v8-dev] Build of 5.7-lkgr fails with default options

2017-03-01 Thread 'Clemens Hammacher' via v8-dev 
The fix for this has landed yesterday as
https://github.com/v8/v8/commit/6bb221b49ebcac13653477d2d3e01f921a721474.
It should work if you just retry.

--Clemens


On Tue, Feb 28, 2017 at 11:31 AM  wrote:

> I ran:
>
> git checkout 5.7-lkgr
> gclient sync
> make x64.release
>
> Errors:
>
> make[1]: Entering directory '/home/mzasso/git/chromium/v8/v8/out'
>   CXX(target)
> /home/mzasso/git/chromium/v8/v8/out/x64.release/obj.target/v8_base/src/wasm/wasm-js.o
> ../src/wasm/wasm-js.cc:250:8: error: unused variable 'bytes'
> [-Werror,-Wunused-variable]
>   auto bytes = GetFirstArgumentAsBytes(args, );
>^
> ../src/wasm/wasm-js.cc:296:8: error: unused variable 'bytes'
> [-Werror,-Wunused-variable]
>   auto bytes = GetFirstArgumentAsBytes(args, );
>^
> 2 errors generated.
> src/v8_base.target.x64.release.mk:697: recipe for target
> '/home/mzasso/git/chromium/v8/v8/out/x64.release/obj.target/v8_base/src/wasm/wasm-js.o'
> failed
> make[1]: ***
> [/home/mzasso/git/chromium/v8/v8/out/x64.release/obj.target/v8_base/src/wasm/wasm-js.o]
> Error 1
>
>
>
> The lines were introduced in this commit:
> https://github.com/v8/v8/commit/b98b2190bf24960388760146c771fa94b4860ac0
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 

Clemens Hammacher

Software Engineer

cleme...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.



This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

2017-03-01 Thread Benedikt Meurer 
The ObjectBuiltinsAssembler adds a couple of additional helper methods.

-- Benedikt


Benedikt Meurer |  Software Engineer, V8 |  Google Germany GmbH |
Erika-Mann-Str.
33, 80636 München

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft:
Hamburg | Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

On Wed, Mar 1, 2017 at 3:12 PM,  wrote:

> Thank you so much for your hints, I finally get valueOf to work now (was
> getting crashes in run mksnapshot step before I asked help here)!
>
> toString uses ObjectBuiltinsAssembler instead of CodeStubAssembler, what
> are the differences between them?
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

2017-03-01 Thread loorongjie 
Thank you so much for your hints, I finally get valueOf to work now (was 
getting crashes in run mksnapshot step before I asked help here)!

toString uses ObjectBuiltinsAssembler instead of CodeStubAssembler, what 
are the differences between them?

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-dev] Re: Contributing to V8

2017-03-01 Thread leszeks 
Hi Umang,

Great to hear that you're interested in contributing. Your best way to get 
started is just to get things compiling; V8 is a pretty complex project, 
and even getting it running can take some time :). You can find information 
on getting source code and building on our public wiki: 
https://github.com/v8/v8/wiki/Building%20from%20Source.

Once you've done that, it really depends on your interests and expertise. 
We have a public bug tracker for currently known issues (
https://bugs.chromium.org/p/v8/issues/list), or if you have your own ideas 
then we always welcome design documents and patches. If you want to get a 
*lot* more involved in V8 development, you may even want to consider 
applying to Google for an internship (https://careers.google.com/students/).

Cheers,

Leszek

On Tuesday, February 28, 2017 at 5:28:57 PM UTC, Umang Sharma wrote:
>
> Hi I am Umang ,Looking to contribute to V8 , I am pretty good with C++ and 
> have worked on a lot of AI and Data science project .
> It would be great if someone , guides me on how to get started on 
> contributing to V8 :) 
>
>
> Thanks ,
> Umang
>

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

2017-03-01 Thread Benedikt Meurer 
We don't really have a policy for the builtins, it's good judgement whether
to use C++ or CSA. I'd say Object.prototype.valueOf is a good starting
point. It can be migrated to a TF_BUILTIN, based on the CodeStubAssembler.
The builtin (with JavaScript linkage) would basically become a wrapper for
the ToObject builtin (which has internal stub linkage). I don't think you
need to touch src/runtime or src/debug for this.

HTH,
Benedikt


Benedikt Meurer |  Software Engineer, V8 |  Google Germany GmbH |
Erika-Mann-Str.
33, 80636 München

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft:
Hamburg | Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

On Wed, Mar 1, 2017 at 11:51 AM,  wrote:

> Hi all!
>
> I am new to V8 project. I am trying to work on crbug.com/v8/6005 (Migrate
> v8natives.js). By referencing commit history and the style of the codes and
> lots help from cs.chromium.org/chromium/src/v8/, I at least figured out
> how to migrate the constants (CL accepted). However, migrating functions is
> a lot harder for me.
>
> Things I feel confused about:
>
>- In builtins/builtins-object.cc, functions wrapped by BUILTIN()
>sometimes return Handle, sometimes Handle.
>- In several commits where JS functions are moved to C++, sometimes
>runtime/runtime.h, runtime/runtime-{type}.cc and
>debug/debug-evaluate.cc need to be modified as well, but not always.
>- How to decide whether to implement the function as C++ builtin or TF
>builtin?
>
> It will be great someone can guide me through this. Is there existing
> documentation on how V8 codes are organized, how to use certain C++
> functions, https://tc39.github.io/ecma262/ and so on?
>
> Thanks in advance.
>
> Regards,
> Rong Jie
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

2017-03-01 Thread loorongjie 
Hi all!

I am new to V8 project. I am trying to work on crbug.com/v8/6005 (Migrate 
v8natives.js). By referencing commit history and the style of the codes and 
lots help from cs.chromium.org/chromium/src/v8/, I at least figured out how 
to migrate the constants (CL accepted). However, migrating functions is a 
lot harder for me.

Things I feel confused about:

   - In builtins/builtins-object.cc, functions wrapped by BUILTIN() 
   sometimes return Handle, sometimes Handle.
   - In several commits where JS functions are moved to C++, sometimes 
   runtime/runtime.h, runtime/runtime-{type}.cc and debug/debug-evaluate.cc 
   need to be modified as well, but not always.
   - How to decide whether to implement the function as C++ builtin or TF 
   builtin?

It will be great someone can guide me through this. Is there existing 
documentation on how V8 codes are organized, how to use certain C++ 
functions, https://tc39.github.io/ecma262/ and so on?

Thanks in advance.

Regards,
Rong Jie

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.