Re: [vdr] [Makefile] `-fPIC` not added to externally defined `C[XX]FLAGS` of PLUGINS if `Make.config` not available
On tiistai, 26. tammikuuta 2010 12:09:11 Frank Schmirler wrote: > On Tue, 26 Jan 2010 10:54:00 +0100, Paul Menzel wrote > > > Am Dienstag, den 26.01.2010, 10:34 +0100 schrieb Frank Schmirler: > > > This has already been discussed during the last months, I just didn't > > > take the time yet to propose a fix: > > > > > > http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html > > > http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html > > > > Thank you for the links. I could not figure out what alternativ is > > preferred though. If you tell me, I could prepare a patch. > > Well, there hasn't been much feedback... At first I preferred the "copy > Make.config.template to Make.config if it doesn't exist" approach as it > doesn't require any change in plugin Makefiles and adds just a single line > to VDR's Makefile. But the cleaner solution is clearly "include a > Make.global in plugin plugin and VDR Makefiles before Make.config" as > preferred by Udo Richter. I also prefer this approach. Make.global should contain the necessary stuff and Make.config should contain strictly user-defined optional stuff. > Would be great if you could prepare the patch. -- Anssi Hannula ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [Makefile] `-fPIC` not added to externally defined `C[XX]FLAGS` of PLUGINS if `Make.config` not available
On Tue, 26 Jan 2010 10:54:00 +0100, Paul Menzel wrote > Am Dienstag, den 26.01.2010, 10:34 +0100 schrieb Frank Schmirler: > > This has already been discussed during the last months, I just didn't take > > the > > time yet to propose a fix: > > > > http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html > > http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html > > Thank you for the links. I could not figure out what alternativ is > preferred though. If you tell me, I could prepare a patch. Well, there hasn't been much feedback... At first I preferred the "copy Make.config.template to Make.config if it doesn't exist" approach as it doesn't require any change in plugin Makefiles and adds just a single line to VDR's Makefile. But the cleaner solution is clearly "include a Make.global in plugin plugin and VDR Makefiles before Make.config" as preferred by Udo Richter. Would be great if you could prepare the patch. Cheers, Frank ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [Makefile] `-fPIC` not added to externally defined `C[XX]FLAGS` of PLUGINS if `Make.config` not available
Am Dienstag, den 26.01.2010, 10:34 +0100 schrieb Frank Schmirler: > On Mon, 25 Jan 2010 23:43:11 +0100, Paul Menzel wrote > > 1. Each `Makefile` of a plugin gets rewritten to always append `- > > fPIC` to `C[XX]FLAGS`. Here is an example for the plugin hello. > > > > 2. If `DEFINES` from the beginning is also needed, that we should factor > > the snippet out into a file `Make.plugins` and every plugin has to > > include it in its Makefile. > > > > What do you think? What alternative is preferable? When this is decided > > I would create a patch to change that in VDR. > > This has already been discussed during the last months, I just didn't take the > time yet to propose a fix: > > http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html > http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html Thank you for the links. I could not figure out what alternativ is preferred though. If you tell me, I could prepare a patch. Thanks, Paul signature.asc Description: Dies ist ein digital signierter Nachrichtenteil ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [Makefile] `-fPIC` not added to externally defined `C[XX]FLAGS` of PLUGINS if `Make.config` not available
On Mon, 25 Jan 2010 23:43:11 +0100, Paul Menzel wrote > 1. Each `Makefile` of a plugin gets rewritten to always append `- > fPIC` to `C[XX]FLAGS`. Here is an example for the plugin hello. > > 2. If `DEFINES` from the beginning is also needed, that we should factor > the snippet out into a file `Make.plugins` and every plugin has to > include it in its Makefile. > > What do you think? What alternative is preferable? When this is decided > I would create a patch to change that in VDR. This has already been discussed during the last months, I just didn't take the time yet to propose a fix: http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html Best regards, Frank ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
