[webkit-changes] [212134] trunk

[beidson]

Title: [212134] trunk








Revision 212134
Author beid...@apple.com
Date 2017-02-10 12:38:35 -0800 (Fri, 10 Feb 2017)


Log Message
Replace all WebKit Library Version checks in WK2 with SDK version checks.
https://bugs.webkit.org/show_bug.cgi?id=168124

Reviewed by Geoffrey Garen.

Source/WebKit2:

This change gets rid of WebKit Library Version checks and replaces them with SDK version checks.

To allow our tools to still be able to test new behaviors even when built against older SDKs,
it also opts them into an SPI default to have "linkedOnOrAfter()" always return true.

* Shared/Cocoa/CompletionHandlerCallChecker.mm:
(WebKit::shouldThrowExceptionForDuplicateCompletionHandlerCall):

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):

* UIProcess/Cocoa/VersionChecks.h:
(WebKit::linkedOnOrAfter): Deleted.
* UIProcess/Cocoa/VersionChecks.mm:
(WebKit::linkedOnOrAfter):

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::isNetworkCacheEnabled):

Tools:

For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.

* MiniBrowser/mac/main.m:
(main):
* MobileMiniBrowser/MobileMiniBrowser/main.m:
(main):
* TestWebKitAPI/ios/mainIOS.mm:
(main):
* TestWebKitAPI/mac/mainMac.mm:
(main):
* WebKitTestRunner/ios/mainIOS.mm:
(main):
* WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h
trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.mm
trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/main.m
trunk/Tools/MobileMiniBrowser/MobileMiniBrowser/main.m
trunk/Tools/TestWebKitAPI/ios/mainIOS.mm
trunk/Tools/TestWebKitAPI/mac/mainMac.mm
trunk/Tools/WebKitTestRunner/ios/mainIOS.mm
trunk/Tools/WebKitTestRunner/mac/main.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212133 => 212134)

--- trunk/Source/WebKit2/ChangeLog	2017-02-10 20:35:59 UTC (rev 212133)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-10 20:38:35 UTC (rev 212134)
@@ -1,3 +1,29 @@
+2017-02-10  Brady Eidson  
+
+Replace all WebKit Library Version checks in WK2 with SDK version checks.
+https://bugs.webkit.org/show_bug.cgi?id=168124
+
+Reviewed by Geoffrey Garen.
+
+This change gets rid of WebKit Library Version checks and replaces them with SDK version checks.
+
+To allow our tools to still be able to test new behaviors even when built against older SDKs,
+it also opts them into an SPI default to have "linkedOnOrAfter()" always return true.
+
+* Shared/Cocoa/CompletionHandlerCallChecker.mm:
+(WebKit::shouldThrowExceptionForDuplicateCompletionHandlerCall):
+
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration init]):
+
+* UIProcess/Cocoa/VersionChecks.h:
+(WebKit::linkedOnOrAfter): Deleted.
+* UIProcess/Cocoa/VersionChecks.mm:
+(WebKit::linkedOnOrAfter):
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::isNetworkCacheEnabled):
+
 2017-02-10  Brian Burg  
 
 [Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator


Modified: trunk/Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm (212133 => 212134)

--- trunk/Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm	2017-02-10 20:35:59 UTC (rev 212133)
+++ trunk/Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm	2017-02-10 20:38:35 UTC (rev 212134)
@@ -67,7 +67,7 @@
 static bool shouldThrowException;
 static std::once_flag once;
 std::call_once(once, [] {
-shouldThrowException = linkedOnOrAfter();
+shouldThrowException = linkedOnOrAfter(SDKVersion::FirstWithExceptionsForDuplicateCompletionHandlerCalls);
 });
 return shouldThrowException;
 }


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (212133 => 212134)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-02-10 20:35:59 UTC (rev 212133)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-02-10 20:38:35 UTC (rev 212134)
@@ -145,7 +145,7 @@
 _inlineMediaPlaybackRequiresPlaysInlineAttribute = !_allowsInlineMediaPlayback;
 _allowsInlineMediaPlaybackAfterFullscreen = !_allowsInlineMediaPlayback;
 _mediaDataLoadsAutomatically = NO;
-if (WebKit::linkedOnOrAfter())
+if (WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstWithMediaTypesRequiringUserActionForPlayback))
 _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAudio;
 else
 _mediaTypesRequiringUserActionForPlayback = 

[webkit-changes] [212136] trunk/LayoutTests

[cdumez]

Title: [212136] trunk/LayoutTests








Revision 212136
Author cdu...@apple.com
Date 2017-02-10 12:45:00 -0800 (Fri, 10 Feb 2017)


Log Message
fast/forms/formsubmission-appendFormData-crash.html times out on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=168133

Reviewed by Brent Fulgham.

Call testRunner.notifyDone() synchronously instead of doing it in a
setTimeout(). The test no longer times out on WK1 and still reproduces
the original bug.

* fast/forms/formsubmission-appendFormData-crash.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (212135 => 212136)

--- trunk/LayoutTests/ChangeLog	2017-02-10 20:39:54 UTC (rev 212135)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 20:45:00 UTC (rev 212136)
@@ -1,3 +1,16 @@
+2017-02-10  Chris Dumez  
+
+fast/forms/formsubmission-appendFormData-crash.html times out on WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=168133
+
+Reviewed by Brent Fulgham.
+
+Call testRunner.notifyDone() synchronously instead of doing it in a
+setTimeout(). The test no longer times out on WK1 and still reproduces
+the original bug.
+
+* fast/forms/formsubmission-appendFormData-crash.html:
+
 2017-02-10  Filip Pizlo  
 
 LayoutTest workers/sab/postMessage-clones.html is a flaky failure


Modified: trunk/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html (212135 => 212136)

--- trunk/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	2017-02-10 20:39:54 UTC (rev 212135)
+++ trunk/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	2017-02-10 20:45:00 UTC (rev 212136)
@@ -12,10 +12,8 @@
 input.autofocus = true;
 output.appendChild(input);
 form.submit();
-setTimeout(function() {
 if (window.testRunner)
 testRunner.notifyDone();
-}, 0);
 }
 
 function focushandler() {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212132] trunk/LayoutTests

[fpizlo]

Title: [212132] trunk/LayoutTests








Revision 212132
Author fpi...@apple.com
Date 2017-02-10 12:34:15 -0800 (Fri, 10 Feb 2017)


Log Message
LayoutTest workers/sab/postMessage-clones.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168129

Unreviewed, make this test more deterministic.

* workers/sab/postMessage-clones.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/workers/sab/postMessage-clones.html




Diff

Modified: trunk/LayoutTests/ChangeLog (212131 => 212132)

--- trunk/LayoutTests/ChangeLog	2017-02-10 20:26:30 UTC (rev 212131)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 20:34:15 UTC (rev 212132)
@@ -1,3 +1,12 @@
+2017-02-10  Filip Pizlo  
+
+LayoutTest workers/sab/postMessage-clones.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=168129
+
+Unreviewed, make this test more deterministic.
+
+* workers/sab/postMessage-clones.html:
+
 2017-02-10  Dave Hyatt  
 
 [CSS Parser] Make intercap property values serialize correctly


Modified: trunk/LayoutTests/workers/sab/postMessage-clones.html (212131 => 212132)

--- trunk/LayoutTests/workers/sab/postMessage-clones.html	2017-02-10 20:26:30 UTC (rev 212131)
+++ trunk/LayoutTests/workers/sab/postMessage-clones.html	2017-02-10 20:34:15 UTC (rev 212132)
@@ -26,7 +26,11 @@
 testRunner.notifyDone();
 });
 
-postMessage(memory, "*");
+window.setTimeout(
+function() {
+window.postMessage(memory, "*");
+},
+0);
 
 

[webkit-changes] [212135] trunk/Tools

[jiewen_tan]

Title: [212135] trunk/Tools








Revision 212135
Author jiewen_...@apple.com
Date 2017-02-10 12:39:54 -0800 (Fri, 10 Feb 2017)


Log Message
[WebCrypto] Add WebCryptoAPI to watchlist
https://bugs.webkit.org/show_bug.cgi?id=168138

Reviewed by Youenn Fablet.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (212134 => 212135)

--- trunk/Tools/ChangeLog	2017-02-10 20:38:35 UTC (rev 212134)
+++ trunk/Tools/ChangeLog	2017-02-10 20:39:54 UTC (rev 212135)
@@ -1,3 +1,12 @@
+2017-02-10  Jiewen Tan  
+
+[WebCrypto] Add WebCryptoAPI to watchlist
+https://bugs.webkit.org/show_bug.cgi?id=168138
+
+Reviewed by Youenn Fablet.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2017-02-10  Brady Eidson  
 
 Replace all WebKit Library Version checks in WK2 with SDK version checks.


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (212134 => 212135)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2017-02-10 20:38:35 UTC (rev 212134)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2017-02-10 20:39:54 UTC (rev 212135)
@@ -342,6 +342,14 @@
 "NetworkCache": {
 "filename": r"Source/WebKit2/NetworkProcess/cache/",
 },
+"WebCryptoAPI": {
+"filename": r"Source/WebCore/crypto/"
+r"|Source/WebCore/bindings/js/.*Crypto.*"
+r"|Source/WebCore/page/.*Crypto.*"
+r"|Source/WebCore/PAL/pal/crypto/"
+r"|LayoutTests/crypto/"
+r"|LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/",
+},
 },
 "CC_RULES": {
 # Note: All email addresses listed must be registered with bugzilla.
@@ -411,6 +419,7 @@
 "XSS": [ "dba...@webkit.org" ],
 "webkitperl": [ "dba...@webkit.org" ],
 "webkitpy": [ "gl...@skynav.com" ],
+"WebCryptoAPI": [ "jiewen_...@apple.com" ],
 },
 "MESSAGE_RULES": {
 "GtkWebKit2PublicAPI": [ "Thanks for the patch. If this patch contains new public API "






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212131] trunk

[hyatt]

Title: [212131] trunk








Revision 212131
Author hy...@apple.com
Date 2017-02-10 12:26:30 -0800 (Fri, 10 Feb 2017)


Log Message
[CSS Parser] Make intercap property values serialize correctly
https://bugs.webkit.org/show_bug.cgi?id=168073

Reviewed by Zalan Bujtas.

Source/WebCore:

Fix CSS value keywords to preserve case when the value contains capital
letters. Examples include optimizeSpeed, translateX, scaleY, etc.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
* css/MediaQueryEvaluator.cpp:
(WebCore::colorGamutEvaluate):
* css/SVGCSSValueKeywords.in:
* css/TransformFunctions.cpp:
(WebCore::transformOperationType):
(WebCore::transformsForValue):
* css/makevalues.pl:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::parseTransformTranslateArguments):
(WebCore::parseSimpleTransformValue):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTransformValue):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseColorFunctionParameters):

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/image-rendering-parsing-expected.txt:
* fast/css/parsing-text-rendering-expected.txt:
* fast/css/resources/parsing-text-rendering.js:
* fast/css/script-tests/image-rendering-parsing.js:
* svg/css/getComputedStyle-basic-expected.txt:
* svg/css/script-tests/shape-rendering-parsing.js:
* svg/css/shape-rendering-parsing-expected.txt:
* transforms/2d/transform-value-types-expected.txt:
* transforms/2d/transform-value-types.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/fast/css/image-rendering-parsing-expected.txt
trunk/LayoutTests/fast/css/parsing-text-rendering-expected.txt
trunk/LayoutTests/fast/css/resources/parsing-text-rendering.js
trunk/LayoutTests/fast/css/script-tests/image-rendering-parsing.js
trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/svg/css/script-tests/shape-rendering-parsing.js
trunk/LayoutTests/svg/css/shape-rendering-parsing-expected.txt
trunk/LayoutTests/transforms/2d/transform-value-types-expected.txt
trunk/LayoutTests/transforms/2d/transform-value-types.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/MediaQueryEvaluator.cpp
trunk/Source/WebCore/css/SVGCSSValueKeywords.in
trunk/Source/WebCore/css/TransformFunctions.cpp
trunk/Source/WebCore/css/makevalues.pl
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (212130 => 212131)

--- trunk/LayoutTests/ChangeLog	2017-02-10 19:52:57 UTC (rev 212130)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 20:26:30 UTC (rev 212131)
@@ -1,3 +1,22 @@
+2017-02-10  Dave Hyatt  
+
+[CSS Parser] Make intercap property values serialize correctly
+https://bugs.webkit.org/show_bug.cgi?id=168073
+
+Reviewed by Zalan Bujtas.
+
+* fast/css/getComputedStyle/computed-style-expected.txt:
+* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* fast/css/image-rendering-parsing-expected.txt:
+* fast/css/parsing-text-rendering-expected.txt:
+* fast/css/resources/parsing-text-rendering.js:
+* fast/css/script-tests/image-rendering-parsing.js:
+* svg/css/getComputedStyle-basic-expected.txt:
+* svg/css/script-tests/shape-rendering-parsing.js:
+* svg/css/shape-rendering-parsing-expected.txt:
+* transforms/2d/transform-value-types-expected.txt:
+* transforms/2d/transform-value-types.html:
+
 2017-02-08  Jiewen Tan  
 
 [WebCrypto] Import imported/w3c/web-platform-tests/WebCryptoAPI tests


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (212130 => 212131)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2017-02-10 19:52:57 UTC (rev 212130)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2017-02-10 20:26:30 UTC (rev 212131)
@@ -249,8 +249,8 @@
 lighting-color: rgb(255, 255, 255);
 stop-color: rgb(0, 0, 0);
 stop-opacity: 1;
-color-interpolation: srgb;
-color-interpolation-filters: linearrgb;
+color-interpolation: sRGB;

[webkit-changes] [212126] trunk/Source/ThirdParty/libwebrtc

[commit-queue]

Title: [212126] trunk/Source/ThirdParty/libwebrtc








Revision 212126
Author commit-qu...@webkit.org
Date 2017-02-10 11:03:56 -0800 (Fri, 10 Feb 2017)


Log Message
[WebRTC] Activate libwebrtc G711/G722 audio codecs
https://bugs.webkit.org/show_bug.cgi?id=168123

Patch by Youenn Fablet  on 2017-02-10
Reviewed by Alex Christensen.

Adding G711/G722 missing codec files.
Activating use of these in the build system.

* Configurations/libwebrtc.xcconfig:
* Source/webrtc/modules/audio_coding/codecs/g711/g711.c: Added.
(ulaw_to_alaw):
* Source/webrtc/modules/audio_coding/codecs/g711/g711.h: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/g722_decode.c: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/g722_enc_dec.h: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/g722_encode.c: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.c: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.h: Added.
* Source/webrtc/modules/audio_coding/codecs/g722/test/testG722.cc: Added.
* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj


Added Paths

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g711/g711.c
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g711/g711.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/g722_decode.c
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/g722_enc_dec.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/g722_encode.c
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.c
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/test/
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/g722/test/testG722.cc




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212125 => 212126)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 18:56:07 UTC (rev 212125)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 19:03:56 UTC (rev 212126)
@@ -1,3 +1,29 @@
+2017-02-10  Youenn Fablet  
+
+[WebRTC] Activate libwebrtc G711/G722 audio codecs
+https://bugs.webkit.org/show_bug.cgi?id=168123
+
+Reviewed by Alex Christensen.
+
+Adding G711/G722 missing codec files.
+Activating use of these in the build system.
+
+* Configurations/libwebrtc.xcconfig:
+* Source/webrtc/modules/audio_coding/codecs/g711/g711.c: Added.
+(ulaw_to_alaw):
+* Source/webrtc/modules/audio_coding/codecs/g711/g711.h: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/g722_decode.c: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/g722_enc_dec.h: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/g722_encode.c: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.c: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.h: Added.
+* Source/webrtc/modules/audio_coding/codecs/g722/test/testG722.cc: Added.
+* libwebrtc.xcodeproj/project.pbxproj:
+
 2017-02-10  Alex Christensen  
 
 Fix ASAN build.


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (212125 => 212126)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig	2017-02-10 18:56:07 UTC (rev 212125)
+++ 

[webkit-changes] [212127] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [212127] trunk/Source/ThirdParty/libwebrtc








Revision 212127
Author achristen...@apple.com
Date 2017-02-10 11:16:59 -0800 (Fri, 10 Feb 2017)


Log Message
Remove unnecessary automatic reference counting in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=168134

Reviewed by Youenn Fablet.

* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212126 => 212127)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 19:03:56 UTC (rev 212126)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 19:16:59 UTC (rev 212127)
@@ -1,3 +1,12 @@
+2017-02-10  Alex Christensen  
+
+Remove unnecessary automatic reference counting in libwebrtc
+https://bugs.webkit.org/show_bug.cgi?id=168134
+
+Reviewed by Youenn Fablet.
+
+* libwebrtc.xcodeproj/project.pbxproj:
+
 2017-02-10  Youenn Fablet  
 
 [WebRTC] Activate libwebrtc G711/G722 audio codecs


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (212126 => 212127)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 19:03:56 UTC (rev 212126)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 19:16:59 UTC (rev 212127)
@@ -608,79 +608,6 @@
 		5C4B4BBA1E431C90002651C8 /* h264_video_toolbox_encoder.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B601E431C8F002651C8 /* h264_video_toolbox_encoder.mm */; };
 		5C4B4BBC1E431C90002651C8 /* h264_video_toolbox_nalu.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B621E431C8F002651C8 /* h264_video_toolbox_nalu.cc */; };
 		5C4B4BBD1E431C90002651C8 /* h264_video_toolbox_nalu.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B631E431C8F002651C8 /* h264_video_toolbox_nalu.h */; };
-		5C4B4BBE1E431C90002651C8 /* NSString+StdString.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B641E431C8F002651C8 /* NSString+StdString.h */; };
-		5C4B4BBF1E431C90002651C8 /* NSString+StdString.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B651E431C8F002651C8 /* NSString+StdString.mm */; };
-		5C4B4BC01E431C90002651C8 /* RTCAudioSource.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B661E431C8F002651C8 /* RTCAudioSource.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BC11E431C90002651C8 /* RTCAudioSource+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B671E431C8F002651C8 /* RTCAudioSource+Private.h */; };
-		5C4B4BC21E431C90002651C8 /* RTCAudioTrack.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B681E431C8F002651C8 /* RTCAudioTrack.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BC31E431C90002651C8 /* RTCAudioTrack+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B691E431C8F002651C8 /* RTCAudioTrack+Private.h */; };
-		5C4B4BC41E431C90002651C8 /* RTCAVFoundationVideoSource.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B6A1E431C8F002651C8 /* RTCAVFoundationVideoSource.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BC51E431C90002651C8 /* RTCAVFoundationVideoSource+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B6B1E431C8F002651C8 /* RTCAVFoundationVideoSource+Private.h */; };
-		5C4B4BC71E431C90002651C8 /* RTCConfiguration.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B6D1E431C8F002651C8 /* RTCConfiguration.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BC81E431C90002651C8 /* RTCConfiguration+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B6E1E431C8F002651C8 /* RTCConfiguration+Private.h */; };
-		5C4B4BCA1E431C90002651C8 /* RTCDataChannel+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B701E431C8F002651C8 /* RTCDataChannel+Private.h */; };
-		5C4B4BCB1E431C90002651C8 /* RTCDataChannelConfiguration.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B711E431C8F002651C8 /* RTCDataChannelConfiguration.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BCC1E431C90002651C8 /* RTCDataChannelConfiguration+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B721E431C8F002651C8 /* RTCDataChannelConfiguration+Private.h */; };
-		5C4B4BCD1E431C90002651C8 /* RTCDispatcher.m in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B731E431C8F002651C8 /* RTCDispatcher.m */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BCE1E431C90002651C8 /* RTCDispatcher+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B4B741E431C8F002651C8 /* RTCDispatcher+Private.h */; };
-		5C4B4BD01E431C90002651C8 /* RTCFieldTrials.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B4B761E431C8F002651C8 /* RTCFieldTrials.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
-		5C4B4BD11E431C90002651C8 /* RTCFileLogger.mm in Sources */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [212128] trunk/Source/WebKit/mac

[aakash_jain]

Title: [212128] trunk/Source/WebKit/mac








Revision 212128
Author aakash_j...@apple.com
Date 2017-02-10 11:26:36 -0800 (Fri, 10 Feb 2017)


Log Message
WebResourceLoadDelegatePrivate.h cannot be imported standalone
https://bugs.webkit.org/show_bug.cgi?id=168096

Reviewed by Alexey Proskuryakov.

* WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212127 => 212128)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-10 19:16:59 UTC (rev 212127)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-10 19:26:36 UTC (rev 212128)
@@ -1,3 +1,12 @@
+2017-02-10  Aakash Jain  
+
+WebResourceLoadDelegatePrivate.h cannot be imported standalone
+https://bugs.webkit.org/show_bug.cgi?id=168096
+
+Reviewed by Alexey Proskuryakov.
+
+* WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
+
 2017-02-09  Antti Koivisto  
 
 Remove most cases of #if ENABLE(CACHE_PARTITIONING)


Modified: trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h (212127 => 212128)

--- trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h	2017-02-10 19:16:59 UTC (rev 212127)
+++ trunk/Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h	2017-02-10 19:26:36 UTC (rev 212128)
@@ -26,7 +26,7 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#import 
+#import 
 
 @class WebView;
 @class WebDataSource;
@@ -58,7 +58,7 @@
 #if TARGET_OS_IPHONE
 - (id)webThreadWebView:(WebView *)sender identifierForInitialRequest:(NSURLRequest *)request fromDataSource:(WebDataSource *)dataSource;
 - (NSURLRequest *)webThreadWebView:(WebView *)sender resource:(id)identifier willSendRequest:(NSURLRequest *)request redirectResponse:(NSURLResponse *)redirectResponse fromDataSource:(WebDataSource *)dataSource;
-- (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveContentLength:(WebNSInteger)length fromDataSource:(WebDataSource *)dataSource;
+- (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveContentLength:(NSInteger)length fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)sender resource:(id)identifier didReceiveResponse:(NSURLResponse *)response fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)webView didLoadResourceFromMemoryCache:(NSURLRequest *)request response:(NSURLResponse *)response length:(NSInteger)length fromDataSource:(WebDataSource *)dataSource;
 - (void)webThreadWebView:(WebView *)sender resource:(id)identifier didFinishLoadingFromDataSource:(WebDataSource *)dataSource;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212130] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [212130] trunk/Source/ThirdParty/libwebrtc








Revision 212130
Author achristen...@apple.com
Date 2017-02-10 11:52:57 -0800 (Fri, 10 Feb 2017)


Log Message
Fix iOS libwebrtc build after r212127
https://bugs.webkit.org/show_bug.cgi?id=168134

* libwebrtc.xcodeproj/project.pbxproj:
I got a little carried away removing -fobjc-arc.  These files need it.
It was originally added in r211902 and these files are in the 
EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] list in libwebrtc.xcconfig
so adding this flag won't break the 32-bit El Capitan build.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212129 => 212130)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 19:49:55 UTC (rev 212129)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 19:52:57 UTC (rev 212130)
@@ -1,5 +1,16 @@
 2017-02-10  Alex Christensen  
 
+Fix iOS libwebrtc build after r212127
+https://bugs.webkit.org/show_bug.cgi?id=168134
+
+* libwebrtc.xcodeproj/project.pbxproj:
+I got a little carried away removing -fobjc-arc.  These files need it.
+It was originally added in r211902 and these files are in the 
+EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] list in libwebrtc.xcconfig
+so adding this flag won't break the 32-bit El Capitan build.
+
+2017-02-10  Alex Christensen  
+
 Remove unnecessary automatic reference counting in libwebrtc
 https://bugs.webkit.org/show_bug.cgi?id=168134
 


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (212129 => 212130)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 19:49:55 UTC (rev 212129)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 19:52:57 UTC (rev 212130)
@@ -2403,19 +2403,19 @@
 		5CDD90831E43D15C00621E92 /* nonlinear_beamformer.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD90731E43D15C00621E92 /* nonlinear_beamformer.h */; };
 		5CFD53601E4BA34B00482908 /* helpers_ios.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD535F1E4BA34B00482908 /* helpers_ios.mm */; };
 		5CFD536C1E4BA4DC00482908 /* RTCAudioSession.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53631E4BA4DC00482908 /* RTCAudioSession.h */; };
-		5CFD536D1E4BA4DC00482908 /* RTCAudioSession.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53641E4BA4DC00482908 /* RTCAudioSession.mm */; };
-		5CFD536E1E4BA4DC00482908 /* RTCAudioSession+Configuration.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53651E4BA4DC00482908 /* RTCAudioSession+Configuration.mm */; };
+		5CFD536D1E4BA4DC00482908 /* RTCAudioSession.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53641E4BA4DC00482908 /* RTCAudioSession.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
+		5CFD536E1E4BA4DC00482908 /* RTCAudioSession+Configuration.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53651E4BA4DC00482908 /* RTCAudioSession+Configuration.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
 		5CFD536F1E4BA4DC00482908 /* RTCAudioSession+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53661E4BA4DC00482908 /* RTCAudioSession+Private.h */; };
 		5CFD53701E4BA4DC00482908 /* RTCAudioSessionConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53671E4BA4DC00482908 /* RTCAudioSessionConfiguration.h */; };
-		5CFD53711E4BA4DC00482908 /* RTCAudioSessionConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53681E4BA4DC00482908 /* RTCAudioSessionConfiguration.m */; };
+		5CFD53711E4BA4DC00482908 /* RTCAudioSessionConfiguration.m in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53681E4BA4DC00482908 /* RTCAudioSessionConfiguration.m */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
 		5CFD53721E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53691E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.h */; };
-		5CFD53731E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD536A1E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.mm */; };
+		5CFD53731E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD536A1E4BA4DC00482908 /* RTCAudioSessionDelegateAdapter.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
 		5CFD537C1E4BA4F500482908 /* audio_device_ios.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53751E4BA4F500482908 /* audio_device_ios.h */; };
-		5CFD537D1E4BA4F500482908 /* audio_device_ios.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53761E4BA4F500482908 /* audio_device_ios.mm */; };
+		5CFD537D1E4BA4F500482908 /* audio_device_ios.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53761E4BA4F500482908 /* audio_device_ios.mm */; settings = 

[webkit-changes] [212133] branches/safari-603-branch

[matthew_hanson]

Title: [212133] branches/safari-603-branch








Revision 212133
Author matthew_han...@apple.com
Date 2017-02-10 12:35:59 -0800 (Fri, 10 Feb 2017)


Log Message
Merge r212131. rdar://problem/30271744

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
branches/safari-603-branch/LayoutTests/fast/css/image-rendering-parsing-expected.txt
branches/safari-603-branch/LayoutTests/fast/css/parsing-text-rendering-expected.txt
branches/safari-603-branch/LayoutTests/fast/css/resources/parsing-text-rendering.js
branches/safari-603-branch/LayoutTests/fast/css/script-tests/image-rendering-parsing.js
branches/safari-603-branch/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
branches/safari-603-branch/LayoutTests/svg/css/script-tests/shape-rendering-parsing.js
branches/safari-603-branch/LayoutTests/svg/css/shape-rendering-parsing-expected.txt
branches/safari-603-branch/LayoutTests/transforms/2d/transform-value-types-expected.txt
branches/safari-603-branch/LayoutTests/transforms/2d/transform-value-types.html
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/css/CSSPrimitiveValueMappings.h
branches/safari-603-branch/Source/WebCore/css/MediaQueryEvaluator.cpp
branches/safari-603-branch/Source/WebCore/css/SVGCSSValueKeywords.in
branches/safari-603-branch/Source/WebCore/css/TransformFunctions.cpp
branches/safari-603-branch/Source/WebCore/css/makevalues.pl
branches/safari-603-branch/Source/WebCore/css/parser/CSSParserFastPaths.cpp
branches/safari-603-branch/Source/WebCore/css/parser/CSSPropertyParser.cpp
branches/safari-603-branch/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (212132 => 212133)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 20:34:15 UTC (rev 212132)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 20:35:59 UTC (rev 212133)
@@ -1,5 +1,28 @@
 2017-02-10  Matthew Hanson  
 
+Merge r212131. rdar://problem/30271744
+
+2017-02-10  Dave Hyatt  
+
+[CSS Parser] Make intercap property values serialize correctly
+https://bugs.webkit.org/show_bug.cgi?id=168073
+
+Reviewed by Zalan Bujtas.
+
+* fast/css/getComputedStyle/computed-style-expected.txt:
+* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* fast/css/image-rendering-parsing-expected.txt:
+* fast/css/parsing-text-rendering-expected.txt:
+* fast/css/resources/parsing-text-rendering.js:
+* fast/css/script-tests/image-rendering-parsing.js:
+* svg/css/getComputedStyle-basic-expected.txt:
+* svg/css/script-tests/shape-rendering-parsing.js:
+* svg/css/shape-rendering-parsing-expected.txt:
+* transforms/2d/transform-value-types-expected.txt:
+* transforms/2d/transform-value-types.html:
+
+2017-02-10  Matthew Hanson  
+
 Merge r211910. rdar://problem/30358835
 
 2017-02-08  Chris Dumez  


Modified: branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (212132 => 212133)

--- branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2017-02-10 20:34:15 UTC (rev 212132)
+++ branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2017-02-10 20:35:59 UTC (rev 212133)
@@ -226,8 +226,8 @@
 lighting-color: rgb(255, 255, 255);
 stop-color: rgb(0, 0, 0);
 stop-opacity: 1;
-color-interpolation: srgb;
-color-interpolation-filters: linearrgb;
+color-interpolation: sRGB;
+color-interpolation-filters: linearRGB;
 color-rendering: auto;
 fill: rgb(0, 0, 0);
 fill-opacity: 1;


Modified: branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (212132 => 212133)

--- branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2017-02-10 20:34:15 UTC (rev 212132)
+++ branches/safari-603-branch/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2017-02-10 20:35:59 UTC (rev 212133)
@@ -225,8 +225,8 @@
 lighting-color: rgb(255, 255, 255)
 stop-color: rgb(0, 0, 0)
 stop-opacity: 1
-color-interpolation: srgb
-color-interpolation-filters: linearrgb
+color-interpolation: sRGB
+color-interpolation-filters: linearRGB
 color-rendering: auto
 fill: rgb(0, 0, 0)
 fill-opacity: 1


Modified: branches/safari-603-branch/LayoutTests/fast/css/image-rendering-parsing-expected.txt (212132 => 212133)

--- branches/safari-603-branch/LayoutTests/fast/css/image-rendering-parsing-expected.txt	

[webkit-changes] [212125] branches/safari-603-branch

[matthew_hanson]

Title: [212125] branches/safari-603-branch








Revision 212125
Author matthew_han...@apple.com
Date 2017-02-10 10:56:07 -0800 (Fri, 10 Feb 2017)


Log Message
Merge r211910. rdar://problem/30358835

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/page/FrameView.cpp
branches/safari-603-branch/Source/WebCore/page/FrameView.h
branches/safari-603-branch/Source/WebCore/page/Page.cpp
branches/safari-603-branch/Source/WebCore/page/Page.h
branches/safari-603-branch/Source/WebCore/platform/graphics/TiledBacking.h
branches/safari-603-branch/Source/WebCore/platform/graphics/ca/TileController.cpp
branches/safari-603-branch/Source/WebCore/platform/graphics/ca/TileController.h
branches/safari-603-branch/Source/WebCore/testing/Internals.cpp
branches/safari-603-branch/Source/WebCore/testing/Internals.h
branches/safari-603-branch/Source/WebCore/testing/Internals.idl
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm


Added Paths

branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size-expected.txt
branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size.html
branches/safari-603-branch/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/non-active-window-tiles-size-expected.txt
branches/safari-603-branch/LayoutTests/platform/mac-wk1/compositing/tiling/non-active-window-tiles-size-expected.txt




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (212124 => 212125)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 18:21:16 UTC (rev 212124)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 18:56:07 UTC (rev 212125)
@@ -1,5 +1,24 @@
 2017-02-10  Matthew Hanson  
 
+Merge r211910. rdar://problem/30358835
+
+2017-02-08  Chris Dumez  
+
+Use smaller tiles in windows that are not active to facilitate App Napping
+https://bugs.webkit.org/show_bug.cgi?id=167997
+
+
+Reviewed by Simon Fraser.
+
+Add layout test coverage.
+
+* compositing/tiling/non-active-window-tiles-size-expected.txt: Added.
+* compositing/tiling/non-active-window-tiles-size.html: Added.
+* platform/ios-simulator-wk2/compositing/tiling/non-active-window-tiles-size-expected.txt: Added.
+* platform/mac-wk1/compositing/tiling/non-active-window-tiles-size-expected.txt: Added.
+
+2017-02-10  Matthew Hanson  
+
 Rollout r212118. rdar://problem/30096323
 
 2017-02-10  Matthew Hanson  


Added: branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size-expected.txt (0 => 212125)

--- branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size-expected.txt	2017-02-10 18:56:07 UTC (rev 212125)
@@ -0,0 +1,49 @@
+Tiles when window is active:
+
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (tile cache coverage 0, 0 800 x 600)
+  (tile size 800 x 600)
+  (top left tile 0, 0 tiles grid 1 x 1)
+  (in window 1)
+)
+  )
+)
+Tiles when window is not active:
+
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (tile cache coverage 0, 0 800 x 600)
+  (tile size 512 x 512)
+  (top left tile 0, 0 tiles grid 2 x 2)
+  (in window 1)
+)
+  )
+)
+


Added: branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size.html (0 => 212125)

--- branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/compositing/tiling/non-active-window-tiles-size.html	2017-02-10 18:56:07 UTC (rev 212125)
@@ -0,0 +1,31 @@
+
+
+
+Tiles when window is active:
+
+Tiles when window is not active:
+
+
+if (window.testRunner) 

[webkit-changes] [212129] trunk/PerformanceTests

[fpizlo]

Title: [212129] trunk/PerformanceTests








Revision 212129
Author fpi...@apple.com
Date 2017-02-10 11:49:55 -0800 (Fri, 10 Feb 2017)


Log Message
Beef up the ARES-6 explainer text
https://bugs.webkit.org/show_bug.cgi?id=167867

Reviewed by Saam Barati.

Added appropriate links.

Added text that explains the subscores.

* ARES-6/index.html:

Modified Paths

trunk/PerformanceTests/ARES-6/index.html
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/ARES-6/index.html (212128 => 212129)

--- trunk/PerformanceTests/ARES-6/index.html	2017-02-10 19:26:36 UTC (rev 212128)
+++ trunk/PerformanceTests/ARES-6/index.html	2017-02-10 19:49:55 UTC (rev 212129)
@@ -104,9 +104,13 @@
 
 ARES-6 measures the execution time of _javascript_s newest features, including symbols, for-of, arrow functions, Map/Set/WeakMap, let/const, classes, proxies, string interpolation, destructuring, default arguments, spread, tail calls, and generators.
 
-Air is an ES2015 port of the s . This code is a heavy user of Map, Set, classes, spread, and for-of. The benchmark runs allocateStack on hot function bodies from other popular _javascript_ benchmarks: executeIteration from Octane/Gameboy, gaussianBlur from Kraken, and scanIdentifier from Octane/Typescript. Because metacircularity, the benchmark also runs allocateStack on the largest hot function in Air.
+Air is an ES2015 port of the s . This code is a heavy user of Map, Set, classes, spread, and for-of. The benchmark runs allocateStack on hot function bodies from other popular _javascript_ benchmarks: executeIteration from gaussianBlur from scanIdentifier from Octane/Typescript. Because metacircularity, the benchmark also runs allocateStack on the largest hot function in Air. Browse the source.
 
-Basic is an . BASIC was an interactive language from the start, so our implementation uses generator functions for the entire interpreter. When the BASIC program says INPUT, our interpreter says yield. This allows users of the interpreter to easily integrate it into a runloop. Basic also uses classes, Map, and WeakMap. The benchmark runs a handful of simple programs, the most complex of which finds prime numbers.
+Basic is an  of the . BASIC was an interactive language from the start, so our implementation uses generator functions for the entire interpreter. When the BASIC program says INPUT, our interpreter says yield. This allows users of the interpreter to easily integrate it into a runloop. Basic also uses classes, Map, and WeakMap. The benchmark runs a handful of simple programs, the most complex of which finds prime numbers. 
+
+ARES-6 rewards browsers that start up quickly and run smoothly. It's not enough to just measure the total running time of a workload. Browsers may perform differently for the same workload depending on how many times it has run. Garbage collection runs periodically, making some iterations take longer than others. Code that runs repeatedly gets optimized by the browser, so the first iteration of any workload is more expensive than the rest. ARES-6 runs these benchmarks for 200 iterations and reports the execution time of the first iteration, the average of the worst 2% iterations, and the overall geometric mean. Each of these values is given an equal weight when computing the ovarall time. ARES-6 equally rewards fast start-up, low jank, and sophisticated adaptive optimizations for long-running code.
+
+Each ARES-6 sample has 200 iterations of Air and 200 iterations of Basic. ARES-6 runs 10 samples, and reports the average with 95% confidence intervals. Each sample runs in a fresh iframe to simulate some of the effects of page navigation.
 
 We like making _javascript_ run faster, but we didnt have any ES2015 code to optimize. ARES-6 is a collection of sample ES2015 code written by the WebKit _javascript_ team, which we used to bootstrap our ES2015 optimization efforts.
 
@@ -122,4 +126,4 @@
 

[webkit-changes] [212116] trunk/Source

[bburg]

Title: [212116] trunk/Source








Revision 212116
Author bb...@apple.com
Date 2017-02-10 09:29:36 -0800 (Fri, 10 Feb 2017)


Log Message
[Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator
https://bugs.webkit.org/show_bug.cgi?id=168019


Reviewed by Joseph Pecoraro.

Source/_javascript_Core:

It's useful to have an symbolic value (not a string) for each of the supported platform values.
Generate this once per protocol for the Objective-C bindings. Covered by existing tests.

* inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator.generate_output):
(ObjCHeaderGenerator._generate_enum_for_platforms):
Create an NS_ENUM for Platform values in Platforms.

* inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:
(ObjCProtocolTypeConversionsHeaderGenerator.generate_output):
(ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_conversion_for_platforms):
Add type conversion/parsing methods for the newly added enum.

* inspector/scripts/codegen/generator.py:
(Generator.stylized_name_for_enum_value):
(Generator.stylized_name_for_enum_value.replaceCallback):
Support arbitrary special-cased substrings in enums, not just all-caps. Add 'IOS' and 'MacOS'.

* inspector/scripts/codegen/models.py:
(Platforms):
Use lower-case string values for platform names, to avoid guesswork.

(Platforms.__metaclass__):
(Platforms.__metaclass__.__iter__):
Make it possible to iterate over Platform instances of Platforms.

* inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
* inspector/scripts/tests/generic/expected/domain-availability.json-result:
* inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/generic/expected/enum-values.json-result:
* inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
* inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
* inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
* inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
* inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
* inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
* inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
* inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
* inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Rebaseline results.

Source/WebKit2:

* UIProcess/Automation/Automation.json: Fix the platform values to be lowercase.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py
trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domain-availability.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result

[webkit-changes] [212121] branches/safari-603-branch/Source/WebCore

[bfulgham]

Title: [212121] branches/safari-603-branch/Source/WebCore








Revision 212121
Author bfulg...@apple.com
Date 2017-02-10 09:46:37 -0800 (Fri, 10 Feb 2017)


Log Message
Unreviewed build fix.

* dom/Document.cpp:
(WebCore::Document::adoptNode): isConnected -> inDocument.

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/dom/Document.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212120 => 212121)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:45:21 UTC (rev 212120)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:46:37 UTC (rev 212121)
@@ -1,3 +1,10 @@
+2017-02-10  Brent Fulgham  
+
+Unreviewed build fix.
+
+* dom/Document.cpp:
+(WebCore::Document::adoptNode): isConnected -> inDocument.
+
 2017-02-10  Matthew Hanson  
 
 Rollout r212118. rdar://problem/30096323


Modified: branches/safari-603-branch/Source/WebCore/dom/Document.cpp (212120 => 212121)

--- branches/safari-603-branch/Source/WebCore/dom/Document.cpp	2017-02-10 17:45:21 UTC (rev 212120)
+++ branches/safari-603-branch/Source/WebCore/dom/Document.cpp	2017-02-10 17:46:37 UTC (rev 212121)
@@ -1042,7 +1042,7 @@
 auto result = source.remove();
 if (result.hasException())
 return result.releaseException();
-ASSERT_WITH_SECURITY_IMPLICATION(!source.isConnected());
+ASSERT_WITH_SECURITY_IMPLICATION(!source.inDocument());
 ASSERT_WITH_SECURITY_IMPLICATION(!source.parentNode());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212122] branches/safari-603-branch/Source/WebCore

[bfulgham]

Title: [212122] branches/safari-603-branch/Source/WebCore








Revision 212122
Author bfulg...@apple.com
Date 2017-02-10 09:54:50 -0800 (Fri, 10 Feb 2017)


Log Message
Merge r212026. rdar://problem/30096323

2017-02-09  Chris Dumez  

Crash under FormSubmission::create()
https://bugs.webkit.org/show_bug.cgi?id=167200


Reviewed by Darin Adler.

The issue is that FormSubmission::create() was iterating over
form.associatedElements() as was calling Element::appendFormData()
in the loop. HTMLObjectElement::appendFormData() was calling
pluginWidget(PluginLoadingPolicy::Load) which causes a synchronous
layout and can fire events (such as focus event) synchronously.
Firing those events synchronously allows the JS to modify the
form.associatedElements() vector we are currently iterating on.

To avoid this issue, we now call pluginWidget(PluginLoadingPolicy::DoNotLoad)
in HTMLObjectElement::appendFormData() as we are not allowed to fire
synchronous events at this point. I also added a security assertion
in FormSubmission::create() to catch cases where we fire JS events
while iterating over the form associated elements to more easily
notice these things in the future.

Test: fast/forms/formsubmission-appendFormData-crash.html

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::appendFormData):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp
branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212121 => 212122)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:46:37 UTC (rev 212121)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:54:50 UTC (rev 212122)
@@ -1,5 +1,39 @@
 2017-02-10  Brent Fulgham  
 
+Merge r212026. rdar://problem/30096323
+
+2017-02-09  Chris Dumez  
+
+Crash under FormSubmission::create()
+https://bugs.webkit.org/show_bug.cgi?id=167200
+
+
+Reviewed by Darin Adler.
+
+The issue is that FormSubmission::create() was iterating over
+form.associatedElements() as was calling Element::appendFormData()
+in the loop. HTMLObjectElement::appendFormData() was calling
+pluginWidget(PluginLoadingPolicy::Load) which causes a synchronous
+layout and can fire events (such as focus event) synchronously.
+Firing those events synchronously allows the JS to modify the
+form.associatedElements() vector we are currently iterating on.
+
+To avoid this issue, we now call pluginWidget(PluginLoadingPolicy::DoNotLoad)
+in HTMLObjectElement::appendFormData() as we are not allowed to fire
+synchronous events at this point. I also added a security assertion
+in FormSubmission::create() to catch cases where we fire JS events
+while iterating over the form associated elements to more easily
+notice these things in the future.
+
+Test: fast/forms/formsubmission-appendFormData-crash.html
+
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::appendFormData):
+* loader/FormSubmission.cpp:
+(WebCore::FormSubmission::create):
+
+2017-02-10  Brent Fulgham  
+
 Unreviewed build fix.
 
 * dom/Document.cpp:


Modified: branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp (212121 => 212122)

--- branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp	2017-02-10 17:46:37 UTC (rev 212121)
+++ branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp	2017-02-10 17:54:50 UTC (rev 212122)
@@ -509,7 +509,9 @@
 if (name().isEmpty())
 return false;
 
-Widget* widget = pluginWidget();
+// Use PluginLoadingPolicy::DoNotLoad here or it would fire JS events synchronously
+// which would not be safe here.
+auto* widget = pluginWidget(PluginLoadingPolicy::DoNotLoad);
 if (!is(widget))
 return false;
 String value;


Modified: branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp (212121 => 212122)

--- branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp	2017-02-10 17:46:37 UTC (rev 212121)
+++ branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp	2017-02-10 17:54:50 UTC (rev 212122)
@@ -47,6 +47,7 @@
 #include "HTMLInputElement.h"
 #include "HTMLNames.h"
 #include "HTMLParserIdioms.h"
+#include "NoEventDispatchAssertion.h"
 #include "TextEncoding.h"
 #include 
 
@@ -204,18 +205,23 @@
 Vector> formValues;
 
 bool containsPasswordData = false;
-  

[webkit-changes] [212123] trunk/LayoutTests

[ryanhaddad]

Title: [212123] trunk/LayoutTests








Revision 212123
Author ryanhad...@apple.com
Date 2017-02-10 10:01:38 -0800 (Fri, 10 Feb 2017)


Log Message
Mark compositing/masks/solid-color-masked.html as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=168054

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (212122 => 212123)

--- trunk/LayoutTests/ChangeLog	2017-02-10 17:54:50 UTC (rev 212122)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 18:01:38 UTC (rev 212123)
@@ -1,5 +1,14 @@
 2017-02-10  Ryan Haddad  
 
+Mark compositing/masks/solid-color-masked.html as failing on ios-simulator.
+https://bugs.webkit.org/show_bug.cgi?id=168054
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
+2017-02-10  Ryan Haddad  
+
 Add platform specific expected.txt  file for fast/text/mark-matches-overflow-clip.html after r212113.
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (212122 => 212123)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-10 17:54:50 UTC (rev 212122)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-10 18:01:38 UTC (rev 212123)
@@ -2865,3 +2865,5 @@
 webkit.org/b/167619 css3/filters/backdrop/dynamic-with-clip-path.html [ ImageOnlyFailure ]
 
 webkit.org/b/167967 http/tests/security/credentials-iframes.html [ Failure ]
+
+webkit.org/b/168054 compositing/masks/solid-color-masked.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212115] trunk/Source/WebKit2

[bburg]

Title: [212115] trunk/Source/WebKit2








Revision 212115
Author bb...@apple.com
Date 2017-02-10 09:25:36 -0800 (Fri, 10 Feb 2017)


Log Message
Web Automation: fail gracefully when a screenshot cannot be encoded as base64
https://bugs.webkit.org/show_bug.cgi?id=168095


Reviewed by Joseph Pecoraro.

Convert platformGetBase64EncodedPNGData to return a std::optional.
Return nullopt if we can't create a screenshot or convert it to base64.

* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::didTakeScreenshot):
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h
trunk/Source/WebKit2/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212114 => 212115)

--- trunk/Source/WebKit2/ChangeLog	2017-02-10 16:50:57 UTC (rev 212114)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-10 17:25:36 UTC (rev 212115)
@@ -1,3 +1,21 @@
+2017-02-10  Brian Burg  
+
+Web Automation: fail gracefully when a screenshot cannot be encoded as base64
+https://bugs.webkit.org/show_bug.cgi?id=168095
+
+
+Reviewed by Joseph Pecoraro.
+
+Convert platformGetBase64EncodedPNGData to return a std::optional.
+Return nullopt if we can't create a screenshot or convert it to base64.
+
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::didTakeScreenshot):
+(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
+* UIProcess/Automation/WebAutomationSession.h:
+* UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
+(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
+
 2017-02-09  Carlos Garcia Campos  
 
 Unreviewed. Fix GTK+ build with threaded compositor disabled.


Modified: trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp (212114 => 212115)

--- trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp	2017-02-10 16:50:57 UTC (rev 212114)
+++ trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp	2017-02-10 17:25:36 UTC (rev 212115)
@@ -916,13 +916,13 @@
 return;
 }
 
-String base64EncodedData = platformGetBase64EncodedPNGData(imageDataHandle);
-if (base64EncodedData.isEmpty()) {
+std::optional base64EncodedData = platformGetBase64EncodedPNGData(imageDataHandle);
+if (!base64EncodedData) {
 callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError));
 return;
 }
 
-callback->sendSuccess(base64EncodedData);
+callback->sendSuccess(base64EncodedData.value());
 }
 
 // Platform-dependent Implementation Stubs.
@@ -942,7 +942,7 @@
 #endif // !PLATFORM(MAC)
 
 #if !PLATFORM(COCOA)
-String WebAutomationSession::platformGetBase64EncodedPNGData(const ShareableBitmap::Handle&)
+std::optional WebAutomationSession::platformGetBase64EncodedPNGData(const ShareableBitmap::Handle&)
 {
 return String();
 }


Modified: trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h (212114 => 212115)

--- trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h	2017-02-10 16:50:57 UTC (rev 212114)
+++ trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h	2017-02-10 17:25:36 UTC (rev 212115)
@@ -167,7 +167,7 @@
 // Simulates key presses to produce the codepoints in a string. One or more code points are delivered atomically at grapheme cluster boundaries.
 void platformSimulateKeySequence(WebPageProxy&, const String&);
 // Get base64 encoded PNG data from a bitmap.
-String platformGetBase64EncodedPNGData(const ShareableBitmap::Handle&);
+std::optional platformGetBase64EncodedPNGData(const ShareableBitmap::Handle&);
 
 #if PLATFORM(MAC)
 void sendSynthesizedEventsToPage(WebPageProxy&, NSArray *eventsToSend);


Modified: trunk/Source/WebKit2/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm (212114 => 212115)

--- trunk/Source/WebKit2/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm	2017-02-10 16:50:57 UTC (rev 212114)
+++ trunk/Source/WebKit2/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm	2017-02-10 17:25:36 UTC (rev 212115)
@@ -37,19 +37,22 @@
 
 namespace WebKit {
 
-String WebAutomationSession::platformGetBase64EncodedPNGData(const ShareableBitmap::Handle& imageDataHandle)
+std::optional WebAutomationSession::platformGetBase64EncodedPNGData(const ShareableBitmap::Handle& imageDataHandle)
 {
 RefPtr bitmap = ShareableBitmap::create(imageDataHandle, SharedMemory::Protection::ReadOnly);
+if (!bitmap)
+return std::nullopt;
+
 RetainPtr cgImage = 

[webkit-changes] [212118] branches/safari-603-branch

[matthew_hanson]

Title: [212118] branches/safari-603-branch








Revision 212118
Author matthew_han...@apple.com
Date 2017-02-10 09:33:28 -0800 (Fri, 10 Feb 2017)


Log Message
Merge r212026. rdar://problem/30096323

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp
branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp


Added Paths

branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt
branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (212117 => 212118)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:31:37 UTC (rev 212117)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:33:28 UTC (rev 212118)
@@ -1,5 +1,22 @@
 2017-02-10  Matthew Hanson  
 
+Merge r212026. rdar://problem/30096323
+
+2017-02-09  Chris Dumez  
+
+Crash under FormSubmission::create()
+https://bugs.webkit.org/show_bug.cgi?id=167200
+
+
+Reviewed by Darin Adler.
+
+Add layout test coverage.
+
+* fast/forms/formsubmission-appendFormData-crash-expected.txt: Added.
+* fast/forms/formsubmission-appendFormData-crash.html: Added.
+
+2017-02-10  Matthew Hanson  
+
 Merge r211495. rdar://problem/30106362
 
 2017-02-01  Jer Noble  


Added: branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt (0 => 212118)

--- branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt	2017-02-10 17:33:28 UTC (rev 212118)
@@ -0,0 +1,3 @@
+This test passes if it does not crash.
+
+ a  


Added: branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html (0 => 212118)

--- branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	2017-02-10 17:33:28 UTC (rev 212118)
@@ -0,0 +1,35 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function runTest() {
+object.name = "foo";
+input.autofocus = true;
+output.appendChild(input);
+form.submit();
+setTimeout(function() {
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0);
+}
+
+function focushandler() {
+for(var i = 0; i < 100; i++) {
+var e = document.createElement("input");
+form.appendChild(e);
+}
+}
+
+
+This test passes if it does not crash.
+
+
+a
+
+
+


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212117 => 212118)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:31:37 UTC (rev 212117)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:33:28 UTC (rev 212118)
@@ -1,5 +1,39 @@
 2017-02-10  Matthew Hanson  
 
+Merge r212026. rdar://problem/30096323
+
+2017-02-09  Chris Dumez  
+
+Crash under FormSubmission::create()
+https://bugs.webkit.org/show_bug.cgi?id=167200
+
+
+Reviewed by Darin Adler.
+
+The issue is that FormSubmission::create() was iterating over
+form.associatedElements() as was calling Element::appendFormData()
+in the loop. HTMLObjectElement::appendFormData() was calling
+pluginWidget(PluginLoadingPolicy::Load) which causes a synchronous
+layout and can fire events (such as focus event) synchronously.
+Firing those events synchronously allows the JS to modify the
+form.associatedElements() vector we are currently iterating on.
+
+To avoid this issue, we now call pluginWidget(PluginLoadingPolicy::DoNotLoad)
+in HTMLObjectElement::appendFormData() as we are not allowed to fire
+synchronous events at this point. I also added a security assertion
+in FormSubmission::create() to catch cases where we fire JS events
+while iterating over the form associated elements to more easily
+notice these things in the future.
+
+Test: fast/forms/formsubmission-appendFormData-crash.html
+
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::appendFormData):
+* loader/FormSubmission.cpp:
+(WebCore::FormSubmission::create):
+
+2017-02-10  Matthew Hanson  
+
  

[webkit-changes] [212114] trunk/Tools

[achristensen]

Title: [212114] trunk/Tools








Revision 212114
Author achristen...@apple.com
Date 2017-02-10 08:50:57 -0800 (Fri, 10 Feb 2017)


Log Message
Fix El Capitan build.

* Scripts/build-webkit:
Don't build libwebrtc anywhere for now.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (212113 => 212114)

--- trunk/Tools/ChangeLog	2017-02-10 14:32:59 UTC (rev 212113)
+++ trunk/Tools/ChangeLog	2017-02-10 16:50:57 UTC (rev 212114)
@@ -1,3 +1,10 @@
+2017-02-10  Alex Christensen  
+
+Fix El Capitan build.
+
+* Scripts/build-webkit:
+Don't build libwebrtc anywhere for now.
+
 2017-02-10  Andy Estes  
 
 Move two MiniBrowserBundle settings out of the .pbxproj


Modified: trunk/Tools/Scripts/build-webkit (212113 => 212114)

--- trunk/Tools/Scripts/build-webkit	2017-02-10 14:32:59 UTC (rev 212113)
+++ trunk/Tools/Scripts/build-webkit	2017-02-10 16:50:57 UTC (rev 212114)
@@ -62,7 +62,6 @@
 my $coverageSupport = 0;
 my $shouldRunStaticAnalyzer = 0;
 my $startTime = time();
-my $archsi386 = 0;
 
 my @features = getFeatureOptionList();
 
@@ -73,8 +72,6 @@
 foreach (@ARGV) {
 if ($_ eq '--minimal') {
 $minimal = 1;
-} elsif ($_ =~ /ARCHS.*i386/) {
-$archsi386 = 1;
 }
 }
 
@@ -184,7 +181,6 @@
 
 # ANGLE and libwebrtc must come before WebCore
 splice @projects, 0, 0, ("Source/ThirdParty/ANGLE");
-if (not architecture() eq "i386" and not $archsi386) { splice @projects, 0, 0, ("Source/ThirdParty/libwebrtc"); }
 
 push @projects, ("Source/WebKit2");
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212120] branches/safari-603-branch

[matthew_hanson]

Title: [212120] branches/safari-603-branch








Revision 212120
Author matthew_han...@apple.com
Date 2017-02-10 09:45:21 -0800 (Fri, 10 Feb 2017)


Log Message
Roll out r212026 via r212118. rdar://problem/30096323

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp
branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp


Removed Paths

branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt
branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (212119 => 212120)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:45:21 UTC (rev 212120)
@@ -1,5 +1,9 @@
 2017-02-10  Matthew Hanson  
 
+Rollout r212118. rdar://problem/30096323
+
+2017-02-10  Matthew Hanson  
+
 Merge r212026. rdar://problem/30096323
 
 2017-02-09  Chris Dumez  


Deleted: branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt (212119 => 212120)

--- branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash-expected.txt	2017-02-10 17:45:21 UTC (rev 212120)
@@ -1,3 +0,0 @@
-This test passes if it does not crash.
-
- a  


Deleted: branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html (212119 => 212120)

--- branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/LayoutTests/fast/forms/formsubmission-appendFormData-crash.html	2017-02-10 17:45:21 UTC (rev 212120)
@@ -1,35 +0,0 @@
-
-
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function runTest() {
-object.name = "foo";
-input.autofocus = true;
-output.appendChild(input);
-form.submit();
-setTimeout(function() {
-if (window.testRunner)
-testRunner.notifyDone();
-}, 0);
-}
-
-function focushandler() {
-for(var i = 0; i < 100; i++) {
-var e = document.createElement("input");
-form.appendChild(e);
-}
-}
-
-
-This test passes if it does not crash.
-
-
-a
-
-
-


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212119 => 212120)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:45:21 UTC (rev 212120)
@@ -1,5 +1,9 @@
 2017-02-10  Matthew Hanson  
 
+Rollout r212118. rdar://problem/30096323
+
+2017-02-10  Matthew Hanson  
+
 Merge r212026. rdar://problem/30096323
 
 2017-02-09  Chris Dumez  


Modified: branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp (212119 => 212120)

--- branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/Source/WebCore/html/HTMLObjectElement.cpp	2017-02-10 17:45:21 UTC (rev 212120)
@@ -509,9 +509,7 @@
 if (name().isEmpty())
 return false;
 
-// Use PluginLoadingPolicy::DoNotLoad here or it would fire JS events synchronously
-// which would not be safe here.
-auto* widget = pluginWidget(PluginLoadingPolicy::DoNotLoad);
+Widget* widget = pluginWidget();
 if (!is(widget))
 return false;
 String value;


Modified: branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp (212119 => 212120)

--- branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp	2017-02-10 17:44:36 UTC (rev 212119)
+++ branches/safari-603-branch/Source/WebCore/loader/FormSubmission.cpp	2017-02-10 17:45:21 UTC (rev 212120)
@@ -1,4 +1,4 @@
-*
+/*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2015-2016 Apple Inc. All rights reserved.
  *
@@ -47,7 +47,6 @@
 #include "HTMLInputElement.h"
 #include "HTMLNames.h"
 #include "HTMLParserIdioms.h"
-#include "NoEventDispatchAssertion.h"
 #include "TextEncoding.h"
 #include 
 
@@ -205,23 +204,18 @@
 Vector> formValues;
 
 bool containsPasswordData = false;
-{
-NoEventDispatchAssertion noEventDispatchAssertion;
-
-for (auto& control : form->associatedElements()) {
-auto& element = control->asHTMLElement();
-if (!element.isDisabledFormControl())
-control->appendFormData(*domFormData, isMultiPartForm);
-

[webkit-changes] [212117] branches/safari-603-branch

[matthew_hanson]

Title: [212117] branches/safari-603-branch








Revision 212117
Author matthew_han...@apple.com
Date 2017-02-10 09:31:37 -0800 (Fri, 10 Feb 2017)


Log Message
Merge r211495. rdar://problem/30106362

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/track/InbandDataTextTrack.cpp


Added Paths

branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt
branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (212116 => 212117)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:29:36 UTC (rev 212116)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-10 17:31:37 UTC (rev 212117)
@@ -1,5 +1,19 @@
 2017-02-10  Matthew Hanson  
 
+Merge r211495. rdar://problem/30106362
+
+2017-02-01  Jer Noble  
+
+NULL-deref crash in TextTrack::removeCue()
+https://bugs.webkit.org/show_bug.cgi?id=167615
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/track-in-band-hls-metadata-crash-expected.txt: Added.
+* http/tests/media/track-in-band-hls-metadata-crash.html: Added.
+
+2017-02-10  Matthew Hanson  
+
 Merge r211650. rdar://problem/30268004
 
 2017-02-03  Jeremy Jones  


Added: branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt (0 => 212117)

--- branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	2017-02-10 17:31:37 UTC (rev 212117)
@@ -0,0 +1,18 @@
+
+Test that seeking HLS streams containing metadata tracks does not crash.
+
+
+** Set video.src, wait for media data to load
+RUN(video.src = '')
+
+EVENT(addtrack)
+RUN(track = video.textTracks[0])
+RUN(track.mode = 'hidden')
+RUN(video.play())
+EVENT(cuechange)
+
+** Seek, should not crash.
+RUN(video.currentTime = 5)
+EVENT(seeked)
+END OF TEST
+


Added: branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html (0 => 212117)

--- branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	2017-02-10 17:31:37 UTC (rev 212117)
@@ -0,0 +1,43 @@
+
+
+
+
+
+
+var track;
+
+function addtrack(event)
+{
+tracks = event.target;
+run("track = video.textTracks[0]");
+run("track.mode = 'hidden'");
+run("video.play()");
+waitForEvent('cuechange', cuechange, false, true, track);
+}
+
+function cuechange()
+{
+consoleWrite("
** Seek, should not crash.");
+run("video.currentTime = 5"); 
+waitForEventAndEnd("seeked");
+}
+
+function start()
+{
+consoleWrite("
** Set video.src, wait for media data to load");
+findMediaElement();
+run("video.src = ''");
+
+consoleWrite("");
+waitForEvent('addtrack', addtrack, false, true, video.textTracks);
+}
+
+
+
+
+Test that seeking HLS streams containing metadata tracks does not crash.
+
+


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212116 => 212117)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:29:36 UTC (rev 212116)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-10 17:31:37 UTC (rev 212117)
@@ -1,5 +1,31 @@
 2017-02-10  Matthew Hanson  
 
+Merge r211495. rdar://problem/30106362
+
+2017-02-01  Jer Noble  
+
+NULL-deref crash in TextTrack::removeCue()
+https://bugs.webkit.org/show_bug.cgi?id=167615
+
+Reviewed by Eric Carlson.
+
+Test: http/tests/media/track-in-band-hls-metadata-crash.html
+
+Follow-up to r211401. When passing around a reference to an object, the assumption is that
+the caller is retaining the underlying object. This breaks down for
+InbandDataTextTrack::removeDataCue(), which releases its own ownership of the cue object,
+then passes the reference to that object to its superclass to do further remove steps. The
+retain count of the cue can thus drop to zero within the scope of
+

[webkit-changes] [212119] trunk/LayoutTests

[ryanhaddad]

Title: [212119] trunk/LayoutTests








Revision 212119
Author ryanhad...@apple.com
Date 2017-02-10 09:44:36 -0800 (Fri, 10 Feb 2017)


Log Message
Add platform specific expected.txt  file for fast/text/mark-matches-overflow-clip.html after r212113.

Unreviewed test gardening.

* fast/text/mark-matches-overflow-clip-expected.txt:
* platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt: Copied from LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt


Added Paths

trunk/LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (212118 => 212119)

--- trunk/LayoutTests/ChangeLog	2017-02-10 17:33:28 UTC (rev 212118)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 17:44:36 UTC (rev 212119)
@@ -1,3 +1,12 @@
+2017-02-10  Ryan Haddad  
+
+Add platform specific expected.txt  file for fast/text/mark-matches-overflow-clip.html after r212113.
+
+Unreviewed test gardening.
+
+* fast/text/mark-matches-overflow-clip-expected.txt:
+* platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt: Copied from LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt.
+
 2017-02-10  Carlos Garcia Campos  
 
 Unreviewed GTK+ gardening. Rebaseline several fast/text/ tests.


Modified: trunk/LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt (212118 => 212119)

--- trunk/LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt	2017-02-10 17:33:28 UTC (rev 212118)
+++ trunk/LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt	2017-02-10 17:44:36 UTC (rev 212119)
@@ -1 +1 @@
-marker rects: (58, 92, 12.6719, 17)
+marker rects: (58, 94, 13.7656, 18)


Copied: trunk/LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt (from rev 212116, trunk/LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt) (0 => 212119)

--- trunk/LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt	2017-02-10 17:44:36 UTC (rev 212119)
@@ -0,0 +1 @@
+marker rects: (58, 92, 12.6719, 17)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212138] trunk/LayoutTests

[jiewen_tan]

Title: [212138] trunk/LayoutTests








Revision 212138
Author jiewen_...@apple.com
Date 2017-02-10 12:59:40 -0800 (Fri, 10 Feb 2017)


Log Message
[WebCrypto] Remove imported/w3c/WebCryptoAPI tests
https://bugs.webkit.org/show_bug.cgi?id=168064

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* WebCryptoAPI/OWNERS: Removed.
* WebCryptoAPI/README.md: Removed.
* WebCryptoAPI/WebCryptoAPI.idl: Removed.
* WebCryptoAPI/digest/digest.js: Removed.
* WebCryptoAPI/digest/digest.worker.js: Removed.
* WebCryptoAPI/digest/test_digest-expected.txt: Removed.
* WebCryptoAPI/digest/test_digest.html: Removed.
* WebCryptoAPI/digest/w3c-import.log: Removed.
* WebCryptoAPI/encrypt_decrypt/aes.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_cbc_vectors.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_ctr_vectors.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.js: Removed.
* WebCryptoAPI/encrypt_decrypt/aes_gcm_vectors.js: Removed.
* WebCryptoAPI/encrypt_decrypt/rsa.js: Removed.
* WebCryptoAPI/encrypt_decrypt/rsa.worker.js: Removed.
* WebCryptoAPI/encrypt_decrypt/rsa_vectors.js: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_cbc-expected.txt: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_cbc.html: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_ctr-expected.txt: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_ctr.html: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt: Removed.
* WebCryptoAPI/encrypt_decrypt/test_aes_gcm.html: Removed.
* WebCryptoAPI/encrypt_decrypt/test_rsa_oaep-expected.txt: Removed.
* WebCryptoAPI/encrypt_decrypt/test_rsa_oaep.html: Removed.
* WebCryptoAPI/encrypt_decrypt/w3c-import.log: Removed.
* WebCryptoAPI/generateKey/failures.js: Removed.
* WebCryptoAPI/generateKey/failures.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_AES-CBC.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_AES-CTR.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_AES-GCM.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_AES-KW.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_ECDH.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_ECDSA.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_HMAC.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_RSA-PSS.worker.js: Removed.
* WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.js: Removed.
* WebCryptoAPI/generateKey/successes.js: Removed.
* WebCryptoAPI/generateKey/successes.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_AES-CBC.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_AES-CTR.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_AES-GCM.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_AES-KW.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_ECDH.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_ECDSA.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_HMAC.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_RSA-PSS.worker.js: Removed.
* WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.js: Removed.
* WebCryptoAPI/generateKey/test_aes-cbc-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_aes-cbc.html: Removed.
* WebCryptoAPI/generateKey/test_aes-ctr-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_aes-ctr.html: Removed.
* WebCryptoAPI/generateKey/test_failures-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures.html: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-CBC-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-CBC.html: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-CTR-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-CTR.html: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-GCM.html: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-KW-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_AES-KW.html: Removed.
* WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_ECDH.html: Removed.
* WebCryptoAPI/generateKey/test_failures_ECDSA-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_ECDSA.html: Removed.
* WebCryptoAPI/generateKey/test_failures_HMAC-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_HMAC.html: Removed.
* WebCryptoAPI/generateKey/test_failures_RSA-OAEP-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html: Removed.
* WebCryptoAPI/generateKey/test_failures_RSA-PSS-expected.txt: Removed.
* WebCryptoAPI/generateKey/test_failures_RSA-PSS.html: Removed.
* WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5-expected.txt: Removed.
* 

[webkit-changes] [212140] trunk/Source/WebCore

[rniwa]

Title: [212140] trunk/Source/WebCore








Revision 212140
Author rn...@webkit.org
Date 2017-02-10 13:15:51 -0800 (Fri, 10 Feb 2017)


Log Message
HTMLConstructionSiteTask::Insert should never be called on a node with a parent
https://bugs.webkit.org/show_bug.cgi?id=168099

Reviewed by Sam Weinig.

insertAlreadyParsedChild always use HTMLConstructionSiteTask::InsertAlreadyParsedChild instead
of using HTMLConstructionSiteTask::Insert when fostering a child.

Also combine the step to take all children and re-parenting into a single task instead of
separately issuing TakeAllChildren and Reparent tasks.

No new tests since this is a refactoring.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::insert): Now asserts that the child node never have a parent.
(WebCore::executeInsertAlreadyParsedChildTask): Moved the code to remove the parent here.
(WebCore::executeTakeAllChildrenAndReparentTask): Renamed from executeTakeAllChildrenTask
now that this function also does the reparenting.
(WebCore::executeTask):
(WebCore::HTMLConstructionSite::reparent): Removed the variant only used with takeAllChildren.
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild): Always use InsertAlreadyParsedChild
instead of calling fosterParent which uses Insert when fostering parents.
(WebCore::HTMLConstructionSite::takeAllChildrenAndReparent): Renamed from takeAllChildren.
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSiteTask:Operation):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
trunk/Source/WebCore/html/parser/HTMLConstructionSite.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212139 => 212140)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 21:08:32 UTC (rev 212139)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 21:15:51 UTC (rev 212140)
@@ -1,3 +1,33 @@
+2017-02-10  Ryosuke Niwa  
+
+HTMLConstructionSiteTask::Insert should never be called on a node with a parent
+https://bugs.webkit.org/show_bug.cgi?id=168099
+
+Reviewed by Sam Weinig.
+
+insertAlreadyParsedChild always use HTMLConstructionSiteTask::InsertAlreadyParsedChild instead
+of using HTMLConstructionSiteTask::Insert when fostering a child.
+
+Also combine the step to take all children and re-parenting into a single task instead of
+separately issuing TakeAllChildren and Reparent tasks.
+
+No new tests since this is a refactoring.
+
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::insert): Now asserts that the child node never have a parent.
+(WebCore::executeInsertAlreadyParsedChildTask): Moved the code to remove the parent here.
+(WebCore::executeTakeAllChildrenAndReparentTask): Renamed from executeTakeAllChildrenTask
+now that this function also does the reparenting.
+(WebCore::executeTask):
+(WebCore::HTMLConstructionSite::reparent): Removed the variant only used with takeAllChildren.
+(WebCore::HTMLConstructionSite::insertAlreadyParsedChild): Always use InsertAlreadyParsedChild
+instead of calling fosterParent which uses Insert when fostering parents.
+(WebCore::HTMLConstructionSite::takeAllChildrenAndReparent): Renamed from takeAllChildren.
+* html/parser/HTMLConstructionSite.h:
+(WebCore::HTMLConstructionSiteTask:Operation):
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
+
 2017-02-10  Dave Hyatt  
 
 [CSS Parser] Make intercap property values serialize correctly


Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (212139 => 212140)

--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2017-02-10 21:08:32 UTC (rev 212139)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2017-02-10 21:15:51 UTC (rev 212140)
@@ -105,9 +105,7 @@
 if (is(*task.parent))
 task.parent = (*task.parent).content();
 
-if (ContainerNode* parent = task.child->parentNode())
-parent->parserRemoveChild(*task.child);
-
+ASSERT(!task.child->parentNode());
 if (task.nextChild)
 task.parent->parserInsertBefore(*task.child, *task.nextChild);
 else
@@ -140,16 +138,19 @@
 {
 ASSERT(task.operation == HTMLConstructionSiteTask::InsertAlreadyParsedChild);
 
+if (ContainerNode* parent = task.child->parentNode())
+parent->parserRemoveChild(*task.child);
 insert(task);
 }
 
-static inline void executeTakeAllChildrenTask(HTMLConstructionSiteTask& task)
+static inline void executeTakeAllChildrenAndReparentTask(HTMLConstructionSiteTask& task)
 {
-ASSERT(task.operation == HTMLConstructionSiteTask::TakeAllChildren);
+ASSERT(task.operation == HTMLConstructionSiteTask::TakeAllChildrenAndReparent);
 
-

[webkit-changes] [212141] trunk/LayoutTests

[ryanhaddad]

Title: [212141] trunk/LayoutTests








Revision 212141
Author ryanhad...@apple.com
Date 2017-02-10 13:15:57 -0800 (Fri, 10 Feb 2017)


Log Message
Skip some very slow WebCryptoAPI tests.

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (212140 => 212141)

--- trunk/LayoutTests/ChangeLog	2017-02-10 21:15:51 UTC (rev 212140)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 21:15:57 UTC (rev 212141)
@@ -1,3 +1,11 @@
+2017-02-10  Ryan Haddad  
+
+Skip some very slow WebCryptoAPI tests.
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2017-02-10  Jiewen Tan  
 
 [WebCrypto] Remove imported/w3c/WebCryptoAPI tests


Modified: trunk/LayoutTests/TestExpectations (212140 => 212141)

--- trunk/LayoutTests/TestExpectations	2017-02-10 21:15:51 UTC (rev 212140)
+++ trunk/LayoutTests/TestExpectations	2017-02-10 21:15:57 UTC (rev 212141)
@@ -923,8 +923,11 @@
 workers/bomb-with-v8.html [ Skip ]
 
 # WebCryptoAPI tests that take too long to complete, need to scale down. webkit.org/b/159638
-imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.html [ Slow ]
+imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html [ Skip ]
+imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html [ Skip ]
+imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.html [ Skip ]
 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Slow ]
+imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-OAEP.html [ Skip ]
 imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html [ Slow ]
 imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html [ Slow ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212145] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [212145] trunk/Source/ThirdParty/libwebrtc








Revision 212145
Author achristen...@apple.com
Date 2017-02-10 13:31:28 -0800 (Fri, 10 Feb 2017)


Log Message
Fix iOS libwebrtc build after r212127
https://bugs.webkit.org/show_bug.cgi?id=168134

* Configurations/libwebrtc.xcconfig:
* libwebrtc.xcodeproj/project.pbxproj:
I got a little carried away removing ObjC sources.
We still need RTCLogging.mm and RTCUIApplication.mm on iOS.
Also sorted the project file.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212144 => 212145)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 21:29:32 UTC (rev 212144)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-10 21:31:28 UTC (rev 212145)
@@ -3,7 +3,18 @@
 Fix iOS libwebrtc build after r212127
 https://bugs.webkit.org/show_bug.cgi?id=168134
 
+* Configurations/libwebrtc.xcconfig:
 * libwebrtc.xcodeproj/project.pbxproj:
+I got a little carried away removing ObjC sources.
+We still need RTCLogging.mm and RTCUIApplication.mm on iOS.
+Also sorted the project file.
+
+2017-02-10  Alex Christensen  
+
+Fix iOS libwebrtc build after r212127
+https://bugs.webkit.org/show_bug.cgi?id=168134
+
+* libwebrtc.xcodeproj/project.pbxproj:
 I got a little carried away removing -fobjc-arc.  These files need it.
 It was originally added in r211902 and these files are in the 
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] list in libwebrtc.xcconfig


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (212144 => 212145)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig	2017-02-10 21:29:32 UTC (rev 212144)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig	2017-02-10 21:31:28 UTC (rev 212145)
@@ -21,4 +21,4 @@
 
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphoneos*] = *_sse.cc *_sse2.cc macutils.cc macwindowpicker.cc audio_device_mac.cc audio_mixer_manager_mac.cc;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphonesimulator*] = macutils.cc macwindowpicker.cc audio_device_mac.cc audio_mixer_manager_mac.cc;
-EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = audio_device_ios.mm voice_processing_audio_unit.mm audio_device_not_implemented_ios.mm RTCAudioSessionConfiguration.m RTCAudioSessionDelegateAdapter.mm RTCAudioSession.mm RTCAudioSession+Configuration.mm;
+EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = audio_device_ios.mm voice_processing_audio_unit.mm audio_device_not_implemented_ios.mm RTCAudioSessionConfiguration.m RTCAudioSessionDelegateAdapter.mm RTCAudioSession.mm RTCAudioSession+Configuration.mm RTCUIApplication.mm RTCLogging.mm;


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (212144 => 212145)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 21:29:32 UTC (rev 212144)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-10 21:31:28 UTC (rev 212145)
@@ -2463,6 +2463,9 @@
 		5CFD54881E4C55D300482908 /* RTCVideoTrack.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD54611E4C55D200482908 /* RTCVideoTrack.h */; };
 		5CFD54891E4C55D300482908 /* UIDevice+RTCDevice.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD54621E4C55D200482908 /* UIDevice+RTCDevice.h */; };
 		5CFD548A1E4C55D300482908 /* WebRTC.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD54631E4C55D200482908 /* WebRTC.h */; };
+		5CFD548E1E4E587300482908 /* RTCUIApplication.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD548C1E4E587300482908 /* RTCUIApplication.h */; };
+		5CFD548F1E4E587300482908 /* RTCUIApplication.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD548D1E4E587300482908 /* RTCUIApplication.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
+		5CFD54911E4E650700482908 /* RTCLogging.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD54901E4E650700482908 /* RTCLogging.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -5148,6 +5151,9 @@
 		5CFD54611E4C55D200482908 /* RTCVideoTrack.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RTCVideoTrack.h; sourceTree = ""; };
 		5CFD54621E4C55D200482908 /* UIDevice+RTCDevice.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIDevice+RTCDevice.h"; sourceTree = ""; };
 		5CFD54631E4C55D200482908 /* WebRTC.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebRTC.h; sourceTree = ""; };
+		5CFD548C1E4E587300482908 /* RTCUIApplication.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RTCUIApplication.h; 

[webkit-changes] [212148] trunk

[jbedard]

Title: [212148] trunk








Revision 212148
Author jbed...@apple.com
Date 2017-02-10 13:58:23 -0800 (Fri, 10 Feb 2017)


Log Message
Removing LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=165927

Reviewed by Daniel Bates.
Part 2

LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
simulators through simctl (iOS 10 and later), use this functionality instead.

Source/WebCore:

* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isDumpRenderTree): Update comment to reflect removal of LayoutTestRelay.

Tools:

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
Added a FIXME that we will need to implement similar archiving machinery once we build
ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
* BuildSlaveSupport/kill-old-processes:
(main): Remove LayoutTestRelay from list of processes.
* LayoutTestRelay: Removed LayoutTestRelay.
* Makefile:
* Scripts/build-layouttestrelay: Removed.
* Scripts/build-webkit: Removed LayoutTestRelay references.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm
trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/BuildSlaveSupport/kill-old-processes
trunk/Tools/ChangeLog
trunk/Tools/Makefile
trunk/Tools/Scripts/build-webkit


Removed Paths

trunk/Tools/LayoutTestRelay/
trunk/Tools/Scripts/build-layouttestrelay




Diff

Modified: trunk/Source/WebCore/ChangeLog (212147 => 212148)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 21:51:44 UTC (rev 212147)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 21:58:23 UTC (rev 212148)
@@ -1,3 +1,17 @@
+2017-02-10  Jonathan Bedard  
+
+Removing LayoutTestRelay
+https://bugs.webkit.org/show_bug.cgi?id=165927
+
+Reviewed by Daniel Bates.
+Part 2
+
+LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
+simulators through simctl (iOS 10 and later), use this functionality instead.
+
+* platform/RuntimeApplicationChecks.mm:
+(WebCore::IOSApplication::isDumpRenderTree): Update comment to reflect removal of LayoutTestRelay.
+
 2017-02-10  Youenn Fablet  
 
 [WebRTC] Implement Outgoing libwebrtc audio source support


Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm (212147 => 212148)

--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm	2017-02-10 21:51:44 UTC (rev 212147)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm	2017-02-10 21:58:23 UTC (rev 212148)
@@ -178,8 +178,8 @@
 
 bool IOSApplication::isDumpRenderTree()
 {
-// We use a prefix match instead of strict equality since LayoutTestRelay may launch multiple instances of
-// DumpRenderTree where the bundle identifier of each instance has a unique suffix.
+// We use a prefix match instead of strict equality since multiple instances of DumpRenderTree
+// may be launched, where the bundle identifier of each instance has a unique suffix.
 static bool isDumpRenderTree = applicationBundleIsEqualTo("org.webkit.DumpRenderTree"); // e.g. org.webkit.DumpRenderTree0
 return isDumpRenderTree;
 }


Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (212147 => 212148)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-02-10 21:51:44 UTC (rev 212147)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-02-10 21:58:23 UTC (rev 212148)
@@ -165,29 +165,9 @@
 def archiveBuiltProduct(configuration, platform, fullPlatform):
 assert platform in ('mac', 'win', 'gtk', 'efl', 'ios')
 
-if fullPlatform.startswith('ios-simulator'):
-# We need to include in the archive the Mac tool, LayoutTestRelay, to run layout tests in the iOS simulator.
-combinedDirectory = os.path.join(_topLevelBuildDirectory, 'combined-mac-and-ios')
-removeDirectoryIfExists(combinedDirectory)
-os.makedirs(combinedDirectory)
-
-if subprocess.call(['/bin/cp', '-pR', _configurationBuildDirectory, combinedDirectory]):
-return 1
-
-macBuildDirectory = webkitBuildDirectoryForConfigurationAndPlatform(configuration, 'mac')
-destinationDirectory = os.path.join(combinedDirectory, os.path.relpath(macBuildDirectory, _topLevelBuildDirectory))
-os.makedirs(destinationDirectory)
-for filename in ['LayoutTestRelay', 'LayoutTestRelay.dSYM']:
-sourceFile = os.path.join(macBuildDirectory, filename)
-if not os.path.exists(sourceFile):
-continue
-if subprocess.call(['/bin/cp', '-pR', sourceFile, destinationDirectory]):
-return 1
-
-if createZip(combinedDirectory, configuration):
-return 1
-shutil.rmtree(combinedDirectory)
-elif platform in ('mac', 'ios'):
+# FIXME: ImageDiff should 

[webkit-changes] [212151] trunk

[zalan]

Title: [212151] trunk








Revision 212151
Author za...@apple.com
Date 2017-02-10 14:36:12 -0800 (Fri, 10 Feb 2017)


Log Message
Mail hangs when removing multiple rows from large table.
https://bugs.webkit.org/show_bug.cgi?id=168103


Reviewed by Ryosuke Niwa.

PerformanceTests:

* DOM/large-table-edit.html: Added.

Source/WebCore:

DeleteSelectionCommand::removeNode doesn't actually destroy table structure items,
but instead it removes their content. In order to be able to continue editing the table after
the delete, we need to ensure that its cells' width and height are > 0. Currently we issue layout on
each table item recursively.
This patch delays the layout until after we've finished with the entire subtree delete (10x progression).

Performance test added.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::insertBlockPlaceholderForTableCellIfNeeded):
(WebCore::DeleteSelectionCommand::removeNodeUpdatingStates):
(WebCore::shouldRemoveContentOnly):
(WebCore::DeleteSelectionCommand::removeNode):
* editing/DeleteSelectionCommand.h:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
trunk/Source/WebCore/editing/DeleteSelectionCommand.h


Added Paths

trunk/PerformanceTests/DOM/large-table-edit.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (212150 => 212151)

--- trunk/PerformanceTests/ChangeLog	2017-02-10 22:28:56 UTC (rev 212150)
+++ trunk/PerformanceTests/ChangeLog	2017-02-10 22:36:12 UTC (rev 212151)
@@ -1,3 +1,13 @@
+2017-02-10  Zalan Bujtas  
+
+Mail hangs when removing multiple rows from large table.
+https://bugs.webkit.org/show_bug.cgi?id=168103
+
+
+Reviewed by Ryosuke Niwa.
+
+* DOM/large-table-edit.html: Added.
+
 2017-02-05  Filip Pizlo  
 
 Beef up the ARES-6 explainer text


Added: trunk/PerformanceTests/DOM/large-table-edit.html (0 => 212151)

--- trunk/PerformanceTests/DOM/large-table-edit.html	(rev 0)
+++ trunk/PerformanceTests/DOM/large-table-edit.html	2017-02-10 22:36:12 UTC (rev 212151)
@@ -0,0 +1,46 @@
+
+
+
+
+
+
+
+
+
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
<
 ;div>22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
&
 lt;/td>
44
45
46
47
48
49
50
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
2
 2
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
2
 



[webkit-changes] [212144] trunk/Source/WebCore


2017-02-10

Thread
commit-queue

Title: [212144] trunk/Source/WebCore








Revision 212144
Author commit-qu...@webkit.org
Date 2017-02-10 13:29:32 -0800 (Fri, 10 Feb 2017)


Log Message
[WebRTC] Implement Outgoing libwebrtc audio source support
https://bugs.webkit.org/show_bug.cgi?id=168118

Patch by Youenn Fablet  on 2017-02-10
Reviewed by Eric Carlson.

No new automated tests as we need the audio rendering to work to test the whole loop.

Using an AudioSampleDataSource to convert the captured data to libwebrtc expected format.
Capturing and pushing data happens in the capture thread.
Pulling of converted data happens in libwebrtc thread.

Introducing LibWebRTCAudioFormat.h to centralize libwbebrtc expected audio format.

* WebCore.xcodeproj/project.pbxproj:
* platform/audio/WebAudioBufferList.cpp:
(WebCore::WebAudioBufferList::WebAudioBufferList): Missing initialization leads to assertion failure.
* platform/audio/mac/AudioSampleBufferList.cpp:
(WebCore::AudioSampleBufferList::copyFrom): In case of interleaved channels, there is one buffer but two channels.
* platform/audio/mac/AudioSampleDataSource.cpp:
(WebCore::AudioSampleDataSource::pushSamples):
(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):
* platform/audio/mac/AudioSampleDataSource.h:
* platform/mediastream/libwebrtc/LibWebRTCAudioFormat.h: Added.
* platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::libwebrtcAudioFormat):
(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):
* platform/mediastream/mac/RealtimeOutgoingAudioSource.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/audio/WebAudioBufferList.cpp
trunk/Source/WebCore/platform/audio/mac/AudioSampleBufferList.cpp
trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp
trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.h


Added Paths

trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioFormat.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (212143 => 212144)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 21:24:43 UTC (rev 212143)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 21:29:32 UTC (rev 212144)
@@ -1,3 +1,36 @@
+2017-02-10  Youenn Fablet  
+
+[WebRTC] Implement Outgoing libwebrtc audio source support
+https://bugs.webkit.org/show_bug.cgi?id=168118
+
+Reviewed by Eric Carlson.
+
+No new automated tests as we need the audio rendering to work to test the whole loop.
+
+Using an AudioSampleDataSource to convert the captured data to libwebrtc expected format.
+Capturing and pushing data happens in the capture thread.
+Pulling of converted data happens in libwebrtc thread.
+
+Introducing LibWebRTCAudioFormat.h to centralize libwbebrtc expected audio format.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/audio/WebAudioBufferList.cpp:
+(WebCore::WebAudioBufferList::WebAudioBufferList): Missing initialization leads to assertion failure.
+* platform/audio/mac/AudioSampleBufferList.cpp:
+(WebCore::AudioSampleBufferList::copyFrom): In case of interleaved channels, there is one buffer but two channels.
+* platform/audio/mac/AudioSampleDataSource.cpp:
+(WebCore::AudioSampleDataSource::pushSamples):
+(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):
+* platform/audio/mac/AudioSampleDataSource.h:
+* platform/mediastream/libwebrtc/LibWebRTCAudioFormat.h: Added.
+* platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
+(WebCore::libwebrtcAudioFormat):
+(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
+(WebCore::RealtimeOutgoingAudioSource::sourceMutedChanged):
+(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
+(WebCore::RealtimeOutgoingAudioSource::pullAudioData):
+* platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
+
 2017-02-10  Ryosuke Niwa  
 
 HTMLConstructionSiteTask::Insert should never be called on a node with a parent


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (212143 => 212144)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-10 21:24:43 UTC (rev 212143)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2017-02-10 21:29:32 UTC (rev 212144)
@@ -8876,6 +8876,7 @@
 		41CF8BE61D46222C00707DC9 /* FetchInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode._javascript_; path = FetchInternals.js; sourceTree = ""; };
 		



[webkit-changes] [212154] trunk/Source/WebCore


2017-02-10

Thread
andersca

Title: [212154] trunk/Source/WebCore








Revision 212154
Author ander...@apple.com
Date 2017-02-10 15:09:45 -0800 (Fri, 10 Feb 2017)


Log Message
Add a DragImage class that wraps a DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=168131

Reviewed by Beth Dakin.

This allows us to get rid of the explicit deleteDragImage calls and will make additional cleanup of the
various drag code paths possible. No functionality change.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::updateDragImage):
* page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
* page/DragController.h:
* platform/DragImage.cpp:
(WebCore::DragImage::DragImage):
(WebCore::DragImage::operator=):
(WebCore::DragImage::~DragImage):
* platform/DragImage.h:
* platform/Pasteboard.h:
* platform/StaticPasteboard.h:
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DataTransfer.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/DragController.h
trunk/Source/WebCore/platform/DragImage.cpp
trunk/Source/WebCore/platform/DragImage.h
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/StaticPasteboard.h
trunk/Source/WebCore/platform/efl/PasteboardEfl.cpp
trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp
trunk/Source/WebCore/platform/mac/PasteboardMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (212153 => 212154)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:02:36 UTC (rev 212153)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 23:09:45 UTC (rev 212154)
@@ -1,3 +1,30 @@
+2017-02-10  Anders Carlsson  
+
+Add a DragImage class that wraps a DragImageRef
+https://bugs.webkit.org/show_bug.cgi?id=168131
+
+Reviewed by Beth Dakin.
+
+This allows us to get rid of the explicit deleteDragImage calls and will make additional cleanup of the
+various drag code paths possible. No functionality change.
+
+* dom/DataTransfer.cpp:
+(WebCore::DataTransfer::updateDragImage):
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+(WebCore::DragController::doImageDrag):
+(WebCore::DragController::doSystemDrag):
+* page/DragController.h:
+* platform/DragImage.cpp:
+(WebCore::DragImage::DragImage):
+(WebCore::DragImage::operator=):
+(WebCore::DragImage::~DragImage):
+* platform/DragImage.h:
+* platform/Pasteboard.h:
+* platform/StaticPasteboard.h:
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::setDragImage):
+
 2017-02-10  Simon Fraser  
 
 Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections


Modified: trunk/Source/WebCore/dom/DataTransfer.cpp (212153 => 212154)

--- trunk/Source/WebCore/dom/DataTransfer.cpp	2017-02-10 23:02:36 UTC (rev 212153)
+++ trunk/Source/WebCore/dom/DataTransfer.cpp	2017-02-10 23:09:45 UTC (rev 212154)
@@ -283,11 +283,11 @@
 return;
 
 IntPoint computedHotSpot;
-DragImageRef computedImage = createDragImage(computedHotSpot);
+auto computedImage = DragImage { createDragImage(computedHotSpot) };
 if (!computedImage)
 return;
 
-m_pasteboard->setDragImage(computedImage, computedHotSpot);
+m_pasteboard->setDragImage(WTFMove(computedImage), computedHotSpot);
 }
 
 #if !PLATFORM(MAC)


Modified: trunk/Source/WebCore/page/DragController.cpp (212153 => 212154)

--- trunk/Source/WebCore/page/DragController.cpp	2017-02-10 23:02:36 UTC (rev 212153)
+++ trunk/Source/WebCore/page/DragController.cpp	2017-02-10 23:09:45 UTC (rev 212154)
@@ -772,11 +772,13 @@
 else
 sourceContainsHitNode = state.source->containsIncludingShadowDOM(hitTestResult.innerNode());
 
-if (!sourceContainsHitNode)
+if (!sourceContainsHitNode) {
 // The original node being dragged isn't under the drag origin anymore... maybe it was
 // hidden or moved out from under the cursor. Regardless, we don't want to start a drag on
 // something that's not actually under the drag origin.
 return false;
+}
+
 URL linkURL = hitTestResult.absoluteLinkURL();
 URL imageURL = hitTestResult.absoluteImageURL();
 #if ENABLE(ATTACHMENT_ELEMENT)
@@ -789,7 +791,7 @@
 m_draggingImageURL = URL();
 m_sourceDragOperation = srcOp;
 
-DragImageRef dragImage = nullptr;
+DragImage dragImage;
 IntPoint dragLoc(0, 0);
 IntPoint dragImageOffset(0, 0);
 
@@ -797,7 +799,7 @@
 
 DataTransfer& dataTransfer = *state.dataTransfer;
 if (state.type == DragSourceActionDHTML)
-dragImage = dataTransfer.createDragImage(dragImageOffset);
+dragImage = DragImage { dataTransfer.createDragImage(dragImageOffset) };
 if (state.type == DragSourceActionSelection || !imageURL.isEmpty() 



[webkit-changes] [212147] trunk/LayoutTests


2017-02-10

Thread
cdumez

Title: [212147] trunk/LayoutTests








Revision 212147
Author cdu...@apple.com
Date 2017-02-10 13:51:44 -0800 (Fri, 10 Feb 2017)


Log Message
Update LayoutTests/resources/testharness.js
https://bugs.webkit.org/show_bug.cgi?id=168100

Reviewed by Youenn Fablet.

Update LayoutTests/resources/testharness.js to match the web-platform-tests
one landed in r211930.

* media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt:
* media/track/w3c/interfaces/TextTrack/language-expected.txt:
* resources/testharness.js:
(SharedWorkerTestEnvironment):
(ServiceWorkerTestEnvironment):
(create_test_environment):
(promise_test):
(EventWatcher):
(is_node):
(format_value):
* streams/shadowing-Promise-expected.txt:
* streams/shadowing-Promise.html:
* streams/streams-public-array-api-expected.txt: Added.
* streams/streams-public-array-api.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt
trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/language-expected.txt
trunk/LayoutTests/resources/testharness.js
trunk/LayoutTests/streams/shadowing-Promise-expected.txt
trunk/LayoutTests/streams/shadowing-Promise.html


Added Paths

trunk/LayoutTests/streams/streams-public-array-api-expected.txt
trunk/LayoutTests/streams/streams-public-array-api.html




Diff

Modified: trunk/LayoutTests/ChangeLog (212146 => 212147)

--- trunk/LayoutTests/ChangeLog	2017-02-10 21:34:27 UTC (rev 212146)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 21:51:44 UTC (rev 212147)
@@ -1,3 +1,28 @@
+2017-02-10  Chris Dumez  
+
+Update LayoutTests/resources/testharness.js
+https://bugs.webkit.org/show_bug.cgi?id=168100
+
+Reviewed by Youenn Fablet.
+
+Update LayoutTests/resources/testharness.js to match the web-platform-tests
+one landed in r211930.
+
+* media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt:
+* media/track/w3c/interfaces/TextTrack/language-expected.txt:
+* resources/testharness.js:
+(SharedWorkerTestEnvironment):
+(ServiceWorkerTestEnvironment):
+(create_test_environment):
+(promise_test):
+(EventWatcher):
+(is_node):
+(format_value):
+* streams/shadowing-Promise-expected.txt:
+* streams/shadowing-Promise.html:
+* streams/streams-public-array-api-expected.txt: Added.
+* streams/streams-public-array-api.html: Added.
+
 2017-02-10  Ryan Haddad  
 
 Skip some very slow WebCryptoAPI tests.


Modified: trunk/LayoutTests/media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt (212146 => 212147)

--- trunk/LayoutTests/media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt	2017-02-10 21:34:27 UTC (rev 212146)
+++ trunk/LayoutTests/media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt	2017-02-10 21:51:44 UTC (rev 212147)
@@ -1,9 +1,9 @@
 CONSOLE MESSAGE: line 43: The language contains a null character and is not a valid BCP 47 language tag.
 CONSOLE MESSAGE: line 64: The language ' foo 
 ' is not a valid BCP 47 language tag.
-CONSOLE MESSAGE: line 1380: The language ' foo 
+CONSOLE MESSAGE: line 1409: The language ' foo 
 ' is not a valid BCP 47 language tag.
-CONSOLE MESSAGE: line 1380: The language contains a null character and is not a valid BCP 47 language tag.
+CONSOLE MESSAGE: line 1409: The language contains a null character and is not a valid BCP 47 language tag.
 
 PASS HTMLTrackElement.srclang missing value 
 PASS HTMLTrackElement.srclang empty string content attribute 


Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/language-expected.txt (212146 => 212147)

--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/language-expected.txt	2017-02-10 21:34:27 UTC (rev 212146)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/language-expected.txt	2017-02-10 21:51:44 UTC (rev 212147)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1380: The language contains a null character and is not a valid BCP 47 language tag.
+CONSOLE MESSAGE: line 1409: The language contains a null character and is not a valid BCP 47 language tag.
 CONSOLE MESSAGE: line 26: The language contains a null character and is not a valid BCP 47 language tag.
 
 PASS TextTrack.language 


Modified: trunk/LayoutTests/resources/testharness.js (212146 => 212147)

--- trunk/LayoutTests/resources/testharness.js	2017-02-10 21:34:27 UTC (rev 212146)
+++ trunk/LayoutTests/resources/testharness.js	2017-02-10 21:51:44 UTC (rev 212147)
@@ -389,7 +389,7 @@
 self.addEventListener("connect",
 function(message_event) {
 this_obj._add_message_port(message_event.source);
-});
+}, false);
 }
 SharedWorkerTestEnvironment.prototype = Object.create(WorkerTestEnvironment.prototype);
 
@@ -430,7 +430,7 @@
 



[webkit-changes] [212149] trunk/Source


2017-02-10

Thread
mitz

Title: [212149] trunk/Source








Revision 212149
Author m...@apple.com
Date 2017-02-10 14:16:19 -0800 (Fri, 10 Feb 2017)


Log Message
[Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate
https://bugs.webkit.org/show_bug.cgi?id=168097

Reviewed by Tim Horton.

Source/WebCore:

Added a userTriggered argument to FrameSelection::setSelectedRange so that WebKit2 can
indicate that changes should be agreed to by the delegate.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectedRange): If the change is user-triggered, check with
  shouldChangeSelection.
* editing/FrameSelection.h:

Source/WebKit2:

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:
  Declared new delegate method.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Dispatch new delegate
  method.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture): Pass UserTriggered whan calling
  WebCore::Frame::Selection::setSelectedRange, so that the delegate is consulted.
(WebKit::WebPage::changeBlockSelection): Ditto.
(WebKit::WebPage::updateSelectionWithTouches): Ditto.
(WebKit::WebPage::selectWithTwoTouches): Ditto.
(WebKit::WebPage::extendSelection): Ditto.
(WebKit::WebPage::selectWordBackward): Ditto,
(WebKit::WebPage::moveSelectionByOffset): Ditto.
(WebKit::WebPage::selectPositionAtPoint): Ditto.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (212148 => 212149)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 21:58:23 UTC (rev 212148)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 22:16:19 UTC (rev 212149)
@@ -1,3 +1,18 @@
+2017-02-10  Dan Bernstein  
+
+[Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate
+https://bugs.webkit.org/show_bug.cgi?id=168097
+
+Reviewed by Tim Horton.
+
+Added a userTriggered argument to FrameSelection::setSelectedRange so that WebKit2 can
+indicate that changes should be agreed to by the delegate.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::setSelectedRange): If the change is user-triggered, check with
+  shouldChangeSelection.
+* editing/FrameSelection.h:
+
 2017-02-10  Jonathan Bedard  
 
 Removing LayoutTestRelay


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (212148 => 212149)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2017-02-10 21:58:23 UTC (rev 212148)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2017-02-10 22:16:19 UTC (rev 212149)
@@ -1943,7 +1943,7 @@
 }
 }
 
-bool FrameSelection::setSelectedRange(Range* range, EAffinity affinity, bool closeTyping)
+bool FrameSelection::setSelectedRange(Range* range, EAffinity affinity, bool closeTyping, EUserTriggered userTriggered)
 {
 if (!range)
 return false;
@@ -1957,6 +1957,14 @@
 return false;
 #endif
 
+if (userTriggered == UserTriggered) {
+FrameSelection trialFrameSelection;
+trialFrameSelection.setSelection(newSelection, ClearTypingStyle | (closeTyping ? CloseTyping : 0));
+
+if (!shouldChangeSelection(trialFrameSelection.selection()))
+return false;
+}
+
 setSelection(newSelection, ClearTypingStyle | (closeTyping ? CloseTyping : 0));
 return true;
 }


Modified: trunk/Source/WebCore/editing/FrameSelection.h (212148 => 212149)

--- trunk/Source/WebCore/editing/FrameSelection.h	2017-02-10 21:58:23 UTC (rev 212148)
+++ trunk/Source/WebCore/editing/FrameSelection.h	2017-02-10 22:16:19 UTC (rev 212149)
@@ -145,7 +145,7 @@
 
 const VisibleSelection& selection() const { return m_selection; }
 WEBCORE_EXPORT void setSelection(const VisibleSelection&, SetSelectionOptions = defaultSetSelectionOptions(), AXTextStateChangeIntent = AXTextStateChangeIntent(), CursorAlignOnScroll = AlignCursorOnScrollIfNeeded, TextGranularity = CharacterGranularity);
-WEBCORE_EXPORT bool setSelectedRange(Range*, EAffinity, bool closeTyping);
+WEBCORE_EXPORT bool setSelectedRange(Range*, EAffinity, bool closeTyping, EUserTriggered = NotUserTriggered);
 WEBCORE_EXPORT void selectAll();
 WEBCORE_EXPORT void 



[webkit-changes] [212146] trunk/Source/JavaScriptCore


2017-02-10

Thread
mark . lam

Title: [212146] trunk/Source/_javascript_Core








Revision 212146
Author mark@apple.com
Date 2017-02-10 13:34:27 -0800 (Fri, 10 Feb 2017)


Log Message
StructureStubInfo::considerCaching() should write barrier its owner CodeBlock when buffering a new Structure.
https://bugs.webkit.org/show_bug.cgi?id=168137


Reviewed by Filip Pizlo.

If we're adding a new structure to StructureStubInfo's bufferedStructures, we
should write barrier the StubInfo's owner CodeBlock because that structure may be
collected during the next GC.  Write barrier-ing the owner CodeBlock ensures that
CodeBlock::finalizeBaselineJITInlineCaches() is called on it during the GC,
which, in turn, gives the StructureStubInfo the opportunity to filter out the
dead structure.

* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::considerCaching):
* jit/JITOperations.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/jit/JITOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (212145 => 212146)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-10 21:31:28 UTC (rev 212145)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-10 21:34:27 UTC (rev 212146)
@@ -1,3 +1,22 @@
+2017-02-10  Mark Lam  
+
+StructureStubInfo::considerCaching() should write barrier its owner CodeBlock when buffering a new Structure.
+https://bugs.webkit.org/show_bug.cgi?id=168137
+
+
+Reviewed by Filip Pizlo.
+
+If we're adding a new structure to StructureStubInfo's bufferedStructures, we
+should write barrier the StubInfo's owner CodeBlock because that structure may be
+collected during the next GC.  Write barrier-ing the owner CodeBlock ensures that
+CodeBlock::finalizeBaselineJITInlineCaches() is called on it during the GC,
+which, in turn, gives the StructureStubInfo the opportunity to filter out the
+dead structure.
+
+* bytecode/StructureStubInfo.h:
+(JSC::StructureStubInfo::considerCaching):
+* jit/JITOperations.cpp:
+
 2017-02-10  Brian Burg  
 
 [Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator


Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h (212145 => 212146)

--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2017-02-10 21:31:28 UTC (rev 212145)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2017-02-10 21:34:27 UTC (rev 212146)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008, 2012-2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include "CodeBlock.h"
 #include "CodeOrigin.h"
 #include "Instruction.h"
 #include "JITStubRoutine.h"
@@ -85,7 +86,7 @@
 // This returns true if it has marked everything that it will ever mark.
 bool propagateTransitions(SlotVisitor&);
 
-ALWAYS_INLINE bool considerCaching(Structure* structure)
+ALWAYS_INLINE bool considerCaching(CodeBlock* codeBlock, Structure* structure)
 {
 // We never cache non-cells.
 if (!structure)
@@ -137,7 +138,12 @@
 // we don't already have a case buffered for. Note that if this returns true but the
 // bufferingCountdown is not zero then we will buffer the access case for later without
 // immediately generating code for it.
-return bufferedStructures.add(structure);
+bool isNewlyAdded = bufferedStructures.add(structure);
+if (isNewlyAdded) {
+VM& vm = *codeBlock->vm();
+vm.heap.writeBarrier(codeBlock);
+}
+return isNewlyAdded;
 }
 countdown--;
 return false;


Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (212145 => 212146)

--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2017-02-10 21:31:28 UTC (rev 212145)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2017-02-10 21:34:27 UTC (rev 212146)
@@ -210,7 +210,7 @@
 baseValue.getPropertySlot(exec, ident, slot);
 RETURN_IF_EXCEPTION(scope, encodedJSValue());
 
-if (stubInfo->considerCaching(baseValue.structureOrNull()) && !slot.isTaintedByOpaqueObject() && (slot.isCacheableValue() || slot.isCacheableGetter() || slot.isUnset()))
+if (stubInfo->considerCaching(exec->codeBlock(), baseValue.structureOrNull()) && !slot.isTaintedByOpaqueObject() && (slot.isCacheableValue() || slot.isCacheableGetter() || slot.isUnset()))
 repatchGetByID(exec, baseValue, ident, slot, *stubInfo, GetByIDKind::Pure);
 
 return JSValue::encode(slot.getPureResult());
@@ -259,7 +259,7 @@
 LOG_IC((ICEvent::OperationGetByIdOptimize, 



[webkit-changes] [212139] trunk/Source/WTF


2017-02-10

Thread
commit-queue

Title: [212139] trunk/Source/WTF








Revision 212139
Author commit-qu...@webkit.org
Date 2017-02-10 13:08:32 -0800 (Fri, 10 Feb 2017)


Log Message
Fix misleading comment in RunLoop.h
https://bugs.webkit.org/show_bug.cgi?id=167832

Patch by Joseph Pecoraro  on 2017-02-10
Reviewed by Sam Weinig.

* wtf/RunLoop.h:
Mac initialization used to force using CFRunLoopGetMain(). Now however it just
uses RunLoop::current which uses CFRunLoopGetCurrent(). So this comment that
it can be done on any thread is misleading and can lead to incorrect behavior
if it is actually done on a non-main thread on Mac.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RunLoop.cpp
trunk/Source/WTF/wtf/RunLoop.h




Diff

Modified: trunk/Source/WTF/ChangeLog (212138 => 212139)

--- trunk/Source/WTF/ChangeLog	2017-02-10 20:59:40 UTC (rev 212138)
+++ trunk/Source/WTF/ChangeLog	2017-02-10 21:08:32 UTC (rev 212139)
@@ -1,3 +1,16 @@
+2017-02-10  Joseph Pecoraro  
+
+Fix misleading comment in RunLoop.h
+https://bugs.webkit.org/show_bug.cgi?id=167832
+
+Reviewed by Sam Weinig.
+
+* wtf/RunLoop.h:
+Mac initialization used to force using CFRunLoopGetMain(). Now however it just
+uses RunLoop::current which uses CFRunLoopGetCurrent(). So this comment that
+it can be done on any thread is misleading and can lead to incorrect behavior
+if it is actually done on a non-main thread on Mac.
+
 2017-02-09  Alex Christensen  
 
 Unreviewed, rolling out r212040.


Modified: trunk/Source/WTF/wtf/RunLoop.cpp (212138 => 212139)

--- trunk/Source/WTF/wtf/RunLoop.cpp	2017-02-10 20:59:40 UTC (rev 212138)
+++ trunk/Source/WTF/wtf/RunLoop.cpp	2017-02-10 21:08:32 UTC (rev 212139)
@@ -50,6 +50,9 @@
 
 void RunLoop::initializeMainRunLoop()
 {
+#if OS(DARWIN)
+ASSERT(pthread_main_np());
+#endif
 if (s_mainRunLoop)
 return;
 s_mainRunLoop = ::current();


Modified: trunk/Source/WTF/wtf/RunLoop.h (212138 => 212139)

--- trunk/Source/WTF/wtf/RunLoop.h	2017-02-10 20:59:40 UTC (rev 212138)
+++ trunk/Source/WTF/wtf/RunLoop.h	2017-02-10 21:08:32 UTC (rev 212139)
@@ -50,8 +50,7 @@
 class RunLoop : public FunctionDispatcher {
 WTF_MAKE_NONCOPYABLE(RunLoop);
 public:
-// Must be called from the main thread (except for the Mac platform, where it
-// can be called from any thread).
+// Must be called from the main thread.
 WTF_EXPORT_PRIVATE static void initializeMainRunLoop();
 
 WTF_EXPORT_PRIVATE static RunLoop& current();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212142] trunk/Source/WebInspectorUI


2017-02-10

Thread
mattbaker

Title: [212142] trunk/Source/WebInspectorUI








Revision 212142
Author mattba...@apple.com
Date 2017-02-10 13:17:37 -0800 (Fri, 10 Feb 2017)


Log Message
REGRESSION (r211829): Web Inspector: Elements tab is blank when added after page load
https://bugs.webkit.org/show_bug.cgi?id=168142

Reviewed by Brian Burg.

The Elements tab can be shown in two ways: by adding the Elements tab
from the "New Tab" tab, or via Inspect Element. In both cases we should
be checking that the ContentView exists, and create it if needed.

* UserInterface/Views/ElementsTabContentView.js:
(WebInspector.ElementsTabContentView.prototype.showRepresentedObject):
(WebInspector.ElementsTabContentView.prototype.shown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (212141 => 212142)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-02-10 21:15:57 UTC (rev 212141)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-02-10 21:17:37 UTC (rev 212142)
@@ -1,3 +1,18 @@
+2017-02-10  Matt Baker  
+
+REGRESSION (r211829): Web Inspector: Elements tab is blank when added after page load
+https://bugs.webkit.org/show_bug.cgi?id=168142
+
+Reviewed by Brian Burg.
+
+The Elements tab can be shown in two ways: by adding the Elements tab
+from the "New Tab" tab, or via Inspect Element. In both cases we should
+be checking that the ContentView exists, and create it if needed.
+
+* UserInterface/Views/ElementsTabContentView.js:
+(WebInspector.ElementsTabContentView.prototype.showRepresentedObject):
+(WebInspector.ElementsTabContentView.prototype.shown):
+
 2017-02-09  Devin Rousso  
 
 Web Inspector: changing dock side from windowed to bottom should cause split console to collapse on Timeline and Network tabs


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (212141 => 212142)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js	2017-02-10 21:15:57 UTC (rev 212141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js	2017-02-10 21:17:37 UTC (rev 212142)
@@ -67,16 +67,15 @@
 
 showRepresentedObject(representedObject, cookie)
 {
-var domTreeContentView = this.contentBrowser.currentContentView;
-console.assert(!domTreeContentView || domTreeContentView instanceof WebInspector.DOMTreeContentView);
-if (!domTreeContentView || !(domTreeContentView instanceof WebInspector.DOMTreeContentView)) {
-// FIXME: Remember inspected node for later when _mainFrameDidChange.
-return;
-}
+if (!this.contentBrowser.currentContentView)
+this._showDOMTreeContentView();
 
 if (!cookie || !cookie.nodeToSelect)
 return;
 
+let domTreeContentView = this.contentBrowser.currentContentView;
+console.assert(domTreeContentView instanceof WebInspector.DOMTreeContentView, "Unexpected DOMTreeContentView representedObject.", domTreeContentView);
+
 domTreeContentView.selectAndRevealDOMNode(cookie.nodeToSelect);
 
 // Because nodeToSelect is ephemeral, we don't want to keep
@@ -84,6 +83,14 @@
 cookie.nodeToSelect = undefined;
 }
 
+shown()
+{
+super.shown();
+
+if (!this.contentBrowser.currentContentView)
+this._showDOMTreeContentView();
+}
+
 closed()
 {
 super.closed();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212143] trunk/Source/WebKit/mac


2017-02-10

Thread
aakash_jain

Title: [212143] trunk/Source/WebKit/mac








Revision 212143
Author aakash_j...@apple.com
Date 2017-02-10 13:24:43 -0800 (Fri, 10 Feb 2017)


Log Message
cleanup WebLocalizableStrings.
https://bugs.webkit.org/show_bug.cgi?id=168078

Reviewed by Alexey Proskuryakov.

* Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle
as it's for each framework's own consumption, and never needs to be exported.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (212142 => 212143)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-10 21:17:37 UTC (rev 212142)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-10 21:24:43 UTC (rev 212143)
@@ -1,5 +1,15 @@
 2017-02-10  Aakash Jain  
 
+cleanup WebLocalizableStrings.
+https://bugs.webkit.org/show_bug.cgi?id=168078
+
+Reviewed by Alexey Proskuryakov.
+
+* Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
+as it's for each framework's own consumption, and never needs to be exported.
+
+2017-02-10  Aakash Jain  
+
 WebResourceLoadDelegatePrivate.h cannot be imported standalone
 https://bugs.webkit.org/show_bug.cgi?id=168096
 


Modified: trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h (212142 => 212143)

--- trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-02-10 21:17:37 UTC (rev 212142)
+++ trunk/Source/WebKit/mac/Misc/WebLocalizableStrings.h	2017-02-10 21:24:43 UTC (rev 212143)
@@ -62,6 +62,8 @@
 
 #define LOCALIZABLE_STRINGS_BUNDLE(F) LOCALIZABLE_STRINGS_BUNDLE_HELPER(F)
 #define LOCALIZABLE_STRINGS_BUNDLE_HELPER(F) F ## LocalizableStringsBundle
+
+__attribute__((visibility("hidden")))
 extern WebLocalizableStringsBundle LOCALIZABLE_STRINGS_BUNDLE(FRAMEWORK_NAME);
 
 #define UI_STRING(string, comment) WebLocalizedStringWithValue(_STRINGS_BUNDLE(FRAMEWORK_NAME), string, string)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212152] trunk


2017-02-10

Thread
simon . fraser

Title: [212152] trunk








Revision 212152
Author simon.fra...@apple.com
Date 2017-02-10 14:40:18 -0800 (Fri, 10 Feb 2017)


Log Message
Tiled layers are sometimes left with some tiles when outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=168104
Source/WebCore:

rdar://problem/30459055

Reviewed by Tim Horton.

When the coverage rect of a TiledBacking goes from a non-empty rect to an empty rect, we
shouldn't just early return from TileGrid::revalidateTiles(), otherwise we are left with some
tiles. Run through the function as normal, which will remove all the tiles for an empty coverage rect.

Minor logging changes.

Test: tiled-drawing/tile-coverage-iframe-to-zero-coverage.html

* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::revalidateTiles):

LayoutTests:

Reviewed by Tim Horton.

* tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: Added.
* tiled-drawing/tile-coverage-iframe-to-zero-coverage.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp


Added Paths

trunk/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt
trunk/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html




Diff

Modified: trunk/LayoutTests/ChangeLog (212151 => 212152)

--- trunk/LayoutTests/ChangeLog	2017-02-10 22:36:12 UTC (rev 212151)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 22:40:18 UTC (rev 212152)
@@ -1,3 +1,13 @@
+2017-02-09  Simon Fraser  
+
+Tiled layers are sometimes left with some tiles when outside the viewport
+https://bugs.webkit.org/show_bug.cgi?id=168104
+
+Reviewed by Tim Horton.
+
+* tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: Added.
+* tiled-drawing/tile-coverage-iframe-to-zero-coverage.html: Added.
+
 2017-02-10  Joseph Pecoraro  
 
 [Resource Timing] Enable Resource Timing by default in Tests


Added: trunk/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt (0 => 212152)

--- trunk/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt	(rev 0)
+++ trunk/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt	2017-02-10 22:40:18 UTC (rev 212152)
@@ -0,0 +1,104 @@
+
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 858.00 5016.00)
+  (visible rect 0.00, 3000.00 785.00 x 585.00)
+  (coverage rect 0.00, 3000.00 785.00 x 585.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (bounds 858.00 5016.00)
+  (contentsOpaque 1)
+  (visible rect 0.00, 3000.00 785.00 x 585.00)
+  (coverage rect 0.00, 3000.00 785.00 x 585.00)
+  (intersects coverage rect 1)
+  (contentsScale 1.00)
+  (tile cache coverage 0, 2560 858 x 1536)
+  (tile size 512 x 512)
+  (top left tile 0, 5 tiles grid 2 x 3)
+  (in window 1)
+  (children 1
+(GraphicsLayer
+  (position 1.00 1.00)
+  (bounds 857.00 464.00)
+  (drawsContent 1)
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect -1.00, 2999.00 785.00 x 585.00)
+  (intersects coverage rect 0)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (position 32.00 32.00)
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect -33.00, 2967.00 785.00 x 585.00)
+  (intersects coverage rect 0)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 400.00)
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect 0.00, 0.00 0.00 x 0.00)
+  (intersects coverage rect 0)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect 0.00, 0.00 0.00 x 0.00)
+  (intersects coverage rect 0)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 2508.00 400.00)
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect 0.00, 0.00 0.00 x 0.00)
+  (intersects coverage rect 0)
+  (contentsScale 1.00)
+  (children 1
+(GraphicsLayer
+  (bounds 2508.00 400.00)
+  (usingTiledLayer 1)
+  (drawsContent 1)
+  (visible rect 0.00, 0.00 0.00 x 0.00)
+  (coverage rect 0.00, 0.00 0.00 



[webkit-changes] [212137] trunk/LayoutTests


2017-02-10

Thread
commit-queue

Title: [212137] trunk/LayoutTests








Revision 212137
Author commit-qu...@webkit.org
Date 2017-02-10 12:51:00 -0800 (Fri, 10 Feb 2017)


Log Message
Remove platform expectations without tests
https://bugs.webkit.org/show_bug.cgi?id=168139

Patch by Joseph Pecoraro  on 2017-02-10
Reviewed by Sam Weinig.

* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Removed.
* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/gtk/http/tests/w3c/




Diff

Modified: trunk/LayoutTests/ChangeLog (212136 => 212137)

--- trunk/LayoutTests/ChangeLog	2017-02-10 20:45:00 UTC (rev 212136)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 20:51:00 UTC (rev 212137)
@@ -1,3 +1,13 @@
+2017-02-10  Joseph Pecoraro  
+
+Remove platform expectations without tests
+https://bugs.webkit.org/show_bug.cgi?id=168139
+
+Reviewed by Sam Weinig.
+
+* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Removed.
+* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Removed.
+
 2017-02-10  Chris Dumez  
 
 fast/forms/formsubmission-appendFormData-crash.html times out on WebKit1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212150] trunk


2017-02-10

Thread
joepeck

Title: [212150] trunk








Revision 212150
Author joep...@webkit.org
Date 2017-02-10 14:28:56 -0800 (Fri, 10 Feb 2017)


Log Message
[Resource Timing] Enable Resource Timing by default in Tests
https://bugs.webkit.org/show_bug.cgi?id=168145

Reviewed by Ryosuke Niwa.

Source/WebCore:

* loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setResourceTimingEnabled): Deleted.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
No longer needed for tests.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resourceTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

* fast/dom/Window/window-properties-performance-resource-timing.html:
* http/tests/misc/resource-timing-resolution.html:
* http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
* http/tests/performance/performance-resource-timing-cached-entries.html:
* http/tests/performance/performance-resource-timing-entries-iterable.html:
* http/tests/performance/performance-resource-timing-entries.html:
* http/tests/performance/performance-resource-timing-initiator-css.html:
* http/tests/performance/performance-resource-timing-initiator-no-override.html:
* http/tests/performance/performance-resource-timing-xhr-single-entry.html:
* http/tests/preload/dynamic_remove_preload_href-expected.txt:
* http/tests/preload/dynamic_remove_preload_href.html:
* http/tests/preload/dynamic_removing_preload.html:
* http/tests/preload/not_evicting_preload_at_onload.html:
* http/tests/preload/single_download_preload-expected.txt:
* http/tests/preload/single_download_preload.html:
* resources/testharnessreport.js:
Eliminate the internals setResourceTimingEnabled way to toggle a runtime feature.

* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
Update results when ResourceTiming is enabled.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html
trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt
trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-css.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-no-override.html
trunk/LayoutTests/http/tests/performance/performance-resource-timing-xhr-single-entry.html
trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt
trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href.html
trunk/LayoutTests/http/tests/preload/dynamic_removing_preload.html
trunk/LayoutTests/http/tests/preload/not_evicting_preload_at_onload.html
trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt
trunk/LayoutTests/http/tests/preload/single_download_preload.html
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt




[webkit-changes] [212153] trunk


2017-02-10

Thread
simon . fraser

Title: [212153] trunk








Revision 212153
Author simon.fra...@apple.com
Date 2017-02-10 15:02:36 -0800 (Fri, 10 Feb 2017)


Log Message
Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
https://bugs.webkit.org/show_bug.cgi?id=168127
rdar://problem/30467120

Reviewed by Tim Horton.
Source/WebCore:

Replace the special-case, but wrong, GraphicsLayer traversal in setIsInWindowIncludingDescendants()
which forgot to hit masks and replica layers with a generic traverse() function, which
is then used for setting 'inWindow' as well as resetting tracked repaints.

Tests: compositing/tiling/tiled-mask-inwindow.html
   compositing/tiling/tiled-reflection-inwindow.html

* page/PageOverlayController.cpp:
(WebCore::PageOverlayController::layerWithDocumentOverlays):
(WebCore::PageOverlayController::layerWithViewOverlays):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setIsInWindow):
(WebCore::GraphicsLayer::setReplicatedByLayer):
(WebCore::GraphicsLayer::traverse):
(WebCore::GraphicsLayer::setIsInWindowIncludingDescendants): Deleted.
* platform/graphics/GraphicsLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
(WebCore::resetTrackedRepaintRectsRecursive): Deleted.

Tools:

Reparent the web view before we try to fetch it via:
[[[window contentView] subviews] objectAtIndex:0];
which would throw an exception if the test unparented it.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
(runTest):

LayoutTests:

* compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
* compositing/tiling/tiled-mask-inwindow.html: Added.
* compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
* compositing/tiling/tiled-reflection-inwindow.html: Added.
* platform/ios-simulator-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
* platform/ios-simulator-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
* platform/ios-simulator-wk2/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
* platform/ios-simulator-wk2/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
* platform/mac-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
* platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageOverlayController.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm


Added Paths

trunk/LayoutTests/compositing/tiling/tiled-mask-inwindow-expected.txt
trunk/LayoutTests/compositing/tiling/tiled-mask-inwindow.html
trunk/LayoutTests/compositing/tiling/tiled-reflection-inwindow-expected.txt
trunk/LayoutTests/compositing/tiling/tiled-reflection-inwindow.html
trunk/LayoutTests/platform/ios-simulator-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/tiled-mask-inwindow-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/tiled-reflection-inwindow-expected.txt
trunk/LayoutTests/platform/mac-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt
trunk/LayoutTests/platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (212152 => 212153)

--- trunk/LayoutTests/ChangeLog	2017-02-10 22:40:18 UTC (rev 212152)
+++ trunk/LayoutTests/ChangeLog	2017-02-10 23:02:36 UTC (rev 212153)
@@ -1,3 +1,22 @@
+2017-02-10  Simon Fraser  
+
+Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
+https://bugs.webkit.org/show_bug.cgi?id=168127
+rdar://problem/30467120
+
+Reviewed by Tim Horton.
+
+* compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
+* compositing/tiling/tiled-mask-inwindow.html: Added.
+* compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
+* compositing/tiling/tiled-reflection-inwindow.html: Added.
+* platform/ios-simulator-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
+* platform/ios-simulator-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
+* platform/ios-simulator-wk2/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
+* platform/ios-simulator-wk2/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
+* platform/mac-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
+* platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: 



[webkit-changes] [212165] trunk/Source/WTF


2017-02-10

Thread
commit-queue

Title: [212165] trunk/Source/WTF








Revision 212165
Author commit-qu...@webkit.org
Date 2017-02-10 16:19:06 -0800 (Fri, 10 Feb 2017)


Log Message
Unreviewed, rolling out r212139.
https://bugs.webkit.org/show_bug.cgi?id=168152

Caused some assertions (Requested by JoePeck on #webkit).

Reverted changeset:

"Fix misleading comment in RunLoop.h"
https://bugs.webkit.org/show_bug.cgi?id=167832
http://trac.webkit.org/changeset/212139

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RunLoop.cpp
trunk/Source/WTF/wtf/RunLoop.h




Diff

Modified: trunk/Source/WTF/ChangeLog (212164 => 212165)

--- trunk/Source/WTF/ChangeLog	2017-02-11 00:12:41 UTC (rev 212164)
+++ trunk/Source/WTF/ChangeLog	2017-02-11 00:19:06 UTC (rev 212165)
@@ -1,3 +1,16 @@
+2017-02-10  Commit Queue  
+
+Unreviewed, rolling out r212139.
+https://bugs.webkit.org/show_bug.cgi?id=168152
+
+Caused some assertions (Requested by JoePeck on #webkit).
+
+Reverted changeset:
+
+"Fix misleading comment in RunLoop.h"
+https://bugs.webkit.org/show_bug.cgi?id=167832
+http://trac.webkit.org/changeset/212139
+
 2017-02-10  Joseph Pecoraro  
 
 Fix misleading comment in RunLoop.h


Modified: trunk/Source/WTF/wtf/RunLoop.cpp (212164 => 212165)

--- trunk/Source/WTF/wtf/RunLoop.cpp	2017-02-11 00:12:41 UTC (rev 212164)
+++ trunk/Source/WTF/wtf/RunLoop.cpp	2017-02-11 00:19:06 UTC (rev 212165)
@@ -50,9 +50,6 @@
 
 void RunLoop::initializeMainRunLoop()
 {
-#if OS(DARWIN)
-ASSERT(pthread_main_np());
-#endif
 if (s_mainRunLoop)
 return;
 s_mainRunLoop = ::current();


Modified: trunk/Source/WTF/wtf/RunLoop.h (212164 => 212165)

--- trunk/Source/WTF/wtf/RunLoop.h	2017-02-11 00:12:41 UTC (rev 212164)
+++ trunk/Source/WTF/wtf/RunLoop.h	2017-02-11 00:19:06 UTC (rev 212165)
@@ -50,7 +50,8 @@
 class RunLoop : public FunctionDispatcher {
 WTF_MAKE_NONCOPYABLE(RunLoop);
 public:
-// Must be called from the main thread.
+// Must be called from the main thread (except for the Mac platform, where it
+// can be called from any thread).
 WTF_EXPORT_PRIVATE static void initializeMainRunLoop();
 
 WTF_EXPORT_PRIVATE static RunLoop& current();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212168] trunk/LayoutTests


2017-02-10

Thread
ryanhaddad

Title: [212168] trunk/LayoutTests








Revision 212168
Author ryanhad...@apple.com
Date 2017-02-10 17:12:07 -0800 (Fri, 10 Feb 2017)


Log Message
Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (212167 => 212168)

--- trunk/LayoutTests/ChangeLog	2017-02-11 01:09:55 UTC (rev 212167)
+++ trunk/LayoutTests/ChangeLog	2017-02-11 01:12:07 UTC (rev 212168)
@@ -1,3 +1,9 @@
+2017-02-10  Ryan Haddad  
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2017-02-10  Simon Fraser  
 
 Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections


Modified: trunk/LayoutTests/TestExpectations (212167 => 212168)

--- trunk/LayoutTests/TestExpectations	2017-02-11 01:09:55 UTC (rev 212167)
+++ trunk/LayoutTests/TestExpectations	2017-02-11 01:12:07 UTC (rev 212168)
@@ -1022,6 +1022,10 @@
 webkit.org/b/168066 performance-api/performance-now-api.html [ Pass Failure ]
 webkit.org/b/168005 performance-api/performance-now-time-origin-in-worker.html [ Pass Failure ]
 
+fast/history/page-cache-after-window-open.html [ Skip ]
+fast/history/page-cache-back-navigation-crash.html [ Skip ]
+fast/history/page-cache-with-opener.html [ Skip ]
+
 
 ### START OF -disabled tests
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212159] tags/Safari-603.1.26/


2017-02-10

Thread
matthew_hanson

Title: [212159] tags/Safari-603.1.26/








Revision 212159
Author matthew_han...@apple.com
Date 2017-02-10 15:48:44 -0800 (Fri, 10 Feb 2017)


Log Message
Tag Safari-603.1.26.

Added Paths

tags/Safari-603.1.26/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212158] trunk/Source/WebCore


2017-02-10

Thread
commit-queue

Title: [212158] trunk/Source/WebCore








Revision 212158
Author commit-qu...@webkit.org
Date 2017-02-10 15:47:41 -0800 (Fri, 10 Feb 2017)


Log Message
Update features.json for Performance Timing APIs
https://bugs.webkit.org/show_bug.cgi?id=168148

Patch by Joseph Pecoraro  on 2017-02-10
Reviewed by Simon Fraser.

* features.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (212157 => 212158)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:47:02 UTC (rev 212157)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 23:47:41 UTC (rev 212158)
@@ -1,3 +1,12 @@
+2017-02-10  Joseph Pecoraro  
+
+Update features.json for Performance Timing APIs
+https://bugs.webkit.org/show_bug.cgi?id=168148
+
+Reviewed by Simon Fraser.
+
+* features.json:
+
 2017-02-10  Anders Carlsson  
 
 Try to fix the iOS and Windows builds.


Modified: trunk/Source/WebCore/features.json (212157 => 212158)

--- trunk/Source/WebCore/features.json	2017-02-10 23:47:02 UTC (rev 212157)
+++ trunk/Source/WebCore/features.json	2017-02-10 23:47:41 UTC (rev 212158)
@@ -345,6 +345,45 @@
 "description": "An API that can be used to understand the visibility and position of DOM elements relative to a containing element or to the top-level viewport."
 },
 {
+"name": "Navigation Timing Level 1",
+"status": {
+"status": "Done"
+},
+"url": "https://www.w3.org/TR/navigation-timing/",
+"keywords": ["performance", "navigation timing"],
+"description": "An API that exposes page load measurements to the page."
+},
+{
+"name": "Navigation Timing Level 2",
+"status": {
+"status": "In Development",
+"enabled-by-default": false
+},
+"url": "https://w3c.github.io/navigation-timing/",
+"keywords": ["performance", "navigation timing"],
+"description": "An API that exposes page load measurements to the page and adds entries to the performance timeline.",
+"contact": {
+"name": "Joseph Pecoraro",
+"email": "joep...@webkit.org",
+"twitter": "@JosephPecoraro"
+}
+},
+{
+"name": "Performance Observer",
+"status": {
+"status": "In Development",
+"enabled-by-default": false
+},
+"url": "https://w3c.github.io/performance-timeline/",
+"keywords": ["performance", "performance observer", "performance timeline"],
+"description": "An API to observe performance timeline entries at idle times.",
+"contact": {
+"name": "Joseph Pecoraro",
+"email": "joep...@webkit.org",
+"twitter": "@JosephPecoraro"
+}
+},
+{
 "name": "Pointer Lock",
 "status": {
 "status": "In Development",
@@ -372,19 +411,19 @@
 }
 },
 {
-"name": "Resource Timing",
+"name": "Resource Timing Level 2",
 "status": {
 "status": "In Development",
 "enabled-by-default": false
 },
-"url": "http://www.w3.org/TR/resource-timing/",
+"url": "https://w3c.github.io/resource-timing/",
 "webkit-url": "https://webkit.org/b/61138",
-"keywords": ["resourcetiming","resource timing","rsrc"],
-"description": "Provides detailed timing information to _javascript_ for sub-resources loaded by the page.",
+"keywords": ["performance", "resourcetiming", "resource timing", "rsrc"],
+"description": "An API to that provides detailed timing information for resource loads.",
 "contact": {
-"name": "Jonathan Davis",
-"email": "web-evangel...@apple.com",
-"twitter": "@jonathandavis"
+"name": "Joseph Pecoraro",
+"email": "joep...@webkit.org",
+"twitter": "@JosephPecoraro"
 }
 },
 {
@@ -409,13 +448,13 @@
 "category": "webapps"
 },
 {
-"name": "User Timing",
+"name": "User Timing Level 2",
 "status": {
 "status": "In Development",
 "enabled-by-default": false
 },
-"url": "http://www.w3.org/TR/user-timing/",
-"keywords": ["usertiming","user timing"],
+"url": "https://w3c.github.io/user-timing/",
+"keywords": ["performance", "usertiming", "user timing"],
 "description": "Provides high precision timestamp marking APIs.",
 "contact": {
 "name": "Jonathan Davis",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212157] trunk/Source/JavaScriptCore


2017-02-10

Thread
bburg

Title: [212157] trunk/Source/_javascript_Core








Revision 212157
Author bb...@apple.com
Date 2017-02-10 15:47:02 -0800 (Fri, 10 Feb 2017)


Log Message
[Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly
https://bugs.webkit.org/show_bug.cgi?id=168141

Reviewed by Joseph Pecoraro.

The generated code erroneously uses the ObjC variable name as the payload key,
rather than the raw type member name. For example, 'identifier' would be used instead of 'id'.

* inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_payload):

* inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
Rebaseline an affected test.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (212156 => 212157)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-10 23:41:35 UTC (rev 212156)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-10 23:47:02 UTC (rev 212157)
@@ -1,3 +1,19 @@
+2017-02-10  Brian Burg  
+
+[Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=168141
+
+Reviewed by Joseph Pecoraro.
+
+The generated code erroneously uses the ObjC variable name as the payload key,
+rather than the raw type member name. For example, 'identifier' would be used instead of 'id'.
+
+* inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
+(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_payload):
+
+* inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
+Rebaseline an affected test.
+
 2017-02-10  Mark Lam  
 
 StructureStubInfo::considerCaching() should write barrier its owner CodeBlock when buffering a new Structure.


Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py (212156 => 212157)

--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py	2017-02-10 23:41:35 UTC (rev 212156)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py	2017-02-10 23:47:02 UTC (rev 212157)
@@ -128,10 +128,13 @@
 lines.append('')
 
 for member in declaration.type_members:
-var_name = ObjCGenerator.identifier_to_objc_identifier(member.member_name)
+member_name = member.member_name
+conversion_expression = self.payload_to_objc_expression_for_member(declaration, member)
+
 if not member.is_optional:
-lines.append('THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"%s"], @"%s");' % (var_name, var_name))
-conversion_expression = self.payload_to_objc_expression_for_member(declaration, member)
+lines.append('THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"%s"], @"%s");' % (member_name, member_name))
+
+var_name = ObjCGenerator.identifier_to_objc_identifier(member_name)
 lines.append('self.%s = %s;' % (var_name, conversion_expression))
 lines.append('')
 


Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result (212156 => 212157)

--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result	2017-02-10 23:41:35 UTC (rev 212156)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result	2017-02-10 23:47:02 UTC (rev 212157)
@@ -1463,7 +1463,7 @@
 THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"animals"], @"animals");
 self.animals = fromProtocolString(payload[@"animals"]);
 
-THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"identifier"], @"identifier");
+THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"id"], @"id");
 self.identifier = [payload[@"id"] integerValue];
 
 THROW_EXCEPTION_FOR_REQUIRED_PROPERTY(payload[@"tree"], @"tree");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212162] trunk


2017-02-10

Thread
commit-queue

Title: [212162] trunk








Revision 212162
Author commit-qu...@webkit.org
Date 2017-02-10 15:53:31 -0800 (Fri, 10 Feb 2017)


Log Message
[Fetch API] fetch fails when undefined is passed as headers
https://bugs.webkit.org/show_bug.cgi?id=168043

Patch by Youenn Fablet  on 2017-02-10
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/request/request-headers-expected.txt:
* web-platform-tests/fetch/api/request/request-headers.html:

Source/WebCore:

Covered by updated test.

* Modules/fetch/FetchInternals.js:
(fillFetchHeaders): Exit early in case of undefined headers, since it is an optional parameter.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchInternals.js




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212161 => 212162)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-10 23:51:47 UTC (rev 212161)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-10 23:53:31 UTC (rev 212162)
@@ -1,3 +1,13 @@
+2017-02-10  Youenn Fablet  
+
+[Fetch API] fetch fails when undefined is passed as headers
+https://bugs.webkit.org/show_bug.cgi?id=168043
+
+Reviewed by Geoffrey Garen.
+
+* web-platform-tests/fetch/api/request/request-headers-expected.txt:
+* web-platform-tests/fetch/api/request/request-headers.html:
+
 2017-02-10  Jiewen Tan  
 
 [WebCrypto] Remove imported/w3c/WebCryptoAPI tests


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers-expected.txt (212161 => 212162)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers-expected.txt	2017-02-10 23:51:47 UTC (rev 212161)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers-expected.txt	2017-02-10 23:53:31 UTC (rev 212162)
@@ -55,4 +55,5 @@
 PASS Request should get its content-type from init headers if one is provided 
 PASS Testing request header creations with various objects 
 PASS Testing empty Request Content-Type header 
+PASS Passing undefined headers to Request constructor should not throw 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers.html (212161 => 212162)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers.html	2017-02-10 23:51:47 UTC (rev 212161)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-headers.html	2017-02-10 23:53:31 UTC (rev 212162)
@@ -168,6 +168,11 @@
 });
   }, "Testing empty Request Content-Type header");
 
+  test(function() {
+var request = new Request("", {"headers" : undefined, "body" : "this is my plate", "method" : "POST"});
+assert_equals(request.headers.get("Content-Type"), "text/plain;charset=UTF-8");
+  }, "Passing undefined headers to Request constructor should not throw");
+
 
   
 


Modified: trunk/Source/WebCore/ChangeLog (212161 => 212162)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:51:47 UTC (rev 212161)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 23:53:31 UTC (rev 212162)
@@ -1,3 +1,15 @@
+2017-02-10  Youenn Fablet  
+
+[Fetch API] fetch fails when undefined is passed as headers
+https://bugs.webkit.org/show_bug.cgi?id=168043
+
+Reviewed by Geoffrey Garen.
+
+Covered by updated test.
+
+* Modules/fetch/FetchInternals.js:
+(fillFetchHeaders): Exit early in case of undefined headers, since it is an optional parameter.
+
 2017-02-10  Csaba Osztrogonác  
 
 Fix the !ENABLE(WEB_TIMING) build


Modified: trunk/Source/WebCore/Modules/fetch/FetchInternals.js (212161 => 212162)

--- trunk/Source/WebCore/Modules/fetch/FetchInternals.js	2017-02-10 23:51:47 UTC (rev 212161)
+++ trunk/Source/WebCore/Modules/fetch/FetchInternals.js	2017-02-10 23:53:31 UTC (rev 212162)
@@ -30,6 +30,9 @@
 {
 "use strict";
 
+if (headersInit === @undefined)
+return;
+
 if (headersInit instanceof @Headers) {
 @Headers.prototype.@fillFromJS.@call(headers, headersInit);
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212164] trunk/Source/WebCore


2017-02-10

Thread
ossy

Title: [212164] trunk/Source/WebCore








Revision 212164
Author o...@webkit.org
Date 2017-02-10 16:12:41 -0800 (Fri, 10 Feb 2017)


Log Message
Fix the !ENABLE(WEBGL) build
https://bugs.webkit.org/show_bug.cgi?id=168112

Reviewed by Alex Christensen.

* html/canvas/WebGLRenderingContextBase.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (212163 => 212164)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:55:14 UTC (rev 212163)
+++ trunk/Source/WebCore/ChangeLog	2017-02-11 00:12:41 UTC (rev 212164)
@@ -1,3 +1,12 @@
+2017-02-10  Csaba Osztrogonác  
+
+Fix the !ENABLE(WEBGL) build
+https://bugs.webkit.org/show_bug.cgi?id=168112
+
+Reviewed by Alex Christensen.
+
+* html/canvas/WebGLRenderingContextBase.h:
+
 2017-02-10  Youenn Fablet  
 
 [Fetch API] fetch fails when undefined is passed as headers


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h (212163 => 212164)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h	2017-02-10 23:55:14 UTC (rev 212163)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h	2017-02-11 00:12:41 UTC (rev 212164)
@@ -25,6 +25,8 @@
 
 #pragma once
 
+#if ENABLE(WEBGL)
+
 #include "ActiveDOMObject.h"
 #include "CanvasRenderingContext.h"
 #include "GraphicsContext3D.h"
@@ -836,3 +838,5 @@
 } // namespace WebCore
 
 SPECIALIZE_TYPE_TRAITS_CANVASRENDERINGCONTEXT(WebCore::WebGLRenderingContextBase, is3d())
+
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212173] trunk


2017-02-10

Thread
dbates

Title: [212173] trunk








Revision 212173
Author dba...@webkit.org
Date 2017-02-10 18:53:53 -0800 (Fri, 10 Feb 2017)


Log Message
Detach frame from document when entering page cache
https://bugs.webkit.org/show_bug.cgi?id=166774


Reviewed by Chris Dumez.

Source/WebCore:

When a page enters the page cache it is unnecessary for it to hold a reference to its
associated frame because subsequent interactions with the page do not need to make use
of it. Once a page exits the page cache we associate it with its frame.

* dom/Document.cpp:
(WebCore::Document::frameDestroyed): Update comment to reflect the renaming of disconnectFromFrame().
(WebCore::Document::attachToCachedFrame): Added.
(WebCore::Document::detachFromCachedFrame): Added.
(WebCore::Document::prepareForDestruction): Only call CSSAnimationController::detachFromDocument() if
we have a frame. Substitute detachFromFrame() for disconnectFromFrame() as the latter was renamed to
the former.
(WebCore::Document::hasEverCalledWindowOpen): Deleted.
(WebCore::Document::markHasCalledWindowOpen): Deleted.
(WebCore::Document::disconnectFromFrame): Renamed to detachFromFrame.
* dom/Document.h:
(WebCore::Document::detachFromFrame): Renamed; formerly named disconnectFromFrame(). Changed
visibility from public to private and made this function inline.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::pruneDetachedChildFrames): Remove cached child frames that were
removed from the page when it was in the page cache as there is no need to restore such frames.
(WebCore::CachedFrameBase::restore): Call pruneDetachedChildFrames() before restoring the
frame tree.
(WebCore::CachedFrame::CachedFrame): Detach from the frame.
(WebCore::CachedFrame::open): Assert that we have a document and re-attach the frame.
(WebCore::CachedFrame::destroy): Update assertion as this function should only be called for a
frameless document. Only detach the FrameView, DocumentLoader, and Page when the cached frame is for
subframe and is associated with a Page object. Call CSSAnimationController::detachFromDocument() to
detach the animation controller from the document as it is being destroyed. We have to do this here
because the document does not have a frame. And Document::prepareForDestruction() only calls
CSSAnimationController::detachFromDocument() if the document has a frame.
* history/CachedFrame.h:
* history/PageCache.cpp:
(WebCore::canCachePage): Remove logic that prevents caching of a page that called window.open()
or has an opener as it is feasible to keep such pages in the page cache.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Fix style nit.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::frameDetached): Only stop all loaders and stop active DOM objects if the
page is not in- or about to enter- the page cache. A page in the page cache has finished loading
and its active DOM objects are suspended. Also fix style nit in comment.
(WebCore::FrameLoader::detachFromParent): Only stop all loaders if the page is not in- or about to
enter- the page cache. A page in the page cache has finished loading. Also added a comment to explain
that we protect the frame because stopAllLoaders() can cause the frame to be deallocated.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow): Remove logic to call markHasCalledWindowOpen() as this
function will be removed.
* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::hasCalledWindowOpenKey): Deleted.
(WebCore::DiagnosticLoggingKeys::hasOpenerKey): Deleted.
* page/DiagnosticLoggingKeys.h:
* page/Page.cpp:
(WebCore::Page::openedByWindowOpen): Deleted.
* page/Page.h:
* page/Settings.in: Remove setting allowsPageCacheWithWindowOpener.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
(-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
(WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAllowsPageCacheWithWindowOpener): Deleted.
(WKPreferencesGetAllowsPageCacheWithWindowOpener): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:




[webkit-changes] [212161] trunk/Source/WebCore


2017-02-10

Thread
ossy

Title: [212161] trunk/Source/WebCore








Revision 212161
Author o...@webkit.org
Date 2017-02-10 15:51:47 -0800 (Fri, 10 Feb 2017)


Log Message
Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=168113

Reviewed by Alex Christensen.

* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212160 => 212161)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:49:26 UTC (rev 212160)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 23:51:47 UTC (rev 212161)
@@ -1,3 +1,13 @@
+2017-02-10  Csaba Osztrogonác  
+
+Fix the !ENABLE(WEB_TIMING) build
+https://bugs.webkit.org/show_bug.cgi?id=168113
+
+Reviewed by Alex Christensen.
+
+* workers/WorkerGlobalScope.cpp:
+(WebCore::WorkerGlobalScope::WorkerGlobalScope):
+
 2017-02-10  Joseph Pecoraro  
 
 Update features.json for Performance Timing APIs


Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.cpp (212160 => 212161)

--- trunk/Source/WebCore/workers/WorkerGlobalScope.cpp	2017-02-10 23:49:26 UTC (rev 212160)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.cpp	2017-02-10 23:51:47 UTC (rev 212161)
@@ -79,6 +79,9 @@
 #if !ENABLE(WEB_SOCKETS)
 UNUSED_PARAM(socketProvider);
 #endif
+#if !ENABLE(WEB_TIMING)
+UNUSED_PARAM(timeOrigin);
+#endif
 
 auto origin = SecurityOrigin::create(url);
 if (m_topOrigin->hasUniversalAccess())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212166] trunk/Source/WebInspectorUI


2017-02-10

Thread
mattbaker

Title: [212166] trunk/Source/WebInspectorUI








Revision 212166
Author mattba...@apple.com
Date 2017-02-10 16:44:42 -0800 (Fri, 10 Feb 2017)


Log Message
Web Inspector: ContentViewContainer can have redundant back-forward entries after ContentView close
https://bugs.webkit.org/show_bug.cgi?id=168105

Reviewed by Joseph Pecoraro.

* UserInterface/Models/BackForwardEntry.js:
(WebInspector.BackForwardEntry.prototype.isEqual):
Make check for equal ContentView/cookie reusable.

* UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
Use BackForwardEntry.prototype.isEqual.
(WebInspector.ContentViewContainer.prototype.replaceContentView):
(WebInspector.ContentViewContainer.prototype.closeContentView):
Clean-up the BackForwardEntry list after changes that can cause
identical entries to become adjacent.

(WebInspector.ContentViewContainer.prototype._removeIdenticalAdjacentBackForwardEntries):
Remove consecutive entries with the same ContentView and cookie.
(WebInspector.ContentViewContainer):
(WebInspector.ContentViewContainer.closeAllContentViewsOfPrototype): Deleted.
Drive-by cleanup: removed dead code.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js
trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (212165 => 212166)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-02-11 00:19:06 UTC (rev 212165)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-02-11 00:44:42 UTC (rev 212166)
@@ -1,5 +1,30 @@
 2017-02-10  Matt Baker  
 
+Web Inspector: ContentViewContainer can have redundant back-forward entries after ContentView close
+https://bugs.webkit.org/show_bug.cgi?id=168105
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Models/BackForwardEntry.js:
+(WebInspector.BackForwardEntry.prototype.isEqual):
+Make check for equal ContentView/cookie reusable.
+
+* UserInterface/Views/ContentViewContainer.js:
+(WebInspector.ContentViewContainer.prototype.showContentView):
+Use BackForwardEntry.prototype.isEqual.
+(WebInspector.ContentViewContainer.prototype.replaceContentView):
+(WebInspector.ContentViewContainer.prototype.closeContentView):
+Clean-up the BackForwardEntry list after changes that can cause
+identical entries to become adjacent.
+
+(WebInspector.ContentViewContainer.prototype._removeIdenticalAdjacentBackForwardEntries):
+Remove consecutive entries with the same ContentView and cookie.
+(WebInspector.ContentViewContainer):
+(WebInspector.ContentViewContainer.closeAllContentViewsOfPrototype): Deleted.
+Drive-by cleanup: removed dead code.
+
+2017-02-10  Matt Baker  
+
 REGRESSION (r211829): Web Inspector: Elements tab is blank when added after page load
 https://bugs.webkit.org/show_bug.cgi?id=168142
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js (212165 => 212166)

--- trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js	2017-02-11 00:19:06 UTC (rev 212165)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js	2017-02-11 00:44:42 UTC (rev 212166)
@@ -97,6 +97,13 @@
 this._saveScrollPositions();
 }
 
+isEqual(other)
+{
+if (!other)
+return false;
+return this._contentView === other._contentView && Object.shallowEqual(this._cookie, other._cookie);
+}
+
 // Private
 
 _restoreFromCookie()


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js (212165 => 212166)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js	2017-02-11 00:19:06 UTC (rev 212165)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js	2017-02-11 00:44:42 UTC (rev 212166)
@@ -106,7 +106,7 @@
 provisionalEntry = new WebInspector.BackForwardEntry(contentView, cookie);
 
 // Don't do anything if we would have added an identical back/forward list entry.
-if (currentEntry && currentEntry.contentView === contentView && Object.shallowEqual(provisionalEntry.cookie, currentEntry.cookie)) {
+if (provisionalEntry.isEqual(currentEntry)) {
 const shouldCallShown = false;
 currentEntry.prepareToShow(shouldCallShown);
 return currentEntry.contentView;
@@ -203,6 +203,8 @@
 }
 }
 
+this._removeIdenticalAdjacentBackForwardEntries();
+
 // Re-show the current entry, because its content view instance was replaced.
 if (currentlyShowing) {
 this._showEntry(this.currentBackForwardEntry, true);
@@ -210,62 +212,6 @@
 }
 }
 
-closeAllContentViewsOfPrototype(constructor)
-{
-if (!this._backForwardList.length) {
-  



[webkit-changes] [212171] trunk/Source/WebInspectorUI


2017-02-10

Thread
mattbaker

Title: [212171] trunk/Source/WebInspectorUI








Revision 212171
Author mattba...@apple.com
Date 2017-02-10 18:25:04 -0800 (Fri, 10 Feb 2017)


Log Message
Web Inspector: Debugger sidebar panel should not have multiple tree selections
https://bugs.webkit.org/show_bug.cgi?id=166000


Reviewed by Timothy Hatcher.

The method for synchronizing tree element selection across a sidebar's
tree outlines fails for selections made during startup, because it depends
on events which are being suppressed.

This adds a new class, TreeOutlineGroup, which restricts tree element selection
inside a group of tree outlines by receiving messages directly from TreeElement.

* UserInterface/Main.html:
Add file for TreeOutlineGroup class.

* UserInterface/Views/ContentBrowserTabContentView.js:
(WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObject):
(WebInspector.ContentBrowserTabContentView):
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
Update `createContentTreeOutline` calls for new signature.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel):
Replace _visibleContentTreeOutlines with a TreeOutlineGroup, which
contains the single-selection behavior previously handled by the sidebar.

(WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlines):
(WebInspector.NavigationSidebarPanel.prototype.get hasSelectedElement):
Implement using the sidebar's tree outline group.
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Remove first parameter, which is always true.
(WebInspector.NavigationSidebarPanel.prototype.treeElementForRepresentedObject):
(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
(WebInspector.NavigationSidebarPanel.prototype.pruneStaleResourceTreeElements):
(WebInspector.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie):
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline): Deleted.
Remove unused setter.
(WebInspector.NavigationSidebarPanel.prototype.get visibleContentTreeOutlines): Deleted.
Renamed to contentTreeOutlines.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus): Deleted.
No longer needed.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange): Deleted.
Selection across trees handled by the tree outline group.

* UserInterface/Views/TreeElement.js:
(WebInspector.TreeElement.prototype.select):
Inform the element's tree outline group (if any), of the selection changed.

* UserInterface/Views/TreeOutlineGroup.js: Added.
(WebInspector.TreeOutlineGroup):
(WebInspector.TreeOutlineGroup.groupForTreeOutline):
(WebInspector.TreeOutlineGroup.prototype.get selectedTreeElement):
(WebInspector.TreeOutlineGroup.prototype.itemAdded):
Associate tree outline with the group and wrap tree elements. If the
incoming tree outline has a selection, deselect the group's currently
selected tree element.

(WebInspector.TreeOutlineGroup.prototype.itemRemoved):
Disassociate the tree outline from the group.
(WebInspector.TreeOutlineGroup.prototype.didSelectTreeElement):
Called by TreeElement when it becomes selected.
(WebInspector.TreeOutlineGroup.prototype._removeConflictingTreeSelections):
Deselect any selected items in all tree outlines belonging to the group,
except for the specified item.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineGroup.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (212170 => 212171)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-02-11 02:20:21 UTC (rev 212170)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-02-11 02:25:04 UTC (rev 212171)
@@ -1,5 +1,77 @@
 2017-02-10  Matt Baker  
 
+Web Inspector: Debugger sidebar panel should not have multiple tree selections
+https://bugs.webkit.org/show_bug.cgi?id=166000
+
+
+Reviewed by Timothy Hatcher.
+
+The method for synchronizing tree element selection across a sidebar's
+tree outlines fails for selections made during startup, because it depends
+on events which are being suppressed.
+
+This adds a new class, TreeOutlineGroup, which restricts tree element selection
+inside a group of tree outlines by receiving messages directly from TreeElement.
+
+* 



[webkit-changes] [212155] trunk


2017-02-10

Thread
bburg

Title: [212155] trunk








Revision 212155
Author bb...@apple.com
Date 2017-02-10 15:14:39 -0800 (Fri, 10 Feb 2017)


Log Message
Add basic debugging macros for CMake
https://bugs.webkit.org/show_bug.cgi?id=161538

Reviewed by Michael Catanzaro.

It's useful to be able to dump the state of everything when debugging
CMake build problems, especially when they happen on EWS (but not locally).

Start with macros for:
- dumping out all CMake variables
- dumping all executed commands (by turning off pretty-printing)

* Source/cmake/WebKitMacros.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (212154 => 212155)

--- trunk/ChangeLog	2017-02-10 23:09:45 UTC (rev 212154)
+++ trunk/ChangeLog	2017-02-10 23:14:39 UTC (rev 212155)
@@ -1,3 +1,19 @@
+2017-02-10  Brian Burg  
+
+Add basic debugging macros for CMake
+https://bugs.webkit.org/show_bug.cgi?id=161538
+
+Reviewed by Michael Catanzaro.
+
+It's useful to be able to dump the state of everything when debugging
+CMake build problems, especially when they happen on EWS (but not locally).
+
+Start with macros for:
+- dumping out all CMake variables
+- dumping all executed commands (by turning off pretty-printing)
+
+* Source/cmake/WebKitMacros.cmake:
+
 2017-02-09  Alex Christensen  
 
 Build libwebrtc on bots without using it yet


Modified: trunk/Source/cmake/WebKitMacros.cmake (212154 => 212155)

--- trunk/Source/cmake/WebKitMacros.cmake	2017-02-10 23:09:45 UTC (rev 212154)
+++ trunk/Source/cmake/WebKitMacros.cmake	2017-02-10 23:14:39 UTC (rev 212155)
@@ -430,3 +430,15 @@
 endforeach ()
 
 endmacro()
+
+# Helper macros for debugging CMake problems.
+macro(WEBKIT_DEBUG_DUMP_COMMANDS)
+set(CMAKE_VERBOSE_MAKEFILE ON)
+endmacro()
+
+macro(WEBKIT_DEBUG_DUMP_VARIABLES)
+set_cmake_property(_variableNames VARIABLES)
+foreach (_variableName ${_variableNames})
+   message(STATUS "${_variableName}=${${_variableName}}")
+endforeach ()
+endmacro()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212156] trunk/Source/WebCore


2017-02-10

Thread
andersca

Title: [212156] trunk/Source/WebCore








Revision 212156
Author ander...@apple.com
Date 2017-02-10 15:41:35 -0800 (Fri, 10 Feb 2017)


Log Message
Try to fix the iOS and Windows builds.

* platform/ios/DragImageIOS.mm:
(WebCore::deleteDragImage):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::setDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/DragImageIOS.mm
trunk/Source/WebCore/platform/win/PasteboardWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212155 => 212156)

--- trunk/Source/WebCore/ChangeLog	2017-02-10 23:14:39 UTC (rev 212155)
+++ trunk/Source/WebCore/ChangeLog	2017-02-10 23:41:35 UTC (rev 212156)
@@ -1,5 +1,14 @@
 2017-02-10  Anders Carlsson  
 
+Try to fix the iOS and Windows builds.
+
+* platform/ios/DragImageIOS.mm:
+(WebCore::deleteDragImage):
+* platform/win/PasteboardWin.cpp:
+(WebCore::Pasteboard::setDragImage):
+
+2017-02-10  Anders Carlsson  
+
 Add a DragImage class that wraps a DragImageRef
 https://bugs.webkit.org/show_bug.cgi?id=168131
 


Modified: trunk/Source/WebCore/platform/ios/DragImageIOS.mm (212155 => 212156)

--- trunk/Source/WebCore/platform/ios/DragImageIOS.mm	2017-02-10 23:14:39 UTC (rev 212155)
+++ trunk/Source/WebCore/platform/ios/DragImageIOS.mm	2017-02-10 23:41:35 UTC (rev 212156)
@@ -36,6 +36,12 @@
 
 namespace WebCore {
 
+void deleteDragImage(RetainPtr)
+{
+// Since this is a RetainPtr, there's nothing additional we need to do to
+// delete it. It will be released when it falls out of scope.
+}
+
 // FIXME: fix signature of dragImageSize() to avoid copying the argument.
 IntSize dragImageSize(RetainPtr image)
 {


Modified: trunk/Source/WebCore/platform/win/PasteboardWin.cpp (212155 => 212156)

--- trunk/Source/WebCore/platform/win/PasteboardWin.cpp	2017-02-10 23:14:39 UTC (rev 212155)
+++ trunk/Source/WebCore/platform/win/PasteboardWin.cpp	2017-02-10 23:41:35 UTC (rev 212156)
@@ -409,7 +409,7 @@
 }
 
 #if ENABLE(DRAG_SUPPORT)
-void Pasteboard::setDragImage(DragImageRef, const IntPoint&)
+void Pasteboard::setDragImage(DragImage, const IntPoint&)
 {
 // Do nothing in Windows.
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212160] trunk/Source/WebKit2


2017-02-10

Thread
commit-queue

Title: [212160] trunk/Source/WebKit2








Revision 212160
Author commit-qu...@webkit.org
Date 2017-02-10 15:49:26 -0800 (Fri, 10 Feb 2017)


Log Message
WebProcess: remove unused m_inDidClose
https://bugs.webkit.org/show_bug.cgi?id=168121

Patch by Olivier Blin  on 2017-02-10
Reviewed by Alex Christensen.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
* WebProcess/WebProcess.h:
m_inDidClose has been unused since r83774

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212159 => 212160)

--- trunk/Source/WebKit2/ChangeLog	2017-02-10 23:48:44 UTC (rev 212159)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-10 23:49:26 UTC (rev 212160)
@@ -1,3 +1,15 @@
+2017-02-10  Olivier Blin  
+
+WebProcess: remove unused m_inDidClose
+https://bugs.webkit.org/show_bug.cgi?id=168121
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::didClose):
+* WebProcess/WebProcess.h:
+m_inDidClose has been unused since r83774
+
 2017-02-10  Joseph Pecoraro  
 
 [Resource Timing] Enable Resource Timing by default in Tests


Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (212159 => 212160)

--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2017-02-10 23:48:44 UTC (rev 212159)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2017-02-10 23:49:26 UTC (rev 212160)
@@ -645,8 +645,6 @@
 void WebProcess::didClose(IPC::Connection&)
 {
 #ifndef NDEBUG
-m_inDidClose = true;
-
 // Close all the live pages.
 Vector pages;
 copyValuesToVector(m_pageMap, pages);


Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (212159 => 212160)

--- trunk/Source/WebKit2/WebProcess/WebProcess.h	2017-02-10 23:48:44 UTC (rev 212159)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h	2017-02-10 23:49:26 UTC (rev 212160)
@@ -352,8 +352,6 @@
 RefPtr m_viewUpdateDispatcher;
 #endif
 
-bool m_inDidClose { false };
-
 HashMap> m_plugInAutoStartOriginHashes;
 HashSet m_plugInAutoStartOrigins;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212163] trunk/Source/WebKit2


2017-02-10

Thread
commit-queue

Title: [212163] trunk/Source/WebKit2








Revision 212163
Author commit-qu...@webkit.org
Date 2017-02-10 15:55:14 -0800 (Fri, 10 Feb 2017)


Log Message
Add mediaStreamEnabled property to WKPreferences for Cocoa.
https://bugs.webkit.org/show_bug.cgi?id=168080

Patch by Andrew Gold  on 2017-02-10
Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Sets the pageConfiguration's mediaStreamEnabled preference value.

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]): Copies the mediaStreamEnabled property.
(-[WKWebViewConfiguration _mediaStreamEnabled]): Gets the mediaStreamEnabled property.
(-[WKWebViewConfiguration _setMediaStreamEnabled:]): Sets the mediaStreamEnabled property.
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212162 => 212163)

--- trunk/Source/WebKit2/ChangeLog	2017-02-10 23:53:31 UTC (rev 212162)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-10 23:55:14 UTC (rev 212163)
@@ -1,3 +1,19 @@
+2017-02-10  Andrew Gold  
+
+Add mediaStreamEnabled property to WKPreferences for Cocoa.
+https://bugs.webkit.org/show_bug.cgi?id=168080
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]): Sets the pageConfiguration's mediaStreamEnabled preference value.
+
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration copyWithZone:]): Copies the mediaStreamEnabled property.
+(-[WKWebViewConfiguration _mediaStreamEnabled]): Gets the mediaStreamEnabled property.
+(-[WKWebViewConfiguration _setMediaStreamEnabled:]): Sets the mediaStreamEnabled property.
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+
 2017-02-10  Olivier Blin  
 
 WebProcess: remove unused m_inDidClose


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (212162 => 212163)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-10 23:53:31 UTC (rev 212162)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-10 23:55:14 UTC (rev 212163)
@@ -433,6 +433,9 @@
 pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldConvertPositionStyleOnCopyKey(), WebKit::WebPreferencesStore::Value(!![_configuration _convertsPositionStyleOnCopy]));
 pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::httpEquivEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsMetaRefresh]));
 pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowUniversalAccessFromFileURLsKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowUniversalAccessFromFileURLs]));
+#if ENABLE(MEDIA_STREAM)
+pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::mediaStreamEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _mediaStreamEnabled]));
+#endif
 pageConfiguration->setInitialCapitalizationEnabled([_configuration _initialCapitalizationEnabled]);
 pageConfiguration->setWaitsForPaintAfterViewDidMoveToWindow([_configuration _waitsForPaintAfterViewDidMoveToWindow]);
 pageConfiguration->setControlledByAutomation([_configuration _isControlledByAutomation]);


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (212162 => 212163)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-02-10 23:53:31 UTC (rev 212162)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-02-10 23:55:14 UTC (rev 212163)
@@ -125,6 +125,9 @@
 BOOL _initialCapitalizationEnabled;
 BOOL _waitsForPaintAfterViewDidMoveToWindow;
 BOOL _controlledByAutomation;
+#if ENABLE(MEDIA_STREAM)
+BOOL _mediaStreamEnabled;
+#endif
 
 #if ENABLE(APPLE_PAY)
 BOOL _applePayEnabled;
@@ -293,6 +296,9 @@
 configuration->_initialCapitalizationEnabled = self->_initialCapitalizationEnabled;
 configuration->_waitsForPaintAfterViewDidMoveToWindow = self->_waitsForPaintAfterViewDidMoveToWindow;
 configuration->_controlledByAutomation = self->_controlledByAutomation;
+#if ENABLE(MEDIA_STREAM)
+configuration->_mediaStreamEnabled = self->_mediaStreamEnabled;
+#endif
 
 #if PLATFORM(IOS)
 configuration->_allowsInlineMediaPlayback = self->_allowsInlineMediaPlayback;
@@ -686,6 +692,22 @@
 _controlledByAutomation = controlledByAutomation;
 }
 
+- (BOOL)_mediaStreamEnabled
+{
+#if ENABLE(MEDIA_STREAM)
+return _mediaStreamEnabled;
+#else
+return NO;
+#endif
+}
+
+- (void)_setMediaStreamEnabled:(BOOL)enabled
+{
+#if ENABLE(MEDIA_STREAM)
+



[webkit-changes] [212167] trunk


2017-02-10

Thread
timothy_horton

Title: [212167] trunk








Revision 212167
Author timothy_hor...@apple.com
Date 2017-02-10 17:09:55 -0800 (Fri, 10 Feb 2017)


Log Message
Infinite UI process hang under ensurePositionInformationIsUpToDate
https://bugs.webkit.org/show_bug.cgi?id=168154


Reviewed by Simon Fraser.

Source/WebKit2:

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
If the web process crashes or we're being torn down for another reason,
assume that we aren't ever going to receive any pending async interaction
information update. Otherwise, ensurePositionInformationIsUpToDate can end
up waiting for it forever.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
(recursiveFindHighlightLongPressRecognizer):
(TEST):
Add a somewhat nasty test that does an async interaction information update, but
kills the Web process before it arrives, and then does a sync interaction
information update, which will wait for the oustanding async interaction
information update if we still think it's coming. Before the patch, this
test times out with the UI process stuck under ensurePositionInformationIsUpToDate.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212166 => 212167)

--- trunk/Source/WebKit2/ChangeLog	2017-02-11 00:44:42 UTC (rev 212166)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-11 01:09:55 UTC (rev 212167)
@@ -1,3 +1,18 @@
+2017-02-10  Tim Horton  
+
+Infinite UI process hang under ensurePositionInformationIsUpToDate
+https://bugs.webkit.org/show_bug.cgi?id=168154
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView cleanupInteraction]):
+If the web process crashes or we're being torn down for another reason,
+assume that we aren't ever going to receive any pending async interaction
+information update. Otherwise, ensurePositionInformationIsUpToDate can end
+up waiting for it forever.
+
 2017-02-10  Andrew Gold  
 
 Add mediaStreamEnabled property to WKPreferences for Cocoa.


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (212166 => 212167)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-02-11 00:44:42 UTC (rev 212166)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-02-11 01:09:55 UTC (rev 212167)
@@ -632,6 +632,7 @@
 [_formInputSession invalidate];
 _formInputSession = nil;
 [_highlightView removeFromSuperview];
+_outstandingPositionInformationRequest = std::nullopt;
 
 if (_interactionViewsContainerView) {
 [self.layer removeObserver:self forKeyPath:@"transform"];


Modified: trunk/Tools/ChangeLog (212166 => 212167)

--- trunk/Tools/ChangeLog	2017-02-11 00:44:42 UTC (rev 212166)
+++ trunk/Tools/ChangeLog	2017-02-11 01:09:55 UTC (rev 212167)
@@ -1,3 +1,21 @@
+2017-02-10  Tim Horton  
+
+Infinite UI process hang under ensurePositionInformationIsUpToDate
+https://bugs.webkit.org/show_bug.cgi?id=168154
+
+
+Reviewed by Simon Fraser.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
+(recursiveFindHighlightLongPressRecognizer):
+(TEST):
+Add a somewhat nasty test that does an async interaction information update, but
+kills the Web process before it arrives, and then does a sync interaction
+information update, which will wait for the oustanding async interaction
+information update if we still think it's coming. Before the patch, this
+test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
+
 2017-02-10  Simon Fraser  
 
 Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (212166 => 212167)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-02-11 00:44:42 UTC (rev 212166)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-02-11 01:09:55 UTC (rev 212167)
@@ -61,6 +61,7 @@
 		2D1C04A71D76298B000A6816 /* TestNavigationDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D1C04A61D76298B000A6816 /* TestNavigationDelegate.mm */; };
 		2D4CF8BD1D8360CC0001CE8D /* WKThumbnailView.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D4CF8BC1D8360CC0001CE8D /* WKThumbnailView.mm */; };
 		2D51A0C71C8BF00C00765C45 /* 



[webkit-changes] [212170] trunk/Source/WebCore


2017-02-10

Thread
commit-queue

Title: [212170] trunk/Source/WebCore








Revision 212170
Author commit-qu...@webkit.org
Date 2017-02-10 18:20:21 -0800 (Fri, 10 Feb 2017)


Log Message
Unreviewed, rolling out r212154, r212154, and r212156.
https://bugs.webkit.org/show_bug.cgi?id=168156

broke internal builds (Requested by smfr on #webkit).

Reverted changesets:

"Add a DragImage class that wraps a DragImageRef"
https://bugs.webkit.org/show_bug.cgi?id=168131
http://trac.webkit.org/changeset/212154

"Add a DragImage class that wraps a DragImageRef"
https://bugs.webkit.org/show_bug.cgi?id=168131
http://trac.webkit.org/changeset/212154

"Try to fix the iOS and Windows builds."
http://trac.webkit.org/changeset/212156

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DataTransfer.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/DragController.h
trunk/Source/WebCore/platform/DragImage.cpp
trunk/Source/WebCore/platform/DragImage.h
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/StaticPasteboard.h
trunk/Source/WebCore/platform/efl/PasteboardEfl.cpp
trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp
trunk/Source/WebCore/platform/ios/DragImageIOS.mm
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
trunk/Source/WebCore/platform/win/PasteboardWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212169 => 212170)

--- trunk/Source/WebCore/ChangeLog	2017-02-11 01:27:21 UTC (rev 212169)
+++ trunk/Source/WebCore/ChangeLog	2017-02-11 02:20:21 UTC (rev 212170)
@@ -1,3 +1,23 @@
+2017-02-10  Commit Queue  
+
+Unreviewed, rolling out r212154, r212154, and r212156.
+https://bugs.webkit.org/show_bug.cgi?id=168156
+
+broke internal builds (Requested by smfr on #webkit).
+
+Reverted changesets:
+
+"Add a DragImage class that wraps a DragImageRef"
+https://bugs.webkit.org/show_bug.cgi?id=168131
+http://trac.webkit.org/changeset/212154
+
+"Add a DragImage class that wraps a DragImageRef"
+https://bugs.webkit.org/show_bug.cgi?id=168131
+http://trac.webkit.org/changeset/212154
+
+"Try to fix the iOS and Windows builds."
+http://trac.webkit.org/changeset/212156
+
 2017-02-10  Csaba Osztrogonác  
 
 Fix the !ENABLE(WEBGL) build


Modified: trunk/Source/WebCore/dom/DataTransfer.cpp (212169 => 212170)

--- trunk/Source/WebCore/dom/DataTransfer.cpp	2017-02-11 01:27:21 UTC (rev 212169)
+++ trunk/Source/WebCore/dom/DataTransfer.cpp	2017-02-11 02:20:21 UTC (rev 212170)
@@ -283,11 +283,11 @@
 return;
 
 IntPoint computedHotSpot;
-auto computedImage = DragImage { createDragImage(computedHotSpot) };
+DragImageRef computedImage = createDragImage(computedHotSpot);
 if (!computedImage)
 return;
 
-m_pasteboard->setDragImage(WTFMove(computedImage), computedHotSpot);
+m_pasteboard->setDragImage(computedImage, computedHotSpot);
 }
 
 #if !PLATFORM(MAC)


Modified: trunk/Source/WebCore/page/DragController.cpp (212169 => 212170)

--- trunk/Source/WebCore/page/DragController.cpp	2017-02-11 01:27:21 UTC (rev 212169)
+++ trunk/Source/WebCore/page/DragController.cpp	2017-02-11 02:20:21 UTC (rev 212170)
@@ -772,13 +772,11 @@
 else
 sourceContainsHitNode = state.source->containsIncludingShadowDOM(hitTestResult.innerNode());
 
-if (!sourceContainsHitNode) {
+if (!sourceContainsHitNode)
 // The original node being dragged isn't under the drag origin anymore... maybe it was
 // hidden or moved out from under the cursor. Regardless, we don't want to start a drag on
 // something that's not actually under the drag origin.
 return false;
-}
-
 URL linkURL = hitTestResult.absoluteLinkURL();
 URL imageURL = hitTestResult.absoluteImageURL();
 #if ENABLE(ATTACHMENT_ELEMENT)
@@ -791,7 +789,7 @@
 m_draggingImageURL = URL();
 m_sourceDragOperation = srcOp;
 
-DragImage dragImage;
+DragImageRef dragImage = nullptr;
 IntPoint dragLoc(0, 0);
 IntPoint dragImageOffset(0, 0);
 
@@ -799,7 +797,7 @@
 
 DataTransfer& dataTransfer = *state.dataTransfer;
 if (state.type == DragSourceActionDHTML)
-dragImage = DragImage { dataTransfer.createDragImage(dragImageOffset) };
+dragImage = dataTransfer.createDragImage(dragImageOffset);
 if (state.type == DragSourceActionSelection || !imageURL.isEmpty() || !linkURL.isEmpty())
 // Selection, image, and link drags receive a default set of allowed drag operations that
 // follows from:
@@ -852,7 +850,7 @@
 }
 m_client.willPerformDragSourceAction(DragSourceActionSelection, dragOrigin, dataTransfer);
 if (!dragImage) {
-dragImage = DragImage { dissolveDragImageToFraction(createDragImageForSelection(src), DragImageAlpha) };
+dragImage = dissolveDragImageToFraction(createDragImageForSelection(src), DragImageAlpha);
 dragLoc 



[webkit-changes] [212172] trunk


2017-02-10

Thread
simon . fraser

Title: [212172] trunk








Revision 212172
Author simon.fra...@apple.com
Date 2017-02-10 18:30:23 -0800 (Fri, 10 Feb 2017)


Log Message
REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168054

Reviewed by Tim Horton.

Source/WebCore:

When adding mask layers, there was an ordering dependency. There was a hack in GraphicsLayerCA::setVisibleAndCoverageRects()
to propagate m_intersectsCoverageRect to masks. However, if GraphicsLayerCA::setVisibleAndCoverageRects()
ran on the masked layer before the mask was added, nothing updated the "m_intersectsCoverageRect" state of the mask layer.

Fix by explicitly calling setVisibleAndCoverageRects() on the mask layer, passing the same rects and
viewport-constrained state as for its host layer (we already assume that their geometry matches).

Tested by compositing/masks/solid-color-masked.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

LayoutTests:

Make the timeout 10ms so the test consistently fails with the old code.

* compositing/masks/solid-color-masked.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/masks/solid-color-masked.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (212171 => 212172)

--- trunk/LayoutTests/ChangeLog	2017-02-11 02:25:04 UTC (rev 212171)
+++ trunk/LayoutTests/ChangeLog	2017-02-11 02:30:23 UTC (rev 212172)
@@ -1,3 +1,14 @@
+2017-02-10  Simon Fraser  
+
+REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=168054
+
+Reviewed by Tim Horton.
+
+Make the timeout 10ms so the test consistently fails with the old code.
+
+* compositing/masks/solid-color-masked.html:
+
 2017-02-10  Ryan Haddad  
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/compositing/masks/solid-color-masked.html (212171 => 212172)

--- trunk/LayoutTests/compositing/masks/solid-color-masked.html	2017-02-11 02:25:04 UTC (rev 212171)
+++ trunk/LayoutTests/compositing/masks/solid-color-masked.html	2017-02-11 02:30:23 UTC (rev 212172)
@@ -10,7 +10,7 @@
 }
 
 .composited {
-  -webkit-transform: translateZ(0);
+  transform: translateZ(0);
 }
 
 .masked {
@@ -26,7 +26,7 @@
 document.getElementById('box').classList.add('masked');
 if (window.testRunner)
 testRunner.notifyDone();
-}, 0);
+}, 10);
 }
 window.addEventListener('load', doTest, false);
 


Modified: trunk/Source/WebCore/ChangeLog (212171 => 212172)

--- trunk/Source/WebCore/ChangeLog	2017-02-11 02:25:04 UTC (rev 212171)
+++ trunk/Source/WebCore/ChangeLog	2017-02-11 02:30:23 UTC (rev 212172)
@@ -1,3 +1,23 @@
+2017-02-10  Simon Fraser  
+
+REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=168054
+
+Reviewed by Tim Horton.
+
+When adding mask layers, there was an ordering dependency. There was a hack in GraphicsLayerCA::setVisibleAndCoverageRects()
+to propagate m_intersectsCoverageRect to masks. However, if GraphicsLayerCA::setVisibleAndCoverageRects()
+ran on the masked layer before the mask was added, nothing updated the "m_intersectsCoverageRect" state of the mask layer.
+
+Fix by explicitly calling setVisibleAndCoverageRects() on the mask layer, passing the same rects and
+viewport-constrained state as for its host layer (we already assume that their geometry matches).
+
+Tested by compositing/masks/solid-color-masked.html
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
+(WebCore::GraphicsLayerCA::recursiveCommitChanges):
+
 2017-02-10  Commit Queue  
 
 Unreviewed, rolling out r212154, r212154, and r212156.


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (212171 => 212172)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2017-02-11 02:25:04 UTC (rev 212171)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2017-02-11 02:30:23 UTC (rev 212172)
@@ -1332,32 +1332,16 @@
 if (intersectsCoverageRect != m_intersectsCoverageRect) {
 m_uncommittedChanges |= CoverageRectChanged;
 m_intersectsCoverageRect = intersectsCoverageRect;
-
-if (GraphicsLayerCA* maskLayer = downcast(m_maskLayer)) {
-maskLayer->m_uncommittedChanges |= 



[webkit-changes] [212174] trunk/Source/WebCore


2017-02-10

Thread
dbates

Title: [212174] trunk/Source/WebCore








Revision 212174
Author dba...@webkit.org
Date 2017-02-10 19:09:10 -0800 (Fri, 10 Feb 2017)


Log Message
Attempt to fix the build following 
(https://bugs.webkit.org/show_bug.cgi?id=166774)

* dom/Document.cpp:
(WebCore::Document::detachFromCachedFrame): Use ASSER_UNUSED() instead of ASSERT() since
the parameter cachedFrame is unused in non-debug build.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212173 => 212174)

--- trunk/Source/WebCore/ChangeLog	2017-02-11 02:53:53 UTC (rev 212173)
+++ trunk/Source/WebCore/ChangeLog	2017-02-11 03:09:10 UTC (rev 212174)
@@ -1,5 +1,14 @@
 2017-02-10  Daniel Bates  
 
+Attempt to fix the build following 
+(https://bugs.webkit.org/show_bug.cgi?id=166774)
+
+* dom/Document.cpp:
+(WebCore::Document::detachFromCachedFrame): Use ASSER_UNUSED() instead of ASSERT() since
+the parameter cachedFrame is unused in non-debug build.
+
+2017-02-10  Daniel Bates  
+
 Detach frame from document when entering page cache
 https://bugs.webkit.org/show_bug.cgi?id=166774
 


Modified: trunk/Source/WebCore/dom/Document.cpp (212173 => 212174)

--- trunk/Source/WebCore/dom/Document.cpp	2017-02-11 02:53:53 UTC (rev 212173)
+++ trunk/Source/WebCore/dom/Document.cpp	2017-02-11 03:09:10 UTC (rev 212174)
@@ -2191,8 +2191,8 @@
 
 void Document::detachFromCachedFrame(CachedFrameBase& cachedFrame)
 {
+ASSERT_UNUSED(cachedFrame, cachedFrame.view());
 ASSERT_WITH_SECURITY_IMPLICATION(cachedFrame.document() == this);
-ASSERT(cachedFrame.view());
 ASSERT(m_frame == ()->frame());
 ASSERT(m_pageCacheState == Document::InPageCache);
 detachFromFrame();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212182] trunk/Tools


2017-02-10

Thread
clopez

Title: [212182] trunk/Tools








Revision 212182
Author clo...@igalia.com
Date 2017-02-10 22:01:20 -0800 (Fri, 10 Feb 2017)


Log Message
REGRESSION(r182916) run-perf-tests never timeouts
https://bugs.webkit.org/show_bug.cgi?id=167626

Reviewed by Ryosuke Niwa.

The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
was beeing ignored because the driver was created with no_timeout=True
unconditionally.
This adds a new parameter --no-timeout (disabled by default), that
allows to use the driver with the expected timeout values.
It also passes --no-timeout to DRT/WTR to ensure that timeouts
are always controlled by the Python Driver.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
(PerfTest.run): Disabling timeout should be done when the Driver is created.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
(PerfTestsRunner._parse_args): Add a --no-timeout parameter.
(_run_tests_set): Pass the no-timeout parameter.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
(MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
(MainTest.test_parse_args): Test that the argument no-timeout.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (212181 => 212182)

--- trunk/Tools/ChangeLog	2017-02-11 05:49:23 UTC (rev 212181)
+++ trunk/Tools/ChangeLog	2017-02-11 06:01:20 UTC (rev 212182)
@@ -1,3 +1,30 @@
+2017-02-10  Carlos Alberto Lopez Perez  
+
+REGRESSION(r182916) run-perf-tests never timeouts
+https://bugs.webkit.org/show_bug.cgi?id=167626
+
+Reviewed by Ryosuke Niwa.
+
+The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
+was beeing ignored because the driver was created with no_timeout=True
+unconditionally.
+This adds a new parameter --no-timeout (disabled by default), that
+allows to use the driver with the expected timeout values.
+It also passes --no-timeout to DRT/WTR to ensure that timeouts
+are always controlled by the Python Driver.
+
+* Scripts/webkitpy/performance_tests/perftest.py:
+(PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
+(PerfTest.run): Disabling timeout should be done when the Driver is created.
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
+(PerfTestsRunner._parse_args): Add a --no-timeout parameter.
+(_run_tests_set): Pass the no-timeout parameter.
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
+(MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
+(MainTest.test_parse_args): Test that the argument no-timeout.
+
 2017-02-10  Daniel Bates  
 
 Detach frame from document when entering page cache


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (212181 => 212182)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2017-02-11 05:49:23 UTC (rev 212181)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2017-02-11 06:01:20 UTC (rev 212182)
@@ -122,12 +122,12 @@
 def prepare(self, time_out_ms):
 return True
 
-def _create_driver(self):
-return self._port.create_driver(worker_number=0, no_timeout=True)
+def _create_driver(self, no_timeout):
+return self._port.create_driver(worker_number=0, no_timeout=no_timeout)
 
-def run(self, time_out_ms):
+def run(self, time_out_ms, no_timeout=False):
 for _ in xrange(self._test_runner_count):
-driver = self._create_driver()
+driver = self._create_driver(no_timeout)
 try:
 if not self._run_with_driver(driver, time_out_ms):
 return None


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (212181 => 212182)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2017-02-11 05:49:23 UTC (rev 212181)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2017-02-11 06:01:20 UTC (rev 212182)
@@ -66,6 +66,9 @@
 self._host = Host()
 self._port = self._host.port_factory.get(self._options.platform, self._options)
 
+# Timeouts are controlled by the Python Driver, so DRT/WTR runs with no-timeout.
+



[webkit-changes] [212175] trunk/Source/WebKit/win


2017-02-10

Thread
dbates

Title: [212175] trunk/Source/WebKit/win








Revision 212175
Author dba...@webkit.org
Date 2017-02-10 19:32:40 -0800 (Fri, 10 Feb 2017)


Log Message
Attempt to fix the WinCairo 64-Bit Release build following 
(https://bugs.webkit.org/show_bug.cgi?id=166774)

Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.

* Interfaces/WebKit.idl:

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/WebKit.idl




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (212174 => 212175)

--- trunk/Source/WebKit/win/ChangeLog	2017-02-11 03:09:10 UTC (rev 212174)
+++ trunk/Source/WebKit/win/ChangeLog	2017-02-11 03:32:40 UTC (rev 212175)
@@ -1,5 +1,14 @@
 2017-02-10  Daniel Bates  
 
+Attempt to fix the WinCairo 64-Bit Release build following 
+(https://bugs.webkit.org/show_bug.cgi?id=166774)
+
+Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
+
+* Interfaces/WebKit.idl:
+
+2017-02-10  Daniel Bates  
+
 Detach frame from document when entering page cache
 https://bugs.webkit.org/show_bug.cgi?id=166774
 


Modified: trunk/Source/WebKit/win/Interfaces/WebKit.idl (212174 => 212175)

--- trunk/Source/WebKit/win/Interfaces/WebKit.idl	2017-02-11 03:09:10 UTC (rev 212174)
+++ trunk/Source/WebKit/win/Interfaces/WebKit.idl	2017-02-11 03:32:40 UTC (rev 212175)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2006-2010, 2015 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212176] trunk/Source/WebKit2


2017-02-10

Thread
simon . fraser

Title: [212176] trunk/Source/WebKit2








Revision 212176
Author simon.fra...@apple.com
Date 2017-02-10 19:59:06 -0800 (Fri, 10 Feb 2017)


Log Message
Zero out some WKWebView state in the case of a web content crash
https://bugs.webkit.org/show_bug.cgi?id=168157

Reviewed by Tim Horton.

Reset some bits of state in WKWebView when the web content process crashes, in
to try to avoid states that might cause the web view to stay blank.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _processDidExit]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (212175 => 212176)

--- trunk/Source/WebKit2/ChangeLog	2017-02-11 03:32:40 UTC (rev 212175)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-11 03:59:06 UTC (rev 212176)
@@ -1,3 +1,16 @@
+2017-02-10  Simon Fraser  
+
+Zero out some WKWebView state in the case of a web content crash
+https://bugs.webkit.org/show_bug.cgi?id=168157
+
+Reviewed by Tim Horton.
+
+Reset some bits of state in WKWebView when the web content process crashes, in
+to try to avoid states that might cause the web view to stay blank.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _processDidExit]):
+
 2017-02-10  Daniel Bates  
 
 Detach frame from document when entering page cache


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (212175 => 212176)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-11 03:32:40 UTC (rev 212175)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-11 03:59:06 UTC (rev 212176)
@@ -1302,6 +1302,13 @@
 _scrollViewBackgroundColor = WebCore::Color();
 _delayUpdateVisibleContentRects = NO;
 _hadDelayedUpdateVisibleContentRects = NO;
+
+_frozenVisibleContentRect = std::nullopt;
+_frozenUnobscuredContentRect = std::nullopt;
+
+_firstPaintAfterCommitLoadTransactionID = 0;
+_firstTransactionIDAfterPageRestore = 0;
+_resizeAnimationTransformTransactionID = std::nullopt;
 }
 
 - (void)_didCommitLoadForMainFrame






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes





[webkit-changes] [212180] trunk/Source/WTF


2017-02-10

Thread
mitz

Title: [212180] trunk/Source/WTF








Revision 212180
Author m...@apple.com
Date 2017-02-10 21:33:44 -0800 (Fri, 10 Feb 2017)


Log Message
[Xcode] WTF installs extra copies of two headers outside /usr/local/include/wtf
https://bugs.webkit.org/show_bug.cgi?id=168160

Reviewed by Sam Weinig.

* WTF.xcodeproj/project.pbxproj: Demoted OrdinalNumber.h MemoryFootprint.h from Private to
  Project.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WTF/ChangeLog (212179 => 212180)

--- trunk/Source/WTF/ChangeLog	2017-02-11 04:54:32 UTC (rev 212179)
+++ trunk/Source/WTF/ChangeLog	2017-02-11 05:33:44 UTC (rev 212180)
@@ -1,3 +1,13 @@
+2017-02-10  Dan Bernstein  
+
+[Xcode] WTF installs extra copies of two headers outside /usr/local/include/wtf
+https://bugs.webkit.org/show_bug.cgi?id=168160
+
+Reviewed by Sam Weinig.
+
+* WTF.xcodeproj/project.pbxproj: Demoted OrdinalNumber.h MemoryFootprint.h from Private to
+  Project.
+
 2017-02-10  Commit Queue  
 
 Unreviewed, rolling out r212139.


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (212179 => 212180)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-02-11 04:54:32 UTC (rev 212179)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-02-11 05:33:44 UTC (rev 212180)
@@ -93,7 +93,7 @@
 		1469419C16EAB10A0024E146 /* AutodrainedPool.h in Headers */ = {isa = PBXBuildFile; fileRef = 1469419A16EAB10A0024E146 /* AutodrainedPool.h */; };
 		1469419D16EAB10A0024E146 /* AutodrainedPoolMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */; };
 		149EF16316BBFE0D000A4331 /* TriState.h in Headers */ = {isa = PBXBuildFile; fileRef = 149EF16216BBFE0D000A4331 /* TriState.h */; settings = {ATTRIBUTES = (); }; };
-		14E785E81DFB330100209BD1 /* OrdinalNumber.h in Headers */ = {isa = PBXBuildFile; fileRef = 14E785E71DFB330100209BD1 /* OrdinalNumber.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		14E785E81DFB330100209BD1 /* OrdinalNumber.h in Headers */ = {isa = PBXBuildFile; fileRef = 14E785E71DFB330100209BD1 /* OrdinalNumber.h */; };
 		14F3B0F715E45E4600210069 /* SaturatedArithmetic.h in Headers */ = {isa = PBXBuildFile; fileRef = 14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */; settings = {ATTRIBUTES = (); }; };
 		1A1D8B9C173186CE00141DA4 /* FunctionDispatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */; };
 		1A1D8B9E1731879800141DA4 /* FunctionDispatcher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */; };
@@ -337,7 +337,7 @@
 		A8A47487151A825B004123FF /* WTFThreadData.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4737B151A825B004123FF /* WTFThreadData.h */; };
 		A8A4748C151A8264004123FF /* config.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4748B151A8264004123FF /* config.h */; };
 		AD7C434B1DD2A4A70026888B /* Expected.h in Headers */ = {isa = PBXBuildFile; fileRef = AD7C434A1DD2A4A70026888B /* Expected.h */; };
-		ADF2CE661E39F106006889DB /* MemoryFootprint.h in Headers */ = {isa = PBXBuildFile; fileRef = ADF2CE641E39F106006889DB /* MemoryFootprint.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		ADF2CE661E39F106006889DB /* MemoryFootprint.h in Headers */ = {isa = PBXBuildFile; fileRef = ADF2CE641E39F106006889DB /* MemoryFootprint.h */; };
 		ADF2CE671E39F106006889DB /* MemoryFootprint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = ADF2CE651E39F106006889DB /* MemoryFootprint.cpp */; };
 		B38FD7BD168953E80065C969 /* FeatureDefines.h in Headers */ = {isa = PBXBuildFile; fileRef = B38FD7BC168953E80065C969 /* FeatureDefines.h */; };
 		C4F8A93719C65EB400B2B15D /* Stopwatch.h in Headers */ = {isa = PBXBuildFile; fileRef = C4F8A93619C65EB400B2B15D /* Stopwatch.h */; };
@@ -1453,6 +1453,7 @@
 A8A473E8151A825B004123FF /* MathExtras.h in Headers */,
 A8A473EA151A825B004123FF /* MD5.h in Headers */,
 CD5497AD15857D0300B5BC30 /* MediaTime.h in Headers */,
+ADF2CE661E39F106006889DB /* MemoryFootprint.h in Headers */,
 A8A473EB151A825B004123FF /* MessageQueue.h in Headers */,
 A8A473ED151A825B004123FF /* MetaAllocator.h in Headers */,
 A8A473EE151A825B004123FF /* MetaAllocatorHandle.h in Headers */,
@@ -1500,7 +1501,6 @@
 A8A4741C151A825B004123FF /* RefPtr.h in Headers */,
 A8A4741E151A825B004123FF /* RetainPtr.h in Headers */,
 2CDED0F418115C85004DBA70 /* RunLoop.h in Headers */,
-ADF2CE661E39F106006889DB /* MemoryFootprint.h in Headers */,
 1469419216EAAF6D0024E146 /* RunLoopTimer.h in Headers */,
 A5098B001C169E0700087797 /* SandboxSPI.h in Headers */,
 14F3B0F715E45E4600210069 /* SaturatedArithmetic.h in Headers */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org




[webkit-changes] [212181] trunk


2017-02-10

Thread
commit-queue

Title: [212181] trunk








Revision 212181
Author commit-qu...@webkit.org
Date 2017-02-10 21:49:23 -0800 (Fri, 10 Feb 2017)


Log Message
[WebIDL] Cleanup XMLHttpRequest's bindings
https://bugs.webkit.org/show_bug.cgi?id=168067

Patch by Sam Weinig  on 2017-02-10
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt:
* web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
Update results now that we pass.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::jsOwnedStringOrNull): Deleted.
* bindings/js/JSDOMBinding.h:
Remove jsOwnedStringOrNull and inline it into it's one use
in JSXMLHttpRequestCustom.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::responseText):
(WebCore::SendFunctor::SendFunctor): Deleted.
(WebCore::SendFunctor::line): Deleted.
(WebCore::SendFunctor::column): Deleted.
(WebCore::SendFunctor::url): Deleted.
(WebCore::SendFunctor::operator()): Deleted.
(WebCore::JSXMLHttpRequest::send): Deleted.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
* xml/XMLHttpRequest.h:
Remove custom send, replacing it with a single send implementation that
takes a variant.

* xml/XMLHttpRequest.idl:
Cleanup the IDL to better match the spec. Update correct types where trivial.

LayoutTests:

* http/tests/xmlhttprequest/set-bad-headervalue.html:
Update test now that we throw the correct exceptions.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/xmlhttprequest/set-bad-headervalue.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (212180 => 212181)

--- trunk/LayoutTests/ChangeLog	2017-02-11 05:33:44 UTC (rev 212180)
+++ trunk/LayoutTests/ChangeLog	2017-02-11 05:49:23 UTC (rev 212181)
@@ -1,3 +1,13 @@
+2017-02-10  Sam Weinig  
+
+[WebIDL] Cleanup XMLHttpRequest's bindings
+https://bugs.webkit.org/show_bug.cgi?id=168067
+
+Reviewed by Chris Dumez.
+
+* http/tests/xmlhttprequest/set-bad-headervalue.html:
+Update test now that we throw the correct exceptions.
+
 2017-02-10  Chris Dumez  
 
 document.origin doesn't match spec


Modified: trunk/LayoutTests/http/tests/xmlhttprequest/set-bad-headervalue.html (212180 => 212181)

--- trunk/LayoutTests/http/tests/xmlhttprequest/set-bad-headervalue.html	2017-02-11 05:33:44 UTC (rev 212180)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/set-bad-headervalue.html	2017-02-11 05:49:23 UTC (rev 212181)
@@ -15,21 +15,21 @@
   var client = new XMLHttpRequest()
   client.open("GET", "...")
   if (expectError)
-  assert_throws("SyntaxError", function() { client.setRequestHeader("x-test", value) }, ' given value ' + value+', ')
+  assert_throws(expectError, function() { client.setRequestHeader("x-test", value) }, ' given value ' + value+', ')
   else
   client.setRequestHeader("x-test", value)  
   })
   }
 
-  try_value("t\rt", true)
-  try_value("t\nt", true)
-  try_value("ﾃｽﾄ", true)
-  try_value("t\bt", true)
-  try_value("t\vt", true)
-  try_value("t\tt", false)
-  try_value("t t", false)
-  try_value("\xd0\xa1", false)
-  try_value("\x7f", true)
+  try_value("t\rt", {name:'SyntaxError'})
+  try_value("t\nt", {name:'SyntaxError'})
+  try_value("ﾃｽﾄ", {name:'TypeError'})
+  try_value("t\bt", {name:'SyntaxError'})
+  try_value("t\vt", {name:'SyntaxError'})
+  try_value("t\tt")
+  try_value("t t")
+  try_value("\xd0\xa1")
+  try_value("\x7f", {name:'SyntaxError'})
   test(function() {
 var client = new XMLHttpRequest()
 client.open("GET", "...")


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212180 => 212181)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-11 05:33:44 UTC (rev 212180)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-11 05:49:23 UTC (rev 212181)
@@ -1,3 +1,14 @@
+2017-02-10  Sam Weinig  
+
+[WebIDL] Cleanup XMLHttpRequest's bindings
+https://bugs.webkit.org/show_bug.cgi?id=168067
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt:
+* web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
+Update results now 



[webkit-changes] [212177] trunk


2017-02-10

Thread
sbarati

Title: [212177] trunk








Revision 212177
Author sbar...@apple.com
Date 2017-02-10 20:05:06 -0800 (Fri, 10 Feb 2017)


Log Message
Object allocation sinking phase doesn't properly handle control flow when emitting a PutHint of a materialized object into a PromotedHeapLocation of a still sunken object
https://bugs.webkit.org/show_bug.cgi?id=168140


Reviewed by Filip Pizlo.

JSTests:

* stress/allocation-sinking-puthint-control-flow.js: Added.
(e):
(bar):
(let.y):
(else.let.y):
(baz):
(foo):
(catch):

Source/_javascript_Core:

This patch fixes a bug in allocation sinking phase where
we don't properly handle control flow when materializing
an object and also PutHinting that materialization into
a still sunken object. We were performing the PutHint
for the materialization at the point of materialization,
however, we may have materialized along both edges
of a control flow diamond, in which case, we need to
also PutHint at the join point. Consider this program:

```
bb#0:
b: PhantomActivation()
a: PhantomNewFunction()
c: PutHint(@a, @b, ActivationLoc)
Branch(#1, #2)

bb#1:
d: MaterializeActivation()
e: PutHint(@a, @d, ActivationLoc)
f: Upsilon(@d, ^p)
Jump(#3)

bb#2:
g: MaterializeActivation()
h: PutHint(@a, @g, ActivationLoc)
i: Upsilon(@d, ^p)
Jump(#3)

bb#3:
p: Phi()
// What is PromotedHeapLocation(@a, ActivationLoc) here?
// What would we do if we exited?
```
Before this patch, we didn't perform a PutHint of the Phi.
However, we need to, otherwise when exit, we won't know
the value of PromotedHeapLocation(@a, ActivationLoc)

The program we need then, for correctness, is this:
```
bb#0:
b: PhantomActivation()
a: PhantomNewFunction()
c: PutHint(@a, @b, ActivationLoc)
Branch(#1, #2)

bb#1:
d: MaterializeActivation()
e: PutHint(@a, @d, ActivationLoc)
f: Upsilon(@d, ^p)
Jump(#3)

bb#2:
g: MaterializeActivation()
h: PutHint(@a, @g, ActivationLoc)
i: Upsilon(@d, ^p)
Jump(#3)

bb#3:
p: Phi()
j: PutHint(@a, @p, ActivationLoc)
```

This patch makes it so that we emit the necessary PutHint at node `j`.
I've also added more validation to the OSRAvailabilityAnalysisPhase
to catch this problem during validation.

* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLOperations.cpp


Added Paths

trunk/JSTests/stress/allocation-sinking-puthint-control-flow.js




Diff

Modified: trunk/JSTests/ChangeLog (212176 => 212177)

--- trunk/JSTests/ChangeLog	2017-02-11 03:59:06 UTC (rev 212176)
+++ trunk/JSTests/ChangeLog	2017-02-11 04:05:06 UTC (rev 212177)
@@ -1,3 +1,20 @@
+2017-02-10  Saam Barati  
+
+Object allocation sinking phase doesn't properly handle control flow when emitting a PutHint of a materialized object into a PromotedHeapLocation of a still sunken object
+https://bugs.webkit.org/show_bug.cgi?id=168140
+
+
+Reviewed by Filip Pizlo.
+
+* stress/allocation-sinking-puthint-control-flow.js: Added.
+(e):
+(bar):
+(let.y):
+(else.let.y):
+(baz):
+(foo):
+(catch):
+
 2017-02-09  Mark Lam  
 
 B3::Procedure::deleteOrphans() should neutralize upsilons with dead phis.


Added: trunk/JSTests/stress/allocation-sinking-puthint-control-flow.js (0 => 212177)

--- trunk/JSTests/stress/allocation-sinking-puthint-control-flow.js	(rev 0)
+++ trunk/JSTests/stress/allocation-sinking-puthint-control-flow.js	2017-02-11 04:05:06 UTC (rev 212177)
@@ -0,0 +1,41 @@
+function e() { }
+noInline(e);
+
+function foo(b, c, d) {
+let x;
+function bar() { return x; }
+if (b) {
+let y = function() { return x; }
+} else {
+let y = function() { return x; }
+}
+
+if (c) {
+function baz() { }
+if (b) {
+let y = function() { return x; }
+e(y);
+} else {
+let y = function() { return x; }
+e(y);
+}
+if (d)
+d();
+e(baz);
+}
+
+}
+noInline(foo);
+
+for (let i = 0; i < 10; i++) {
+foo(!!(i % 2), true, false);
+}
+
+let threw = false;
+try {
+foo(true, true, true);
+} catch(e) {
+threw = true;
+}
+if (!threw)
+throw new Error("Bad test")


Modified: trunk/Source/_javascript_Core/ChangeLog (212176 => 212177)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-11 03:59:06 UTC (rev 212176)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-11 04:05:06 UTC (rev 212177)
@@ -1,3 +1,83 @@
+2017-02-10  Saam Barati  
+
+Object allocation sinking phase doesn't properly handle control flow when emitting 



[webkit-changes] [212178] trunk


2017-02-10

Thread
cdumez

Title: [212178] trunk








Revision 212178
Author cdu...@apple.com
Date 2017-02-10 20:40:38 -0800 (Fri, 10 Feb 2017)


Log Message
document.origin doesn't match spec
https://bugs.webkit.org/show_bug.cgi?id=168022

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline test now that document.origin has the right format.

* web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:

Source/WebCore:

Update document.origin to return the origin in the expected format:
- https://dom.spec.whatwg.org/#dom-document-origin

Change: "https_webkit.org_0 -> "https://webkit.org".

The new behavior matches Firefox and Chrome.

No new tests, updated existing tests.

* dom/Document.cpp:
(WebCore::Document::origin):

LayoutTests:

* http/tests/media/media-stream/enumerate-devices-source-id-persistent.html:
Fix test that was passing only because the document.origin would never match the
expected string:
- Move idCounts to the global scope has the handler function is called 3 times
  and we need to properly update the same idCounts object in all 3 calls.
- Fix initialization of idCounts to start at 1, not 0. Otherwise, idCounts[uniqueID]
  is 0 instead of 1.
- Use a Map instead of an array since the ids are UUID strings, not integers.
- Fix check for non-unique ids, was idCounts[deviceId] == 1 instead of
 idCounts[deviceId] != 1.

* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html:
* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html:
* http/tests/ssl/iframe-upgrade.https.html:
Update / rebaseline now that document.origin has the right format.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id-persistent.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html
trunk/LayoutTests/http/tests/ssl/iframe-upgrade.https.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (212177 => 212178)

--- trunk/LayoutTests/ChangeLog	2017-02-11 04:05:06 UTC (rev 212177)
+++ trunk/LayoutTests/ChangeLog	2017-02-11 04:40:38 UTC (rev 212178)
@@ -1,3 +1,26 @@
+2017-02-10  Chris Dumez  
+
+document.origin doesn't match spec
+https://bugs.webkit.org/show_bug.cgi?id=168022
+
+Reviewed by Sam Weinig.
+
+* http/tests/media/media-stream/enumerate-devices-source-id-persistent.html:
+Fix test that was passing only because the document.origin would never match the
+expected string:
+- Move idCounts to the global scope has the handler function is called 3 times
+  and we need to properly update the same idCounts object in all 3 calls.
+- Fix initialization of idCounts to start at 1, not 0. Otherwise, idCounts[uniqueID]
+  is 0 instead of 1.
+- Use a Map instead of an array since the ids are UUID strings, not integers.
+- Fix check for non-unique ids, was idCounts[deviceId] == 1 instead of
+ idCounts[deviceId] != 1.
+
+* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html:
+* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html:
+* http/tests/ssl/iframe-upgrade.https.html:
+Update / rebaseline now that document.origin has the right format.
+
 2017-02-10  Simon Fraser  
 
 REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure


Modified: trunk/LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id-persistent.html (212177 => 212178)

--- trunk/LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id-persistent.html	2017-02-11 04:05:06 UTC (rev 212177)
+++ trunk/LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id-persistent.html	2017-02-11 04:40:38 UTC (rev 212178)
@@ -7,6 +7,7 @@