[weld-issues] [JBoss JIRA] (CDITCK-607) EnterpriseBeanDiscoveryTest assumes that AnnotatedType class must reflect the @Local interface, but this is not backed by the spec

2018-02-07 Thread Mark Struberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Struberg created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 CDI TCK /  CDITCK-607  
 
 
  EnterpriseBeanDiscoveryTest assumes that AnnotatedType class must reflect the @Local interface, but this is not backed by the spec   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 2.0.3.Final  
 
 
Assignee: 
 Matej Novotny  
 
 
Components: 
 Tests  
 
 
Created: 
 07/Feb/18 12:57 PM  
 
 
Fix Versions: 
 TBD  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Mark Struberg  
 

  
 
 
 
 

 
 EnterpriseBeanDiscoveryTest assumes that AnnotatedType class must reflect the @Local interface, but this is not backed by the spec. The TCK tests in question all refer to 26.1 and 26.2, but this dose nowhere even mention @Local. Furthermore the old spec didn't define this but the 'type of the EJB class which is parsed'  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 
 

[weld-issues] [JBoss JIRA] (CDITCK-608) LongRunningConversationLifecycleEventTest and others wrongly assume that Session get destroyed at shutdown

2018-02-07 Thread Mark Struberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Struberg created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 CDI TCK /  CDITCK-608  
 
 
  LongRunningConversationLifecycleEventTest and others wrongly assume that Session get destroyed at shutdown   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 2.0.3.Final  
 
 
Assignee: 
 Matej Novotny  
 
 
Components: 
 Tests  
 
 
Created: 
 07/Feb/18 4:06 PM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Mark Struberg  
 

  
 
 
 
 

 
 Some tests wrongly assume that the Servlet Sessions will all get destroyed during shutdown. But that is not necessarily the case. An undeploy or shudown might passivate the Session to a storage and pick it up later again.  This is perfectly valid from a Servlet perspective and CDI must follow those rules.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
  

[weld-issues] [JBoss JIRA] (WELD-2458) OSGi - import javax.ejb optionally

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2458  
 
 
  OSGi - import javax.ejb optionally   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Fix Version/s: 
 3.0.3.Final  
 
 
Fix Version/s: 
 2.4.7.Final  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2458) OSGi - import javax.ejb optionally

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated  WELD-2458  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2458  
 
 
  OSGi - import javax.ejb optionally   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Status: 
 Pull Request Sent Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2459) Ignore module-info during discovery

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated  WELD-2459  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2459  
 
 
  Ignore module-info during discovery   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Status: 
 Open Pull Request Sent  
 
 
Git Pull Request: 
 https://github.com/weld/core/pull/1788  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (CDITCK-606) org.jboss.cdi.tck.tests.deployment.discovery.enterprise.annotated.EnterpriseDefaultBeanDiscoveryModeTest should fail because of ambiguous beans

2018-02-07 Thread Mark Struberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Struberg created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 CDI TCK /  CDITCK-606  
 
 
  org.jboss.cdi.tck.tests.deployment.discovery.enterprise.annotated.EnterpriseDefaultBeanDiscoveryModeTest should fail because of ambiguous beans   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 2.0.3.Final  
 
 
Assignee: 
 Matej Novotny  
 
 
Components: 
 Tests  
 
 
Created: 
 07/Feb/18 6:10 AM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Mark Struberg  
 

  
 
 
 
 

 
 org.jboss.cdi.tck.tests.deployment.discovery.enterprise.annotated.EnterpriseDefaultBeanDiscoveryModeTest contains a class AppleTrea which has 2 producer for the same class+qualifier plus only one disposal method.  
 
 
 
 
 @Produces  
 
 
 static Apple apple = new Apple();  
 
 
   
 
 
 @Produces  
 
 
   

[weld-issues] [JBoss JIRA] (CDITCK-606) org.jboss.cdi.tck.tests.deployment.discovery.enterprise.annotated.EnterpriseDefaultBeanDiscoveryModeTest should fail because of ambiguous beans

2018-02-07 Thread Matej Novotny (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny resolved as Rejected  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 This test verifies just the discovery of producer/disposer/observer method and producer field on an EJB, not injection itself. 

So we have one injection point (Apple) but...
 There is no injection point in that test. Hence there is no AmbiguousResolutionException. Note that for disposer methods, the parameter annotated @Disposes is not an injection point. Looking at spec 3.4.2: Declaring disposer method: 

A disposer method may be declared by annotating a parameter @javax.enterprise.inject.Disposes. That parameter is the disposed parameter. Qualifiers may be declared by annotating the disposed parameter
 And a bit further it adds: 

In addition to the disposed parameter, a disposer method may declare additional parameters, which may also specify qualifiers. These additional parameters are injection points.
 One of the reasons, why it cannot be an IP is (spec link): 

A disposer method may resolve to multiple producer methods or producer fields declared by the bean class
  
 

  
 
 
 
 

 
 CDI TCK /  CDITCK-606  
 
 
  org.jboss.cdi.tck.tests.deployment.discovery.enterprise.annotated.EnterpriseDefaultBeanDiscoveryModeTest should fail because of ambiguous beans   
 

  
 
 
 
 

 
Change By: 
 Matej Novotny  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Rejected  
 

  
 
 
 
 

 
 
 

 
 

[weld-issues] [JBoss JIRA] (WELD-2463) ProbeObserversTest relies on a specific java.lang.annotation.Annotation.toString() implementation

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2463  
 
 
  ProbeObserversTest relies on a specific java.lang.annotation.Annotation.toString() implementation   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Component/s: 
 Development Tools (Probe)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2463) ProbeObserversTest relies on a specific java.lang.annotation.Annotation.toString() implementation

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2463  
 
 
  ProbeObserversTest relies on a specific java.lang.annotation.Annotation.toString() implementation   
 

  
 
 
 
 

 
Issue Type: 
  Sub-task  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 07/Feb/18 8:32 AM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Martin Kouba  
 

  
 
 
 
 

 
 It seems that the impl differs in Oracle JDK 8 and Oracle JDK 9. We should either modify Probe to build annotation string representation (regardless of JDK version/impl) instead of using Annotation.toString() or modify the test.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 
  

[weld-issues] [JBoss JIRA] (WELD-2462) Migrate from findbugs to spotbugs

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated  WELD-2462  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2462  
 
 
  Migrate from findbugs to spotbugs   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Status: 
 Pull Request Sent Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2459) Ignore module-info during discovery

2018-02-07 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated  WELD-2459  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2459  
 
 
  Ignore module-info during discovery   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Status: 
 Pull Request Sent Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues