[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-12 Thread Baloch007 
Baloch007 added a comment.
Yes it's correct :-)


In T198818#4417946, @Jdlrobson wrote:
@Baloch007 could you please confirm this is working as expected on our test server?:
 https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en
 https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=ps


@Jdlrobson Yes it's correct :-)TASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Baloch007Cc: gerritbot, Jdlrobson, jhsoby, jeblad, Olasyar, Aklapper, Baloch007, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread Jdlrobson 
Jdlrobson added a comment.
@Baloch007 could you please confirm this is working as expected on our test server?:
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=psTASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, Jdlrobson, jhsoby, jeblad, Olasyar, Aklapper, Baloch007, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread gerritbot 
gerritbot added a comment.
Change 445239 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Banners should display same in RTL or LTR

https://gerrit.wikimedia.org/r/445239TASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdlrobson, jhsoby, jeblad, Olasyar, Aklapper, Baloch007, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread gerritbot 
gerritbot added a comment.
Change 445239 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikidataPageBanner@master] Use margin-right rather than margin-left on RTL wikis

https://gerrit.wikimedia.org/r/445239TASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdlrobson, jhsoby, jeblad, Olasyar, Aklapper, Baloch007, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Winter, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Huji, Amire80, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs