[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Arian_Bozorg]

Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg added a comment.


  Thanks so much!

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Arian_Bozorg
Cc: Arian_Bozorg, noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, 
Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a comment.


  In T329488#8782147 , 
@Sarai-WMDE wrote:
  
  > Keyboard navigation appears to work correctly. The specified keyboard 
shortcuts 

 were tested in Netlify (https://894028--clicky-sparqly.netlify.app/) using 
Chrome v112, Safari v15.6 and Firefox v111 on macOS 12.5.1.
  >
  > Nevertheless, the tested version of the component doesn't allow selecting 
an option from the menu on click (see gif below). In all browsers, the menu 
also presents a scroll bar that shouldn't be there (this is a known issue).
  >
  > These issues should probably be reported in separate tickets (in case they 
don't exist yet).
  
  The problem detected was solved as part of 
{https://phabricator.wikimedia.org/T333932} and thus verification can be 
considered done.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T329488#8782147 , 
@Sarai-WMDE wrote:
  
  > Nevertheless, the tested version of the component doesn't allow selecting 
an option from the menu on click (see gif below).
  
  Ah, I think that’s a special case of T333932: Query Builder language selector 
closes too eagerly on blur  
(clicking an option blurs the input and thus instantly closes the query 
builder).

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Lucas_Werkmeister_WMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Keyboard navigation appears to work correctly. The specified keyboard 
shortcuts 

 were tested in Netlify (https://894028--clicky-sparqly.netlify.app/) using 
Chrome v112, Safari v15.6 and Firefox v111 on macOS 12.5.1.
  
  Nevertheless, the tested version of the component doesn't allow selecting an 
option from the menu on click (see gif below). In all browsers, the menu also 
presents a scroll bar that shouldn't be there (this is a known issue).
  
  F36951731: Apr-14-2023 16-56-06.gif 

  
  These issues should probably be reported in separate tickets (in case they 
don't exist yet).

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  In T329488#8771553 , 
@guergana.tzatchkova wrote:
  
  > Still missing: Resetting the highlightedIndex from the resetting the scroll 
too.
  
  This issue will be fixed in a separate ticket: T334664 


TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  In T329488#8776625 , 
@ItamarWMDE wrote:
  
  > I think it would be best to open up new tickets to be triaged later as a 
way forward. While it's not perfect, IMO this is good enough as an early 
version, and we can deal with the loose ends and improvements later on if 
needed.
  
  Sounds like a very good solution. @ItamarWMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a comment.
Restricted Application added a project: User-ItamarWMDE.


  In T329488#8776625 , 
@ItamarWMDE wrote:
  
  > I think it would be best to open up new tickets to be triaged later as a 
way forward. While it's not perfect, IMO this is good enough as an early 
version, and we can deal with the loose ends and improvements later on if 
needed.
  
  Agreeing with Itamar. The current behavior is good enough, and the detected 
improvements should be triaged as separate tickets for simplification.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[ItamarWMDE]

ItamarWMDE added a comment.


  I think it would be best to open up new tickets to be triaged later as a way 
forward. While it's not perfect, IMO this is good enough as an early version, 
and we can deal with the loose ends and improvements later on if needed.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, ItamarWMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Still missing: Resetting the highlightedIndex from the resetting the scroll 
too.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.


  Thanks for your comments @guergana.tzatchkova and @LucasWerkmeister. TL;DR: 
yes, keyboard highlight should be reset on blur.
  
  > If one language is highlighted [via keyboard] and the menu is closed and 
opened again, that same language is still hightlighted. Do we want this 
behavior or when opening the menu again the highlight has to be reset?
  
  There's no need to preserve keyboard highlight in this scenario. So yes, the 
highlight should be reset on blur.
  
  > I think another option would be to (also?) reset the highlighted language 
on input. Currently, typing into the input field highlights the first available 
language.
  
  If I'm understanding correctly: yes. If the input is dirty and the user 
utilizes the keyboard to navigate to another option, that highlight should be 
reset too: when the component is opened again, the highlight should be placed 
in the first language on the list.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: LucasWerkmeister, noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, 
Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a comment.


  Change 906584 **merged** by jenkins-bot:
  
  [wikidata/query-builder@master] Add browser tests for keyboard navigation of 
Language Selector
  
  https://gerrit.wikimedia.org/r/906584

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, gerritbot
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a comment.


  Change 906584 had a related patch set uploaded (by Guergana Tzatchkova; 
author: Guergana Tzatchkova):
  
  [wikidata/query-builder@master] Add browser tests for keyboard navigation of 
Language Selector
  
  https://gerrit.wikimedia.org/r/906584

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a comment.


  Change 894028 **merged** by jenkins-bot:
  
  [wikidata/query-builder@master] Add Keyboard navigation to the language 
selector
  
  https://gerrit.wikimedia.org/r/894028

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think another option would be to (also?) reset the highlighted language on 
input. Currently, typing into the input field highlights the first available 
language.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  @Sarai-WMDE we have a question here. 
  This is the deploy of this ticket here: 
https://894028--clicky-sparqly.netlify.app/
  Once the the arrows have highlighted the languages and changed the index, 
there is always something selected. If one language is highlighted and the menu 
is closed and opened again, that same language is still hightlighted. Do you 
want this behavior or when opened the highlight has to be reset?

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[noarave]

noarave moved this task from Peer Review to Todo/Backlog on the Wikidata Dev 
Team (Sprint-∞) board.
noarave added a comment.


  I think this thing is as far as it could go functionality wise. Browser tests 
might make sense. i've unassigned myself for now so that someone else could 
pick this up as i am not around in the next couple of weeks.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[noarave]

noarave removed noarave as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Perfect! 💯

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Alright, thanks! We already implemented looping in one direction in the 
change – now we know that’s correct, and also we should “close the loop” and do 
it in the other direction too.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Sarai-WMDE]

Sarai-WMDE added a subscriber: LucasWerkmeister.
Sarai-WMDE added a comment.


  Thanks for your questions, @LucasWerkmeister 🙏🏻  Answering inline:
  
  > According to the Figma specs, “When the focus is placed on the first option 
of the menu, [the up arrow key] moves the focus back to the input.” To me this 
sounds like focus is either on the input or on one of the options; but that’s 
not what we have in the current patch set by Noa (Netlify 
): There, the text input is always 
focused, and additionally one of the options may be highlighted. Should we 
change it so that the text input loses focus when the arrow keys are used?
  
  The current implementation is better than what is suggested in the design 
specs. I think I incorrectly assumed that the input would lose focus, but the 
fact that this is not the case is better behavior. Nothing to change.
  
  > Also, is there anything special that should happen to the down arrow key, 
or should that just have no effect when the last entry is already selected?
  
  I had doubts here (connected to the first point). Now that it's clear that 
the focus can remain within the menu instead of moving back to the input, it 
would be ideal if we could make the menu navigation loop. Meaning:
  
  - If the highlight/focus is placed on the last item on the menu, pressing the 
down arrow key will move the focus back to the first menu option.
  - If the highlight/focus is placed on the first item on the menu, pressing 
the up arrow key will move the focus back to the last menu option.
  
  That would be the recommendation (see an example in Codex 
), but let 
me know if this is feasible or whether it arises any other questions.
  
  Thanks again!

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: LucasWerkmeister, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, 
ItamarWMDE, guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T329488#8742267 , 
@gerritbot wrote:
  
  > Change 904555 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  >
  > [mediawiki/extensions/EntitySchema@master] More consistently recommend 
mwcli in README instead of fresh-node
  >
  > https://gerrit.wikimedia.org/r/904555
  
  (Disregard, wrong task ID.)
  
  ---
  
  Question for @Sarai-WMDE: According to the Figma specs, “When the focus is 
placed on the first option of the menu, [the up arrow key] moves the focus back 
to the input.” To me this sounds like focus is either on the input or on one of 
the options; but that’s not what we have in the current patch set by Noa 
(Netlify ): There, the text input 
is always focused, and additionally one of the options may be highlighted. 
Should we change it so that the text input loses focus when the arrow keys are 
used?
  
  Also, is there anything special that should happen to the down arrow key, or 
should that just have no effect when the last entry is already selected?

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, 
guergana.tzatchkova, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a comment.


  Change 904555 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  
  [mediawiki/extensions/EntitySchema@master] More consistently recommend mwcli 
in README instead of fresh-node
  
  https://gerrit.wikimedia.org/r/904555

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[gerritbot]

gerritbot added a comment.


  Change 894028 had a related patch set uploaded (by Noa wmde; author: Noa 
wmde):
  
  [wikidata/query-builder@master] Add Keyboard navigation to the language 
selector
  
  https://gerrit.wikimedia.org/r/894028

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[noarave]

noarave claimed this task.
Restricted Application added a project: User-Noarave.

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

[guergana.tzatchkova]

guergana.tzatchkova renamed this task from "Query Builder: Add keyboard 
navigaton to Language Selector Component" to "Query Builder: Add keyboard 
navigation to Language Selector Component".

TASK DETAIL
  https://phabricator.wikimedia.org/T329488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org