[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

Michel Dänzer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Michel Dänzer  ---
Thanks for the report, fixed in Git master:

https://cgit.freedesktop.org/xorg/driver/xf86-video-amdgpu/commit/?id=981bac185cfd74ae50dffc28f57cf34623a9595f

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

--- Comment #7 from timo...@gmail.com ---
(In reply to Michel Dänzer from comment #6)
> Did you also remove the static keyword from the function declaration
> src/amdgpu_kms.c? If not, that might explain why the patch didn't work.

Hmm, I thought I did. But I guess it probably would only fail on load saying it
can't find the symbol, and I probably stupidly didn't properly verify what the
output was...

Really sorry about the sloppiness on my side.

> BTW, does the Virtual line serve any purpose? Xorg seems to resize the
> screen to fit the rotated output anyway for me.

Probably was need at some point a long time ago, and was simply leftover.
Right now doesn't seem to be necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

Michel Dänzer  changed:

   What|Removed |Added

 Attachment #130373|0   |1
is obsolete||

--- Comment #6 from Michel Dänzer  ---
Comment on attachment 130373
  --> https://bugs.freedesktop.org/attachment.cgi?id=130373
Bail from drmmode_set_mode_major if it's called too early

(In reply to timon37 from comment #5)
> Patch didn't help. Actually it initially didn't compile for me
> (AMDGPUWindowExposures_oneshot was undefined)

Oops, sorry, I thought I'd at least compile-tested the patch, but I obviously
hadn't.

> but I added a prototype for it.

Did you also remove the static keyword from the function declaration
src/amdgpu_kms.c? If not, that might explain why the patch didn't work.


> But when I comment out the "Virtual 4096 4096" line it consistently works,
> and if then uncomment it it crashes.

Thanks, this allowed me to reproduce the problem.
https://patchwork.freedesktop.org/patch/145922/ fixes it for me.

BTW, does the Virtual line serve any purpose? Xorg seems to resize the screen
to fit the rotated output anyway for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

--- Comment #5 from timo...@gmail.com ---
Patch didn't help. Actually it initially didn't compile for me
(AMDGPUWindowExposures_oneshot was undefined) but I added a prototype for it.

Indeed DRI3 didn't seem to affect it on further tries (not sure what happened
originally).

But when I comment out the "Virtual 4096 4096" line it consistently works, and
if then uncomment it it crashes.

To clarify the crash is because pScreen->root is 0. It doesn't crash without
rotation because that's not queried in the else case (I verified that it was
also 0 without screen rotation).

And I'm guessing it's not 0 when the Virtual setting isn't used.
Alternatively the code never reaches that point, I can try to verify that or
anything else you want. Though hopefully you'll be able to repro it now?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

--- Comment #4 from Michel Dänzer  ---
Created attachment 130373
  --> https://bugs.freedesktop.org/attachment.cgi?id=130373=edit
Bail from drmmode_set_mode_major if it's called too early

(In reply to timon37 from comment #3)
> Huh, it also seems to work after deleting the: Option "DRI" "3"

That must be luck, DRI3 should be enabled by default anyway.

I can't seem to reproduce the problem. It looks like maybe crtc->enabled isn't
always initialized to FALSE in drmmode_xf86crtc_resize at this point (valgrind
doesn't complain about any access to uninitialized memory though).

Does this patch avoid the problem for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

--- Comment #3 from timo...@gmail.com ---
Created attachment 130327
  --> https://bugs.freedesktop.org/attachment.cgi?id=130327=edit
xorg.conf that resulted in the crash

Huh, it also seems to work after deleting the: Option "DRI" "3"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

--- Comment #2 from Michel Dänzer  ---
Please attach the /etc/X11/xorg.conf file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

Michel Dänzer  changed:

   What|Removed |Added

 Attachment #130307|text/x-log  |text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati

[Bug 100276] xf86-video-amdgpu-1.3.0 segfaults with a rotated screen (regression caused by commit ad53635af1)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=100276

timo...@gmail.com changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
xorg-driver-ati mailing list
xorg-driver-ati@lists.x.org
https://lists.x.org/mailman/listinfo/xorg-driver-ati