[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241290#comment-14241290 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1988 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1988/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241232#comment-14241232 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #38 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/38/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java * hadoop-yarn-project/CHANGES.txt > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241196#comment-14241196 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #34 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/34/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241167#comment-14241167 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1968 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1968/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240923#comment-14240923 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Yarn-trunk #771 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/771/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240904#comment-14240904 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #36 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/36/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java * hadoop-yarn-project/CHANGES.txt > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240526#comment-14240526 ] Wangda Tan commented on YARN-2924: -- Thanks for [~jianhe]'s review & commit. > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240523#comment-14240523 ] Hudson commented on YARN-2924: -- FAILURE: Integrated in Hadoop-trunk-Commit #6686 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6686/]) YARN-2924. Fixed RMAdminCLI to not convert node labels to lower case. Contributed by Wangda Tan (jianhe: rev 437322afcaa4b1b260501af160283c97eb589419) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java * hadoop-yarn-project/CHANGES.txt > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Fix For: 2.7.0 > > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240485#comment-14240485 ] Hadoop QA commented on YARN-2924: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685152/YARN-2924.1.patch against trunk revision 2ed90a5. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 10 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6067//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6067//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-client.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6067//console This message is automatically generated. > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240411#comment-14240411 ] Hadoop QA commented on YARN-2924: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685152/YARN-2924.1.patch against trunk revision 03867eb. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:red}-1 eclipse:eclipse{color}. The patch failed to build with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6065//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6065//console This message is automatically generated. > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
[ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240347#comment-14240347 ] Hadoop QA commented on YARN-2924: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685152/YARN-2924.1.patch against trunk revision 03867eb. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 10 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6062//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6062//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-client.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6062//console This message is automatically generated. > Node to labels mapping should not transfer to lowercase when adding from > RMAdminCLI > --- > > Key: YARN-2924 > URL: https://issues.apache.org/jira/browse/YARN-2924 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-2924.1.patch > > > In existing implementation, when parsing node-to-labels mapping from > RMAdminCLI, it transferred all labels to lowercase: > {code} > for (int i = 1; i < splits.length; i++) { > if (!splits[i].trim().isEmpty()) { > map.get(nodeId).add(splits[i].trim().toLowerCase()); > } > } > {code} > That is not correct, we should fix that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)