owenca wrote:
/cherry-pick
https://github.com/llvm/llvm-project/commit/7579787e05966f21684dd4b4a15b9deac13d09e1
https://github.com/llvm/llvm-project/pull/106484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/106817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/106817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
Please run `git clang-format HEAD~` and `ninja clang-format-check-format`
before pushing.
https://github.com/llvm/llvm-project/pull/106145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick e0f2368cdeb7312973a92fb2d22199d1de540db8
https://github.com/llvm/llvm-project/pull/106654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/106654
>From b71f4cf3ae2844583171cd0cc75826b8911a7b2b Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 29 Aug 2024 19:27:32 -0700
Subject: [PATCH 1/2] [clang-format] Correctly annotate braces in ObjC square
brackets
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106662
Fixes #106418.
>From fbefbaae69e7238cf0fd52afe5ccc6b871e81b84 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 29 Aug 2024 22:14:46 -0700
Subject: [PATCH] [clang-format] Correctly annotate braces in macro defi
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106654
See https://github.com/llvm/llvm-project/pull/88238#issuecomment-2316954781.
>From b71f4cf3ae2844583171cd0cc75826b8911a7b2b Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 29 Aug 2024 19:27:32 -0700
Subject:
owenca wrote:
/cherry-pick 7579787e05966f21684dd4b4a15b9deac13d09e1
https://github.com/llvm/llvm-project/pull/106484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/106484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
@dklimkin I known this is a trivial fix, but it would be better to request
anyone from https://github.com/orgs/llvm/teams/pr-subscribers-clang-format to
have a look before merging it.
There was an outstanding PR #106305 before yours. Can you review it and see if
you want to ask
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106484
See https://github.com/llvm/llvm-project/pull/89706#issuecomment-2315549955.
>From 9b05f16c3540a8a43c6bf8bf34e7e0fb38056e17 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 28 Aug 2024 19:56:32 -0700
Subject:
owenca wrote:
/cherry-pick 438ad9f2bf25575c474313de4ad85a5da6f69e4c
https://github.com/llvm/llvm-project/pull/105923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/106242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
LG except some nits.
https://github.com/llvm/llvm-project/pull/106242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3238,6 +3238,12 @@ TEST_F(TokenAnnotatorTest, BraceKind) {
EXPECT_BRACE_KIND(Tokens[8], BK_BracedInit);
EXPECT_BRACE_KIND(Tokens[11], BK_BracedInit);
EXPECT_BRACE_KIND(Tokens[13], BK_Block);
+
+ Tokens = annotate("a = class extends goog.a {}",
+ge
owenca wrote:
Please give a more descriptive title.
https://github.com/llvm/llvm-project/pull/106305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -579,6 +579,14 @@ TEST_F(FormatTestJS, GoogScopes) {
"});");
}
+TEST_F(FormatTestJS, GoogAnonymousClass) {
owenca wrote:
Please add a `TokenAnnotatorTest` to test the annotation of the braces instead
of (preferred), or in addition to, this
owenca wrote:
/cherry-pick 656d5aa95825515a55ded61f19d41053c850c82d
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106175
It doesn't make sense to remove the space between new/delete and a C-style cast
when SpaceBeforeParensOptions.AfterPlacementOperator is set to false.
Fixes #105628.
>From 8266cfb1d52dd55c710c16d9c57ca974bd94bb9
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/106013
>From a880299cd884d064e2bd03af308afa52736fa75d Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 25 Aug 2024 14:30:32 -0700
Subject: [PATCH 1/2] [clang-format] Fix misalignments of pointers in angle
brackets
F
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106013
Fixes #105898.
>From a880299cd884d064e2bd03af308afa52736fa75d Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 25 Aug 2024 14:30:32 -0700
Subject: [PATCH] [clang-format] Fix misalignments of pointers in angle
owenca wrote:
/cherry-pick 0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 6bc225e0630f28e83290a43c3d9b25b057fc815a
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105941
Fixes #105877.
>From 28983f4532df55ee31fc366fb5a945594c0baf1a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 24 Aug 2024 07:32:08 -0700
Subject: [PATCH] [clang-format] Fix a misannotation of less/greater as
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105923
>From dbf35d6d7e1b0ba5c80453105757baf5357169d4 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 23 Aug 2024 02:24:39 -0700
Subject: [PATCH 1/2] [clang-format] Revert "[clang-format][NFC] Delete
TT_LambdaArrow
@@ -3369,6 +3371,20 @@ TEST_F(TokenAnnotatorTest, GNULanguageStandard) {
EXPECT_TOKEN(Tokens[2], tok::spaceship, TT_BinaryOperator);
}
+TEST_F(TokenAnnotatorTest, SplitPenalty) {
+ auto Style = getLLVMStyle();
+ Style.ColumnLimit = 20;
+
+ auto Tokens = annotate("class fo
owenca wrote:
See #105923.
https://github.com/llvm/llvm-project/pull/105613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105923
…519)"
This reverts commit e00d32afb9d33a1eca48e2b041c9688436706c5b and adds a test
for lambda arrow SplitPenalty.
Fixes #105480.
>From dbf35d6d7e1b0ba5c80453105757baf5357169d4 Mon Sep 17 00:00:00 2001
From: O
owenca wrote:
After reviewing commit e00d32afb9d33a1eca48e2b041c9688436706c5b, I've come to
the conclusion that it would be better to revert it and keep lambda arrows
differentiated from function arrows.
https://github.com/llvm/llvm-project/pull/105613
_
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105921
Fixes #105880.
>From c3db574bd29bc71e49aa28dc8d1349726f547089 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 23 Aug 2024 20:28:50 -0700
Subject: [PATCH] [clang-format] Fix a misannotation of redundant r_pare
owenca wrote:
Bisected to 834ac2e205dd8e492d6084a7952e68e19a1f54db. @rymiel
https://github.com/llvm/llvm-project/pull/96801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -848,6 +848,11 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
const auto IsSimpleFunction = [&](const FormatToken &Tok) {
if (!Tok.FakeLParens.empty() && Tok.FakeLParens.back() > prec::Unknown)
return false;
+// Nested cal
@@ -848,6 +848,8 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
const auto IsSimpleFunction = [&](const FormatToken &Tok) {
if (!Tok.FakeLParens.empty() && Tok.FakeLParens.back() > prec::Unknown)
return false;
+if (Tok.is(tok
@@ -4050,7 +4050,7 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const {
ChildSize + Current->SpacesRequiredBefore;
}
-if (Current->is(TT_CtorInitializerColon))
+if (Current->isOneOf(TT_CtorInitializerColo
owenca wrote:
> @mydeveloperday, what do you think, is this good to merge?
@mydeveloperday can we merge this?
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 714033a6bf3a81b1350f969ddd83bcd9fbb703e8
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/6] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/5] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/4] [clang-format] Don't insert a space between :: and *
Also, don't
@@ -4589,9 +4589,12 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- const auto *Prev = BeforeLeft->Previous;
- return Left.is(tok::star) && Prev &&
-
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/3] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca deleted
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -403,13 +416,25 @@ TEST_F(FormatTestComments, UnderstandsBlockComments) {
verifyFormat("f(/* aa = */\n"
" );");
- FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParamet
@@ -403,13 +416,29 @@ TEST_F(FormatTestComments, UnderstandsBlockComments) {
verifyFormat("f(/* aa = */\n"
" );");
- FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParamet
https://github.com/owenca deleted
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -403,13 +416,29 @@ TEST_F(FormatTestComments, UnderstandsBlockComments) {
verifyFormat("f(/* aa = */\n"
" );");
- FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParamet
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -403,13 +416,25 @@ TEST_F(FormatTestComments, UnderstandsBlockComments) {
verifyFormat("f(/* aa = */\n"
" );");
- FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParamet
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105613
Fixes #105480.
>From 4bb6856deb83b89a5530efca2155da40663753e1 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 21 Aug 2024 21:45:12 -0700
Subject: [PATCH] [clang-format] Correctly compute SplitPenalty of
Trai
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/2] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105043
Also, don't insert a space after ::* for method pointers.
See https://github.com/llvm/llvm-project/pull/86253#issuecomment-2298404887.
Fixes #100841.
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00
@@ -436,6 +435,19 @@ TEST(ConfigParseTest, ParsesConfiguration) {
CHECK_PARSE("BreakBeforeInheritanceComma: true", BreakInheritanceList,
FormatStyle::BILS_BeforeComma);
+ Style.BinPackParameters = FormatStyle::BPPS_BinPack;
+ CHECK_PARSE("BinPackParameters: O
@@ -1192,20 +1192,36 @@ struct FormatStyle {
/// \version 3.7
bool BinPackArguments;
- /// If ``false``, a function declaration's or function definition's
- /// parameters will either all be on the same line or will have one line
each.
- /// \code
- /// true:
- ///
@@ -403,13 +416,25 @@ TEST_F(FormatTestComments, UnderstandsBlockComments) {
verifyFormat("f(/* aa = */\n"
" );");
- FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParamet
@@ -8925,6 +8925,97 @@ TEST_F(FormatTest,
FormatsOneParameterPerLineIfNecessary) {
NoBinPacking);
}
+TEST_F(FormatTest, FormatsDeclarationBreakAlways) {
+ FormatStyle BreakAlways = getGoogleStyle();
+ BreakAlways.BinPackParameters = FormatStyle::BPPS_AlwaysOnePerLine;
@@ -134,6 +134,19 @@ template <> struct
ScalarEnumerationTraits {
}
};
+template <>
+struct ScalarEnumerationTraits {
+ static void enumeration(IO &IO, FormatStyle::BinPackParametersStyle &Value) {
+IO.enumCase(Value, "OnePerLine", FormatStyle::BPPS_OnePerLine);
+I
@@ -5475,6 +5475,14 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
&Line,
return true;
}
+ // Ignores the first parameter as this will be handled separately by
+ // BreakFunctionDefinitionParameters or AlignAfterOpenBracket.
+ if (FormatStyle::BPPS_Alway
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/104669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1192,20 +1192,36 @@ struct FormatStyle {
/// \version 3.7
bool BinPackArguments;
- /// If ``false``, a function declaration's or function definition's
- /// parameters will either all be on the same line or will have one line
each.
- /// \code
- /// true:
- ///
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/104669
>From d7c7c0da69864067999ecd9b1621fdbb85d4d365 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 17 Aug 2024 02:32:19 -0700
Subject: [PATCH 1/2] [clang-format] Change GNU style language standard to
LS_Latest
F
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/104669
Fixes #104655.
>From d7c7c0da69864067999ecd9b1621fdbb85d4d365 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 17 Aug 2024 02:32:19 -0700
Subject: [PATCH] [clang-format] Change GNU style language standard to
@@ -1192,20 +1192,36 @@ struct FormatStyle {
/// \version 3.7
bool BinPackArguments;
- /// If ``false``, a function declaration's or function definition's
- /// parameters will either all be on the same line or will have one line
each.
- /// \code
- /// true:
- ///
@@ -128,25 +128,6 @@ static bool startsSegmentOfBuilderTypeCall(const
FormatToken &Tok) {
return Tok.isMemberAccess() && Tok.Previous && Tok.Previous->closesScope();
}
-// Returns \c true if \c Current starts a new parameter.
-static bool startsNextParameter(const FormatTok
@@ -1978,6 +1978,25 @@ inline bool continuesLineComment(const FormatToken
&FormatTok,
FormatTok.OriginalColumn >= MinContinueColumn;
}
+// Returns \c true if \c Current starts a new parameter.
+static bool startsNextParameter(const FormatToken &Current,
-
owenca wrote:
> > Whilst I can understand BinPackParameters being deprecated, as its one of
> > the original options I do worry a little about just how much impact such a
> > deprecation might have... it needs to be completely seemless because there
> > is ALOT of documentation references to i
@@ -7165,7 +7165,7 @@ TEST_F(FormatTest, LineBreakingInBinaryExpressions) {
"}");
FormatStyle OnePerLine = getLLVMStyle();
- OnePerLine.BinPackParameters = false;
+ OnePerLine.BinPackParameters = FormatStyle::BPPS_Never;
owenca wrote:
Ditto
@@ -362,6 +362,26 @@ TEST_F(FormatTestComments,
KeepsParameterWithTrailingCommentsOnTheirOwnLine) {
format("aa((,\n"
"), //\n"
", b);"));
+
+ FormatStyle BreakAlways = getLLVMStyle();
+ BreakAlways
@@ -2338,7 +2338,7 @@ TEST_F(FormatTest, FormatsForLoop) {
"for (const Foo &baz = in.value(); !baz.at_end(); ++baz) {\n}");
FormatStyle NoBinPacking = getLLVMStyle();
- NoBinPacking.BinPackParameters = false;
+ NoBinPacking.BinPackParameters = FormatStyle::BPPS_Never
@@ -7694,7 +7694,7 @@ TEST_F(FormatTest, ConstructorInitializers) {
": a(aa, aa,\n"
"aa) {}",
OnePerLine);
- OnePerLine.BinPackParameters = false;
+ On
@@ -8925,6 +8925,97 @@ TEST_F(FormatTest,
FormatsOneParameterPerLineIfNecessary) {
NoBinPacking);
}
+TEST_F(FormatTest, FormatsDeclarationBreakAlways) {
+ FormatStyle BreakAlways = getGoogleStyle();
+ BreakAlways.BinPackParameters = FormatStyle::BPPS_OnePerLine;
+ ve
@@ -7954,7 +7954,7 @@ TEST_F(FormatTest, AllowAllArgumentsOnNextLine) {
}
// This parameter should not affect declarations.
- Style.BinPackParameters = false;
+ Style.BinPackParameters = FormatStyle::BPPS_Never;
owenca wrote:
Ditto.
https://github.com/
@@ -1850,7 +1863,7 @@ FormatStyle getMozillaStyle() {
MozillaStyle.AlwaysBreakAfterDefinitionReturnType =
FormatStyle::DRTBS_TopLevel;
MozillaStyle.BinPackArguments = false;
- MozillaStyle.BinPackParameters = false;
+ MozillaStyle.BinPackParameters = FormatStyle::BP
@@ -8925,6 +8925,97 @@ TEST_F(FormatTest,
FormatsOneParameterPerLineIfNecessary) {
NoBinPacking);
}
+TEST_F(FormatTest, FormatsDeclarationBreakAlways) {
+ FormatStyle BreakAlways = getGoogleStyle();
+ BreakAlways.BinPackParameters = FormatStyle::BPPS_OnePerLine;
+ ve
@@ -8925,6 +8925,97 @@ TEST_F(FormatTest,
FormatsOneParameterPerLineIfNecessary) {
NoBinPacking);
}
+TEST_F(FormatTest, FormatsDeclarationBreakAlways) {
+ FormatStyle BreakAlways = getGoogleStyle();
+ BreakAlways.BinPackParameters = FormatStyle::BPPS_OnePerLine;
+ ve
@@ -8244,7 +8244,7 @@ TEST_F(FormatTest,
BreakConstructorInitializersAfterColon) {
"a(aa, aa,\n"
" aa) {}",
OnePerLine);
- OnePerLine.BinPackParameters =
101 - 200 of 1483 matches
Mail list logo
