https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From 88b48a5df0153a44276f14872c48e10639dcb673 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 01/10] [lldb-dap] Support inspecting memory
Adds supp
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/99012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-09-16T13:46:19+01:00
New Revision: 765e106fb1b0e0aeb1bba18dfd93bd28233bba2f
URL:
https://github.com/llvm/llvm-project/commit/765e106fb1b0e0aeb1bba18dfd93bd28233bba2f
DIFF:
https://github.com/llvm/llvm-project/commit/765e106fb1b0e0aeb1bba18dfd93bd28233bba2f.diff
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From 88b48a5df0153a44276f14872c48e10639dcb673 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/9] [lldb-dap] Support inspecting memory
Adds suppor
dlav-sc wrote:
@JDevlieghere @jasonmolenda @labath @tedwoodward could you take another look,
please.
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 8d0245dfccc607a4237fc94bbbfea646fa1a6887 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/5] [WIP][lldb][test] Add a new __compressed_pair layout to
li
@@ -3828,10 +3828,8 @@ void SymbolFileDWARF::ParseAndAppendGlobalVariable(
break;
default:
-GetObjectFile()->GetModule()->ReportError(
-"didn't find appropriate parent DIE for variable list for {0:x8} "
-"{1} ({2}).\n",
-die.GetID(), DW_TAG_va
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/108806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Ahh thanks for the clarification. Makes sense.
Sounds like a situation where this would arise is:
```
struct Foo {
static int bar;
};
int Foo::bar = 5;
int main() {
static bool bar = false
__builtin_debugtrap();
}
```
Doing `(lldb) target var bar` would produce this er
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
labath wrote:
One more clarification :P
I think it would be reasonable for something like `target variable foo()::v` to
return the static variable `v` in function `foo()`, and to make that work we
might (depending on how exactly this is implemented) need to insert the
variable into the manual
labath wrote:
Adding these to the manual index is very easy -- there just isn't a point in
doing it (except maybe for consistency).
In case I wasn't clear: this warning/error appears in the compiler-generated
indexes, because we find the variable in the name lookup -- and then ignore it.
For t
Author: Michael Buch
Date: 2024-09-16T12:05:00+01:00
New Revision: 9548dbedbc1b2bfb130c91df54e8007acb81e1b0
URL:
https://github.com/llvm/llvm-project/commit/9548dbedbc1b2bfb130c91df54e8007acb81e1b0
DIFF:
https://github.com/llvm/llvm-project/commit/9548dbedbc1b2bfb130c91df54e8007acb81e1b0.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 8d0245dfccc607a4237fc94bbbfea646fa1a6887 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/4] [WIP][lldb][test] Add a new __compressed_pair layout to
li
https://github.com/Michael137 commented:
Seems reasonable to make this less spammy. Though is there a reason why we're
not adding them to the manual index? Is this just something we didn't implement
(yet)?
https://github.com/llvm/llvm-project/pull/108806
___
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI {
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance
// instead.
bool m_is_rv64; // true if target is riscv64; fa
https://github.com/sylvestre edited
https://github.com/llvm/llvm-project/pull/108719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 10d7addd0a86789e268189e00a825af27516323e Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI
Function call
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI {
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance
// instead.
bool m_is_rv64; // true if target is riscv64; fa
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Use a `nullptr` map entry to mean "variable parse was attempted and it failed"
an the absence of an entry to mean "parsing hasn't been attempted yet".
I ran into this because parsing of function-static variabl
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/108810
Use a `nullptr` map entry to mean "variable parse was attempted and it failed"
an the absence of an entry to mean "parsing hasn't been attempted yet".
I ran into this because parsing of function-static variables
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This can legitimately happen for static function-local variables with a
non-manual dwarf index. According to the DWARF spec, these variables should be
(and are) included in the compiler generated indexes, but
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/108806
This can legitimately happen for static function-local variables with a
non-manual dwarf index. According to the DWARF spec, these variables should be
(and are) included in the compiler generated indexes, but th
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-09-16T10:15:52+01:00
New Revision: 7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc
URL:
https://github.com/llvm/llvm-project/commit/7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc
DIFF:
https://github.com/llvm/llvm-project/commit/7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/96538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-09-16T10:11:49+01:00
New Revision: 9e9b1178ca435f690381ffe8241e4bf1bb7e60fb
URL:
https://github.com/llvm/llvm-project/commit/9e9b1178ca435f690381ffe8241e4bf1bb7e60fb
DIFF:
https://github.com/llvm/llvm-project/commit/9e9b1178ca435f690381ffe8241e4bf1bb7e60fb.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96538
>From 16ae2c3c04d908807d78224a8fee34f772a337fa Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 29 Jan 2024 16:23:16 +
Subject: [PATCH 1/4] [lldb] Support new libc++ __compressed_pair layout
---
ll
labath wrote:
> * Everyone (else) I talked to liked the idea of reusing the logging system
> because that's what we already use and are familiar with. Promoting a log
> message to be part of this log becomes as easy as adding a `GetLog` and using
> the same macro.
I'm all for code reuse, and
https://github.com/labath commented:
Actually, the CI failure appears to be relevant. The error path in the test is
`errno->std::error_code->Status->Expected` and the code in `CheckIPSupport`
expects to get a `llvm::ECError`.
It looks like it gets a different type now, and I think that's probab
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
I believe these weren't functional for a very long time now.
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/106505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/106505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vitalybuka requested changes to this pull request.
I think it change the meaning completly.
I read "Coverage Sanitizer" as a tool which finds bugs in Coverage.
When "Sanitizer Coverage" as a coverage used by sanitizers.
https://github.com/llvm/llvm-project/pull/106505
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/108745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Youngsuk Kim
Date: 2024-09-16T00:26:51-04:00
New Revision: d7796855b87911b8ae6c726ab5df4949f173dbd2
URL:
https://github.com/llvm/llvm-project/commit/d7796855b87911b8ae6c726ab5df4949f173dbd2
DIFF:
https://github.com/llvm/llvm-project/commit/d7796855b87911b8ae6c726ab5df4949f173dbd2.diff
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/108745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/108745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/108745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Okay this is safe because after 65b13610a5226b84889b923bae884ba395ad084d,
`raw_string_ostream` is always unbuffered so you (1) don't need to flush and
(2) can use the underlying buffer directly. That makes sense. Please include
that i
root-kidik wrote:
Ping
https://github.com/llvm/llvm-project/pull/105715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Youngsuk Kim (JOE1994)
Changes
* Don't call raw_string_ostream::flush(), which is essentially a no-op.
* Avoid unneeded calls to raw_string_ostream::str(), to avoid excess
indirection.
---
Patch is 26.83 KiB, truncated to 20.00 KiB below,
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/108745
* Don't call raw_string_ostream::flush(), which is essentially a no-op.
* Avoid unneeded calls to raw_string_ostream::str(), to avoid excess
indirection.
>From 35f463d394ec57a38a4e940a61af5cd1f527a00d Mon Sep 1
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is a follow-up to https://github.com/llvm/llvm-project/pull/98330 for the
upcoming `__compressed_pair` refactor in
https://github.com/llvm/llvm-project/issues/93069
This patch just adds the 2 new cop
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/99012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From e3ec030cb404c407ead39b10d5ea0baa4a0683ff Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/4] [WIP][lldb][test] Add a new __compressed_pair layout to
li
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/99012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96538
>From 16ae2c3c04d908807d78224a8fee34f772a337fa Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 29 Jan 2024 16:23:16 +
Subject: [PATCH 1/4] [lldb] Support new libc++ __compressed_pair layout
---
ll
jasonmolenda wrote:
(I hadn't noticed the kernel added this new flavor for intel machines, I've had
people ask for access to these before.)
https://github.com/llvm/llvm-project/pull/108663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
jasonmolenda wrote:
Nice improvement. Let me apply it and experiment a tiny bit next week, but a
quick read looks good.
https://github.com/llvm/llvm-project/pull/108663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
Jlalond wrote:
Hey @kusmour. I actually looked into this on Thursday, see #108248. If we are
going to merge this I think we should just call `std::move` and not
`Status::FromError(std::move(err))` as the API takes an err r-value.
https://github.com/llvm/llvm-project/pull/108719
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Wanyi (kusmour)
Changes
Summary: This introduced from upstream [#107163](https://github.com/llvm/llvm-project/pull/107163)
Test Plan: I can build
---
Full diff: https://github.com/llvm/llvm-project/pull/108719.diff
1 Files Affected:
- (
https://github.com/kusmour created
https://github.com/llvm/llvm-project/pull/108719
Summary: This introduced from upstream
[#107163](https://github.com/llvm/llvm-project/pull/107163)
Test Plan: I can build
>From ff2f26081b5535587e5ccb28522b728a596b6e12 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Reverts llvm/llvm-project#106791 because it breaks
`trap_frame_sym_ctx.test ` on x86_64.
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/5745/
---
Full diff: https://github.com/ll
Author: Jonas Devlieghere
Date: 2024-09-14T10:50:44-07:00
New Revision: fa478bd275f473861f6d4df4896244a730d4853f
URL:
https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f
DIFF:
https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108715
Reverts llvm/llvm-project#106791 because it breaks `trap_frame_sym_ctx.test `
on x86_64.
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/
>From ba6e663299e1d7b54a3ac4a7c647d44f66
JDevlieghere wrote:
It looks like this breaks `Unwind.trap_frame_sym_ctx` on x86_64:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/testReport/junit/lldb-shell/Unwind/trap_frame_sym_ctx_test/
I'm going to revert this to get the bots green over the weekend.
https://gi
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context == "repl") {
+ // If the expression is empty and the last e
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b74e7792194d9a8a9ef32c7dc1ffcd205b299336
4453801c7d8abf7a6adfb7fae57ad9fa9d52a0c4 --e
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brendan Shanks (mrpippy)
Changes
macOS 10.15 added a "full" x86_64 GPR thread state flavor, equivalent to the
normal one but with DS, ES, SS, and GSbase added. This flavor can only be used
with processes that install a custom LDT (function
https://github.com/mrpippy created
https://github.com/llvm/llvm-project/pull/108663
macOS 10.15 added a "full" x86_64 GPR thread state flavor, equivalent to the
normal one but with DS, ES, SS, and GSbase added. This flavor can only be used
with processes that install a custom LDT (functionalit
jasonmolenda wrote:
(1) the armv7/aarch32 step-by-breakpoint fix for lldb-server is merged on
github main.
(2) the change to ProcessGDBRemote to recognize "swbreak" and "hwbreak" as a
breakpoint is merged on github main.
(3) lldb with this patch works fine with the existing debugserver on arm
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 16:12:50 +0400
Subject: [PATCH 1/2] [lldb] Removed gdbserver ports map from lldb-server
Liste
@@ -31,6 +31,22 @@ class ProcessInstanceInfo;
class ProcessInstanceInfoMatch;
typedef std::vector ProcessInstanceInfoList;
+// Always on system log category and channel.
adrian-prantl wrote:
I think we should have a comment that explains what this channel is
https://github.com/JDevlieghere approved this pull request.
Unless someone steps up to maintain these tests I'm fine with removing them.
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/adrian-prantl approved this pull request.
Looks like a nice thing to have conceptually, but if it's not maintained and
not functional ...
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@li
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
These benchmarks don't get run as part of the regular API test-suite. And I'm
not aware of any CI running this. Also, I haven't quite managed to actually run
them locally using the `bench.py` script. It lo
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/108629
These benchmarks don't get run as part of the regular API test-suite. And I'm
not aware of any CI running this. Also, I haven't quite managed to actually run
them locally using the `bench.py` script. It look
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/9] [lldb-dap] Make environment option an object
---
.../tools/l
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 16:12:50 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen to
slydiman wrote:
> I do want it. I don't think it's necessary to transfer the type of the
> socket, as that can be determined by inspecting the socket FD
> (getsockopt(SO_DOMAIN/SO_PROTOCOL)).
Oh, I expected this. We can determine non-tcp by missing or 0 gdb port. But it
is impossible to separ
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/106791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2024-09-13T10:33:43-07:00
New Revision: 0351dc522a25df0473a63b414a5bfde5814d3dc3
URL:
https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3
DIFF:
https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2024-09-13T10:26:01-07:00
New Revision: b6bf27ef3c179eefd805f39aa681705fc980ceed
URL:
https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed
DIFF:
https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed.diff
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-09-13T10:18:03-07:00
New Revision: 02d8813820b1ebf3fae6993e677db269f0077272
URL:
https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272
DIFF:
https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272.diff
LOG
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108602
>From 41bb7f8a13483e55f677d51e049e3d79d763088b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 13 Sep 2024 09:29:46 -0700
Subject: [PATCH 1/2] Add multiplatform minidump determinism test
---
.../TestPr
@@ -94,25 +126,36 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-Status Status::FromError(llvm::Error error) { return Status(std::move(error));
}
+Status Status::FromExpressionError(lldb::ExpressionResults result,
+
@@ -94,25 +126,36 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-Status Status::FromError(llvm::Error error) { return Status(std::move(error));
}
+Status Status::FromExpressionError(lldb::ExpressionResults result,
+
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4...60b48f98ffa70dbf633f1b9bf935479dbfce59d4
lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Adds a test that ensures two minidumps produced from the same target are the
same bytes. Covers the three primary core flavors.
---
Full diff: https://github.com/llvm/llvm-project/pull/108602.diff
1 Files
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108602
Adds a test that ensures two minidumps produced from the same target are the
same bytes. Covers the three primary core flavors.
>From 60b48f98ffa70dbf633f1b9bf935479dbfce59d4 Mon Sep 17 00:00:00 2001
From: Jaco
cmtice wrote:
All reviewer comments have been addressed. Please take another look. Thank you!
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context != "hover") {
cmtice wrote:
Done.
https://git
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix,
// RunTerminateCommands.
static std::mutex handle_command_mutex;
std::lock_guard locker(handle_command_mutex);
- interp.HandleCommand(command.str().c_str(), result);
+ interp.HandleComman
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/6] [lldb-dap] Add feature to remember last non-empty
expression.
901 - 1000 of 35464 matches
Mail list logo
