Re: Implementing CUE sheet support in Amarok

2013-09-15 Thread Abhinandan Ramprasath
On Mon, Sep 16, 2013 at 9:49 AM, Abhinandan Ramprasath wrote: > On Sun, Sep 15, 2013 at 11:58 PM, Matěj Laitl wrote: > >> On 15. 9. 2013 Abhinandan Ramprasath wrote: >> > Hi, >> > >> > After spending a lot of time staring at the code, I would like to >> propose >> > the following changes to impl

Re: Implementing CUE sheet support in Amarok

2013-09-15 Thread Abhinandan Ramprasath
On Sun, Sep 15, 2013 at 11:58 PM, Matěj Laitl wrote: > On 15. 9. 2013 Abhinandan Ramprasath wrote: > > Hi, > > > > After spending a lot of time staring at the code, I would like to propose > > the following changes to implement CUE sheet support in Amarok. > > > > Most of the necessary CUE decodi

Re: Implementing CUE sheet support in Amarok

2013-09-15 Thread Matěj Laitl
On 15. 9. 2013 Abhinandan Ramprasath wrote: > Hi, > > After spending a lot of time staring at the code, I would like to propose > the following changes to implement CUE sheet support in Amarok. > > Most of the necessary CUE decoding and track splitting functions are already > available in CueFile

Implementing CUE sheet support in Amarok

2013-09-15 Thread Abhinandan Ramprasath
Hi, After spending a lot of time staring at the code, I would like to propose the following changes to implement CUE sheet support in Amarok. Most of the necessary CUE decoding and track splitting functions are already available in CueFileSupport.h . It's got functions to scan for and validate CU

Re: Added support for Visualizations using VSXu

2013-09-15 Thread Konrad Zemek
On 15.09.2013 14:15, Konrad Zemek wrote: On 12.09.2013 19:14, Dinesh wrote: Hey Konrad, We have merged the Amarok Fixes branch into VSXu master. And the patch for the problem with the FindVSXu.cmake is in VSXu master now. (It was a broken libvsxu.pc file). As for the blank visualizer apple

Re: Added support for Visualizations using VSXu

2013-09-15 Thread Konrad Zemek
On 12.09.2013 19:14, Dinesh wrote: Hey Konrad, We have merged the Amarok Fixes branch into VSXu master. And the patch for the problem with the FindVSXu.cmake is in VSXu master now. (It was a broken libvsxu.pc file). As for the blank visualizer applet, I still cannot reproduce the problem o

Build failed in Jenkins: amarok_master #647

2013-09-15 Thread KDE CI System
See Changes: [kretschmann] Wtf is a kequalizer? [kretschmann] Remove nonsensical code. -- [...truncated 4 lines...] + /home/jenkins/scripts/setup-env.sh >From git://anongit.kde.org/amarok 3eb2e8b..1f