Re: Changes in GMock

2013-10-01 Thread Konrad Zemek
1 paź 2013 13:22 "Matěj Laitl" napisał(a): > > On 1. 10. 2013 Konrad Zemek wrote: > > The way I see it, possible solutions are: > > > > * go the way of Mir: find sources installed by Kubuntu's package in > > "FindGmock.cmake" (in Mir it's FindGtest.cmake) > > downsides: depends on how distro p

Re: Changes in GMock

2013-10-01 Thread Matěj Laitl
On 1. 10. 2013 Konrad Zemek wrote: > The way I see it, possible solutions are: > > * go the way of Mir: find sources installed by Kubuntu's package in > "FindGmock.cmake" (in Mir it's FindGtest.cmake) > downsides: depends on how distro packages gmock; e.g. Arch has no > gmock package in offi

Re: Changes in GMock

2013-10-01 Thread Konrad Zemek
2013/10/1 Mark Kretschmann : > > While this is a convenient solution, distro packagers generally frown > on bundling libraries with applications. With "frown" I mean the > package won't be accepted at all if they learn about it. (For security > reasons mostly, and generally because it's a packager'

Re: Changes in GMock

2013-10-01 Thread Mark Kretschmann
On Tue, Oct 1, 2013 at 10:19 AM, Konrad Zemek wrote: > * pull gmock's sources into our repository and add it through > add_directory(). This is by far the easiest option, and we still control > the version, and we have include files in place. > downsides: sources are in our repository. Whil

Re: Changes in GMock

2013-10-01 Thread Konrad Zemek
Hey, 2013/10/1 Mark Kretschmann > > So essentially GMock is no longer provided as a binary package, but > instead it has to be compiled from source. While that's not an > insurmountable problem, I think it would be beneficial to discuss it. > Also because we could still influence the packaging to

Changes in GMock

2013-10-01 Thread Mark Kretschmann
Hey all, last night we stumbled upon some changes in Google Mock that might have repercussions for Amarok. It started by Frank upgrading his Kubuntu installation, only to find that Amarok did no longer build with tests enabled. After some research by the Kubuntu developers, the following message w