Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-27 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/ --- (Updated March 27, 2015, 3:34 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-27 Thread Mark Michelson
> On March 27, 2015, 10:39 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 3325-3328 > > > > > > Just a question - if I somehow have two messages in-flight in > > processing what will happen here?

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-27 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14888 --- Just adding a note to the comment. /branches/13/include/aster

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14886 --- /branches/13/main/threadpool.c

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Mark Michelson
> On March 27, 2015, 1:30 a.m., Matt Jordan wrote: > > The testsuite link lead to a 'this review doesn't exist' error. Is there a > > problem with Gerrit, or did it not get published? I hadn't published it. It's published now though. - Mark --

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14879 --- The testsuite link lead to a 'this review doesn't exist' error.

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14878 --- Ship it! Nitpick not withstanding, this looks good to go. /b

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/ --- (Updated March 26, 2015, 10:54 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/ --- (Updated March 26, 2015, 10:33 p.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

2015-03-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/ --- Review request for Asterisk Developers. Repository: Asterisk Description