[libcxx] r293154 - Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard for the intrisic suppo

2017-01-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jan 26 00:58:29 2017 New Revision: 293154 URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev Log: Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard fo

r293149 - Further fixes to test from r293146

2017-01-25 Thread Adam Nemet via cfe-commits
Author: anemet Date: Wed Jan 25 22:34:07 2017 New Revision: 293149 URL: http://llvm.org/viewvc/llvm-project?rev=293149&view=rev Log: Further fixes to test from r293146 Require aarch64 and avoid filename in YAML since it may require quotation. Modified: cfe/trunk/test/CodeGen/opt-record-MIR.c

r293147 - Fix test from r293146

2017-01-25 Thread Adam Nemet via cfe-commits
Author: anemet Date: Wed Jan 25 22:14:04 2017 New Revision: 293147 URL: http://llvm.org/viewvc/llvm-project?rev=293147&view=rev Log: Fix test from r293146 Modified: cfe/trunk/test/CodeGen/opt-record-MIR.c Modified: cfe/trunk/test/CodeGen/opt-record-MIR.c URL: http://llvm.org/viewvc/llvm-pro

r293146 - Support MIR opt-remarks with -fsave-optimization-record

2017-01-25 Thread Adam Nemet via cfe-commits
Author: anemet Date: Wed Jan 25 22:07:11 2017 New Revision: 293146 URL: http://llvm.org/viewvc/llvm-project?rev=293146&view=rev Log: Support MIR opt-remarks with -fsave-optimization-record The handler that deals with IR passed/missed/analysis remarks is extended to also handle the corresponding M

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

2017-01-25 Thread Argyrios Kyrtzidis via cfe-commits
Hi Hans, Could this go into the stable branch ? > On Jan 25, 2017, at 6:11 PM, Argyrios Kyrtzidis via cfe-commits > wrote: > > Author: akirtzidis > Date: Wed Jan 25 20:11:50 2017 > New Revision: 293134 > > URL: http://llvm.org/viewvc/llvm-project?rev=293134&view=rev > Log: > [index] When inde

r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

2017-01-25 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Jan 25 20:11:50 2017 New Revision: 293134 URL: http://llvm.org/viewvc/llvm-project?rev=293134&view=rev Log: [index] When indexing an ObjC method declaration use its base name for the location. Instead of using the location of the beginning '-'/'+'. This is consistent

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

2017-01-25 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. Herald added a reviewer: tstellarAMD. Herald added subscribers: tony-tye, nhaehnle, wdng, kzhuravl. Make sure the spec required type alignments are used in preparation for a possible change which may break this. https://reviews.llvm.org/D29162 Files: test/CodeGen

r293123 - Remove and replace DiagStatePoint tracking and lookup data structure.

2017-01-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 25 19:01:01 2017 New Revision: 293123 URL: http://llvm.org/viewvc/llvm-project?rev=293123&view=rev Log: Remove and replace DiagStatePoint tracking and lookup data structure. Rather than storing a single flat list of SourceLocations where the diagnostic state changes (

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-01-25 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. When building libc++ with hidden visibility, we want explicit template instantiations to export members. This is consistent with existing Windows behavior, and is necessary for clients to be able to link against a hidden visibility built libc++ without running into l

r293111 - Fix test case committed in r293106 so that it passes on targets whose

2017-01-25 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Wed Jan 25 17:36:15 2017 New Revision: 293111 URL: http://llvm.org/viewvc/llvm-project?rev=293111&view=rev Log: Fix test case committed in r293106 so that it passes on targets whose pointers are 4-bytes instead of 8-bytes. Modified: cfe/trunk/test/CodeGen/lifetime2.c M

[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

2017-01-25 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/misc/InvalidatedIteratorsCheck.cpp:61 + cxxMemberCallExpr(has(memberExpr(hasDeclaration(cxxMethodDecl(hasAnyName( + "push_back", "emplace_back", "clear", +

[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

2017-01-25 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. General question: isn't Static Analyzer is better place for such workflow checks? Repository: rL LLVM https://reviews.llvm.org/D29151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r293108 - Remove the return type from the check string in test case.

2017-01-25 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Wed Jan 25 17:16:32 2017 New Revision: 293108 URL: http://llvm.org/viewvc/llvm-project?rev=293108&view=rev Log: Remove the return type from the check string in test case. Bots were failing because some targets emit signext before i32. Modified: cfe/trunk/test/CodeGen/l

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a reviewer: rsmith. hans added a comment. +Richard in case you have any theories on why they do it like this. https://reviews.llvm.org/D29152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. For non-template `dllimport` functions, MSVC allows providing an inline definition without spelling out the attribute again. In the example below, `f` remains a `dllimport` function. __declspec(dllimport) int f(); inline int f() { return 42; } int useit() {

[PATCH] D27430: [libc++] Annotate template methods with visibility

2017-01-25 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai abandoned this revision. smeenai added a comment. Folded into https://reviews.llvm.org/D25208 https://reviews.llvm.org/D27430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

2017-01-25 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293106: [CodeGen] Suppress emission of lifetime markers if a label has been seen (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D27680?vs=85774&id=85817#toc Repository: rL

r293106 - [CodeGen] Suppress emission of lifetime markers if a label has been seen

2017-01-25 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Wed Jan 25 16:55:13 2017 New Revision: 293106 URL: http://llvm.org/viewvc/llvm-project?rev=293106&view=rev Log: [CodeGen] Suppress emission of lifetime markers if a label has been seen in the current lexical scope. clang currently emits the lifetime.start marker of a variab

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

2017-01-25 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 85816. smeenai edited the summary of this revision. smeenai removed a reviewer: compnerd. smeenai added a comment. Folding https://reviews.llvm.org/D27430 and addressing comments from that diff. https://reviews.llvm.org/D25208 Files: docs/DesignDocs/Visib

[PATCH] D21675: New ODR checker for modules

2017-01-25 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D21675#654659, @teemperor wrote: > Would be nice if we could make Stmt::Profile, ODRHash and the CloneDetection > use the same backend. This code is *already* reusing the Stmt::Profile code for hashing of statements. Why was a different mech

[PATCH] D21675: New ODR checker for modules

2017-01-25 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added a comment. In https://reviews.llvm.org/D21675#654659, @teemperor wrote: > I feel like we have a really similar use case in the > Analysis/CloneDetection{.h/.cpp} with the hashing of statements. I tried > substituting the call to the statement hashing with a call to the > CloneDete

r293097 - [CodeGen] [CUDA] Add the ability set default attrs on functions in linked modules.

2017-01-25 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Wed Jan 25 15:29:48 2017 New Revision: 293097 URL: http://llvm.org/viewvc/llvm-project?rev=293097&view=rev Log: [CodeGen] [CUDA] Add the ability set default attrs on functions in linked modules. Summary: Now when you ask clang to link in a bitcode module, you can tell it to

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

2017-01-25 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 85794. dim added a comment. Back to the previous version, using `no_thread_safety_analysis` for FreeBSD only. Optionally, we could delete the `defined(__FreeBSD__)` part, and disable the analysis for all platforms. https://reviews.llvm.org/D28520 Files: in

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

2017-01-25 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In https://reviews.llvm.org/D28520#656202, @delesley wrote: > The big question for me is whether these functions are exposed as part of the > public libcxx API, or whether they are only used internally. As far as I can see, they are only used internally, in `src/algorithm.

[PATCH] D29143: [OpenMP] Codegen support for 'target teams' on the NVPTX device.

2017-01-25 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob created this revision. Herald added a subscriber: jholewinski. This is a simple patch to teach OpenMP codegen to emit the construct in Generic mode. https://reviews.llvm.org/D29143 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_target_teams_codegen.cpp Index: te

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Asiri Rathnayake via cfe-commits
Hi Nico, Thanks for the links. I may have a clue to what is going on. I think in your Mac environment, does not provide either pthread_mach_thread_np() function or define the type mach_port_t (is there a way for you to check this btw? just to make sure). This was not a problem before (for your

[libcxx] r293079 - Fixed a typo in the synopsis (noecept -> noexcept). Thanks to Kim for the catch

2017-01-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 25 14:14:03 2017 New Revision: 293079 URL: http://llvm.org/viewvc/llvm-project?rev=293079&view=rev Log: Fixed a typo in the synopsis (noecept -> noexcept). Thanks to Kim for the catch Modified: libcxx/trunk/include/future Modified: libcxx/trunk/include/future U

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Nico Weber via cfe-commits
Sure! https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/8565/steps/gclient%20runhooks/logs/stdio has the invocations to build llvm/clang/compiler/rt, and https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/8565/steps/compile/logs/stdio is the actual bui

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Asiri Rathnayake via cfe-commits
@Nico: could you let me know your build configuration? (cmake options) I'm surprised this went unnoticed for so long. Thanks. / Asiri On 25 Jan 2017 5:52 p.m., "Asiri Rathnayake" wrote: > (including cfe-commits) > > On Wed, Jan 25, 2017 at 5:51 PM, Asiri Rathnayake < > asiri.rathnay...@gmail.

[PATCH] D29140: [libcxx] [test] Avoid MSVC's non-Standard ABI in underlying_type.pass.cpp.

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Avoid MSVC's non-Standard ABI in underlying_type.pass.cpp. When compiled with Clang for Windows, this was emitting "enumerator value evaluates to 4294967295, which cannot be narrowed to type 'int' [-Wc++11-narrowing]". The test should more strenuo

[PATCH] D29139: [libcxx] [test] Fix Clang -Wpessimizing-move "moving a temporary object prevents copy elision".

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wpessimizing-move "moving a temporary object prevents copy elision". N4618 30.6.6 [futures.unique_future]/12 declares "shared_future share() noexcept;". https://reviews.llvm.org/D29139 Files: test/std/thread/futures/futures.unique_

[PATCH] D29138: [libcxx] [test] Fix Clang -Wdeprecated-declarations with MSVC's CRT.

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wdeprecated-declarations with MSVC's CRT. libcxx's tests use various C Standard Library functions that have been marked by MSVC's CRT as deprecated by Microsoft (not by ISO). libcxx's usage is cromulent (just checking with decltype to se

[PATCH] D29137: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3.

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3. test/std/strings/string.classes/typedefs.pass.cpp Actually test what basic_string's typedefs stand for. test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp NotDerived and ND were comp

[PATCH] D29136: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 2/3.

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 2/3. These typedefs were completely unused. https://reviews.llvm.org/D29136 Files: test/std/containers/sequences/deque/deque.cons/size.pass.cpp test/std/containers/sequences/list/list.cons/size_type.pass

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

2017-01-25 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D27680#656453, @ahatanak wrote: > Yes, we can make VarBypassDetector detect variables declared after labels too > if we want to put all the logic for disabling lifetime markers in one place. Okay. If that's straightforward, that does seem

[PATCH] D29135: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3.

2017-01-25 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3. Mark typedefs as LIBCPP_ONLY when their only usage is within LIBCPP_STATIC_ASSERT. test/std/containers/sequences/vector.bool/move_assign_noexcept.pass.cpp test/std/containers/sequences/vector.bool/move_n

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

2017-01-25 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 85774. ahatanak marked 2 inline comments as done. ahatanak added a comment. Yes, we can make VarBypassDetector detect variables declared after labels too if we want to put all the logic for disabling lifetime markers in one place. https://reviews.llvm.org/

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Asiri Rathnayake via cfe-commits
(including cfe-commits) On Wed, Jan 25, 2017 at 5:51 PM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote: > Hi Nico, > > On Wed, Jan 25, 2017 at 5:32 PM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Is it intentional that this change affects non-LIBCXX_HAS_EXTERNAL_

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Nico Weber via cfe-commits
Is it intentional that this change affects non-LIBCXX_HAS_EXTERNAL_THREAD_API builds at all? On Wed, Jan 25, 2017 at 12:31 PM, Nico Weber wrote: > This breaks all our mac builds with: > > /b/c/b/ClangToTMac__dbg_/src/third_party/llvm-build/ > Release+Asserts/bin/../include/c++/v1/__threading_sup

Re: [libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

2017-01-25 Thread Nico Weber via cfe-commits
This breaks all our mac builds with: /b/c/b/ClangToTMac__dbg_/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__threading_support:154:1: error: unknown type name 'mach_port_t' mach_port_t __libcpp_thread_get_port(); On Tue, Jan 3, 2017 at 7:59 AM, Asiri Rathnayake via cfe-commits

Re: r292991 - PR31742: Don't emit a bogus "zero size array" extwarn when initializing a

2017-01-25 Thread Hans Wennborg via cfe-commits
Thanks! r293072. On Tue, Jan 24, 2017 at 6:03 PM, Richard Smith wrote: > Hi Hans, > > This is relatively minor, but it's safe and fixes a rejects-valid regression > in some configurations. Might be worth taking for Clang 4. > > On 24 January 2017 at 15:18, Richard Smith via cfe-commits > wrote:

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

2017-01-25 Thread Hans Wennborg via cfe-commits
Should we merge this to 4.0? On Tue, Jan 24, 2017 at 3:09 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Tue Jan 24 17:09:12 2017 > New Revision: 292990 > > URL: http://llvm.org/viewvc/llvm-project?rev=292990&view=rev > Log: > Change the return type of emplace_[front|back] ba

[libcxx] r293071 - [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc

2017-01-25 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Jan 25 11:00:30 2017 New Revision: 293071 URL: http://llvm.org/viewvc/llvm-project?rev=293071&view=rev Log: [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/i

[PATCH] D29128: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device.

2017-01-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293069: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX… (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29128?vs=85759&id=85765#toc Repository: r

r293069 - [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device.

2017-01-25 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Wed Jan 25 10:55:10 2017 New Revision: 293069 URL: http://llvm.org/viewvc/llvm-project?rev=293069&view=rev Log: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device. This patch adds support for the proc_bind clause on the Spmd construct 'target

[PATCH] D29128: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device.

2017-01-25 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29128: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device.

2017-01-25 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob created this revision. Herald added a subscriber: jholewinski. This patch adds support for the proc_bind clause on the Spmd construct 'target parallel' on the NVPTX device. Since the parallel region is created upon kernel launch, this clause can be safely ignored on the NVPTX device

r293065 - Clarify how to forward-declare __llvm_profile symbols.

2017-01-25 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Jan 25 10:01:32 2017 New Revision: 293065 URL: http://llvm.org/viewvc/llvm-project?rev=293065&view=rev Log: Clarify how to forward-declare __llvm_profile symbols. Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

2017-01-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:723 +? CGM.getNSConcreteStackBlock() +: llvm::Constant::getNullValue( + CGM.getNSConcreteStackBlock()->getType()); -

[PATCH] D29077: [lsan] Enable LSan for x86 Linux.

2017-01-25 Thread Maxim Ostapenko via Phabricator via cfe-commits
m.ostapenko updated this revision to Diff 85756. m.ostapenko added a comment. Add a test case. Repository: rL LLVM https://reviews.llvm.org/D29077 Files: lib/Driver/ToolChains.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c ===

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

2017-01-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:726 + CGM.getNSConcreteStackBlock()->getType()), + QualType()); isa = llvm::ConstantExpr::getBitCast(isa, VoidPtrTy); The QualTyp

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

2017-01-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:723 +? CGM.getNSConcreteStackBlock() +: llvm::Constant::getNullValue( + CGM.getNSConcreteStackBlock()->getType()); --

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

2017-01-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 85753. Anastasia added a comment. Switched to getNullPointer helper. https://reviews.llvm.org/D28814 Files: lib/AST/Expr.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaType.cpp test/CodeGenOpenCL/cl20

[PATCH] D25674: [Concepts] Class template associated constraints

2017-01-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:355 protected: - // This is probably never used. - TemplateDecl(Kind DK, DeclContext *DC, SourceLocation L, DeclarationName Name

[PATCH] D25674: [Concepts] Class template associated constraints

2017-01-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast updated this revision to Diff 85752. hubert.reinterpretcast added a comment. Address review comments; update to revision 292996 Fix possibly ill-formed NDR case Test template-dependent cases for class redeclaration Address review comment: use lambda instead of do while(0)

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

2017-01-25 Thread Delesley Hutchins via Phabricator via cfe-commits
delesley added a comment. The big question for me is whether these functions are exposed as part of the public libcxx API, or whether they are only used internally. (Again, I'm not a libcxx expert.) If they are part of the public API, then users may want to switch them on and off in their own

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293055: [clang-format] Implement comment reflowing. (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D28764?vs=85739&id=85740#toc Repository: rL LLVM https://reviews.llvm.or

r293055 - [clang-format] Implement comment reflowing.

2017-01-25 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Wed Jan 25 07:58:58 2017 New Revision: 293055 URL: http://llvm.org/viewvc/llvm-project?rev=293055&view=rev Log: [clang-format] Implement comment reflowing. Summary: This presents a version of the comment reflowing with less mutable state inside the comment breakable token s

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 85739. krasimir marked 2 inline comments as done. krasimir added a comment. - Address review comments. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt lib/Format/Comments.cp

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:747 +Split SplitBefore, WhitespaceManager &Whitespaces) { + // If this is the first line of a token, we need to inform Whitespace Manager + // about it: either adapt the whitespace range preceding it,

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:747 +Split SplitBefore, WhitespaceManager &Whitespaces) { + // If this is the first line of a token, we need to inform Whitespace Manager + // about it: either adapt the whitespace range preceding it, o

r293053 - [test] Add HAVE_LIBZ to canonicalized booleans

2017-01-25 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Wed Jan 25 07:31:53 2017 New Revision: 293053 URL: http://llvm.org/viewvc/llvm-project?rev=293053&view=rev Log: [test] Add HAVE_LIBZ to canonicalized booleans Canonicalize HAVE_LIBZ as well to fix buildbot failures. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. Tried to add some comments around range computations. Most of the time it's about converting range offsets from local line-based values to start-of-token-based offsets. Comment at: lib/Format/BreakableToken.cpp:279-280 + return Content.size() >= 2 &

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 85737. krasimir marked 3 inline comments as done. krasimir added a comment. - Address comments. Add a bunch of comments about various range computations. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h

[PATCH] D28529: [test] Port clang tests to canonicalized booleans

2017-01-25 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293052: [test] Port clang tests to canonicalized booleans (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D28529?vs=83852&id=85736#toc Repository: rL LLVM https://reviews.llv

r293052 - [test] Port clang tests to canonicalized booleans

2017-01-25 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Wed Jan 25 07:11:45 2017 New Revision: 293052 URL: http://llvm.org/viewvc/llvm-project?rev=293052&view=rev Log: [test] Port clang tests to canonicalized booleans Use the new llvm_canonicalize_cmake_booleans() function to canonicalize booleans for lit tests. Replace the duplic

[PATCH] D29123: [Driver] Prevent no-arc-exception-silence.m test from writing output.

2017-01-25 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293051: [Driver] Prevent no-arc-exception-silence.m test from writing output. (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D29123?vs=85734&id=85735#toc Repository: rL LLVM

r293051 - [Driver] Prevent no-arc-exception-silence.m test from writing output.

2017-01-25 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Jan 25 06:55:53 2017 New Revision: 293051 URL: http://llvm.org/viewvc/llvm-project?rev=293051&view=rev Log: [Driver] Prevent no-arc-exception-silence.m test from writing output. Summary: This enables the test to run on systems where output cannot be written. Reviewers:

[PATCH] D29123: [Driver] Prevent no-arc-exception-silence.m test from writing output.

2017-01-25 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. This enables the test to run on systems where output cannot be written. https://reviews.llvm.org/D29123 Files: test/Driver/no-arc-exception-silence.m Index: test/Driver/no-arc-exception-silence.m

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

2017-01-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia closed this revision. Anastasia added a comment. Committed in r293050! https://reviews.llvm.org/D28860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r293050 - [OpenCL] Diagnose write_only image3d when extension is disabled

2017-01-25 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jan 25 06:18:50 2017 New Revision: 293050 URL: http://llvm.org/viewvc/llvm-project?rev=293050&view=rev Log: [OpenCL] Diagnose write_only image3d when extension is disabled Prior to OpenCL 2.0, image3d_t can only be used with the write_only access qualifier when the cl_kh

[PATCH] D29087: [OpenMP] Support for thread_limit-clause on the 'target teams' directive.

2017-01-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293049: [OpenMP] Support for thread_limit-clause on the 'target teams' directive. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29087?vs=85592&id=85728#toc Repository: rL L

r293049 - [OpenMP] Support for thread_limit-clause on the 'target teams' directive.

2017-01-25 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Wed Jan 25 05:44:35 2017 New Revision: 293049 URL: http://llvm.org/viewvc/llvm-project?rev=293049&view=rev Log: [OpenMP] Support for thread_limit-clause on the 'target teams' directive. The thread_limit-clause on the combined directive applies to the 'teams' region of this co

[PATCH] D29085: [OpenMP] Support for num_teams-clause on the 'target teams' directive.

2017-01-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293048: [OpenMP] Support for num_teams-clause on the 'target teams' directive. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29085?vs=85587&id=85726#toc Repository: rL LLVM

r293048 - [OpenMP] Support for num_teams-clause on the 'target teams' directive.

2017-01-25 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Wed Jan 25 05:28:18 2017 New Revision: 293048 URL: http://llvm.org/viewvc/llvm-project?rev=293048&view=rev Log: [OpenMP] Support for num_teams-clause on the 'target teams' directive. The num_teams-clause on the combined directive applies to the 'teams' region of this construc

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:279-280 + return Content.size() >= 2 && + Content != "clang-format on" && + Content != "clang-format off" && + !Content.endswith("\\") && Can we now use delimitsRegion here?

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +Current.TokenText.substr(2).ltrim().

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

2017-01-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 85725. krasimir marked 8 inline comments as done. krasimir added a comment. - Address review comments. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt lib/Format/Comments.cp

[PATCH] D28946: [analyzer] Fix memory space for block-captured static locals.

2017-01-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293043: [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D28946?vs=85588&id=85722#toc Repository

r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

2017-01-25 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 25 04:21:45 2017 New Revision: 293043 URL: http://llvm.org/viewvc/llvm-project?rev=293043&view=rev Log: [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks. This is an attempt to avoid new false positives caused by the reverted r292800, ho

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-01-25 Thread Nuno Lopes via Phabricator via cfe-commits
nlopes added a comment. Regarding incremental solving with Z3 (or with most SMT solvers in general), let me just lower the expectations a bit: In Z3, when you do push(), there are a few things that change immediately: 1) it uses a different SAT solver (one that supports incremental reasoning), a

[PATCH] D29031: [mips] Add support for static model on N64

2017-01-25 Thread Sagar Thakur via Phabricator via cfe-commits
slthakur accepted this revision. slthakur added a comment. LGTM Repository: rL LLVM https://reviews.llvm.org/D29031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29117: SPARC: allow usage of floating-point registers in inline ASM

2017-01-25 Thread Patrick Boettcher via Phabricator via cfe-commits
pboettch updated this revision to Diff 85708. pboettch added a comment. Added test-code. https://reviews.llvm.org/D29117 Files: lib/Basic/Targets.cpp test/CodeGen/sparcv8-inline-asm.c Index: test/CodeGen/sparcv8-inline-asm.c ===