[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus doc. https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF added a comment. Please add docs to http://libcxx.llvm.org/docs/UsingLibcxx.html#libc-configuration-macros https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D24371: Add diagnostics to require_constant_initialization

EricWF added a comment. @rsmith gentle ping. Repository: rL LLVM https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added a comment. @AntonBikineev Yeah, this should be abandoned. Sorry my mistake. https://reviews.llvm.org/D26830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added inline comments. Comment at: test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16 + +int main() +{ EricWF wrote: > What's the point of this test that `literal.pass.cpp` doesn't cover? Ping on this comment. Commen

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. Comment at: libcxx/include/math.h:354 inline _LIBCPP_INLINE_VISIBILITY -typename std::enable_if::value, bool>::type +typename std::enable_if::val

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

I think this broke some of the bots. http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/30152/ Could you take a look? > On Apr 12, 2017, at 3:50 PM, Reid Kleckner via cfe-commits > wrote: > > Author:

[libcxx] r300175 - Cleanup any_cast failure test

Author: ericwf Date: Thu Apr 13 00:27:55 2017 New Revision: 300175 URL: http://llvm.org/viewvc/llvm-project?rev=300175&view=rev Log: Cleanup any_cast failure test Modified: libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/reference_types.fail.cpp Modified: libcxx/trunk/test/std/

[PATCH] D31769: Remove the binders `bind1st`, `bind2nd`, `men_fun`, etc from C++17

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The `.fail.cpp` tests should use `// UNSUPPORTED: c++98, c++03, c++11, c++14` instead of `#error `. Other than that this LGTM. Comment at: test/std/depr/depr.function.obje

[PATCH] D30837: [libcxx] Support for shared_ptr

EricWF added a comment. - Please apply this patch on top of yours. It adds tests for the diagnostics produced when the default deleter is used. LGTM other than the inline comments. I'll want to run this by @mclow.lists before g

[PATCH] D31887: [clangd] Add documentation page

malaperle-ericsson updated this revision to Diff 95078. malaperle-ericsson added a comment. Fix mention of "extra Clang tools" https://reviews.llvm.org/D31887 Files: docs/clangd.rst docs/index.rst Index: docs/index.rst === ---

Re: [PATCH] [PPC64]: Add support for Swift calling convention

On Wed, 2017-04-12 at 14:01 -0700, Adrian Prantl wrote: > Is it possible to add a testcase for this? I will look into it. Thanks for the review! Andrew > > -- adrian > > > > On Mar 22, 2017, at 5:00 AM, Andrew Jeffery via cfe-commits > > wrote: > > > > > > Signed-off-by: Andrew Jeffery >

Re: [PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

It seems to me the test have already been simplified enough, so I'm not quite sure what you are trying to do more than this. Isn't this just ready to submit? On Wed, Apr 12, 2017 at 5:46 PM, Yuka Takahashi via Phabricator < revi...@reviews.llvm.org> wrote: > yamaguchi updated this revision to Dif

r300153 - [IR] Take func, ret, and arg attrs separately in AttributeList::get

Author: rnk Date: Wed Apr 12 19:58:09 2017 New Revision: 300153 URL: http://llvm.org/viewvc/llvm-project?rev=300153&view=rev Log: [IR] Take func, ret, and arg attrs separately in AttributeList::get This seems like a much more natural API, based on Derek Schuff's comments on r300015. It further hi

[libcxx] r300152 - Fix the default constructibility of __compressed_pair.

Author: ericwf Date: Wed Apr 12 19:50:45 2017 New Revision: 300152 URL: http://llvm.org/viewvc/llvm-project?rev=300152&view=rev Log: Fix the default constructibility of __compressed_pair. This patch fixes a bug where the =default default ctor for __compressed_pair was incorrect for const qualifie

[libcxx] r300165 - Fix template >> within C++03 code

Author: ericwf Date: Wed Apr 12 21:56:03 2017 New Revision: 300165 URL: http://llvm.org/viewvc/llvm-project?rev=300165&view=rev Log: Fix template >> within C++03 code Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default_allows_incompl

[libcxx] r300164 - Diagnose when reverse_iterator is used on path::iterator.

Author: ericwf Date: Wed Apr 12 21:54:13 2017 New Revision: 300164 URL: http://llvm.org/viewvc/llvm-project?rev=300164&view=rev Log: Diagnose when reverse_iterator is used on path::iterator. path::iterator isn't a strictly conforming iterator. Specifically it stashes the current element inside th

[libcxx] r300159 - Fix C++03 test failures

Author: ericwf Date: Wed Apr 12 20:13:58 2017 New Revision: 300159 URL: http://llvm.org/viewvc/llvm-project?rev=300159&view=rev Log: Fix C++03 test failures Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/

[libcxx] r300158 - Add tests that std::unique_ptr's default constructor is constexpr.

Author: ericwf Date: Wed Apr 12 20:11:58 2017 New Revision: 300158 URL: http://llvm.org/viewvc/llvm-project?rev=300158&view=rev Log: Add tests that std::unique_ptr's default constructor is constexpr. std::unique_ptr's default constructor must be constexpr in order to allow constant initialization

[libcxx] r300154 - Fix more bad member swap definitions in unordered_map.

Author: ericwf Date: Wed Apr 12 20:02:41 2017 New Revision: 300154 URL: http://llvm.org/viewvc/llvm-project?rev=300154&view=rev Log: Fix more bad member swap definitions in unordered_map. The __unordered_map_equal and __unordered_map_hash wrappers attempt to swap const qualified predicates whenev

[libcxx] r300156 - Update tests -verify error messages after r300140.

Author: ericwf Date: Wed Apr 12 20:03:41 2017 New Revision: 300156 URL: http://llvm.org/viewvc/llvm-project?rev=300156&view=rev Log: Update tests -verify error messages after r300140. Modified: libcxx/trunk/test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp Modified

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

EricWF added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:680 + // likely due to the scope at in which this function is called. + auto *VD = Result.getAsSingle(); + if (!VD) { @rsmith is this the correct way to build a `DeclRefExpr` to an existing g

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

EricWF updated this revision to Diff 95074. EricWF added a comment. This revision is now accepted and ready to land. - Add call to `MarkDeclRefReferenced` even though it doesn't prevent the assertion. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sem

r300151 - Fix broken test. We can't assume that 2MB of args is enough to require a response file.

Author: rsmith Date: Wed Apr 12 19:46:50 2017 New Revision: 300151 URL: http://llvm.org/viewvc/llvm-project?rev=300151&view=rev Log: Fix broken test. We can't assume that 2MB of args is enough to require a response file. This test has apparently been broken for years, but we never noticed before

[libcxx] r300148 - Fix most failures caused by r300140

Author: ericwf Date: Wed Apr 12 19:34:24 2017 New Revision: 300148 URL: http://llvm.org/viewvc/llvm-project?rev=300148&view=rev Log: Fix most failures caused by r300140 r300140 introduced a bunch of failures by changing the internal interface provided by __compressed_pair. This patch fixes all of

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

yamaguchi updated this revision to Diff 95064. yamaguchi added a comment. I've been trying to minimal the testcase, add comments to describe what it is testing, and fix styles of the testcase properly. However, I don't have clear idea what will be the best. I would like to ask for the advice.

r300145 - ExternalASTMerger.cpp: Silence another warning. [-Wunused-lambda-capture]

Author: chapuni Date: Wed Apr 12 19:17:28 2017 New Revision: 300145 URL: http://llvm.org/viewvc/llvm-project?rev=300145&view=rev Log: ExternalASTMerger.cpp: Silence another warning. [-Wunused-lambda-capture] Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/Extern

Re: [libcxx] r300140 - [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

This broke a bunch of bots. Fix incoming. Please don't revert. On Wed, Apr 12, 2017 at 5:45 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Wed Apr 12 18:45:53 2017 > New Revision: 300140 > > URL: http://llvm.org/viewvc/llvm-project?rev=300140&view=

[libcxx] r300132 - Fix test failures with older Clang versions

Author: ericwf Date: Wed Apr 12 18:17:17 2017 New Revision: 300132 URL: http://llvm.org/viewvc/llvm-project?rev=300132&view=rev Log: Fix test failures with older Clang versions Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.observers/get_del

[libcxx] r300140 - [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

Author: ericwf Date: Wed Apr 12 18:45:53 2017 New Revision: 300140 URL: http://llvm.org/viewvc/llvm-project?rev=300140&view=rev Log: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr. Summary: __compressed_pair takes and passes it's constructor argu

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

EricWF updated this revision to Diff 95058. EricWF marked an inline comment as done. EricWF added a comment. - Add a static assertion that the new `__compressed_pair` implementation is never used in a way that would be ABI-incompatible with the previous one. Specifically add a static assert that

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

K-ballo accepted this revision. K-ballo added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D27565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r300136 - Update to match LLVM r300135.

Author: rsmith Date: Wed Apr 12 18:21:25 2017 New Revision: 300136 URL: http://llvm.org/viewvc/llvm-project?rev=300136&view=rev Log: Update to match LLVM r300135. Remove "REQUIRES: long_tests" from test/Driver/response-file.c since it is now about 10x faster. (We can add that back if it's still

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

bruno added inline comments. Comment at: lib/Sema/SemaDeclObjC.cpp:4309 + const ObjCMethodDecl *Method) { + SourceLocation Loc; + QualType T; Maybe add an assert for `Triple.getArch() == llvm::Triple::x86)` here? Repos

[PATCH] D31996: Make Gentoo GNU GCC Config override whitespace tolerant

erichkeane updated this revision to Diff 95054. erichkeane added a comment. Oops, yeah, good suggestion. https://reviews.llvm.org/D31996 Files: lib/Driver/ToolChains/Gnu.cpp Index: lib/Driver/ToolChains/Gnu.cpp === --- lib/Driv

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk updated this revision to Diff 95053. vsk edited the summary of this revision. vsk added a comment. Eli pointed out that it's possible to make alignment checks for extern globals work better (llvm.org/PR32630). One solution depends on emitting alignment checks on bases of member expressions w

[PATCH] D31996: Make Gentoo GNU GCC Config override whitespace tolerant

craig.topper added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2176 for (StringRef Line : Lines) { + StringRef TrimLine = Line.trim(); // CURRENT=triple-version Can we just do Line = Line.trim() so we won't have an extra StringRe

[libcxx] r300126 - [libc++] Implement LWG 2911 - add an is_aggregate type-trait

Author: ericwf Date: Wed Apr 12 18:08:46 2017 New Revision: 300126 URL: http://llvm.org/viewvc/llvm-project?rev=300126&view=rev Log: [libc++] Implement LWG 2911 - add an is_aggregate type-trait Summary: This patch implements http://cplusplus.github.io/LWG/lwg-defects.html#2911. I'm putting this

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: include/memory:2058 -template ::type, - typename remove_cv<_T2>::type>::value, -bool = is_empty<_T1>::value -

[PATCH] D31996: Make Gentoo GNU GCC Config override whitespace tolerant

erichkeane created this revision. The config-*triple* file handling isn't tolerant of leading/trailing whitespace, making it not terribly obvious when a single extraneous tab/space/etc will cause the override to be ignored. This patch simply trims the lines to ensure that it is tolerant of whi

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

EricWF updated this revision to Diff 95051. EricWF marked 2 inline comments as done. EricWF added a comment. - Address all inline comments. https://reviews.llvm.org/D27565 Files: include/__hash_table include/memory include/string test/std/utilities/memory/unique.ptr/unique.ptr.runtime/

[libcxx] r300124 - Additional test file for r300123

Author: marshall Date: Wed Apr 12 17:51:56 2017 New Revision: 300124 URL: http://llvm.org/viewvc/llvm-project?rev=300124&view=rev Log: Additional test file for r300123 Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.assign/emplace.pass.cpp Modified: libcx

[libcxx] r300123 - Implement part of LWG#2857 - any/optional. Still to do - variant. Reviewed as https://reviews.llvm.org/D31956

Author: marshall Date: Wed Apr 12 17:51:27 2017 New Revision: 300123 URL: http://llvm.org/viewvc/llvm-project?rev=300123&view=rev Log: Implement part of LWG#2857 - any/optional. Still to do - variant. Reviewed as https://reviews.llvm.org/D31956 Modified: libcxx/trunk/include/any libcxx/t

r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

Author: rnk Date: Wed Apr 12 17:50:51 2017 New Revision: 300122 URL: http://llvm.org/viewvc/llvm-project?rev=300122&view=rev Log: [clang-cl] Make all sanitizer flags available in clang-cl Summary: Use a tablegen let {} block so that new sanitizer flags are available by default in all driver modes

[libcxx] r300121 - Fix incorrectly qualified return type from unique_ptr::get_deleter().

Author: ericwf Date: Wed Apr 12 17:43:49 2017 New Revision: 300121 URL: http://llvm.org/viewvc/llvm-project?rev=300121&view=rev Log: Fix incorrectly qualified return type from unique_ptr::get_deleter(). For reference deleter types the const qualifier on the return type of get_deleter() should be

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

EricWF updated this revision to Diff 95041. EricWF added a comment. - Add comment explaining `_GNUC_VER_NEW`. https://reviews.llvm.org/D31515 Files: include/__config include/type_traits test/libcxx/utilities/meta/meta.unary/meta.unary.prop/missing_is_aggregate_trait.fail.cpp test/std/u

r300116 - [Sema] Add __is_aggregate type-trait

Author: ericwf Date: Wed Apr 12 17:12:15 2017 New Revision: 300116 URL: http://llvm.org/viewvc/llvm-project?rev=300116&view=rev Log: [Sema] Add __is_aggregate type-trait Summary: [LWG 2911](http://cplusplus.github.io/LWG/lwg-defects.html#2911) adds `std::is_aggregate` to the library, which requi

[clang-tools-extra] r300115 - Fix clang-tidy shared link with libc++

Author: ericwf Date: Wed Apr 12 17:07:47 2017 New Revision: 300115 URL: http://llvm.org/viewvc/llvm-project?rev=300115&view=rev Log: Fix clang-tidy shared link with libc++ Currently the ClangTidyMain.cpp fails to link against shared LLVM/Clang libraries due to the missing symbol: clang::tooli

r300114 - [analyzer] Add a check for IvarRegion in getExtraInvalidatedValues

Author: alexshap Date: Wed Apr 12 17:00:13 2017 New Revision: 300114 URL: http://llvm.org/viewvc/llvm-project?rev=300114&view=rev Log: [analyzer] Add a check for IvarRegion in getExtraInvalidatedValues This diff adds a defensive check in getExtraInvalidatedValues for the case when there are no re

[PATCH] D31887: [clangd] Add documentation page

mgehre added inline comments. Comment at: docs/clangd.rst:28 + +You can follow the instructions for `building Clang `_ but "extra Clang Tool" is **not** optional. + In the reference, it is called "extra Clang tools". h

r300110 - [modules] Delay calling DeclMustBeEmitted until it's safe.

Author: vvassilev Date: Wed Apr 12 16:56:05 2017 New Revision: 300110 URL: http://llvm.org/viewvc/llvm-project?rev=300110&view=rev Log: [modules] Delay calling DeclMustBeEmitted until it's safe. This patch implements the suggestion in D29753 that calling DeclMustBeEmitted in the middle of deseria

[PATCH] D27604: [Driver] Add compiler option to generate a reproducer

This revision was automatically updated to reflect the committed changes. Closed by commit rL300109: [Driver] Add compiler option to generate a reproducer (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D27604?vs=80981&id=95035#toc Repository: rL LLVM https://reviews.

[PATCH] D31781: [Modules] Allow local submodule visibility without c++

This revision was automatically updated to reflect the committed changes. Closed by commit rL300108: [Modules] Enable local submodule visibility for ObjC/C (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D31781?vs=94407&id=95034#toc Repository: rL LLVM https://reviews

r300108 - [Modules] Enable local submodule visibility for ObjC/C

Author: bruno Date: Wed Apr 12 16:46:16 2017 New Revision: 300108 URL: http://llvm.org/viewvc/llvm-project?rev=300108&view=rev Log: [Modules] Enable local submodule visibility for ObjC/C Remove the restriction where this is only valid with C++ rdar://problem/29055656 Differential Revision: http

r300109 - [Driver] Add compiler option to generate a reproducer

Author: bruno Date: Wed Apr 12 16:46:20 2017 New Revision: 300109 URL: http://llvm.org/viewvc/llvm-project?rev=300109&view=rev Log: [Driver] Add compiler option to generate a reproducer One way to currently test the reproducers is to setup "FORCE_CLANG_DIAGNOSTICS_CRASH=1" before invoking clang.

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. We agreed to implement a special switch for this, eg. `-Wunused-template` https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r300106 - Modular Codegen: Include testing for inline asm as well as some commentary on the implementaiton choice.

Author: dblaikie Date: Wed Apr 12 16:14:04 2017 New Revision: 300106 URL: http://llvm.org/viewvc/llvm-project?rev=300106&view=rev Log: Modular Codegen: Include testing for inline asm as well as some commentary on the implementaiton choice. Modified: cfe/trunk/test/Modules/Inputs/codegen/foo.

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300105 - Fix up test to handle the now split -fmodules-codegen and -fmodules-debuginfo flags

Author: dblaikie Date: Wed Apr 12 16:09:34 2017 New Revision: 300105 URL: http://llvm.org/viewvc/llvm-project?rev=300105&view=rev Log: Fix up test to handle the now split -fmodules-codegen and -fmodules-debuginfo flags Modified: cfe/trunk/test/Modules/codegen-nodep.test Modified: cfe/trunk/

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. ping... https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300104 - Modular Codegen: Separate flags for function and debug info support

Author: dblaikie Date: Wed Apr 12 15:58:33 2017 New Revision: 300104 URL: http://llvm.org/viewvc/llvm-project?rev=300104&view=rev Log: Modular Codegen: Separate flags for function and debug info support This allows using and testing these two features separately. (noteably, debug info is, so far

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. Here is an example that we recently had where we would be very happy to see better diagnostics: MessageTypes.h: #ifndef ROOT_MessageTypes #define ROOT_MessageTypes enum EMessageTypes { kROOTD_OPEN = 2004, //filename follows + mod

Re: [PATCH] [PPC64]: Add support for Swift calling convention

Is it possible to add a testcase for this? -- adrian > On Mar 22, 2017, at 5:00 AM, Andrew Jeffery via cfe-commits > wrote: > > Signed-off-by: Andrew Jeffery > --- > lib/Basic/Targets.cpp | 11 +++ > lib/CodeGen/TargetInfo.cpp | 14 -- > 2 files changed, 23 insertions(

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300100. https://reviews.llvm.org/D31702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. LGTM! https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek added a comment. ping https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

Yup, that looks like my fault, again. Thanks, Greg, for the test case. It's very similar to the final test in odr_hash.cc, which I thought I had fixed. On Wed, Apr 12, 2017 at 8:09 AM, Greg Bedwell wrote: > We're seeing the same assertion failing in our internal testing (I've not > bisected to

[libcxx] r300097 - [libc++] Use more appropriate conditional for ABI macro definition

Author: smeenai Date: Wed Apr 12 14:56:37 2017 New Revision: 300097 URL: http://llvm.org/viewvc/llvm-project?rev=300097&view=rev Log: [libc++] Use more appropriate conditional for ABI macro definition The inline function definition ABI macro is gated on COFF dllexport semantics, so it's more appr

[PATCH] D31167: Use FPContractModeKind universally

anemet added inline comments. Comment at: cfe/trunk/include/clang/Basic/LangOptions.def:220 +/// \brief FP_CONTRACT mode (on/off/fast). +ENUM_LANGOPT(DefaultFPContractMode, FPContractModeKind, 2, FPC_Off, "FP contraction type") LANGOPT(NoBitFieldTypeAlign , 1, 0, "bit-field typ

Re: [libcxxabi] r296940 - Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp

Hi Eric, This does not seem to do the right thing because, at this point, we have a fall-back implementation of __cxa_thread_atexit_impl (in src/cxa_thread_atexit.cpp), and this will be compiled if libc does not provide an implementation. Thus, the test will always pass (unless LIBCXXABI_ENAB

[PATCH] D31167: Use FPContractModeKind universally

hfinkel added inline comments. Comment at: cfe/trunk/include/clang/Basic/LangOptions.def:220 +/// \brief FP_CONTRACT mode (on/off/fast). +ENUM_LANGOPT(DefaultFPContractMode, FPContractModeKind, 2, FPC_Off, "FP contraction type") LANGOPT(NoBitFieldTypeAlign , 1, 0, "bit-field ty

[libcxx] r300079 - [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp.

Author: stl_msft Date: Wed Apr 12 12:16:38 2017 New Revision: 300079 URL: http://llvm.org/viewvc/llvm-project?rev=300079&view=rev Log: [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp. This happens when using Clang with MSVC's STL, so there are no actual uses of

[clang-tools-extra] r300077 - [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC

Author: krasimir Date: Wed Apr 12 12:13:08 2017 New Revision: 300077 URL: http://llvm.org/viewvc/llvm-project?rev=300077&view=rev Log: [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC Added: clang-tools-extra/trunk/clangd/ClangdMain.cpp - copied, changed from r299961, clang-tools-

[PATCH] D31840: [analyzer] Fix crash on access to property

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, looks good now, thanks! Repository: rL LLVM https://reviews.llvm.org/D31840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965 + +// Performing operator `&' on an lvalue expression is essentially a no-op. +// Then, if we are taking addresses of fields or elements, these are also alexshap wr

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965 + +// Performing operator `&' on an lvalue expression is essentially a no-op. +// Then, if we are taking addresses of fields or elements, these are also "Addre

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94991. gtbercea added a comment. Update check before loop. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94990. gtbercea added a comment. Fix for loop range. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp ==

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ created this revision. In code void foo(int *p) { if (p) {} } void bar(int *p) { foo(p); *p = 5; } we suppress the null dereference warning in `*p = 5` because the state split within the inlined function is essentially irrelevant, as this is merely a defensive check tha

r300074 - Revert r300001 "Revert r298824 & r298816, recommit r298742 & r298754"

Author: hans Date: Wed Apr 12 11:40:26 2017 New Revision: 300074 URL: http://llvm.org/viewvc/llvm-project?rev=300074&view=rev Log: Revert r31 "Revert r298824 & r298816, recommit r298742 & r298754" It caused PR32640. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94985. gtbercea added a comment. Refactor code. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp ===

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94983. gtbercea added a comment. Clean-up. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

r300071 - Moving a C++ test out of Sema and into SemaCXX; NFC.

Author: aaronballman Date: Wed Apr 12 10:56:02 2017 New Revision: 300071 URL: http://llvm.org/viewvc/llvm-project?rev=300071&view=rev Log: Moving a C++ test out of Sema and into SemaCXX; NFC. Added: cfe/trunk/test/SemaCXX/template-specialization.cpp Removed: cfe/trunk/test/Sema/template-s

[PATCH] D31886: [analyzer] Simplify values in binary operations more aggressively

NoQ added a comment. In https://reviews.llvm.org/D31886#724796, @xazax.hun wrote: > maybe we want to skip this kind of simplification in case of Z3? Hmm, that depends on how would we want to use it eventually. - If Z3 acts all alone and fires only over actual bug reports, then yeah, it turns

[PATCH] D31717: CodeGen: Let lifetime intrinsic use alloca address space

yaxunl updated this revision to Diff 94980. yaxunl retitled this revision from "CodeGen: Emit lifetime intrinsics with pointer argument in alloca address space" to "CodeGen: Let lifetime intrinsic use alloca address space". yaxunl edited the summary of this revision. yaxunl added a comment. Reba

[PATCH] D31966: [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D31428: [x86] fix AVX FP cmp intrinsic documentation (PR28110)

This revision was automatically updated to reflect the committed changes. Closed by commit rL300068: [x86] fix AVX FP cmp intrinsic documentation (PR28110) (authored by spatel). Changed prior to commit: https://reviews.llvm.org/D31428?vs=93366&id=94976#toc Repository: rL LLVM https://review

r300068 - [x86] fix AVX FP cmp intrinsic documentation (PR28110)

Author: spatel Date: Wed Apr 12 10:19:08 2017 New Revision: 300068 URL: http://llvm.org/viewvc/llvm-project?rev=300068&view=rev Log: [x86] fix AVX FP cmp intrinsic documentation (PR28110) This copies the text used in the #define statements to the code comments. The conflicting text comes from AM

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:343 +for (unsigned I = Stack.size() - 1; I > 0; --I) + if (checkMappableExprComponentListsForDeclAtLevel(VD, I - 2, Check)) +return true; Are you sure this is correct? If I is 1,

Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

We're seeing the same assertion failing in our internal testing (I've not bisected to a specific change yet though, but it seems likely it's the same thing as in the log from the modules bot). Here's a reduced example that triggers it: $ cat 2.h // tem

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 94972. gtbercea added a comment. Pass correct levels. Refactor code. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp ==

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein marked an inline comment as done. hokein added a comment. friendly ping @alexfh. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:53-54 +PushBackCall)), + hasParent(compoundStmt(unless(has(ReserveCall)), +

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein updated this revision to Diff 94969. hokein added a comment. Improve the way of detecting pre-allocation usage before the loop. https://reviews.llvm.org/D31757 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tidy/perform

[PATCH] D31886: [analyzer] Simplify values in binary operations more aggressively

xazax.hun added a comment. One last question: maybe we want to skip this kind of simplification in case of Z3? Probably the constraint managers could have a flag like "wantsSimplifiedConstraints"? Maybe somehow the checkers that are doing their own simplification could respect this flag as well

[PATCH] D31886: [analyzer] Simplify values in binary operations more aggressively

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thank you for working on this! https://reviews.llvm.org/D31886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

rogfer01 created this revision. Under `-fms-extensions` `__unaligned` is a type-qualifier that can be applied to a non-static member function declaration. This causes an assertion when mangling the name under Itanium, where that qualifier is not mangled. This patch justs makes the minimal chan

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren updated this revision to Diff 94961. yaron.keren added a comment. Added attribute test. https://reviews.llvm.org/D31540 Files: tools/clang/include/clang/AST/DeclBase.h tools/clang/lib/AST/Decl.cpp tools/clang/lib/AST/DeclBase.cpp tools/clang/test/SemaTemplate/friend-template

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Daniel, Thanks for your review! Sorry I am not available until this Friday, then I will update my patch. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-co

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D28670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >