teemperor added a comment.
If you can't reproduce, you should try running a debug build through valgrind.
It points out this issue:
==29522== Invalid read of size 4
==29522==at 0x16EBED0: clang::LocationContext::getCurrentStackFrame()
const (in /opt/clang/build/bin/clang-6.0)
==29522=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309081: [clang] Add ARM64 support to armintr.h for MSVC
compatibility (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D35862?vs=108208&id=108222#toc
Repository:
rL LLVM
https
Author: mgrang
Date: Tue Jul 25 22:29:40 2017
New Revision: 309081
URL: http://llvm.org/viewvc/llvm-project?rev=309081&view=rev
Log:
[clang] Add ARM64 support to armintr.h for MSVC compatibility
Summary: This fixes compiling with headers from the Windows SDK for ARM64.
Reviewers: compnerd, ruiu,
majnemer added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:5625
+ // The Run-time ABI for the ARM Architecture section 4.1.2 requires
+ // AEABI-complying FP helper functions to use the base AAPCS
+ // These AEABI functions are expanded in the ARM llvm backend, all
mgrang added a comment.
Patch updated as per comments.
https://reviews.llvm.org/D35862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang updated this revision to Diff 108208.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D35862
Files:
lib/Headers/CMakeLists.txt
lib/Headers/arm64intr.h
lib/Headers/intrin.h
Index: lib/Headers/intrin.h
===
--
compnerd added a comment.
I think that the approach is reasonable. However, the test needs tweaking.
The function and the call both are ambiguous in the match. Can you match the
call sequence? Or explicitly the local label and then the call.
https://reviews.llvm.org/D35538
_
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Please split this out into `arm64intr.h` and include it from `intrin.h` under a
`#if defined(_M_ARM64)` case before committing.
https://reviews.llvm.org/D35862
mstorsjo added a comment.
The Microsoft version of `intrin.h` includes a header named `arm64intr.h`
(IIRC), I think it'd be better for compatibility if we also provided a file
with the same name instead of reusing this one.
https://reviews.llvm.org/D35862
___
chandlerc added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:843
PGOOptions PGOOpt;
Maybe make this an optional to avoid the big predicate below?
Comment at: lib/CodeGen/BackendUtil.cpp:847-859
if (PGOOpt.RunProfileGen)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309067: [clang-tidy] Do not issue fixit for explicit
template specializations (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D35718?vs=107786&id=108193#toc
Repository:
rL LLVM
Author: flx
Date: Tue Jul 25 17:45:41 2017
New Revision: 309067
URL: http://llvm.org/viewvc/llvm-project?rev=309067&view=rev
Log:
[clang-tidy] Do not issue fixit for explicit template specializations
Summary:
Do not issue fixit in UnnecessaryValueParamCheck if the function is an explicit
templa
Author: szepet
Date: Tue Jul 25 16:49:16 2017
New Revision: 309061
URL: http://llvm.org/viewvc/llvm-project?rev=309061&view=rev
Log:
[StaticAnalyzer] LoopUnrolling - Attempt #2 to fix a crash in r309006.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/LoopUnrolling.cpp
Modified: cfe/trunk/lib/St
Should this go into 5.0 ?
On Tue, Jul 25, 2017 at 4:33 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Tue Jul 25 16:33:58 2017
> New Revision: 309058
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309058&view=rev
> Log:
> [CodeGen] Correctly m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309058: [CodeGen] Correctly model std::byte's aliasing
properties (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D35824?vs=108166&id=108185#toc
Repository:
rL LLVM
https:/
Author: majnemer
Date: Tue Jul 25 16:33:58 2017
New Revision: 309058
URL: http://llvm.org/viewvc/llvm-project?rev=309058&view=rev
Log:
[CodeGen] Correctly model std::byte's aliasing properties
std::byte, when defined as an enum, needs to be given special treatment
with regards to its aliasing pro
Author: rsmith
Date: Tue Jul 25 16:31:42 2017
New Revision: 309054
URL: http://llvm.org/viewvc/llvm-project?rev=309054&view=rev
Log:
Reorder tests to match latest SD-6 draft.
Modified:
cfe/trunk/test/Lexer/cxx-features.cpp
Modified: cfe/trunk/test/Lexer/cxx-features.cpp
URL:
http://llvm.org
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a tweaked comment. Thanks!
Comment at: lib/CodeGen/CodeGenTBAA.cpp:88-90
+ // C++1z [intro.object]p3: If a complete object is created in storage
+ // associated w
Author: chapuni
Date: Tue Jul 25 16:23:17 2017
New Revision: 309052
URL: http://llvm.org/viewvc/llvm-project?rev=309052&view=rev
Log:
clang/StaticAnalyzer/Core/PathSensitive/LoopUnrolling.h: Add a forward decl
AnalysisManager, to unbreak modules build.
Modified:
cfe/trunk/include/clang/Stati
Looks like one more failure (this time under ubsan) remains in this code
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6708/steps/check-clang%20ubsan/logs/stdio
Please fix asap.
/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/lib/StaticAnalyzer/
Author: mgrang
Date: Tue Jul 25 16:00:02 2017
New Revision: 309049
URL: http://llvm.org/viewvc/llvm-project?rev=309049&view=rev
Log:
[clang] Add abi-breaking-checks support to clang
Summary: You can now use REQUIRES:abi-breaking-checks in clang too
Reviewers: chapuni, probinson, ddunbar, jroelof
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309049: [clang] Add abi-breaking-checks support to clang
(authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D35426?vs=106671&id=108180#toc
Repository:
rL LLVM
https://reviews.ll
mgrang added a comment.
Refer
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf
for memory barriers.
https://reviews.llvm.org/D35862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Quuxplusone created this revision.
`pointer_traits::to_pointer(r)` is not required to return a deallocatable
pointer; indeed generally it *cannot* determine a deallocatable representation
without help from the allocator. Therefore, we must not rely on representations
derived from `to_pointer` w
mgrang created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This fixes compiling with headers from the Windows SDK for ARM64.
https://reviews.llvm.org/D35862
Files:
lib/Headers/armintr.h
Index: lib/Headers/armintr.h
=
t-tye added inline comments.
Comment at: include/clang/Basic/Builtins.def:717
+ATOMIC_BUILTIN(__opencl_atomic_fetch_max, "v.", "t")
+
#undef ATOMIC_BUILTIN
Will the OpenCL 2.0 memory fences also be supported which also have a memory
order and memory scope?
==
danielcdh updated this revision to Diff 108174.
danielcdh added a comment.
update
https://reviews.llvm.org/D35746
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.cpp
===
--- lib/CodeGen/BackendUtil.cpp
+++ lib
majnemer updated this revision to Diff 108166.
majnemer added a comment.
- Address review comments
https://reviews.llvm.org/D35824
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGenCXX/std-byte.cpp
Index: test/CodeGenCXX/std-byte.cpp
Author: szepet
Date: Tue Jul 25 14:54:58 2017
New Revision: 309036
URL: http://llvm.org/viewvc/llvm-project?rev=309036&view=rev
Log:
[StaticAnalyzer] LoopUnrolling - Attempt to fix a crash in r309006.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/LoopUnrolling.cpp
Modified: cfe/trunk/lib/Stat
rjmccall added a comment.
In https://reviews.llvm.org/D28691#820641, @b-sumner wrote:
> In https://reviews.llvm.org/D28691#820595, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D28691#820541, @b-sumner wrote:
> >
> > > There are other languages for heterogeneous compute that have scopes,
>
b-sumner added a comment.
In https://reviews.llvm.org/D28691#820595, @rjmccall wrote:
> In https://reviews.llvm.org/D28691#820541, @b-sumner wrote:
>
> > There are other languages for heterogeneous compute that have scopes,
> > although not exposed quite as explicitly as OpenCL. For example AMD
mikerice created this revision.
When an omp for loop is canceled the constructed objects are being destructed
twice.
It looks like the desired code is:
{
Obj o;
If (cancelled) branch-through-cleanups to cancel.exit.
}
[cleanups]
cancel.exit:
__kmpc_for_static_fini
br cancel.cont (*)
shenhan added a comment.
Thanks for pointing out the relevant CLs. I agree that's the clearer and better
solution.
(The only concern is that it has been sitting there for 2 months. I'll check
back.)
In https://reviews.llvm.org/D35849#820473, @vsk wrote:
> This won't do the right thing if more
shenhan added a comment.
Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include
"ubsan_blacklist.txt"?
https://reviews.llvm.org/D32842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
rjmccall added a comment.
In https://reviews.llvm.org/D28691#820541, @b-sumner wrote:
> There are other languages for heterogeneous compute that have scopes,
> although not exposed quite as explicitly as OpenCL. For example AMD's "HC"
> language. And any language making use of clang and targe
Author: spyffe
Date: Tue Jul 25 13:09:30 2017
New Revision: 309018
URL: http://llvm.org/viewvc/llvm-project?rev=309018&view=rev
Log:
Fix a bot by linking clang-import-test against libclangDriver
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clang-import
dcoughlin added inline comments.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313
+static bool isDominatedByNoReturnBlocks(const ExplodedNode *N) {
+ const CFG &Cfg = N->getCFG();
Do you really mean "is dominated by"? That is, "every path fro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309013: [Frontend] Mark some ASTUnit methods as const. NFC.
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35729?vs=107689&id=108138#toc
Repository:
rL LLVM
https://review
Author: spyffe
Date: Tue Jul 25 12:54:22 2017
New Revision: 309014
URL: http://llvm.org/viewvc/llvm-project?rev=309014&view=rev
Log:
[ExternalASTMerger] Import Objective-C classes
This patch adds functionality and a test for importing Objective-C classes
and their methods.
It also adds a flag to
Author: vedantk
Date: Tue Jul 25 12:53:27 2017
New Revision: 309013
URL: http://llvm.org/viewvc/llvm-project?rev=309013&view=rev
Log:
[Frontend] Mark some ASTUnit methods as const. NFC.
Patch by Hamza Sood!
Differential Revision: https://reviews.llvm.org/D35729
Modified:
cfe/trunk/include/c
On Tue, Jul 25, 2017 at 03:09:00PM -0400, Nico Weber via cfe-commits wrote:
> On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote:
>
> > On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> > > If you need this behavior for something, that sounds like something a
>
b-sumner added a comment.
In https://reviews.llvm.org/D28691#820526, @rjmccall wrote:
> In https://reviews.llvm.org/D28691#820489, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
> >
> > > Can we drop the "opencl" part of the name and use something like
> > > __s
vsk closed this revision.
vsk added a comment.
Thanks! This landed in r309008.
https://reviews.llvm.org/D35736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk marked an inline comment as done.
vsk added a comment.
I made the suggested test changes and updated the release notes: r309007
Repository:
rL LLVM
https://reviews.llvm.org/D35735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309007: [ubsan] Null-check pointers in -fsanitize=vptr
(PR33881) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35735?vs=107741&id=108133#toc
Repository:
rL LLVM
https://r
Author: vedantk
Date: Tue Jul 25 12:34:23 2017
New Revision: 309007
URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
Log:
[ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
The instrumentation generated by -fsanitize=vptr does not null check a
user pointer before loading from it
rjmccall added a comment.
In https://reviews.llvm.org/D28691#820489, @yaxunl wrote:
> In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
>
> > Can we drop the "opencl" part of the name and use something like
> > __scoped_atomic_*? Also, it may not make sense to support non-constant
>
Author: szepet
Date: Tue Jul 25 12:23:23 2017
New Revision: 309006
URL: http://llvm.org/viewvc/llvm-project?rev=309006&view=rev
Log:
[StaticAnalyzer] Completely unrolling specific loops with known bound option
This feature allows the analyzer to consider loops to completely unroll.
New requiremen
And this:
echristo@athyra ~/s/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M include/llvm/MC/MCParser/MCAsmParser.h
M lib/Target/X86/AsmParser/X86AsmParser.cpp
Committed r309005
On Tue, Jul 25, 2017 at 12:18 PM Eric Christopher
wrote:
> I've reverted th
I've reverted this and Nemanja's attempt at fixing in:
echristo@athyra ~/s/l/t/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
D test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
M lib/Sema/SemaStmtAsm.cpp
M test/CodeGen/ms-inline-asm.c
M test/CodeGenCXX/ms-inlin
Author: echristo
Date: Tue Jul 25 12:17:32 2017
New Revision: 309004
URL: http://llvm.org/viewvc/llvm-project?rev=309004&view=rev
Log:
Revert "This patch enables the usage of constant Enum identifiers within
Microsoft style inline assembly statements." as it is causing msan failures.
This revert
On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote:
> On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> > If you need this behavior for something, that sounds like something a
> > -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++
> > stdl
On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> If you need this behavior for something, that sounds like something a
> -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++
> stdlib and nothing else.
But the -lm is only there because -lc++ alone (
yaxunl added a comment.
In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
> Can we drop the "opencl" part of the name and use something like
> __scoped_atomic_*? Also, it may not make sense to support non-constant
> scope here since we can't predict what other scopes may be added by
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Otherwise this looks good to me.
Comment at: examples/clang-interpreter/CMakeLists.txt:73
+set_property(TARGET ${TARGET} PROPERTY COMPILE_FLAGS ${editedFlags})
+#mess
yaxunl updated this revision to Diff 108127.
yaxunl added a comment.
Add min/max and missing file.
https://reviews.llvm.org/D28691
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basi
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D28691#820375, @kzhuravl wrote:
> Seems like SyncScope.h file is missing?
Right. I will add it.
https://reviews.llvm.org/D28691
___
cfe-commits mailing l
vsk added a reviewer: vsk.
vsk added a comment.
This won't do the right thing if more than one sanitizer with a default
blacklist is enabled. It's also problematic that a default blacklist for one
sanitizer can blacklist code for a different sanitizer. See:
https://reviews.llvm.org/D32043
https
b-sumner added a comment.
Can we drop the "opencl" part of the name and use something like
__scoped_atomic_*? Also, it may not make sense to support non-constant scope
here since we can't predict what other scopes may be added by other languages
in the future.
https://reviews.llvm.org/D2869
shenhan created this revision.
This is to provide a default blacklist filename for UBSan.
While UBSan is turned on, it's better that clang pick up a blacklist file (when
exists), just as what ASan / MSan does, so we do not end up adding the
"-fsanitize-blacklist" option to every command line.
The test also fails on many other bots on http://lab.llvm.org:8011/console
, a short excerpt:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/9702/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ax86-ms-inline-asm-enum_feature.cpp
http://lab.llvm.org:8011/builders/clang-cmake-aarch64
thakis closed this revision.
thakis added a comment.
r308997, thanks!
https://reviews.llvm.org/D35780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL308996: [coroutines] Add serialization/deserialization of
coroutines (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D35383?vs=
Author: nico
Date: Tue Jul 25 11:02:57 2017
New Revision: 308997
URL: http://llvm.org/viewvc/llvm-project?rev=308997&view=rev
Log:
Introduce -nostdlib++ flag to disable linking the C++ standard library.
Projects that want to statically link their own C++ standard library currently
need to pass -n
Author: gornishanov
Date: Tue Jul 25 11:01:49 2017
New Revision: 308996
URL: http://llvm.org/viewvc/llvm-project?rev=308996&view=rev
Log:
[coroutines] Add serialization/deserialization of coroutines
Reviewers: rsmith
Reviewed By: rsmith
Subscribers: EricWF, cfe-commits
Differential Revision: h
kcc added a comment.
Hi.
This patch causes the msan bots to complain. Please fix or revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6702/steps/check-clang%20msan/logs/stdio
Testing: 0 .. 10..
FAIL: Clang :: CodeGen/ms_this.cpp (2142 of 11057)
- TEST 'Clang :: C
kzhuravl added a comment.
Seems like SyncScope.h file is missing?
https://reviews.llvm.org/D28691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
euhlmann created this revision.
euhlmann added a project: clang.
Change 272124* introduced a regression in spaceRequiredBetween for left aligned
pointers to decltype and typeof expressions. This fix adds logic to fix this.
The test added is based on a related test in determineStarAmpUsage. Also
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me.
Comment at: lib/Driver/ToolChain.cpp:660
+ assert(!Args.hasArg(options::OPT_nostdlibxx) &&
+ "should not have called this");
CXXStdlibTyp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308990: [analyzer] Add diagnostic text for generalized
refcount annotations. (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D35613?vs=107471&id=108115#toc
Repository:
rL L
GorNishanov updated this revision to Diff 108111.
GorNishanov added a comment.
Thank you for the review. Feedback implemented. Preparing to land
https://reviews.llvm.org/D35383
Files:
include/clang/AST/StmtCXX.h
include/clang/Serialization/ASTBitCodes.h
lib/AST/StmtCXX.cpp
lib/Serializa
Author: dcoughlin
Date: Tue Jul 25 10:17:09 2017
New Revision: 308990
URL: http://llvm.org/viewvc/llvm-project?rev=308990&view=rev
Log:
[analyzer] Add diagnostic text for generalized refcount annotations.
Add a 'Generalized' object kind to the retain-count checker and suitable
generic diagnostic
Quuxplusone added inline comments.
Comment at: test/CodeGenCXX/std-byte.cpp:7
+enum byte : unsigned char {};
+}
+
Would it be worth adding an explicit test that `::byte`, `::my::byte`,
`::my::std::byte` are or are not handled in the same way?
https://reviews.l
r308988. Thanks!
On Mon, Jul 24, 2017 at 9:55 AM, Nico Weber wrote:
> We probably want this in 5.0.
>
> On Mon, Jul 24, 2017 at 12:54 PM, Nico Weber via cfe-commits
> wrote:
>>
>> Author: nico
>> Date: Mon Jul 24 09:54:11 2017
>> New Revision: 308897
>>
>> URL: http://llvm.org/viewvc/llvm-projec
dcoughlin added a comment.
Do we have a radar for this? It sounds familiar.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313
+static bool isNoReturnBlock(const CFGBlock *Blk) {
+ if (Blk->hasNoReturnElement())
Maybe a better name for this w
Author: nemanjai
Date: Tue Jul 25 10:04:12 2017
New Revision: 308985
URL: http://llvm.org/viewvc/llvm-project?rev=308985&view=rev
Log:
This test case is causing all PPC and SystemZ bots to remain red.
Notifying the author via Diffusion did not yield any answer. Therefore, I'm
adding the missing t
majnemer updated this revision to Diff 108105.
majnemer added a comment.
- Address review feedback.
https://reviews.llvm.org/D35824
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGenCXX/std-byte.cpp
Index: test/CodeGenCXX/std-byte.cpp
===
chill added a comment.
Ping.
https://reviews.llvm.org/D33676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
In https://reviews.llvm.org/D34030#819699, @MontyKutyi wrote:
> As I can see the `clang/test` contains a lot of different simple tests, but
> for testing this I think it is not enough to run the clang with some
> arguments on a specific input. So I should create a new ex
bruno added a comment.
If there's a precedence for a flag name there, it's nice to be compatible here.
You don't necessarily need to use the same name as the backend.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.ll
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Sorry for the delay! This looks good to me.
We have a really embarrassing FIXMELATER from 2012 (!!!) that disabled the
plist tests for diagnostics. This means we're not getting testing f
dcoughlin added a comment.
I will commit.
Repository:
rL LLVM
https://reviews.llvm.org/D35613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D33900#819237, @dim wrote:
> Also note that it is only added to the `--version` output, not the `-v`
> output (the former is really a "verbose" version of the latter):
Which seems to be the opposite of what gcc does (`gcc -v` is more verbose th
Author: abataev
Date: Tue Jul 25 08:53:26 2017
New Revision: 308979
URL: http://llvm.org/viewvc/llvm-project?rev=308979&view=rev
Log:
[OPENMP] Codegen for 'task_reduction' clause.
Added codegen for taskgroup directive with task_reduction clause.
```
```
The next code is emitted:
```
%struct.kmp_
spetrovic added a comment.
Hi Bruno,
Yes, GCC has similar option (-mtp=soft/hard), but name is not same. I put the
same option name as in backend (https://reviews.llvm.org/D34408).
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-c
peter.smith updated this revision to Diff 108092.
peter.smith added a comment.
Herald added a subscriber: javed.absar.
I've added a clang test that will check that none of the floating point helper
functions defined in the Runtime ABI for the ARM Architecture are directly
called by clang. Given
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
b-sumner wrote:
> yaxunl wrote:
>
b-sumner added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
yaxunl wrote:
> Anastasia wrote:
> > What about min/max? I believe they w
Author: kfunk
Date: Tue Jul 25 07:39:08 2017
New Revision: 308975
URL: http://llvm.org/viewvc/llvm-project?rev=308975&view=rev
Log:
[clang-tidy] Fixup clang-apply-replacements/invalid-files test
Modified:
clang-tools-extra/trunk/test/clang-apply-replacements/invalid-files.cpp
Modified:
clan
arphaman updated this revision to Diff 108078.
arphaman added a comment.
Simplified the implementation of `LexicallyOrderedRecursiveASTVisitor` and
removed redundant DenseMap checks.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D35012
Files:
include/clang/AST/LexicallyOrderedRecursi
kfunk added a comment.
Seems to have worked:
Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ...
A
test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml
A test/clang-apply-replacements/invalid-files.cpp
M c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308974: [clang-tidy] clang-apply-replacements: Don't insert
null entry (authored by kfunk).
Repository:
rL LLVM
https://reviews.llvm.org/D35194
Files:
clang-tools-extra/trunk/clang-apply-replacemen
Author: kfunk
Date: Tue Jul 25 07:28:16 2017
New Revision: 308974
URL: http://llvm.org/viewvc/llvm-project?rev=308974&view=rev
Log:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Summary:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Fix crash when running clang-
yaxunl updated this revision to Diff 108073.
yaxunl marked 16 inline comments as done.
yaxunl edited the summary of this revision.
yaxunl added a reviewer: kzhuravl.
yaxunl added a comment.
Herald added a subscriber: nhaehnle.
Rebased to ToT and revised by Anastasia's comments.
https://reviews.l
yaxunl marked 16 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
Anastasia wrote:
> What about min
abeserminji updated this revision to Diff 108067.
abeserminji added a comment.
Comments resolved and patch adapted to current revision.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
Files:
Basic/Targets/Mips.cpp
clang/Basic/DiagnosticCommonKinds.td
Index: Basic/Targets/Mips.cpp
=
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comments resolved
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Do you need someone to commit the patch for you?
https://reviews.llvm.org/D35194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
sdardis added a reviewer: cfe-commits.
sdardis added a comment.
Also, this need to be posted to cfe-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
aaron.ballman added a comment.
In https://reviews.llvm.org/D33672#819683, @xazax.hun wrote:
> Aaron, could you comment on the applicability of this check to C? Thanks in
> advance.
C has different rules for their enumerations in that the enumerators are all
ints, but the enumeration type is e
1 - 100 of 133 matches
Mail list logo