[PATCH] D45835: Add new driver mode for dumping compiler options

hfinkel added inline comments. Comment at: test/Frontend/compiler-options-dump.cpp:3 +// RUN: %clang_cc1 -compiler-options-dump -std=c++17 %s -o - | FileCheck %s --check-prefix=CXX17 +// RUN: %clang_cc1 -compiler-options-dump -std=c99 -ffast-math -x c %s -o - | FileCheck %s

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

rsmith added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:9690 + CanQualType CanonicalDesiredBase = DesiredBase->getCanonicalTypeUnqualified() +.getUnqualifiedType(); for (auto : Derived->bases()) { How are we getting a qualified type here? Is

[PATCH] D47417: [analyzer] Add missing state transition in IteratorChecker

MTC added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:399 + + C.addTransition(State); } I have two questions may need @NoQ or @xazax.hun who is more familiar with the analyzer engine help to answer. - `State` may not change

[PATCH] D47435: Add __builtin_signbit semantic checking

aaron.ballman added inline comments. Comment at: test/Sema/builtins.c:228 // expected-note {{change size argument to be the size of the destination}} - + __builtin___strlcat_chk(buf, b, sizeof(b),

[PATCH] D47435: Add __builtin_signbit semantic checking

aaron.ballman created this revision. aaron.ballman added reviewers: rengolin, chatur01, rsmith. aaron.ballman added inline comments. Comment at: test/Sema/builtins.c:228 // expected-note {{change size argument to be the size of the

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus marked 9 inline comments as done. Szelethus added a comment. Thanks again for taking a look :) Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:359-372 + // Checking bases. + const auto *CXXRD = dyn_cast(RD); + if (!CXXRD) +return

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

Prazek updated this revision to Diff 148764. Prazek added a comment. small update Repository: rL LLVM https://reviews.llvm.org/D47108 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/LangOptions.def

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

rustam added a comment. I believe this fixed the bug #37600 Repository: rC Clang https://reviews.llvm.org/D47419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

Prazek updated this revision to Diff 148762. Prazek added a comment. Fixed missing vtable commponents Repository: rL LLVM https://reviews.llvm.org/D47108 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman added a comment. In https://reviews.llvm.org/D46112#1098243, @rsmith wrote: > In https://reviews.llvm.org/D46112#1096893, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D46112#1091981, @efriedma wrote: > > > > > Also needs some test coverage for atomic operations which

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman updated this revision to Diff 148753. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Corrected some of the review comments. https://reviews.llvm.org/D46112 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Type.cpp

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman added a comment. Ping. https://reviews.llvm.org/D45835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

Prazek updated this revision to Diff 148746. Prazek marked 3 inline comments as done. Prazek added a comment. one more test Repository: rL LLVM https://reviews.llvm.org/D47299 Files: clang/include/clang/AST/DeclCXX.h clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

Prazek updated this revision to Diff 148745. Prazek added a comment. Herald added a subscriber: hiraditya. Added launder when going from possiblyNotDynamic to possiblyDynamic emitting strip for pointer -> int only if poitner is possiblyDynamic Repository: rL LLVM

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

cpplearner created this revision. cpplearner added a reviewer: rsmith. Herald added a subscriber: cfe-commits. This will allow the following code: struct base {}; using cbase = const base; struct inherit : cbase { using cbase::cbase; // previously error: 'cbase' (aka 'const base') is

r333352 - [DebugInfo] Fix typo. NFC

Author: maskray Date: Sun May 27 00:23:04 2018 New Revision: 52 URL: http://llvm.org/viewvc/llvm-project?rev=52=rev Log: [DebugInfo] Fix typo. NFC Modified: cfe/trunk/include/clang/Basic/DebugInfoOptions.h Modified: cfe/trunk/include/clang/Basic/DebugInfoOptions.h URL: