This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343248: [clangd] Initial supoprt for cross-namespace
global code completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52364?vs=167356=167357#toc
ioeric updated this revision to Diff 167356.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52364
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.h
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:1251
+ // from any scope.
+ std::pair, bool> QueryScopes;
// Include-insertion and proximity scoring rely on the include
kbobyrev added inline comments.
Comment at: clangd/index/dex/Dex.cpp:171
}
+ if (Req.AnyScope)
+ScopeIterators.push_back(createBoost(createTrue(Symbols.size()), 0.2));
Probably also check `!ScopeIterators.empty()`: otherwise the latency might
increase
ioeric added inline comments.
Comment at: clangd/index/Index.h:430
///
- /// The global scope is "", a top level scope is "foo::", etc.
+ /// The global scope is "", a top level scope is "foo::", etc. "*" is
+ /// wildcard.
sammccall wrote:
> I'm not a big
ioeric updated this revision to Diff 167135.
ioeric marked 14 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52364
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.h
sammccall added a comment.
This is really cool!
From reading the code this behaves exactly how I'd expect.
Ranking will be the real test.
Main comment is I'd like to tweak the interface on FuzzyFindRequest, rest is
basically nits.
Comment at: clangd/CodeComplete.cpp:367
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
When no scope qualifier is specified, allow completing index symbols
from any scope and insert proper automatically. This is still
