[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367305: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1589174 , @MaskRay wrote: > >> Even if it were, this would only affect future releases. The user experience >> of "you need to upgrade to Solaris 11.x" or install update y to get this" >> seems pretty dismal to me.

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. > You may not like them, but there are plenty of examples in OSTargets.h (for > kFreeBSD, Hurd, Linux, RTEMS, AIX, Windows, NaCl and several more). Why take offense in the Solaris case if this is already common practice? I used that as an example. Defining _GNU_SOURCE

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1588154 , @rnk wrote: > > To avoid a similar inconsistence with host compilers that don't predefine > > _FILE_OFFSET_BITS=64 > > (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted > > shortly. > > I'm

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > To avoid a similar inconsistence with host compilers that don't predefine > _FILE_OFFSET_BITS=64 > (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted > shortly. I'm

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added reviewers: mehdi_amini, rnk. ro added a comment. Ping? It's been a week and it would be good to get this patch and its companion into LLVM 9: it unbreaks `make check-all` with gcc 9 and restores g++ compatibility. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1579850 , @MaskRay wrote: > > Honestly I find such enforced C/C++ difference very unfortunate... e.g. > > if (Opts.CPlusPlus) > Builder.defineMacro("_GNU_SOURCE"); You may not like them, but there are plenty of

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. In D64482#1578376 , @ro wrote: > In D64482#1578245 , @MaskRay wrote: > > > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > > for C++ only, while clang has

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1578245 , @MaskRay wrote: > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > for C++ only, while clang has long been doing it for all languages > > Can you explain more about the hack >

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE for > C++ only, while clang has long been doing it for all languages Can you explain more about the hack https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0f97ccfdccc033f543ccbcb220697e62e84bf01f

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith. ro added a project: clang. `make check-all` currently fails on `x86_64-pc-solaris2.11` when building with GCC 9: Undefined first referenced symbol in file