Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-07 Thread Alex L via cfe-commits
On 6 December 2016 at 19:39, Vitaly Buka wrote: > Hi Alex, > > > > On Tue, Dec 6, 2016 at 11:14 AM Alex L wrote: > > Hi Vitaly, > > I noticed that you posted this patch up for review at > https://reviews.llvm.org/D27422, but then committed it instantly

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-06 Thread Vitaly Buka via cfe-commits
Hi Alex, On Tue, Dec 6, 2016 at 11:14 AM Alex L wrote: Hi Vitaly, I noticed that you posted this patch up for review at https://reviews.llvm.org/D27422, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-06 Thread Alex L via cfe-commits
Hi Vitaly, I noticed that you posted this patch up for review at https://reviews.llvm.org/D27422, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why you did this? I think that you should've waited for

r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-05 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: http://llvm.org/viewvc/llvm-project?rev=288689=rev Log: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec Summary: Similar to r288685. getExceptionSpec returned structure with pointers to