bmharper added a comment.
Pinging @djasper. Any chance we can get this merged?
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:207
+
+if (i != Start) {
+ if (Changes[i].NestingAndIndentLevel >
Merge the two ifs into a single one?
Comment at: lib/Format/WhitespaceManager.cpp:318
+ for
Author: a.sidorin
Date: Mon Jan 23 03:30:36 2017
New Revision: 292776
URL: http://llvm.org/viewvc/llvm-project?rev=292776&view=rev
Log:
ASTImporter: improve support for C++ templates
* Support template partial specialization
* Avoid infinite recursion in IsStructurallyEquivalent for TemplateArg
Author: a.sidorin
Date: Mon Jan 23 03:45:29 2017
New Revision: 292778
URL: http://llvm.org/viewvc/llvm-project?rev=292778&view=rev
Log:
ASTImporter: add forgotten tests for rL292776
Added:
cfe/trunk/test/ASTMerge/class-template-partial-spec/
cfe/trunk/test/ASTMerge/class-template-partial
Author: a.sidorin
Date: Mon Jan 23 04:16:30 2017
New Revision: 292779
URL: http://llvm.org/viewvc/llvm-project?rev=292779&view=rev
Log:
ASTImporter: quick test fix
Differential Revision: https://reviews.llvm.org/D26753
Modified:
cfe/trunk/test/ASTMerge/class-template-partial-spec/test.cpp
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292779: ASTImporter: quick test fix (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D26753?vs=79054&id=85332#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26753
Files:
Author: a.sidorin
Date: Mon Jan 23 04:39:45 2017
New Revision: 292781
URL: http://llvm.org/viewvc/llvm-project?rev=292781&view=rev
Log:
ASTImporter: fix tests on Windows with removing slashed parts of paths
Differential Revision: https://reviews.llvm.org/D26753
Modified:
cfe/trunk/test/ASTMe
a.sidorin added a comment.
Main revisions: https://reviews.llvm.org/rL292776,
https://reviews.llvm.org/rL292778. Sorry for not mentioning them in
Differential Revision.
Repository:
rL LLVM
https://reviews.llvm.org/D26753
___
cfe-commits mailing
krasimir updated this revision to Diff 85339.
krasimir added a comment.
- [clang-format] Improve the interface of BreakableToken and add comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Commen
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.h:87
/// space.
virtual void replaceWhitespace(unsigned LineIndex, unsigned TailOffset,
Split Split,
By the way, I got confused, this stays because the n
klimek added inline comments.
Comment at: lib/Format/BreakableToken.h:40
+/// of the content after a split has been used for breaking, and
+/// - insertBreak, for executing the split using a whitespace manager.
+///
Do we want to describe how replaceWhitespace
Hi Saleem,
This patch is causing our internal runs of the libc++ and libc++abi tests to
fail, because logDWARF is referenced but not defined in release builds (with
NDEBUG defined).
However, I see that all of the libc++ buildbots are passing. Does this patch
need modifying to make _LIBUNWIND_T
malcolm.parsons created this revision.
Herald added a subscriber: JDevlieghere.
The performance-unnecessary-value-param check mangled inherited
constructors, as the constructors' parameters do not have useful source
locations. Fix this by ignoring implicit functions.
Fixes PR31684.
https://revi
nkakuev added a comment.
Ping.
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nkakuev added a comment.
Ping.
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
madsravn added a comment.
Looks good to me. Nice touch by solving with implicit.
https://reviews.llvm.org/D29018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: malcolm.parsons
Date: Mon Jan 23 07:18:08 2017
New Revision: 292786
URL: http://llvm.org/viewvc/llvm-project?rev=292786&view=rev
Log:
[clang-tidy] Ignore implicit functions in performance-unnecessary-value-param
Summary:
The performance-unnecessary-value-param check mangled inherited
cons
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292786: [clang-tidy] Ignore implicit functions in
performance-unnecessary-value-param (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D29018?vs=85358&id=85365#toc
Repos
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292787: clang-format: remove tests that assume no config
file will be found as this is… (authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D28983?vs=85247&id=85366#toc
Repositor
Author: amaiorano
Date: Mon Jan 23 07:20:23 2017
New Revision: 292787
URL: http://llvm.org/viewvc/llvm-project?rev=292787&view=rev
Log:
clang-format: remove tests that assume no config file will be found as this is
not always the case
These tests fail for developers who place their build directo
mboehme created this revision.
Herald added subscribers: mgorny, mehdi_amini.
This reverts commit r292662.
This change broke internal builds. Will provide a reproducer internally.
https://reviews.llvm.org/D29025
Files:
lib/CodeGen/BackendUtil.cpp
test/CMakeLists.txt
test/CodeGenCXX/type-
krasimir updated this revision to Diff 85376.
krasimir added a comment.
- Add a note about replaceWhitespace in the comments of BreakableToken.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments.
Author: mboehme
Date: Mon Jan 23 08:33:42 2017
New Revision: 292791
URL: http://llvm.org/viewvc/llvm-project?rev=292791&view=rev
Log:
Revert "IRGen: Start using the WriteThinLTOBitcode pass."
Summary:
This reverts commit r292662.
This change broke internal builds. Will provide a reproducer inter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292791: Revert "IRGen: Start using the WriteThinLTOBitcode
pass." (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D29025?vs=85375&id=85379#toc
Repository:
rL LLVM
https://re
> On 17 Jan 2017, at 23:10, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> Date: Tue Jan 17 16:10:32 2017
> New Revision: 292276
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292276&view=rev
> Log:
> Fix std::string assignment ambiguity from braced initializer lists.
>
> When
krasimir updated this revision to Diff 85381.
krasimir added a comment.
- Add back a test case that I had previously removed for no good reason.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments
arpith-jacob created this revision.
The DSAChecker code in SemaOpenMP looks at the captured statement
associated with an OpenMP directive. A combined directive such as
'target parallel' has nested capture statements, which have to be
fully traversed before executing the DSAChecker. This is a pat
jhenderson created this revision.
Herald added a subscriber: fhahn.
Depends on https://reviews.llvm.org/D29023, which is currently under review. In
that change, I am adding diagnostic information to LLVM for why Stack Smash
Protection has been applied to each function. This is the second stage,
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5158
+ case llvm::Triple::avr:
+handleAVRInterruptAttr(S, D, Attr);
+break;
aaron.ballman wrote:
> Just call `handleSimpleAttribute()` instead.
Since this is no longer truly a sim
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:37-38
+ const auto *DeclStatement = Result.Nodes.getNodeAs("declstmt");
+ if (!DeclStatement)
+return;
+
Is there a case where this could happen? I would
sdardis created this revision.
The patch teaches the Clang driver how to handle the N64 static
relocation model properly. It enforces the correct target feature
(+noabicalls) when -fno-pic is used. This is required as non-pic
N64 code as the abi extension to call PIC code (CPIC) is unsupported.
M
sdardis created this revision.
Historically, NetBSD, FreeBSD and OpenBSD have defined the macro ABICALLS in
the preprocessor when -mabicalls is in effect.
Mainline GCC later defined __mips_abicalls when -mabicalls is in effect.
This patch teaches the preprocessor to define these macros when appr
sdardis added a comment.
Sending it to the correct list this time.
https://reviews.llvm.org/D29032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arpith
Date: Mon Jan 23 09:38:49 2017
New Revision: 292794
URL: http://llvm.org/viewvc/llvm-project?rev=292794&view=rev
Log:
[OpenMP] DSAChecker bug fix for combined directives.
The DSAChecker code in SemaOpenMP looks at the captured statement
associated with an OpenMP directive. A combi
aaron.ballman added a comment.
In https://reviews.llvm.org/D28520#652607, @dim wrote:
> In https://reviews.llvm.org/D28520#648880, @delesley wrote:
>
> > Sorry about the slow response. My main concern here is that the thread
> > safety analysis was designed for use with a library that wraps th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292794: [OpenMP] DSAChecker bug fix for combined directives.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29026?vs=85382&id=85393#toc
Repository:
rL LLVM
https://reviews.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arphaman updated this revision to Diff 85398.
arphaman added a comment.
Verify that the using shadow decl can be hidden by its owning using decl.
Repository:
rL LLVM
https://reviews.llvm.org/D28514
Files:
lib/Sema/SemaLookup.cpp
test/Index/complete-cached-globals.cpp
Index: test/Index/
arphaman added a comment.
In https://reviews.llvm.org/D28514#651724, @ahatanak wrote:
> If they are equal, the loop can continue because a UsingDecl doesn't hide a
> UsingShadowDecl that is tied to it.
You're right, that would be better, I didn't notice that method before.
Repository:
rL L
arphaman marked an inline comment as done.
arphaman added a comment.
In https://reviews.llvm.org/D27257#652135, @bruno wrote:
> How does this interact (if at all) with classes annotated with
> `__attribute__((objc_root_class))`?
The root classes are just classes without a superclass, the attr
arphaman updated this revision to Diff 85400.
arphaman added a comment.
Add comment to parameter
Repository:
rL LLVM
https://reviews.llvm.org/D27257
Files:
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-objc-message.m
Index: test/Index/complete-objc-message.m
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
https://reviews.llvm.org/D29033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: krasimir
Date: Mon Jan 23 10:21:06 2017
New Revision: 292796
URL: http://llvm.org/viewvc/llvm-project?rev=292796&view=rev
Log:
[clang-format] Fix LanguageKind comments.
Summary: With the introduction of LK_ObjC, the comment line for LK_Cpp became
obsolete.
Reviewers: djasper
Reviewed B
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292796: [clang-format] Fix LanguageKind comments. (authored
by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29033?vs=85397&id=85403#toc
Repository:
rL LLVM
https://reviews.llvm.org/
This happens to fire in practice in protobuf. It's probably a true positive
and it's cool that this warning found it, but it means we have to disable
Wuser-defined-warnings for a bit -- which then disables all of these
user-defined warnings. Right now there aren't any others, but it feels like
we'd
klimek added inline comments.
Comment at: lib/Format/BreakableToken.h:55-56
+/// been reformatted, and
+/// - replaceWhitespaceBefore, for executing the reflow using a whitespace
+/// manager.
+///
Shouldn't that be called insertBreakBefore for consistency th
Should this test that some specific mangling comes out the other end (tests
that amount to "test that this does anything other than crashing" always
make me a bit suspicious that there's /some/ specific behavior that is
intended/should be tested for)
On Fri, Jan 20, 2017 at 11:01 AM Richard Smith
hamzasood marked 5 inline comments as done.
hamzasood added a comment.
Ping
https://reviews.llvm.org/D28365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dergachev
Date: Mon Jan 23 10:57:11 2017
New Revision: 292800
URL: http://llvm.org/viewvc/llvm-project?rev=292800&view=rev
Log:
[analyzer] Fix memory space of static locals seen from nested blocks.
When a block within a function accesses a function's static local variable,
this local is c
Author: dblaikie
Date: Mon Jan 23 10:57:14 2017
New Revision: 292801
URL: http://llvm.org/viewvc/llvm-project?rev=292801&view=rev
Log:
Revert "DebugInfo: Omit class definitions even in the presence of
available_externally vtables"
Patch crashing on a bootstrapping sanitizer bot:
http://lab.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292800: [analyzer] Fix memory space of static locals seen
from nested blocks. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D28946?vs=85123&id=85408#toc
Repository:
rL LL
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
Thanks LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Anastasia added a comment.
> (I should pass -finclude-default-header after -cc1 without -Xclang then it
> works, but I think also the
> latter version should work, no?)
In general -cc1 and -Xclang have similar effect so I either should work indeed.
> Also, I cannot add -S (even with -emit-llvm
Author: stulova
Date: Mon Jan 23 11:12:36 2017
New Revision: 292804
URL: http://llvm.org/viewvc/llvm-project?rev=292804&view=rev
Log:
[OpenCL] Improved enqueue_kernel diagnostic message
- Removed duplicated word typo.
- Made coherent across multiple similar diagnostics.
Modified:
cfe/trunk/
Anastasia added a comment.
Ping! @yaxunl, Sam do you think you will have time to look into this?
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Mon Jan 23 11:23:23 2017
New Revision: 292805
URL: http://llvm.org/viewvc/llvm-project?rev=292805&view=rev
Log:
[Sema] UsingShadowDecl shouldn't be hidden by the UsingDecl that owns it
rdar://23454249
Differential Revision: https://reviews.llvm.org/D28514
Added:
cfe/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292805: [Sema] UsingShadowDecl shouldn't be hidden by the
UsingDecl that owns it (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28514?vs=85398&id=85414#toc
Repository:
rL
Author: marshall
Date: Mon Jan 23 11:25:38 2017
New Revision: 292806
URL: http://llvm.org/viewvc/llvm-project?rev=292806&view=rev
Log:
Removed some un-needed ifdefs
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp
Modified:
libcxx/trunk/test/std/utili
Anastasia created this revision.
Herald added a subscriber: yaxunl.
A bug is reported regarding incorrect error given for logical NOT operation
with a pointer type:
https://llvm.org/bugs/show_bug.cgi?id=30217
Detailed investigation shows that this has only been a problem for CL earlier
than v1.
Anastasia updated this revision to Diff 85418.
Anastasia added a comment.
Added missing test!
https://reviews.llvm.org/D29038
Files:
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/invalid-logical-ops-1.1.cl
test/SemaOpenCL/invalid-logical-ops-1.2.cl
test/SemaOpenCL/logical-ops.cl
Index: test/Se
r292807.
Thanks,
Hans
On Thu, Jan 19, 2017 at 5:22 PM, Richard Smith wrote:
> Hans, can we get this onto the Clang 4 release branch (along with the
> documentation added in r292558 and fixed in r292559)? This will allow us to
> avoid libc++ carrying a version test for Clang, and allow it to clea
Thanks!
On Thu, Jan 19, 2017 at 6:07 PM, Eric Fiselier wrote:
> Merged.
>
> Relevant commits:
>
> * r292566 - Merge r292564
> * r292565 - Merge r292560
>
> /Eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: marshall
Date: Mon Jan 23 12:00:15 2017
New Revision: 292809
URL: http://llvm.org/viewvc/llvm-project?rev=292809&view=rev
Log:
Revert previous cleanup; I got too agressive removing #ifdefs
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp
Modifi
On Thu, Jan 19, 2017 at 6:25 PM, Richard Smith wrote:
> On 19 January 2017 at 15:52, Hans Wennborg wrote:
>>
>> Richard, what do you think?
>
>
> Yes, let's merge this.
r292808.
Cheers,
Hans
>> On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote:
>> > Hi Hans,
>> >
>> > Would it be possible to merg
Sounds good to me.
On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote:
> We should merge this patch into the 4.0 release branch. It is needed to make
> "check-all" pass when using GCC 4, 5 and 6.
>
> /Eric
>
> On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits
> wrote:
>>
>> Autho
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
-
Author: rsmith
Date: Mon Jan 23 12:17:46 2017
New Revision: 292811
URL: http://llvm.org/viewvc/llvm-project?rev=292811&view=rev
Log:
Fix documentation typo from r292558.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/view
On 22 January 2017 at 07:57, Kim Gräsman wrote:
> Hi Richard,
>
> On Fri, Jan 20, 2017 at 1:58 AM, Richard Smith via cfe-commits
> wrote:
> >
> > +String builtins
> > +---
> > +
> > +Clang provides constant expression evaluation support for builtins
> forms of
> > +the following func
Hans,
Could we merge this one into the 4.0.0 release branch? It's a recent
bugfix for the analyzer.
Thanks,
Artem.
On 1/23/17 7:57 PM, Artem Dergachev via cfe-commits wrote:
Author: dergachev
Date: Mon Jan 23 10:57:11 2017
New Revision: 292800
URL: http://llvm.org/viewvc/llvm-project?rev=2
The only plan that we have at the moment is basically for a
-Wno-user-defined-warnings-in-system-headers type of flag. I agree that it
would be nice if we could be more granular than this, so I'll think about
what we can do.
On Mon, Jan 23, 2017 at 8:36 AM, Nico Weber wrote:
> This happens to fi
yaxunl added a comment.
The tests should be added to SemaOpenCL/extension-version.cl
Comment at: lib/Sema/SemaType.cpp:6683
+ // access qualifier unless the cl_khr_3d_image_writes extension is enabled.
+ if (CurType->isOCLImage3dWOType() &&
+ !S.getOpenCLOptions().isEnab
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok. Thanks Alex, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
arsenm added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
Should this have a 2.0 run l
arsenm added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
arsenm wrote:
> Should this
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This looks fine to me now, might be good to get someone else to ack as well
though.
https://reviews.llvm.org/D27872
___
cfe-commits mailing
Author: probinson
Date: Mon Jan 23 13:09:21 2017
New Revision: 292819
URL: http://llvm.org/viewvc/llvm-project?rev=292819&view=rev
Log:
Guard __gnuc_va_list typedef.
Differential Revision: http://reviews.llvm.org/D28620
Added:
cfe/trunk/test/Headers/stdarg-gnuc_va_list.c
Modified:
cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292819: Guard __gnuc_va_list typedef. (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D28620?vs=84151&id=85430#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28620
Fil
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229
+def remark_ssp_applied_reason
+: Remark<"SSP applied to function due to %select{an unknown reason|a "
+ "call to alloca|a stack allocated buffer or struct containing a "
rsmith added inline comments.
Comment at: include/clang/Sema/Overload.h:758
/// instead.
+/// FIXME: Now that it only alloates ImplicitConversionSequences, do we
want
+/// to un-generalize this?
Typo "alloates"
Comment at: lib/Sem
rsmith added a comment.
Generally looks good, but we have a better way of modeling types with a
trailing variable-length array that you should use.
Comment at: include/clang/AST/StmtCXX.h:299
/// down the coroutine frame.
class CoroutineBodyStmt : public Stmt {
enum SubSt
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
I don't think it's possible to check this in the way you're doing so here. In
general, there's no way to know whether a constant expression will be part of a
`typedef` declaration or
Author: marshall
Date: Mon Jan 23 13:51:54 2017
New Revision: 292822
URL: http://llvm.org/viewvc/llvm-project?rev=292822&view=rev
Log:
Fixed a typo in __config that prevented the aligned new/delete tests from
passing on Mac OS.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/
Author: marshall
Date: Mon Jan 23 13:53:28 2017
New Revision: 292823
URL: http://llvm.org/viewvc/llvm-project?rev=292823&view=rev
Log:
Implement LWG#2778: basic_string_view is missing constexpr.
Added:
libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp
Modified:
li
dim updated this revision to Diff 85440.
dim added a comment.
In https://reviews.llvm.org/D28520#653360, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28520#652607, @dim wrote:
>
> >
>
[...]
>> I'm really open to any variant, as long as something that works can get in
>> before the 4.0
mclow.lists added a comment.
Ok, this is weird. It looks like the changes to <__config> got committed, but
not the test.
https://reviews.llvm.org/D26110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:217
+ /// statements.
+ llvm::SmallVector LabelSeenStack;
+
Shouldn't this be maintained by some existing scoping structure like
LexicalScope?
Comment at: lib/CodeGen/
weimingz updated this revision to Diff 85446.
weimingz edited the summary of this revision.
weimingz added a comment.
As Eli sugguested, it's better to check it in Sema. In order to access
RelocationModel in Sema, we moved it from CodeGenOpts to LangOpts
https://reviews.llvm.org/D28526
Files:
EricWF added a comment.
I think I may have committed these changes as part of another change set.
https://reviews.llvm.org/D26110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:4031
// C99 6.5.3.4p4: the type (an unsigned integer type) is size_t.
+ if (isUnevaluatedContext() && ExprKind == UETT_SizeOf &&
+ TInfo->getType()->isVariablyModifiedType())
Is the isUnev
Author: ericwf
Date: Mon Jan 23 15:24:58 2017
New Revision: 292830
URL: http://llvm.org/viewvc/llvm-project?rev=292830&view=rev
Log:
Fix GCC C++03 build by hiding default template argument in C++03
Modified:
libcxx/trunk/include/string
Modified: libcxx/trunk/include/string
URL:
http://llvm.
This patch should be merge into the 4.0 branch.
It fixes a bug introduced to the 4.0 branch in r292354 (
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054).
/Eric
On Mon, Jan 23, 2017 at 2:24 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date:
Sounds good to me.
Anna, you're the code owner here. Ok to merge this?
Thanks,
Hans
On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote:
> Hans,
>
> Could we merge this one into the 4.0.0 release branch? It's a recent bugfix
> for the analyzer.
>
> Thanks,
> Artem.
>
>
>
> On 1/23/17 7:57 P
Author: ericwf
Date: Mon Jan 23 15:41:13 2017
New Revision: 292833
URL: http://llvm.org/viewvc/llvm-project?rev=292833&view=rev
Log:
Manually force the use of __decltype in C++03 with Clang 3.4.
uses `decltype` in a way incompatible with `__typeof__`.
This is problematic when compiling with Cla
We merged the first one, so I suppose we better fix it :-)
Sounds good to me.
On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote:
> This patch should be merge into the 4.0 branch.
>
> It fixes a bug introduced to the 4.0 branch in r292354
> (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21
This patch needs to get merged into 4.0 since the offending commit with the
misspelling is in the 4.0 branch.
/Eric
On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Jan 23 13:51:54 2017
> New Revision: 292822
>
>
This patch should be merge into 4.0 since it is needed to fix compile time
regressions in when using Clang 3.4 and C++03.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info.
/Eric
On Mon, Jan 23, 2017 at 2:41 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org
On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons
wrote:
> On 20 January 2017 at 21:32, Nico Weber wrote:
> > This warns about code like
> >
> > constexpr int foo = 4;
> > [&foo]() { use(foo); }
> >
> > That's correct, but removing &foo then makes MSVC complain about this
> code
> > like "err
Ok, go ahead.
On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote:
> This patch needs to get merged into 4.0 since the offending commit with the
> misspelling is in the 4.0 branch.
>
> /Eric
>
>
> On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits
> wrote:
>>
>> Author: marshall
>>
EricWF added a comment.
@dim I would really rather just suppress these warnings if we want them merged
into 4.0.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
My dream, and something I would like to work towards is supporting
something like this:
> [[clang::libcxx_diagnose_if(cond, "message", "warning", /* warning-id*/
"non-const-functor")]]
>
> -Wno-libcxx-warnings=non-const-functor
This way libc++ warnings get treated differently from all other users
1 - 100 of 164 matches
Mail list logo
