[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1339 + } + for (uint64_t i = 0, e = SrcATy->getNumElements(); i < e; ++i) { +Address EltPtr = CGF.Builder.CreateConstArrayGEP(Dest, i); Is there a limit on array size? We may en

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

fhahn abandoned this revision. fhahn added a comment. In D64128#1578916 , @fhahn wrote: > In D64128#1576391 , @rjmccall wrote: > > > I wouldn't favor adding something really obscure that was only useful for > > cla

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 265025. yaxunl retitled this revision from "[HIP] Support -offloading-target-id" to "[HIP] Support target id by --offload-arch". yaxunl edited the summary of this revision. yaxunl added a comment. rebased the patch and revised by passing target id by `--offloa

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers created this revision. nickdesaulniers added reviewers: echristo, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes pr/11710. Signed-off-by: Nick Desaulniers Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80242 Files: cla

[clang] 47650dc - Revert "[clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation"

Author: Dávid Bolvanský Date: 2020-05-19T23:20:54+02:00 New Revision: 47650dcbeee215f48277ed8bea5f0e43cbf125fc URL: https://github.com/llvm/llvm-project/commit/47650dcbeee215f48277ed8bea5f0e43cbf125fc DIFF: https://github.com/llvm/llvm-project/commit/47650dcbeee215f48277ed8bea5f0e43cbf125fc.dif

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

NeHuang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { I think we also need to check for `ArchDefi

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265046. zequanwu added a comment. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx11.cpp clang/test/CodeG

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265031. zequanwu added a comment. Remove check for context of `LambdaContextDecl`. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp Index: clan

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD updated this revision to Diff 265048. JakeMerdichAMD added a comment. Reformat with a newer clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 Files: clang/docs/ClangFormatStyleOp

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:72 + binaryOperator(hasOperatorName("=="), + hasEitherOperand(ignoringParenImpCasts(StringNpos)), + hasEithe

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. There are 65 that take a scalar shift amount. Intel documentation shows 60 of them taking unsigned int. There are 5 versions of srli_epi16 that use int, the 512-bit maskz and 128/256 mask/maskz. Fixes PR45931 h

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added a comment. Looks like this only implements support for typedefs, but the flag in GCC does more than that (as the flag name indicates - it's about unused types in general) - could you test this across some non-trivial code and see if it matches GCC's behavior (or, where it doesn't

[clang] b47d1ba - [analyzer][NSOrCFError] Don't emit diagnostics under the name osx.NSOrCFErrorDerefChecker

Author: Kirstóf Umann Date: 2020-05-20T00:05:49+02:00 New Revision: b47d1baa535abe061e6a89341e91c8b885b5b80e URL: https://github.com/llvm/llvm-project/commit/b47d1baa535abe061e6a89341e91c8b885b5b80e DIFF: https://github.com/llvm/llvm-project/commit/b47d1baa535abe061e6a89341e91c8b885b5b80e.diff

[clang] 66224d3 - [analyzer][ObjCGenerics] Don't emit diagnostics under the name core.DynamicTypePropagation

Author: Kirstóf Umann Date: 2020-05-20T00:19:20+02:00 New Revision: 66224d309d08c048b3bea257ceafe4873ce166c6 URL: https://github.com/llvm/llvm-project/commit/66224d309d08c048b3bea257ceafe4873ce166c6 DIFF: https://github.com/llvm/llvm-project/commit/66224d309d08c048b3bea257ceafe4873ce166c6.diff

[PATCH] D79967: Fix debug info for NoDebug attr

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. @yaxunl thanks, this patch lgtm. @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you. CHANGES SIN

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. In D60620#1464633 , @tra wrote: > It looks like you are solving two problems here. > a) you want to create multiple device passes for the same GPU, but with > different options. > b) you may want to pass different compiler option

[PATCH] D80166: [CGCall] Annotate reference parameters with "align" attribute.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGCall.cpp:2258 Attrs.addDereferenceableAttr(info.first.getQuantity()); -Attrs.addAttribute(llvm::Attribute::getWithA

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. ah, right. I need to additionally handle structs, unions, enums. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commit

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___ cfe-commits mailing list cfe-com

[PATCH] D78124: [analyzer][ObjCGenerics] Don't emit diagnostics under the name core.DynamicTypePropagation

This revision was automatically updated to reflect the committed changes. Closed by commit rG66224d309d08: [analyzer][ObjCGenerics] Don't emit diagnostics under the name core. (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78124?vs=257375&id=265067#toc Repository:

[PATCH] D78123: [analyzer][NSOrCFError] Don't emit diagnostics under the name osx.NSOrCFErrorDerefChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47d1baa535a: [analyzer][NSOrCFError] Don't emit diagnostics under the name osx. (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78123?vs=257373&id=265066#toc Repository:

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD added a comment. Can I get your assistance committing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___ cfe-commits mailing list cfe-comm

[clang] 3d0d2fe - analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

Author: Kirstóf Umann Date: 2020-05-20T00:37:59+02:00 New Revision: 3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8 URL: https://github.com/llvm/llvm-project/commit/3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8 DIFF: https://github.com/llvm/llvm-project/commit/3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8.diff

[clang] f2be30d - [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

Author: Kirstóf Umann Date: 2020-05-20T00:56:10+02:00 New Revision: f2be30def37d248a7666cfac3c922ca9db308c2a URL: https://github.com/llvm/llvm-project/commit/f2be30def37d248a7666cfac3c922ca9db308c2a DIFF: https://github.com/llvm/llvm-project/commit/f2be30def37d248a7666cfac3c922ca9db308c2a.diff

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD added a comment. +1 for this idea. It'd eventually be neat to also take all samples from the style guide of each project and test them, if there aren't licensing concerns. LGTM with an appropriate merge fix/CI passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD added a comment. Hey @MyDeveloperDay, can I get your assistance committing this when you have the chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465 __

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4965 + DBuilder.retainType(Ty); +} Looks like I can just reuse CGDebugInfo::EmitExplicitCastType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

saghir closed this revision. saghir added a comment. Herald added subscribers: sstefan1, yaxunl. Support for 'close' map-type-modifier code generation in clang has been added by patch D65341 . This revision can be closed. Repository: rC Clang CHANGES SINCE L

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 21 inline comments as done. fghanim added a comment. In D79675#2044809 , @jdoerfert wrote: > What's the status? Can we split the target specific types stuff if this may > take a while, other patches depend on that :) Could you please list

[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d0d2fefc0a1: analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D77845?vs=256461&id=265074#toc Reposito

[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2be30def37d: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D75431?vs=254816&id=265075#toc Reposi

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim updated this revision to Diff 265071. fghanim marked 2 inline comments as done. fghanim added a comment. Addressing reviewer Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ https://reviews.llvm.org/D79675 Files: clang/l

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a comment. In D79967#2045196 , @vsk wrote: > @yaxunl thanks, this patch lgtm. > > @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up > ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you. Th

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. For C++, I'd imagine: class foo {}; using my_foo = foo; template struct baz { bar my_bar; }; but it seems that `g++` doesn't emit debug info the for the templated struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 265077. nickdesaulniers added a comment. - add support for structs, unions, and enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/include/cla

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

Bigcheese added a comment. In D79998#2038430 , @dang wrote: > Should I add the test here or in the clang-scan-deps patch? It's best to have a test in every non-nfc patch. You should be able to test this with llvm-bcanalyzer. Repository: rG LLVM Gith

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 265081. zbrid added a comment. Add test; Update command for existing test Also rename file to match warning flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files:

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. In D79743#2044676 , @jyu2 wrote: > This looks good to me. Could you also add a test to use this new DiagGroup > (-Wno-slh-asm-goto)? > > Thanks. > > Jennifer Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. > Could you please list the other patches that are being held back by this one? > I'd be interested to have a look at them. :) We need the target type support for D80222 , D79739 can go in but we need

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/lib/Basic/HIP.cpp:16 +const llvm::SmallVector +getAllPossibleTargetIdFeatures(llvm::StringRef Device) { + llvm::SmallVector Ret; Nit: there's an unfortunate clash with already [[ https://github.com/llvm/llvm-project/

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Szelethus added a comment. I'm committing this now as-is, if something breaks, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76510/new/ https://reviews.llvm.org/D76510 ___ cfe-commits mail

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe1a3a7e8c8b: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D76510?vs=251673&id=265087#toc Rep

[clang] fe1a3a7 - [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Author: Kirstóf Umann Date: 2020-05-20T01:36:06+02:00 New Revision: fe1a3a7e8c8be33968b9a768666489823dabab10 URL: https://github.com/llvm/llvm-project/commit/fe1a3a7e8c8be33968b9a768666489823dabab10 DIFF: https://github.com/llvm/llvm-project/commit/fe1a3a7e8c8be33968b9a768666489823dabab10.diff

[clang] 392222d - [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

Author: Kristóf Umann Date: 2020-05-20T02:03:31+02:00 New Revision: 39dd72657244f13d7f99cc6a497cc78eba2e URL: https://github.com/llvm/llvm-project/commit/39dd72657244f13d7f99cc6a497cc78eba2e DIFF: https://github.com/llvm/llvm-project/commit/39dd72657244f13d7f99cc6a497cc78eba2e.diff

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265090. AbbasSabra added a comment. Fix code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp clang/

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

Bigcheese added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:156 /// \param [out] Res - The resulting invocation. + /// \param [in] CommandLineArgs - Array of argument strings, this should not + /// contain "-cc1". Is this r

[PATCH] D75432: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rG39dd7265: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent (authored by Szelethus). Herald added a subscriber: ASDenysPetrov. Changed prior to commit: https://reviews.llvm.org/D

[clang] 3a6ee4f - [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

Author: Kirstóf Umann Date: 2020-05-20T02:26:40+02:00 New Revision: 3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5 URL: https://github.com/llvm/llvm-project/commit/3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5 DIFF: https://github.com/llvm/llvm-project/commit/3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. `CXXRecordDecl` is a funny case, the AST looks like: |-CXXRecordDecl 0x5c661a8 col:7 class foo definition | |-DefinitionData pass_in_registers empty aggregate standard_layout trivially_copyable pod trivial literal has_constexpr_non_copy_ | `-CXXRecordDecl

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 265093. nickdesaulniers added a comment. - add C++ `using` and `class` support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/include/clang/Basi

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5369 if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never) - DebugInfo->completeUnusedClass(cast(*D)); + DebugInfo->completeUnusedClass(*CRD); }

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265095. AbbasSabra added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp clang/test/Anal

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. LGTM. Please changed format for td file. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:247 + + def warn_slh_does_not_support_asm_goto : Warning< +"Speculat

[PATCH] D78101: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6ee4fefec0: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra requested review of this revision. AbbasSabra added a comment. What you both said makes sense. Now, reference parameters are escaped and value parameters are treated as the local variables. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

rsmith added a comment. I would like a specification for this header to be added somewhere. We shouldn't be implementing random things with no specification. (Suppose someone claims that our `` is wrong in some way. How would we know whether they're right?) Ideally, I'd also like this header t

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim added a comment. In D79675#2045405 , @jdoerfert wrote: > > Could you please list the other patches that are being held back by this > > one? I'd be interested to have a look at them. :) > > We need the target type support for D80222

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, Bigcheese. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. HeaderSearch was marking requested HeaderFileInfo as Resolved only based on the presence of ExternalSource. As the result, using

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

xiangzhangllvm added a comment. Hello rsmith, first, very sorry for have committed this patch before your reply, I waited 10 days, I thought you have agreed it. I think the linux-ABI can be the specification of this head file. The context of this cet.h is according to the linux ABI about CET.

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

hjl.tools added a comment. In D79617#2045552 , @rsmith wrote: > I would like a specification for this header to be added somewhere. We > shouldn't be implementing random things with no specification. (Suppose > someone claims that our `` is wrong in some

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. No, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79903/new/ https://reviews.llvm.org/D79903 __

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2045563 , @fghanim wrote: > In D79675#2045405 , @jdoerfert wrote: > > > > Could you please list the other patches that are being held back by this > > > one? I'd be interested t

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2314 + nextToken(); + if (FormatTok->Tok.is(tok::less)) { +while (!FormatTok->Tok.is(tok::greater)) { miscco wrote: > I guess you could use `parseBracedList(/*Con

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai added a comment. Is this patch ready to land? Are there any comments or suggestions I missed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 ___ cfe-

[clang] e71c537 - [clang-format] Fix line lengths w/ comments in align

Author: mydeveloperday Date: 2020-05-20T07:22:01+01:00 New Revision: e71c537a487cacaa00265e1acb765235943d5172 URL: https://github.com/llvm/llvm-project/commit/e71c537a487cacaa00265e1acb765235943d5172 DIFF: https://github.com/llvm/llvm-project/commit/e71c537a487cacaa00265e1acb765235943d5172.diff

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

This revision was automatically updated to reflect the committed changes. Closed by commit rGe71c537a487c: [clang-format] Fix line lengths w/ comments in align (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ ht

[clang] b99bf0e - [clang-format][PR45816] Add AlignConsecutiveBitFields

Author: mydeveloperday Date: 2020-05-20T07:42:58+01:00 New Revision: b99bf0e08be4faa4527709541dfdc29240e0c75c URL: https://github.com/llvm/llvm-project/commit/b99bf0e08be4faa4527709541dfdc29240e0c75c DIFF: https://github.com/llvm/llvm-project/commit/b99bf0e08be4faa4527709541dfdc29240e0c75c.diff

[clang] cc918e9 - [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

Author: mydeveloperday Date: 2020-05-20T07:44:36+01:00 New Revision: cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140 URL: https://github.com/llvm/llvm-project/commit/cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140 DIFF: https://github.com/llvm/llvm-project/commit/cc918e90c048c6c9a59ed08e7b2a2f92b4ac8140.diff

[clang] 807ab2c - [clang-format] [PR42164] Add Option to Break before While

Author: mydeveloperday Date: 2020-05-20T07:48:45+01:00 New Revision: 807ab2cd0db398c420ca5b8a7fc260aaea5051a1 URL: https://github.com/llvm/llvm-project/commit/807ab2cd0db398c420ca5b8a7fc260aaea5051a1 DIFF: https://github.com/llvm/llvm-project/commit/807ab2cd0db398c420ca5b8a7fc260aaea5051a1.diff

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

hliao updated this revision to Diff 265148. hliao added a comment. Revise following comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80237/new/ https://reviews.llvm.org/D80237 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenCUDA/a

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

This revision was automatically updated to reflect the committed changes. Closed by commit rG807ab2cd0db3: [clang-format] [PR42164] Add Option to Break before While (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D79325?vs=264235&id=265153#toc Repository: rG L

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99bf0e08be4: [clang-format][PR45816] Add AlignConsecutiveBitFields (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D80176?vs=265048&id=265152#toc Repository: rG LLVM

[PATCH] D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc918e90c048: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 4c09289 - [clang] Add an API to retrieve implicit constructor arguments.

Author: Martin Böhme Date: 2020-05-19T09:21:26+02:00 New Revision: 4c09289f635c4291c41fe4396afba4ba839d265b URL: https://github.com/llvm/llvm-project/commit/4c09289f635c4291c41fe4396afba4ba839d265b DIFF: https://github.com/llvm/llvm-project/commit/4c09289f635c4291c41fe4396afba4ba839d265b.diff

[clang] 51bb212 - [Analyzer][VLASizeChecker] Check for VLA size overflow.

Author: Balázs Kéri Date: 2020-05-19T09:44:46+02:00 New Revision: 51bb2128ef03985fddf2a84f17d3276f4ae2c6ad URL: https://github.com/llvm/llvm-project/commit/51bb2128ef03985fddf2a84f17d3276f4ae2c6ad DIFF: https://github.com/llvm/llvm-project/commit/51bb2128ef03985fddf2a84f17d3276f4ae2c6ad.diff L

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev marked 2 inline comments as done. hyd-dev added a comment. Any reply? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D79967: Fix debug info for NoDebug attr

djtodoro added a comment. This seems reasonable, so this change looks good to me! @dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field. > That's why DIS

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. The LGTM (nit: clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

klimek added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; loic-joly-sonarsource wrote: > klimek wrote: > > Nice find! Why don't we need more states though? > > 1. wouldn'

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added subscribers: Abpostelnicu, sylvestre.ledru. MyDeveloperDay added a comment. This is totally fine, now I'm just concerned by the choice of defaults, I really don't know if we want to change the defaults for all the styles, I don't want to break all those people using it One

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for remembering this :D Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a comment

[PATCH] D79942: [clang] Add an API to retrieve implicit constructor arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c09289f635c: [clang] Add an API to retrieve implicit constructor arguments. (authored by mboehme, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51bb2128ef03: [Analyzer][VLASizeChecker] Check for VLA size overflow. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79330/new/ https

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay added a comment. In D80144#2042926 , @JakeMerdichAMD wrote: > This is a great improvement in readability. I think this will get in here > before it does for clang proper :D > > Likely/unlikely also seem to be supported on while, do-while,

[clang] d94bacb - [WebAssembly] Handle exception specifications

Author: Heejin Ahn Date: 2020-05-19T01:16:09-07:00 New Revision: d94bacbcf87a06abc0c1fc3405406399460debc3 URL: https://github.com/llvm/llvm-project/commit/d94bacbcf87a06abc0c1fc3405406399460debc3 DIFF: https://github.com/llvm/llvm-project/commit/d94bacbcf87a06abc0c1fc3405406399460debc3.diff LO

[PATCH] D80061: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGd94bacbcf87a: [WebAssembly] Handle exception specifications (authored by aheejin). Changed prior to commit: https://reviews.llvm.org/D80061?vs=264466&id=264821#toc Repository: rG LLVM Github Monorepo

[clang] 1d579f5 - [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

Author: Sam McCall Date: 2020-05-19T11:11:09+02:00 New Revision: 1d579f54d720dcc53e11386fdec59e07614599a5 URL: https://github.com/llvm/llvm-project/commit/1d579f54d720dcc53e11386fdec59e07614599a5 DIFF: https://github.com/llvm/llvm-project/commit/1d579f54d720dcc53e11386fdec59e07614599a5.diff LO

[clang] 48aa781 - [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

Author: Sam McCall Date: 2020-05-19T11:20:02+02:00 New Revision: 48aa781ae44a611967084ca031fdbb3a0712c40c URL: https://github.com/llvm/llvm-project/commit/48aa781ae44a611967084ca031fdbb3a0712c40c DIFF: https://github.com/llvm/llvm-project/commit/48aa781ae44a611967084ca031fdbb3a0712c40c.diff LO

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a comment' >> %t/compile_flags.txt // -I flag is relative to %t (where c

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79992 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80198 Files: clang

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos updated this revision to Diff 264827. nigelp-xmos added a comment. As suggested by FIXME comment in code, and review comment, moved the EmitTargetMetadata loop into XCore target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 Files

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG48aa781ae44a: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines (authored by sammccall). Changed prior to commit: https://reviews.llvm.o

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added a comment. Awesome, Thank you very much, I dragged my feet on starting to implement something for real. As a high level comment I think we need to handle requires expressions to get this correct, as `requires requires` would otherwise to bad things. From my early brainstorming i g

[PATCH] D80154: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d579f54d720: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] e408b54 - [clangd] Fix gcc compiler warning by removing extra ";" [NFC]

Author: Mikael Holmen Date: 2020-05-19T11:57:15+02:00 New Revision: e408b54290bd5dc35b02ef4270292d52c89d9751 URL: https://github.com/llvm/llvm-project/commit/e408b54290bd5dc35b02ef4270292d52c89d9751 DIFF: https://github.com/llvm/llvm-project/commit/e408b54290bd5dc35b02ef4270292d52c89d9751.diff

[clang] 56079e1 - [Analyzer][VLASizeChecker] Try to fix vla.c test problems.

Author: Balázs Kéri Date: 2020-05-19T12:12:28+02:00 New Revision: 56079e1de1129837aa7569d8b3bb5e50afc0f1ea URL: https://github.com/llvm/llvm-project/commit/56079e1de1129837aa7569d8b3bb5e50afc0f1ea DIFF: https://github.com/llvm/llvm-project/commit/56079e1de1129837aa7569d8b3bb5e50afc0f1ea.diff L

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a subscriber: STL_MSFT. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1566 Current.Type = TT_TrailingReturnArrow; - +} else if (Current.is(tok::arrow) && Curre

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

vsavchenko updated this revision to Diff 264831. vsavchenko added a comment. Fix code review remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78990/new/ https://reviews.llvm.org/D78990 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. With recovery expr, it is possible that we have a value-dependent expr within non-dependent context. Repository: rG L

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3499 return true; if (Right.Previous->ClosesTemplateDeclaration && Right.Previous->MatchingParen && I think that your change should actually come in here where we determi

  1   2   3   >