[clang] 7ff0bf5 - [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

Author: Kito Cheng Date: 2022-05-16T15:13:05+08:00 New Revision: 7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9 URL: https://github.com/llvm/llvm-project/commit/7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9 DIFF: https://github.com/llvm/llvm-project/commit/7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9.diff LO

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff0bf576b84: [RISCV][NFC] Refactor RISC-V vector intrinsic utils. (authored by kito-cheng). Changed prior to commit: https://reviews.llvm.org/D124730?vs=429184&id=429620#toc Repository: rG LLVM Gith

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. Still LGTM, thanks! The remaining suggestion can be addressed directly before committing the patch. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:324 + /// Check if the number of runtime checks exceed

[clang] e20bc89 - [clang-format] Fix PointerAlignment: Right not working with tab indentation.

Author: Marek Kurdej Date: 2022-05-16T09:42:20+02:00 New Revision: e20bc892b6facc56fffc012929157888bb798bed URL: https://github.com/llvm/llvm-project/commit/e20bc892b6facc56fffc012929157888bb798bed DIFF: https://github.com/llvm/llvm-project/commit/e20bc892b6facc56fffc012929157888bb798bed.diff

[PATCH] D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGe20bc892b6fa: [clang-format] Fix PointerAlignment: Right not working with tab indentation. (authored by cu

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 429630. upsj marked an inline comment as done. upsj added a comment. remove std::forward bodies from diagnostic tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Fil

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416 +// These mocks aren't quite right - we omit shared_ptr for simplicity. +// forward is included to show its body is not needed to get the diagnostic. +template T&& fo

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Had a read through this. I'm still digesting it, but the high-level approach seems reasonable to me. Could we add a test case for the recursive scenario that came up during chat: void foo(); template void foo(Head head, Tail... tail) { foo(tail...); }

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! A few more nits Comment at: clang-tools-extra/clangd/Headers.cpp:151 + // will know that the next inclusion is behind the IWYU pragma. + if (!Text.cons

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:258 + static inline llvm::SMTExprRef fromUnary(llvm::SMTSolverRef &Solver, + ASTContex

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong updated this revision to Diff 429633. martong marked 2 inline comments as done. martong added a comment. - Use existing fromUnOp - pass nullptr as FromTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://reviews.llvm.org/D12

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762 Opts.ResourceDir = ResourceDir; - Opts.BuildDynamicSymbolIndex = EnableIndex; + Opts.BuildDynamicSymbolIndex = true; Opts.CollectMai

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Another test case that comes to mind is: void f1(int a, int b); void f2(int c, int d); template void foo(Args... args) { if (cond) { f1(args...); } else { f2(args...); } } int main() { foo(1, 2); } I guess in this case it w

[clang] 5bc469f - [RISCV][NFC] Fix build issue

Author: Kito Cheng Date: 2022-05-16T16:00:23+08:00 New Revision: 5bc469fd96192039bafe4bb9f74c85b37f63212e URL: https://github.com/llvm/llvm-project/commit/5bc469fd96192039bafe4bb9f74c85b37f63212e DIFF: https://github.com/llvm/llvm-project/commit/5bc469fd96192039bafe4bb9f74c85b37f63212e.diff LO

[clang-tools-extra] 9902a09 - Add ThreadPriority::Low, and use QoS class Utility on Mac

Author: stk Date: 2022-05-16T10:01:49+02:00 New Revision: 9902a0945d22cd5757b16ebe85fe07059723aa09 URL: https://github.com/llvm/llvm-project/commit/9902a0945d22cd5757b16ebe85fe07059723aa09 DIFF: https://github.com/llvm/llvm-project/commit/9902a0945d22cd5757b16ebe85fe07059723aa09.diff LOG: Add

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rG9902a0945d22: Add ThreadPriority::Low, and use QoS class Utility on Mac (authored by stk , committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

sammccall added a comment. In D124715#3510908 , @stefanhaller wrote: > In D124715#3498846 , @sammccall > wrote: > >> Looks great! I'm happy to land it, will do so on Tuesday unless anyone has >> further comment

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The main idea is to compile the cxx gramma

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein added a comment. This is a revised version of D125231 , based on our discussion. It has a narrow scope: only nonterminals of the grammar are compiled; and it mainly focuses on interfaces; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. One more testcase: template void foo(Args...); template void bar(Args... args) { foo(args...); } template void foo(Args... args) { bar(args...); } int main() { foo(1, 2); } Sure, this is a stack overflow at runtime, but there's

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429637. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-

[clang-tools-extra] 40f361a - [clangd] Include Cleaner: ignore headers with IWYU export pragmas

Author: Kirill Bobyrev Date: 2022-05-16T10:13:47+02:00 New Revision: 40f361ace3e9a9c24bd99300216aeabd49ad99bb URL: https://github.com/llvm/llvm-project/commit/40f361ace3e9a9c24bd99300216aeabd49ad99bb DIFF: https://github.com/llvm/llvm-project/commit/40f361ace3e9a9c24bd99300216aeabd49ad99bb.diff

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40f361ace3e9: [clangd] Include Cleaner: ignore headers with IWYU export pragmas (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125669: Adding support for target in_reduction

RitanyaB created this revision. RitanyaB added reviewers: soumitra, koops, ssquare08, cchen, dreachem. Herald added a project: All. RitanyaB requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: c

[clang-tools-extra] 106e63c - [clangd] NFC: Rename field to be compatible with the function name

Author: Kirill Bobyrev Date: 2022-05-16T10:18:08+02:00 New Revision: 106e63ce47b5b00e376be9eef03a084c71c03f11 URL: https://github.com/llvm/llvm-project/commit/106e63ce47b5b00e376be9eef03a084c71c03f11 DIFF: https://github.com/llvm/llvm-project/commit/106e63ce47b5b00e376be9eef03a084c71c03f11.diff

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. In D125604#3514983 , @jhenderson wrote: > Are the TODO cases where the test fails if changing them? Yes, this and where the fix is not perfectly obvious. Comment at: llvm/test/FileCheck/missspelled-directive.

[clang] e57f578 - [clang-format] fix alignment w/o binpacked args

Author: Gregory Fong Date: 2022-05-16T10:25:06+02:00 New Revision: e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd URL: https://github.com/llvm/llvm-project/commit/e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd DIFF: https://github.com/llvm/llvm-project/commit/e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd.diff

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

This revision was automatically updated to reflect the committed changes. Closed by commit rGe57f57841fbb: [clang-format] fix alignment w/o binpacked args (authored by cha5on, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1251

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

TiehuZhang added a comment. In D122126#3515070 , @fhahn wrote: > Still LGTM, thanks! The remaining suggestion can be addressed directly before > committing the patch. Thanks, @fhahn! I'll add the precommit test when committing the patch Repository:

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein updated this revision to Diff 429645. hokein added a comment. move the findNonterminal to Grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125006/new/ https://reviews.llvm.org/D125006 Files: clang-tools-extra/pseudo/benchmarks/Bench

[clang-tools-extra] 1a65c49 - [pseudo] Support parsing variant target symbols.

Author: Haojian Wu Date: 2022-05-16T10:38:16+02:00 New Revision: 1a65c491be712f89b36af9d828b6ccce02de37db URL: https://github.com/llvm/llvm-project/commit/1a65c491be712f89b36af9d828b6ccce02de37db DIFF: https://github.com/llvm/llvm-project/commit/1a65c491be712f89b36af9d828b6ccce02de37db.diff LO

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG1a65c491be71: [pseudo] Support parsing variant target symbols. (authored by hokein). Changed prior to commi

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks good now! A last few nits here. Would you like me to commit for you? From your patches so far, I think it's appropriate to request commit access

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. Thanks, @rjmccall . I'm sorry I don't have much time on this patch recently. I will update it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end()) {

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

steakhal added a comment. Something is messed up with the diff. You refer to `fromUnOp()` but it's not defined anywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://reviews.llvm.org/D125547 __

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, I'll try to send one for Windows this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125628/new/ https://reviews.llvm.org/D125628

[PATCH] D125318: [analyzer] Add UnarySymExpr

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/unary-sym-expr.c:35 +return; + clang_analyzer_eval(-(x + y) == -3); // expected-warning{{TRUE}} +} martong wrote

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 429653. upsj marked 4 inline comments as done. upsj added a comment. review updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Files: clang-tools-extra/clangd/Cla

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added a comment. @sammccall Feel free to merge with Author: Tobias Ribizel Thanks for the vote of confidence, I'll apply once the forwarding stuff is done :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/

[PATCH] D125673: [clangd] Add command-line flag to set background indexing thread priority.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end()) {

[clang-tools-extra] 71cb8c8 - [clangd] parse all make_unique-like functions in preamble

Author: Tobias Ribizel Date: 2022-05-16T11:17:25+02:00 New Revision: 71cb8c8cb9c162448159f2bffd2c77a8ee82d71f URL: https://github.com/llvm/llvm-project/commit/71cb8c8cb9c162448159f2bffd2c77a8ee82d71f DIFF: https://github.com/llvm/llvm-project/commit/71cb8c8cb9c162448159f2bffd2c77a8ee82d71f.diff

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71cb8c8cb9c1: [clangd] parse all make_unique-like functions in preamble (authored by upsj, committed by sammccall). Repository: rG LLVM Github Mon

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added a comment. In D124749#3514224 , @sstwcw wrote: > The two parents of this revision change the same file, so the build bot says > patch does not apply. Does that mean I have to submit the parent patches > with less context? Mayb

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 429659. njames93 added a comment. Tweak logic for detecting nested `if`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files: clang-tools-extra/clang-tidy/readab

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:839 +void FormatTokenLexer::resizeToken(size_t NewLen) { + resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation( sstwcw wrote: > HazardyKnusperkeks wrote: > > Can

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong added a comment. In D125547#3515259 , @steakhal wrote: > Something is messed up with the diff. You refer to `fromUnOp()` but it's not > defined anywhere. No. There is no mess up here, the diff is correct. `fromUnOp` had been implemented way bef

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 429660. njames93 added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[clang] 9dffab9 - [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

Author: owenca Date: 2022-05-16T02:43:35-07:00 New Revision: 9dffab9d524a05742a765dea27aedc8a7080a402 URL: https://github.com/llvm/llvm-project/commit/9dffab9d524a05742a765dea27aedc8a7080a402 DIFF: https://github.com/llvm/llvm-project/commit/9dffab9d524a05742a765dea27aedc8a7080a402.diff LOG: [

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dffab9d524a: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125626/ne

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Reduces time spent in findRef by 66%. Repository: rG LLVM

[PATCH] D125673: [clangd] Add command-line flag to set background indexing thread priority.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM. i agree that having this as a config to let users prioritise some sources over others could be useful, but it's too intrusive and unclear how useful that would be in practice

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all extensions/features in clang by +default. + svenvh wrote: > Was this meant to go after the command example? true, will fix thi

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. As pointed out in the previous review section, having a dedicated accept acti

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

kadircet added a reviewer: kadircet. kadircet added a comment. 66% win sounds great, it would be nice to have some detailed numbers (but this is clearly a huge win, so no need to reperform the experiments if numbers are gone) Comment at: clang-tools-extra/clangd/XRefs.cpp:895

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 added a comment. Since latest update speed up gone from 0.87s to 0.04s for SemaCodeComplete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 ___ cfe-co

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://reviews.llvm.org/D125401 ___ cfe-commits mailing list

[PATCH] D125208: [OpenCL] Fix __remove_address_space documentation code example

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125208/new/ https://reviews.llvm.org/D125208

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These symbols are understood to not be used for client API consumption by

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

Anastasia created this revision. Anastasia added reviewers: mpaszkowski, iliya-diyachkov, svenvh, linjamaki. Herald added subscribers: ThomasRaoux, ebevhan. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. Following the new flow for exte

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

Anastasia updated this revision to Diff 429678. Anastasia added a comment. Fixed typo in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/include/llvm/ADT/Triple.h llvm/

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

Anastasia added a comment. Actually after some more thinking I have decided to go for a generic flag and I have created the review for it: https://reviews.llvm.org/D125679. Perhaps you can built your functionality on top of it when you get to it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:204 + return true; +} + LegalizeAdulthood wrote: > LegalizeAdulthood wrote: > > aaron.ballman wrote: > > > LegalizeAdulthood wrote: > >

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

aaron.ballman added a comment. Note, I'm in C standards committee meetings all week this week, so I expect I won't be doing many reviews this week and I'll be catching up as best I can starting next week. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp

[PATCH] D124435: [X86] Always extend the integer parameters in callee

jyknight added a comment. I find the option names you have a bit confusing. I'd like to suggest calling them, instead: caller: Extend a small integer parameter in the caller; callee will assume it has already been extended. callee : Pass a small integer parameter directly in caller, extend in c

[clang] acc80ea - [AST] Cleanup on getting the underlying decl of using-shdow decl.

Author: Haojian Wu Date: 2022-05-16T13:58:08+02:00 New Revision: acc80ea71bac51458df9d75552651e7c161db64b URL: https://github.com/llvm/llvm-project/commit/acc80ea71bac51458df9d75552651e7c161db64b DIFF: https://github.com/llvm/llvm-project/commit/acc80ea71bac51458df9d75552651e7c161db64b.diff LO

[PATCH] D123422: [AST] Cleanup on getting the underlying decl of using-shdow decl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc80ea71bac: [AST] Cleanup on getting the underlying decl of using-shdow decl. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125682: Add documentHighlight in clangd check for performance measurements.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository

[PATCH] D125535: [clang][NFC] Cleanup some coroutine tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bebbc7cb77: [clang][NFC] Cleanup some coroutine tests (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 80bebbc - [clang][NFC] Cleanup some coroutine tests

Author: Nathan Sidwell Date: 2022-05-16T05:15:12-07:00 New Revision: 80bebbc7cb77979ef9d229450b7ea84e3e9c6a5a URL: https://github.com/llvm/llvm-project/commit/80bebbc7cb77979ef9d229450b7ea84e3e9c6a5a DIFF: https://github.com/llvm/llvm-project/commit/80bebbc7cb77979ef9d229450b7ea84e3e9c6a5a.diff

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. In D125429#3512642 , @aaronpuchert wrote: > Proposed this in D125580 . Landed this two days ago and no one complained about it so far, so let's hope that solved it. Repository: rG LLVM

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 added a comment. So those times were a little unfair as now we don't use ParentMapContext, however the cost of building that is included in the running time for the check. In a use case where you have other enabled checks with do make use of that, the cost for building would be moved to

[PATCH] D125555: [clang] Add __has_target_feature

aaron.ballman added a comment. It's not clear to me why existing facilities shouldn't be extended to cover this case rather than coming up with another feature testing macro. There's already plenty of confusion for users to decide between `__has_feature` and `__has_extension`, and now we're tal

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added a comment. Glad this is working! It looks exciting... My high level comments are: - the core "what are the ultimate param vars for this call" function is large and reusable enough that we should give this a public interface in AST.h - the implementation does a few "extra" things

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne created this revision. ldionne added reviewers: phosek, mstorsjo. Herald added subscribers: abrachet, mgorny. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, Sanitizers, libc++, libc++abi, LLVM. Herald added subscribers: llvm-commits, li

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

sammccall added a comment. Few initial comments... Comment at: clang-tools-extra/pseudo/gen/Main.cpp:8 +//===--===// + +#include "clang-pseudo/Grammar.h" missing description

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. to make features like

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added a comment. It looks like this patch still lacks compatibility handling for all external users that are setting this option, which need to be able to set the option in this way at least until after the 15.0.0 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429696. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.llvm.org/D125675 Files: clang-tool

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:951 if (const auto *Tok = TB.spelledTokenAt(L)) -References.push_back({*Tok, Roles, ID}); +References.push_back({*Tok, Roles, getSymbolID(D)}); } kadircet

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429697. usaxena95 added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.llvm.org/D125675 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/cla

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:28 + + std::uint8_t R = static_cast(ConsumedCalls * 100) / TotalCalls; + assert(R <= 100 && "Invalid percentage, maybe bogus compacted data?"); =

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f8726191960: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 6f87261 - [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

Author: Nathan James Date: 2022-05-16T14:42:44+01:00 New Revision: 6f8726191960f068d1068f84dfb9077d85c64fb9 URL: https://github.com/llvm/llvm-project/commit/6f8726191960f068d1068f84dfb9077d85c64fb9 DIFF: https://github.com/llvm/llvm-project/commit/6f8726191960f068d1068f84dfb9077d85c64fb9.diff

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:83-86 +void DiscardedReturnValueCheck::onStartOfTranslationUnit() { + ConsumedCalls.clear(); + CallMap.clear(); +} aaron.ballman wrote: > Is this code

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for noticing this, LGTM! Comment at: clang-tools-extra/clangd/XRefs.cpp:961 const ParsedAST &AST; - const llvm::DenseSet &TargetIDs; + llvm::DenseMap TargetDe

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 429703. steplong added a comment. - Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[clang] b147717 - [MSVC] Add support for pragma alloc_text

Author: Stephen Long Date: 2022-05-16T07:00:17-07:00 New Revision: b147717bb36c915bedfb33c07259cac4f09502a1 URL: https://github.com/llvm/llvm-project/commit/b147717bb36c915bedfb33c07259cac4f09502a1 DIFF: https://github.com/llvm/llvm-project/commit/b147717bb36c915bedfb33c07259cac4f09502a1.diff

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

This revision was automatically updated to reflect the committed changes. Closed by commit rGb147717bb36c: [MSVC] Add support for pragma alloc_text (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125011/new/ https://reviews.llv

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3504113 , @heatd wrote: > Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the > comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 429715. njames93 added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/ https://reviews.llvm.org/D124806 Files: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/LanguageExtensions.rst:260 +``__has_target_feature`` + aaron.ballman wrote: > The first question that comes to mind for me is: why is `__has_fe

[PATCH] D125555: [clang] Add __has_target_feature

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/LanguageExtensions.rst:275 + // On amdgcn target + #if __has_target_feature("s-memtime-inst") +x = __builtin_amdgcn_s_memtime(); yaxunl wrote: > aaron.ballman wrot

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

krasimir added a comment. It looks like this regressed the following example by adding an unwanted level of indentation to the `#elif B` branch: % ./clang-format --version clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655) % cat

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

sebpop added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Hi Pavel, We need to handle one more case for __sync_* builtins, please see testcase and patches applied to GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105162 Repository: rG LLVM Github Monorepo C

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Mark this and D125691 as WIP since I'm still testing the approach on various combinations of debug info and optimization options (O0, O3 , thinlto, split-dwarf, split-dwarf-inlining, gline-tabl

[PATCH] D125694: [clang][DebugInfo] Allow function-local statics to be scoped within a lexical block (4/5)

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a part from D113743 split to mak

  1   2   >