[clang] [clang] Fix --entry command line option (PR #69114)

2023-10-16 Thread Tuur Martens via cfe-commits
https://github.com/JohnyTheCarrot updated https://github.com/llvm/llvm-project/pull/69114 >From 111d19a7e03e2c59afc8d40c8210a901378594ee Mon Sep 17 00:00:00 2001 From: Tuur Martens Date: Sun, 15 Oct 2023 18:08:35 +0200 Subject: [PATCH 1/2] [clang] Fix --entry command line option --- clang/inc

[clang] [clang] Additional FP classification functions (PR #69041)

2023-10-16 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/69041 >From 1374e323198d7188e688845eb951df4148a1dfd8 Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Wed, 11 Oct 2023 14:27:26 +0700 Subject: [PATCH 1/5] [clang] Additional FP classification functions C language st

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-16 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/69153 The code was previously using Lexer::findNextToken() which does not handle being passed the completion point as input. Fixes https://github.com/clangd/clangd/issues/1785 >From e1ae800faed2fe3f612686edf6f

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) Changes The code was previously using Lexer::findNextToken() which does not handle being passed the completion point as input. Fixes https://github.com/clangd/clangd/issues/1785 --- Full diff: https://githu

[clang] 5857fec - [clang][ASTImporter] Fix of possible crash "Did not find base!". (#67680)

2023-10-16 Thread via cfe-commits
Author: Balázs Kéri Date: 2023-10-16T10:31:01+02:00 New Revision: 5857fec27fe8ee5a48a2ee48a4d79a9e39b0332b URL: https://github.com/llvm/llvm-project/commit/5857fec27fe8ee5a48a2ee48a4d79a9e39b0332b DIFF: https://github.com/llvm/llvm-project/commit/5857fec27fe8ee5a48a2ee48a4d79a9e39b0332b.diff L

[clang] [clang][ASTImporter] Fix of possible crash "Did not find base!". (PR #67680)

2023-10-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/67680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-16 Thread Fangcao Wang via cfe-commits
@@ -10,6 +10,9 @@ ! Make sure that `-L' is "visible" to Flang's driver ! RUN: %flang -L/ -### %s +! Make sure that `-fcommon' is "visible" to Flang's driver LittleMeepo wrote: So should I put the test for this option somewhere else, or should I still put it

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-16 Thread via cfe-commits
mzyKi wrote: I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this assertion but it will not result in crash.So I think should not remove this assertion and try to find the reason ```!Result.isAbsent()``` Maybe somewhere change its valueKind. https://github.com/llvm/llvm-pr

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-16 Thread Andrzej Warzyński via cfe-commits
@@ -10,6 +10,9 @@ ! Make sure that `-L' is "visible" to Flang's driver ! RUN: %flang -L/ -### %s +! Make sure that `-fcommon' is "visible" to Flang's driver banach-space wrote: Separate file, please. https://github.com/llvm/llvm-project/pull/68657 __

[clang] [clang][Interp] Check pointer inc/dec ops for null (PR #69168)

2023-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/69168 None >From b20da36444adfbdbddd6d0dddf06535815ffe0c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 3 Sep 2023 07:03:04 +0200 Subject: [PATCH] [clang][Interp] Check pointer inc/dec ops f

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-16 Thread Qiu Chaofan via cfe-commits
ecnelises wrote: Does backend have any recognition of Haiku-PPC target? https://github.com/llvm/llvm-project/pull/69134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-16 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > > Agreed: AFAICS the only open issue is whether the Solaris test should use > > the `GNU` label as I have done, introduce an new common one (like `UNIX`; > > there's nothing GNU-specific in that test), or really introduce a separate > > copy of the check under a different

[clang] c68bc17 - [analyzer] Fix note for member reference (#68691)

2023-10-16 Thread via cfe-commits
Author: Gábor Spaits Date: 2023-10-16T10:55:31+02:00 New Revision: c68bc1726c1c14a297c75cae597dab00e9e7e905 URL: https://github.com/llvm/llvm-project/commit/c68bc1726c1c14a297c75cae597dab00e9e7e905 DIFF: https://github.com/llvm/llvm-project/commit/c68bc1726c1c14a297c75cae597dab00e9e7e905.diff

[clang] [analyzer] Fix note for member reference (PR #68691)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Gábor?= Spaits,=?utf-8?q?Gábor?= Spaits, =?utf-8?q?Gábor?= Spaits Message-ID: In-Reply-To: https://github.com/DonatNagyE closed https://github.com/llvm/llvm-project/pull/68691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/68678 >From 78f22a8a57f5b67660763b8c7731b9d3cddede72 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Tue, 10 Oct 2023 17:20:00 +0800 Subject: [PATCH 1/3] [Clang] Support target attr specifying CPU Currently targets

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Qiu Chaofan via cfe-commits
@@ -76,10 +80,14 @@ int __attribute__((target("fpmath=387"))) walrus(void) { return 4; } int __attribute__((target("float128,arch=hiss"))) meow(void) { return 4; } // no warning, same as saying 'nothing'. int __attribute__((target("arch="))) turtle(void) { return 4; } +// no

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-16 Thread Daniel Kutenin via cfe-commits
https://github.com/danlark1 updated https://github.com/llvm/llvm-project/pull/67023 >From 059bbfab50592026ce2785c5f7d98eaf5c9f8bd6 Mon Sep 17 00:00:00 2001 From: Daniel Kutenin Date: Thu, 21 Sep 2023 14:55:11 +0100 Subject: [PATCH 1/6] Add bound checking in nth_element --- libcxx/include/__al

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-16 Thread Qiu Chaofan via cfe-commits
@@ -11595,6 +11595,50 @@ SDValue PPCTargetLowering::LowerFP_EXTEND(SDValue Op, SelectionDAG &DAG) const { llvm_unreachable("ERROR:Should return for all cases within swtich."); } +// Lower mffsl intrinsic with mffs in targets without ISA 3.0 +static SDValue lowerMFFSL(SDValu

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
DonatNagyE wrote: After some delays (I had a short vacation, then forgot about this patch) I finally got some test results... and they revealed that it was causing lots of segfaults. @steakhal thanks for asking for the experimental confirmation, it was useful! After fixing the buggy line and

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-16 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/67299 >From 2d628587b9cede36e7a93ecb1414cc0c16596934 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 25 Sep 2023 17:06:26 +0800 Subject: [PATCH 1/3] [PowerPC] Fix use of FPSCR builtins in smmintrin.h smmintrin

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-16 Thread Mariya Podchishchaeva via cfe-commits
@@ -393,6 +393,9 @@ Bug Fixes in This Version operator in C. No longer issuing a confusing diagnostic along the lines of "incompatible operand types ('foo' and 'foo')" with extensions such as matrix types. Fixes (`#69008

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69079 From 2b127200dc7b7b7c60e3001c7acf49a33a22e2a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:06:05 +0300 Subject: [PATCH 1/2] [clang] [unittest] Add a test for Generi

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
@@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bound access"}; + BugType TaintBT{this, "Out-of-bound access", categories::Tai

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
@@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bound access"}; + BugType TaintBT{this, "Out-of-bound access", categories::Tai

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-16 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 1/7] Fix `Form` to recognize `_Alignas` in addition to `aligna

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-16 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69106 >From 8e599770d1dc3a5cd3edc011e7d830bc5b428410 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 15 Oct 2023 19:48:09 +0800 Subject: [PATCH 1/2] [clang]Avoid to check created local variable multiple tim

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
@@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bound access"}; + BugType TaintBT{this, "Out-of-bound access", categories::Tai

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
@@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bound access"}; + BugType TaintBT{this, "Out-of-bound access", categories::Tai

[clang] [clang][NFC] Replace TypeAlignment with alignof(T) (PR #69185)

2023-10-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/69185 This patch replaces usages of `TypeAlignment` with `alignof(T)`, where `T` is type that will be created in allocated storage with placement-new. This is now possible, because `alignof` reports the correct alignm

[clang] [clang][NFC] Replace TypeAlignment with alignof(T) (PR #69185)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch replaces usages of `TypeAlignment` with `alignof(T)`, where `T` is type that will be created in allocated storage with placement-new. This is now possible, because `alignof` reports the corr

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-10-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-10-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske reopened https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-10-16 Thread Bret Brown via cfe-commits
bretbrownjr wrote: I highly recommend talking to @mathstuf of the CMake project about a way for the build system can emit a next generation set of build graph metadata (think modules appropriate compile commands, including dependencies). I expect it will be more efficient for the build system,

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

2023-10-16 Thread Bushev Dmitry via cfe-commits
https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From d66ffe242716560408bd314a9725bb49556992e0 Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-16 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Thanks @zygoloid. This case was failing with my change. Corrected and added tests. https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922 >From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 12 Oct 2023 21:35:52 +0200 Subject: [PATCH 1/4] Find opertor!= in the correct namespace --- clang/lib/Sema/Se

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:39:27 +0200 Subject: [PAT

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -20794,7 +20794,7 @@ TEST_F(FormatTest, CatchAlignArrayOfStructuresRightAlignment) { verifyFormat("int a[][] = {\n" "{\n" " {0, 2}, //\n" - " {1, 2} //\n" + " {1, 2} //\n" owenca wrote: W

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bound access"}; + BugType T

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -3191,20 +3191,120 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b22917e6e2a0aec05474f58e64b7e87d1ea

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() { parseRequiresClause(RequiresToken); break; } +case tok::equal: + if (InTemplateParameterList) { +nextToken(); +break; + } + return true; owe

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() { parseRequiresClause(RequiresToken); break; } +case tok::equal: + if (InTemplateParameterList) { +nextToken(); +break; + } + return true; owe

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-16 Thread Rainer Orth via cfe-commits
rorth wrote: > I feel that we are bike-shedding here a bit. Please prioritise correctness - > using `GNU` as a label for Solaris would not be correct. The following would > be: > > * duplicating tests with a different label (e.g. `SOLARIS`) would be > correct, > > * renaming the curr

[clang] [clang][Interp] Handle delegating constructors (PR #67823)

2023-10-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/69052 >From 4f532ab0ae47bce011043f41cfac3ad3e601dd41 Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Sat, 14 Oct 2023 16:52:31 +0300 Subject: [PATCH 1/2] [clang-format] Allow default values for template parameters in

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/69057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread via cfe-commits
https://github.com/DonatNagyE commented: The only thing that I know about the dynamic type handling is that it's not too reliable; it would be great if you could improve it. https://github.com/llvm/llvm-project/pull/69057 ___ cfe-commits mailing list

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread via cfe-commits
@@ -0,0 +1,105 @@ +// RUN: %clang_analyze_cc1 %s -verify \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.security.taint.TaintPropagation \ +// RUN: -analyzer-checker=debug.ExprInspection + +// See issue https://github.com/llvm/llvm-project/issues/62663 +

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread via cfe-commits
@@ -392,19 +393,26 @@ void DynamicTypePropagation::checkPostCall(const CallEvent &Call, } } -/// TODO: Handle explicit casts. -/// Handle C++ casts. -/// -/// Precondition: the cast is between ObjCObjectPointers. ExplodedNode *DynamicTypePropagation::dynamicTypePropa

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

2023-10-16 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -32,42 +32,72 @@ using namespace taint; namespace { class ArrayBoundCheckerV2 : public Checker { - mutable std::unique_ptr BT; - mutable std::unique_ptr TaintBT; + BugType BT{this, "Out-of-bou

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-10-16 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > I highly recommend talking to @mathstuf of the CMake project about a way for > the build system can emit a next generation set of build graph metadata > (think modules appropriate compile commands, including dependencies). > > I expect it will be more efficient for the buil

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,105 @@ +// RUN: %clang_analyze_cc1 %s -verify \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.security.taint.TaintPropagation \ +// RUN: -analyzer-checker=debug.ExprInspection + +// See issue https://github.com/llvm/llvm-project/issues/62663 +

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread via cfe-commits
@@ -0,0 +1,105 @@ +// RUN: %clang_analyze_cc1 %s -verify \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.security.taint.TaintPropagation \ +// RUN: -analyzer-checker=debug.ExprInspection + +// See issue https://github.com/llvm/llvm-project/issues/62663 +

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] de9b3c5 - [clang][Interp] Handle delegating constructors (#67823)

2023-10-16 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-16T14:11:25+02:00 New Revision: de9b3c5eba41fd024aef6dfa4dab0c8feae29b18 URL: https://github.com/llvm/llvm-project/commit/de9b3c5eba41fd024aef6dfa4dab0c8feae29b18 DIFF: https://github.com/llvm/llvm-project/commit/de9b3c5eba41fd024aef6dfa4dab0c8feae29b18.diff L

[clang] [clang][Interp] Handle delegating constructors (PR #67823)

2023-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

2023-10-16 Thread Bushev Dmitry via cfe-commits
https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From 51a150e7abd2ff88261f82fc4a4c799f2a1fb11d Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-16 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,82 @@ +//===--- CoroutineSuspensionHostileCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-10-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c202a17 - [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (#66207)

2023-10-16 Thread via cfe-commits
Author: Balázs Kéri Date: 2023-10-16T14:51:05+02:00 New Revision: c202a17d024068c70364116f2d06535d79535b30 URL: https://github.com/llvm/llvm-project/commit/c202a17d024068c70364116f2d06535d79535b30 DIFF: https://github.com/llvm/llvm-project/commit/c202a17d024068c70364116f2d06535d79535b30.diff L

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-16 Thread Daniel Kutenin via cfe-commits
danlark1 wrote: >Also @danlark1 if you rebase onto main the issues with macOS in the CI should >be fixed now. @ldionne, Done https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-16 Thread Daniel Kutenin via cfe-commits
danlark1 wrote: >Also @danlark1 if you rebase onto main the issues with macOS in the CI should >be fixed now. @ldionne, Done https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-16 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,82 @@ +//===--- CoroutineSuspensionHostileCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-16 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,82 @@ +//===--- CoroutineSuspensionHostileCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [clang][ASTMatcher] fix hasAnyBase not binding submatchers (PR #67939)

2023-10-16 Thread via cfe-commits
5chmidti wrote: I think this can be merged, but I don't have write access. https://github.com/llvm/llvm-project/pull/67939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

2023-10-16 Thread Bushev Dmitry via cfe-commits
https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From d61eacc29e0b70dc50ee7eeb96446b7b66dc2e1d Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

2023-10-16 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. This introduced a build failure on s390x: https://github.com/llvm/llvm-project/issues/69146 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143813/new/ https://reviews.llvm.org/D143813 ___ cfe-commits mailing list cfe

[clang] [Driver] Ignore non-clang pch files when -include a.h probes a.h.gch (PR #69204)

2023-10-16 Thread via cfe-commits
https://github.com/zmodem created https://github.com/llvm/llvm-project/pull/69204 Instead of deprecating the "gch probe" as in f726da1193baf51e0a66453cc32dcffb8a9121d4, this makes clang ignore files which are not clang pch files (See discussion on PR #67084). This fixes the issues mentioned in

[clang] [Driver] Ignore non-clang pch files when -include a.h probes a.h.gch (PR #69204)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Hans (zmodem) Changes Instead of deprecating the "gch probe" as in f726da1193baf51e0a66453cc32dcffb8a9121d4, this makes clang ignore files which are not clang pch files (See discussion on PR #67084). This fixes the issues mentioned in the

[clang] [Driver] Ignore non-clang pch files when -include a.h probes a.h.gch (PR #69204)

2023-10-16 Thread via cfe-commits
zmodem wrote: Please take a look. This has the benefit of fixing users broken by gcc-generated .gch files without having to wait a release cycle for deprecation, while at the same time not breaking users relying clang performing these probes at all. cc folks from the previous pr: @MaskRay @ja

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

2023-10-16 Thread via cfe-commits
zmodem wrote: I've posted an alternative patch in https://github.com/llvm/llvm-project/pull/69204 which I believe is fixing the issues mentioned in this pr better (users don't have to wait another release), while not breaking builds relying on gch probing. https://github.com/llvm/llvm-project

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

2023-10-16 Thread Bushev Dmitry via cfe-commits
https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From d1ceb3258b0ade810ebdcb3bf2c5727026bef17f Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/69207 - only return when the return type is non-void - fix missing return on member functions >From 7771acd00ace1362e580531f1a3ed63f81cfa5a3 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.nore

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (5chmidti) Changes - only return when the return type is non-void - fix missing return on member functions --- Full diff: https://github.com/llvm/llvm-project/pull/69207.diff 2 Files Affected: - (modified) clang-tools-extra/c

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -1299,8 +1299,9 @@ static bool checkTupleLikeDecomposition(Sema &S, // in the associated namespaces. Expr *Get = UnresolvedLookupExpr::Create( S.Context, nullptr, NestedNameSpecifierLoc(), SourceLocation(), - DeclarationNameInfo(GetDN, Loc),

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -165,3 +165,18 @@ namespace BindingInStmtExpr { using U = decltype(num_bindings()); // expected-note {{previous}} using U = N<3>; // expected-error-re {{type alias redefinition with different types ('N<3>' vs {{.*}}N<2>}} } + +namespace PR65153 { +struct A{}; + +templat

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: This needs a release note, else I think it is OK. https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-16 Thread Richard Howell via cfe-commits
rmaz wrote: @jansvoboda11 still good with this change, or is there a less invasive way to get this done? https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread Piotr Zegar via cfe-commits
@@ -554,6 +555,8 @@ getLambdaProperties(const MatchFinder::MatchResult &Result) { LP.Callable.Materialization = getCallableMaterialization(Result); LP.Callable.Decl = getCallMethodDecl(Result, LP.Callable.Type, LP.Callable.Materialization); + if (LP.Callable.Decl) +

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Release notes Except that looks +- fine for me. https://github.com/llvm/llvm-project/pull/69207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

2023-10-16 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto added inline comments. Herald added a subscriber: wangpc. Comment at: clang/include/clang/Basic/arm_sve.td:2123 + +def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone, "", [], [ImmCheck<3, ImmCheck0_15>]>; +def SVPSEL_COUNT_ALIAS_H : SIn

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

2023-10-16 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:2129 +def SVWHILEGE_COUNT : SInst<"svwhilege_{d}", "}lli", "QcQsQiQl", MergeNone, "aarch64_sve_whilege_{d}", [IsOverloadNone], [ImmCheck<2, ImmCheck2_4_Mul2>]>; +def SVWHILEGT_COUNT : S

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/69207 >From 7771acd00ace1362e580531f1a3ed63f81cfa5a3 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Mon, 14 Aug 2023 03:04:36 +0200 Subject: [PATCH 1/2] [clang-tidy] mo

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
@@ -554,6 +555,8 @@ getLambdaProperties(const MatchFinder::MatchResult &Result) { LP.Callable.Materialization = getCallableMaterialization(Result); LP.Callable.Decl = getCallMethodDecl(Result, LP.Callable.Type, LP.Callable.Materialization); + if (LP.Callable.Decl) +

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
5chmidti wrote: Any particular reason for the `+-`? Maybe it can be resolved? https://github.com/llvm/llvm-project/pull/69207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-16 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -444,6 +486,29 @@ DeviceTy::getTgtPtrBegin(void *HstPtrBegin, int64_t Size, bool UpdateRefCount, LR.TPR.getEntry()->dynRefCountToStr().c_str(), DynRefCountAction, LR.TPR.getEntry()->holdRefCountToStr().c_str(), HoldRefCountAction); LR.TPR.TargetPointer

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-16 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 updated https://github.com/llvm/llvm-project/pull/69005 >From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 16 Nov 2022 17:23:48 -0600 Subject: [PATCH 1/2] Fix declare target implementation to support enter. --- clan

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-16 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 updated https://github.com/llvm/llvm-project/pull/69005 >From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 16 Nov 2022 17:23:48 -0600 Subject: [PATCH 1/2] Fix declare target implementation to support enter. --- clan

[clang] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-16 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 updated https://github.com/llvm/llvm-project/pull/69005 >From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 16 Nov 2022 17:23:48 -0600 Subject: [PATCH 1/2] Fix declare target implementation to support enter. --- clan

[libunwind] [OpenMP][libomptarget] Add map checks when running under unified shared memory (PR #69005)

2023-10-16 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 updated https://github.com/llvm/llvm-project/pull/69005 >From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 16 Nov 2022 17:23:48 -0600 Subject: [PATCH 1/2] Fix declare target implementation to support enter. --- clan

[clang] Null field access (PR #69223)

2023-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/69223 Looks like this should work as long as we don't dereference the value. Note: This is a change from my local branch where I introduce integral pointers. One th

  1   2   3   4   >