Re: r338301 - Avoid returning an invalid end source loc

2018-08-07 Thread Stephen Kelly via cfe-commits
18 03:23, David Blaikie wrote: test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm.org/viewvc/llvm-project?rev=338301&vi

Re: r338301 - Avoid returning an invalid end source loc

2018-08-07 Thread Stephen Kelly via cfe-commits
On 07/08/18 03:23, David Blaikie wrote: test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm

r339372 - Add getBeginLoc API to replace getLocStart

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:03 2018 New Revision: 339372 URL: http://llvm.org/viewvc/llvm-project?rev=339372&view=rev Log: Add getBeginLoc API to replace getLocStart Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50346 Modified: cfe/trunk/include/clang

r339373 - Add getBeginLoc API to replace getStartLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:18 2018 New Revision: 339373 URL: http://llvm.org/viewvc/llvm-project?rev=339373&view=rev Log: Add getBeginLoc API to replace getStartLoc Reviewers: teemperor! Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50347 Modified:

r339374 - Add getEndLoc API to replace getLocEnd

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:47 2018 New Revision: 339374 URL: http://llvm.org/viewvc/llvm-project?rev=339374&view=rev Log: Add getEndLoc API to replace getLocEnd Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50348 Modified: cfe/trunk/include/clang/AST

r339379 - Fix build

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:21:09 2018 New Revision: 339379 URL: http://llvm.org/viewvc/llvm-project?rev=339379&view=rev Log: Fix build Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL: http://llvm.org/viewvc/llvm-project/c

r339384 - Port getStartLoc -> getBeginLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 14:05:56 2018 New Revision: 339384 URL: http://llvm.org/viewvc/llvm-project?rev=339384&view=rev Log: Port getStartLoc -> getBeginLoc Reviewers: teemperor! Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50349 Modified: cfe/trunk/i

[clang-tools-extra] r339401 - Port getLocEnd -> getEndLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 15:43:02 2018 New Revision: 339401 URL: http://llvm.org/viewvc/llvm-project?rev=339401&view=rev Log: Port getLocEnd -> getEndLoc Subscribers: nemanjai, ioeric, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D50355 Modified: clang-tools

r339402 - Remove obsolete set call

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 15:44:03 2018 New Revision: 339402 URL: http://llvm.org/viewvc/llvm-project?rev=339402&view=rev Log: Remove obsolete set call Summary: Case case of the switch statement here makes the same call, but it is already done at the start of the function. Reviewers: rsm

r339730 - Fix Stmt::ignoreImplicit

2018-08-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 14 14:33:28 2018 New Revision: 339730 URL: http://llvm.org/viewvc/llvm-project?rev=339730&view=rev Log: Fix Stmt::ignoreImplicit Summary: A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was not ignored previously. Fixes the case reported in PR3732

r339731 - Remove obsolete comment

2018-08-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 14 14:34:29 2018 New Revision: 339731 URL: http://llvm.org/viewvc/llvm-project?rev=339731&view=rev Log: Remove obsolete comment This related to the code as first checked in in r266292 ([ASTImporter] Implement some expression-related AST node import., 2016-04-14). M

r339810 - Add a newline to SourceLocation dump output

2018-08-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Aug 15 13:32:06 2018 New Revision: 339810 URL: http://llvm.org/viewvc/llvm-project?rev=339810&view=rev Log: Add a newline to SourceLocation dump output Summary: Migrate callers to print(). dump() should be useful to downstreams and third parties as a debugging aid. Ev

r340376 - Update the docs for using LLVM toolset in Visual Studio

2018-08-21 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 21 18:11:18 2018 New Revision: 340376 URL: http://llvm.org/viewvc/llvm-project?rev=340376&view=rev Log: Update the docs for using LLVM toolset in Visual Studio Reviewers: hans Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51079 Modifie

r340586 - Fix typo

2018-08-23 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 23 15:41:52 2018 New Revision: 340586 URL: http://llvm.org/viewvc/llvm-project?rev=340586&view=rev Log: Fix typo Modified: cfe/trunk/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangCommentHTMLNamedChara

r341140 - Add dump() method for SourceRange

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:10:52 2018 New Revision: 341140 URL: http://llvm.org/viewvc/llvm-project?rev=341140&view=rev Log: Add dump() method for SourceRange Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50662 Modified: cfe/trunk/include/clang/Basic/So

r341141 - Extract parseBindID method

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:11:01 2018 New Revision: 341141 URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev Log: Extract parseBindID method Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51258 Modified: cfe/trunk/include/clang/ASTMatchers/Dyn

r341142 - Allow binding to NamedValue resulting from let expression

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:11:09 2018 New Revision: 341142 URL: http://llvm.org/viewvc/llvm-project?rev=341142&view=rev Log: Allow binding to NamedValue resulting from let expression Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51259 Modified: cfe/trun

[clang-tools-extra] r341145 - Add preload option to clang-query

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:25:44 2018 New Revision: 341145 URL: http://llvm.org/viewvc/llvm-project?rev=341145&view=rev Log: Add preload option to clang-query Summary: This allows loading a file with pre-defined let commands for example. Subscribers: cfe-commits Differential Revision:

[clang-tools-extra] r341144 - Extract runCommandsInFile method

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:25:38 2018 New Revision: 341144 URL: http://llvm.org/viewvc/llvm-project?rev=341144&view=rev Log: Extract runCommandsInFile method Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51260 Modified: clang-tools-extra/trunk/clang-que

r341146 - Remove vestiges of configure buildsystem

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:41:03 2018 New Revision: 341146 URL: http://llvm.org/viewvc/llvm-project?rev=341146&view=rev Log: Remove vestiges of configure buildsystem Summary: Subscribers: mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D50738 Modified: cfe/tru

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
should squash things for review? I don't know. Thanks for any post-commit review! Stephen. On 31/08/18 07:06, Roman Lebedev via cfe-commits wrote: I don't think this was reviewed. The differential is not in 'accepted' state. Roman. On Fri, Aug 31, 2018 at 2:11 AM, S

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
On 06/09/18 20:42, Roman Lebedev wrote: You can specify the dependencies between the differentials in phabricator. I didn't know that, thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang-tools-extra] r341583 - Fix reported range of partial token replacement

2018-09-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Sep 6 13:16:34 2018 New Revision: 341583 URL: http://llvm.org/viewvc/llvm-project?rev=341583&view=rev Log: Fix reported range of partial token replacement Summary: Fixes bug: 38678 Reviewers: klimek, rsmith Subscribers: cfe-commits Differential Revision: https://rev

r338301 - Avoid returning an invalid end source loc

2018-07-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm.org/viewvc/llvm-project?rev=338301&view=rev Log: Avoid returning an invalid end source loc Modified: cfe/trunk/include/clang/AST/DeclarationName.h cfe/trunk/lib/AST/DeclarationName.cpp Modified: cfe/tru

[clang-tools-extra] r344840 - [clang-query] Add option to print matcher expression

2018-10-20 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Oct 20 02:13:59 2018 New Revision: 344840 URL: http://llvm.org/viewvc/llvm-project?rev=344840&view=rev Log: [clang-query] Add option to print matcher expression Summary: This is useful if using clang-query -f with a file containing multiple matchers. Reviewers: aaron.b

[clang-tools-extra] r345192 - [clang-query] Re-word command help

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:14 2018 New Revision: 345192 URL: http://llvm.org/viewvc/llvm-project?rev=345192&view=rev Log: [clang-query] Re-word command help Summary: This will make it possible to easily * Add new commands which accept parameters * Extend the list of features Revie

[clang-tools-extra] r345193 - [clang-query] Add 'detailed-ast' output as an alias for 'dump'

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:45 2018 New Revision: 345193 URL: http://llvm.org/viewvc/llvm-project?rev=345193&view=rev Log: [clang-query] Add 'detailed-ast' output as an alias for 'dump' Summary: Future development can then dump other content than AST. Reviewers: aaron.ballman Subscr

[clang-tools-extra] r345194 - [clang-query] Refactor Output settings to booleans

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:55 2018 New Revision: 345194 URL: http://llvm.org/viewvc/llvm-project?rev=345194&view=rev Log: [clang-query] Refactor Output settings to booleans Summary: This will make it possible to add non-exclusive mode output. Reviewers: aaron.ballman Subscribers: c

[clang-tools-extra] r345522 - [clang-query] Add non-exclusive output API

2018-10-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 29 11:59:56 2018 New Revision: 345522 URL: http://llvm.org/viewvc/llvm-project?rev=345522&view=rev Log: [clang-query] Add non-exclusive output API Summary: Add granular options for AST dumping, text printing and diagnostics. This makes it possible to * Have both d

r350957 - [ASTDump] Add utility for dumping a label with child nodes

2019-01-11 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 11 11:11:17 2019 New Revision: 350957 URL: http://llvm.org/viewvc/llvm-project?rev=350957&view=rev Log: [ASTDump] Add utility for dumping a label with child nodes Summary: Use it to add optional label nodes to Stmt dumps. This preserves behavior of InitExprList dum

r350958 - Implement Attr dumping in terms of visitors

2019-01-11 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 11 11:16:01 2019 New Revision: 350958 URL: http://llvm.org/viewvc/llvm-project?rev=350958&view=rev Log: Implement Attr dumping in terms of visitors Remove now-vestigial dumpType and dumpBareDeclRef methods. The old tablegen generated code used to expect them to be p

r350984 - NFC: Port loop to cxx_range_for

2019-01-11 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 11 16:42:59 2019 New Revision: 350984 URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev Log: NFC: Port loop to cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-project

r351011 - [ASTDump] Change parameter to StringRef

2019-01-12 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 12 07:45:05 2019 New Revision: 351011 URL: http://llvm.org/viewvc/llvm-project?rev=351011&view=rev Log: [ASTDump] Change parameter to StringRef Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h cfe/trunk/lib/AST/TextNodeDumper.cpp Modified: cfe/trunk/i

r351012 - Implement TemplateArgument dumping in terms of Visitor

2019-01-12 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 12 08:35:37 2019 New Revision: 351012 URL: http://llvm.org/viewvc/llvm-project?rev=351012&view=rev Log: Implement TemplateArgument dumping in terms of Visitor Summary: Split the output streaming from the traversal to other AST nodes. Reviewers: aaron.ballman Subsc

r351014 - [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper

2019-01-12 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 12 08:53:27 2019 New Revision: 351014 URL: http://llvm.org/viewvc/llvm-project?rev=351014&view=rev Log: [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

r351015 - NFC: Make utility private

2019-01-12 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 12 09:07:05 2019 New Revision: 351015 URL: http://llvm.org/viewvc/llvm-project?rev=351015&view=rev Log: NFC: Make utility private No callers are external to the class anymore. Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h Modified: cfe/trunk/include/c

r351112 - NFC: Fix nits I missed before

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 11:50:34 2019 New Revision: 351112 URL: http://llvm.org/viewvc/llvm-project?rev=351112&view=rev Log: NFC: Fix nits I missed before Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/TextNodeDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp UR

r351114 - [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:11:02 2019 New Revision: 351114 URL: http://llvm.org/viewvc/llvm-project?rev=351114&view=rev Log: [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.or

r351115 - [ASTDump] NFC: Canonicalize handling of TypeLocInfo

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:13:09 2019 New Revision: 351115 URL: http://llvm.org/viewvc/llvm-project?rev=351115&view=rev Log: [ASTDump] NFC: Canonicalize handling of TypeLocInfo Summary: No need to avoid the Visit method. Reviewers: aaron.ballman Subscribers: cfe-commits Differential

r351116 - [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:15:29 2019 New Revision: 351116 URL: http://llvm.org/viewvc/llvm-project?rev=351116&view=rev Log: [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

r351172 - [ASTDump] NFC: Move dump of type nodes to NodeDumper

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 01:30:00 2019 New Revision: 351172 URL: http://llvm.org/viewvc/llvm-project?rev=351172&view=rev Log: [ASTDump] NFC: Move dump of type nodes to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56642 M

r351175 - NFC: Move Decl node handling to TextNodeDumper

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 01:35:52 2019 New Revision: 351175 URL: http://llvm.org/viewvc/llvm-project?rev=351175&view=rev Log: NFC: Move Decl node handling to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56643 Modifie

r351235 - Implement CXXCtorInitializer dump in terms of Visitor

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:17:33 2019 New Revision: 351235 URL: http://llvm.org/viewvc/llvm-project?rev=351235&view=rev Log: Implement CXXCtorInitializer dump in terms of Visitor Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56707

r351236 - NFC: Implement OMPClause dump in terms of visitors

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:31:31 2019 New Revision: 351236 URL: http://llvm.org/viewvc/llvm-project?rev=351236&view=rev Log: NFC: Implement OMPClause dump in terms of visitors Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56708 Mod

r351239 - Implement BlockDecl::Capture dump in terms of visitors

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:41:37 2019 New Revision: 351239 URL: http://llvm.org/viewvc/llvm-project?rev=351239&view=rev Log: Implement BlockDecl::Capture dump in terms of visitors Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56709

r351268 - NFC: Replace iterator loop with cxx_range_for

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 14:45:46 2019 New Revision: 351268 URL: http://llvm.org/viewvc/llvm-project?rev=351268&view=rev Log: NFC: Replace iterator loop with cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewv

r351269 - Re-order overrides in FunctionDecl dump

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269&view=rev Log: Re-order overrides in FunctionDecl dump Output all content which is local to the FunctionDecl before traversing to child AST nodes. This is necessary so that all

Re: r351269 - Re-order overrides in FunctionDecl dump

2019-01-15 Thread Stephen Kelly via cfe-commits
On 15/01/2019 23:00, Aaron Ballman wrote: On Tue, Jan 15, 2019 at 5:54 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269&view=rev Log: Re-order overrides in FunctionDecl

r351271 - NFC: Some cleanups that I missed in the previous commit

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 15:05:11 2019 New Revision: 351271 URL: http://llvm.org/viewvc/llvm-project?rev=351271&view=rev Log: NFC: Some cleanups that I missed in the previous commit Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm

r351272 - Re-order type param children of ObjC nodes

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 15:07:30 2019 New Revision: 351272 URL: http://llvm.org/viewvc/llvm-project?rev=351272&view=rev Log: Re-order type param children of ObjC nodes Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55394 Modified:

r351597 - [ASTDump] Mark variadic declarations with a tag instead of child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:38:30 2019 New Revision: 351597 URL: http://llvm.org/viewvc/llvm-project?rev=351597&view=rev Log: [ASTDump] Mark variadic declarations with a tag instead of child node Summary: This makes it easier to separate traversal of the AST from output generation. Revi

r351600 - [ASTDump] Mark BlockDecls which capture this with a tag

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:55:24 2019 New Revision: 351600 URL: http://llvm.org/viewvc/llvm-project?rev=351600&view=rev Log: [ASTDump] Mark BlockDecls which capture this with a tag Summary: Removal of the child node makes it easier to separate traversal from output generation. Reviewer

r351601 - [ASTDump] Mark null params with a tag rather than a child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:00:16 2019 New Revision: 351601 URL: http://llvm.org/viewvc/llvm-project?rev=351601&view=rev Log: [ASTDump] Mark null params with a tag rather than a child node Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

r351606 - [ASTDump] Add test for current AST dump behavior

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:13 2019 New Revision: 351606 URL: http://llvm.org/viewvc/llvm-project?rev=351606&view=rev Log: [ASTDump] Add test for current AST dump behavior Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp

r351604 - [ASTDump] NFC: Remove redundant condition

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:05 2019 New Revision: 351604 URL: http://llvm.org/viewvc/llvm-project?rev=351604&view=rev Log: [ASTDump] NFC: Remove redundant condition These conditions are duplicated from the dumpDeclContext function called within the if(). This is presumably an attempt

r351603 - [ASTDump] NFC: Remove non-needed braces

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:14:59 2019 New Revision: 351603 URL: http://llvm.org/viewvc/llvm-project?rev=351603&view=rev Log: [ASTDump] NFC: Remove non-needed braces Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm

r351605 - [ASTDump] NFC: Move variable into if() statement

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:09 2019 New Revision: 351605 URL: http://llvm.org/viewvc/llvm-project?rev=351605&view=rev Log: [ASTDump] NFC: Move variable into if() statement Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/vi

r351637 - Move decl context dumping to TextNodeDumper

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:05:55 2019 New Revision: 351637 URL: http://llvm.org/viewvc/llvm-project?rev=351637&view=rev Log: Move decl context dumping to TextNodeDumper Summary: Only an obscure case is moved. Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: ht

r351646 - [ASTDump] NFC: Use `const auto` in cxx_range_for loops

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:57:51 2019 New Revision: 351646 URL: http://llvm.org/viewvc/llvm-project?rev=351646&view=rev Log: [ASTDump] NFC: Use `const auto` in cxx_range_for loops This is coming up a lot in reviews. Better just to do them all at once. Modified: cfe/trunk/lib/AST/AS

r351647 - [ASTDump] NFC: Convert iterative loops to cxx_range_for

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:57:59 2019 New Revision: 351647 URL: http://llvm.org/viewvc/llvm-project?rev=351647&view=rev Log: [ASTDump] NFC: Convert iterative loops to cxx_range_for This is coming up a lot in reviews. Better just to change them all at once. Modified: cfe/trunk/lib/A

Re: [PATCH] D56829: Move decl context dumping to TextNodeDumper

2019-01-20 Thread Stephen Kelly via cfe-commits
On 20/01/2019 16:57, Stella Stamenova via Phabricator via cfe-commits wrote: stella.stamenova added a comment. It looks like this change broke a number of the LLDB tests: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/781 Could you look into this or revert the change, so that the bot

r352552 - NFC: Implement GenericSelectionExpr::Association dump with Visitor

2019-01-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 29 14:22:55 2019 New Revision: 352552 URL: http://llvm.org/viewvc/llvm-project?rev=352552&view=rev Log: NFC: Implement GenericSelectionExpr::Association dump with Visitor Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm

r352558 - NFC: Move GenericSelectionExpr dump to NodeDumper

2019-01-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 29 14:58:28 2019 New Revision: 352558 URL: http://llvm.org/viewvc/llvm-project?rev=352558&view=rev Log: NFC: Move GenericSelectionExpr dump to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56961 Modi

r352655 - [ASTDump] Move Decl node dumping to TextNodeDumper

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 11:32:48 2019 New Revision: 352655 URL: http://llvm.org/viewvc/llvm-project?rev=352655&view=rev Log: [ASTDump] Move Decl node dumping to TextNodeDumper Reviewers: aaron.ballman Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D57419

r352656 - [ASTDump] NFC: Inline vestigial methods

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 11:41:04 2019 New Revision: 352656 URL: http://llvm.org/viewvc/llvm-project?rev=352656&view=rev Log: [ASTDump] NFC: Inline vestigial methods This was a porting aid. Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: ht

r352657 - [ASTDump] Rename methods which are conceptually Visits

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 11:49:49 2019 New Revision: 352657 URL: http://llvm.org/viewvc/llvm-project?rev=352657&view=rev Log: [ASTDump] Rename methods which are conceptually Visits This is consistent with the TextNodeDumper, and is the appropriate name for the traverser class which will

r352661 - [ASTDump] Re-arrange method declarations to group Visit together

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 12:03:47 2019 New Revision: 352661 URL: http://llvm.org/viewvc/llvm-project?rev=352661&view=rev Log: [ASTDump] Re-arrange method declarations to group Visit together This will make follow-up commits easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

r352663 - [ASTDump] Make method definition order matches declaration order

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 12:06:52 2019 New Revision: 352663 URL: http://llvm.org/viewvc/llvm-project?rev=352663&view=rev Log: [ASTDump] Make method definition order matches declaration order This will make follow-up changes easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

r352676 - [ASTDump] Inline traverse methods into class

2019-01-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Jan 30 13:48:32 2019 New Revision: 352676 URL: http://llvm.org/viewvc/llvm-project?rev=352676&view=rev Log: [ASTDump] Inline traverse methods into class This API will be extracted into a new template class. This change will make the follow-up commit easier to review.

Re: Dumping AST information to other formats

2018-11-27 Thread Stephen Kelly via cfe-commits
On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: Once upon a time, there was -ast-print-xml. This -cc1 option was dropped because it was frequently out of sync with the AST data. It is right to ask: why would JSON, etc be any different? This is still an open question, but a goal of this

Re: Dumping AST information to other formats

2018-11-28 Thread Stephen Kelly via cfe-commits
On 27/11/2018 09:49, Stephen Kelly via cfe-commits wrote: On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: Once upon a time, there was -ast-print-xml. This -cc1 option was dropped because it was frequently out of sync with the AST data. It is right to ask: why would JSON, etc be any

r347899 - NFC: Constify ShowColors

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:30:08 2018 New Revision: 347899 URL: http://llvm.org/viewvc/llvm-project?rev=347899&view=rev Log: NFC: Constify ShowColors Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

r347900 - NFC: Move ColorScope to global scope

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:30:37 2018 New Revision: 347900 URL: http://llvm.org/viewvc/llvm-project?rev=347900&view=rev Log: NFC: Move ColorScope to global scope Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-pr

r347901 - NFC: Fix case of CommentVisitor::Visit methods

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:31:32 2018 New Revision: 347901 URL: http://llvm.org/viewvc/llvm-project?rev=347901&view=rev Log: NFC: Fix case of CommentVisitor::Visit methods This difference is very visible because it is used with other Visitor classes together. Modified: cfe/trunk/in

r347905 - Revert "NFC: Fix case of CommentVisitor::Visit methods"

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:50:10 2018 New Revision: 347905 URL: http://llvm.org/viewvc/llvm-project?rev=347905&view=rev Log: Revert "NFC: Fix case of CommentVisitor::Visit methods" This reverts commit 0859c80137ac5fb3c86e7802cb8c5ef56f921cce. Modified: cfe/trunk/include/clang/AST/C

r348093 - Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 08:36:23 2018 New Revision: 348093 URL: http://llvm.org/viewvc/llvm-project?rev=348093&view=rev Log: Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr Added: cfe/trunk/test/AST/ast-dump-array.cpp Added: cfe/trunk/test/AST/ast-dump-array.cpp URL: h

r348094 - Fix whitespace

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 08:42:34 2018 New Revision: 348094 URL: http://llvm.org/viewvc/llvm-project?rev=348094&view=rev Log: Fix whitespace Modified: cfe/trunk/test/AST/ast-dump-array.cpp Modified: cfe/trunk/test/AST/ast-dump-array.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/

r348101 - Replace FullComment member being visited with parameter

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:40 2018 New Revision: 348101 URL: http://llvm.org/viewvc/llvm-project?rev=348101&view=rev Log: Replace FullComment member being visited with parameter Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55070

r348099 - Remove unecessary methods

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:26 2018 New Revision: 348099 URL: http://llvm.org/viewvc/llvm-project?rev=348099&view=rev Log: Remove unecessary methods The base class calls VisitExpr Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://ll

r348100 - Extend the CommentVisitor with parameter types

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:34 2018 New Revision: 348100 URL: http://llvm.org/viewvc/llvm-project?rev=348100&view=rev Log: Extend the CommentVisitor with parameter types Summary: This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling

r348189 - NFC: Simplify dumpStmt child handling

2018-12-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 3 13:05:52 2018 New Revision: 348189 URL: http://llvm.org/viewvc/llvm-project?rev=348189&view=rev Log: NFC: Simplify dumpStmt child handling Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55068 Modified: cf

r348241 - Extend test for DependentSizedArrayType

2018-12-04 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Dec 4 01:53:36 2018 New Revision: 348241 URL: http://llvm.org/viewvc/llvm-project?rev=348241&view=rev Log: Extend test for DependentSizedArrayType Use a using declaration to force the type to appear in the -ast-dump output. Modified: cfe/trunk/test/AST/ast-dump-ar

r348408 - Add dump tests for inherited default template parameters

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL: http://llvm.org/viewvc/llvm-project?rev=348408&view=rev Log: Add dump tests for inherited default template parameters Modified: cfe/trunk/test/AST/ast-dump-decl.cpp Modified: cfe/trunk/test/AST/ast-dump-decl.cpp URL:

r348409 - NFC: Inline handling of DependentSizedArrayType

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:34:07 2018 New Revision: 348409 URL: http://llvm.org/viewvc/llvm-project?rev=348409&view=rev Log: NFC: Inline handling of DependentSizedArrayType Summary: Re-order handling of getElementType and getBracketsRange. It is necessary to perform all printing before

r348410 - NFC: Extract TextTreeStructure class

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:53:14 2018 New Revision: 348410 URL: http://llvm.org/viewvc/llvm-project?rev=348410&view=rev Log: NFC: Extract TextTreeStructure class Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55188 Added: cfe/tr

Re: r348408 - Add dump tests for inherited default template parameters

2018-12-05 Thread Stephen Kelly via cfe-commits
Surely all of the tests specifically about template decls should be moved? On 05/12/2018 20:31, Aaron Ballman wrote: On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL: http://llvm.org/viewvc/llvm

r348412 - NFC: Extract TextNodeDumper class

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 13:12:39 2018 New Revision: 348412 URL: http://llvm.org/viewvc/llvm-project?rev=348412&view=rev Log: NFC: Extract TextNodeDumper class Summary: Start by moving some utilities to it. It will eventually house dumping of individual nodes (after indentation etc has a

r348469 - Make test resistant to line numbers changing

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 01:22:12 2018 New Revision: 348469 URL: http://llvm.org/viewvc/llvm-project?rev=348469&view=rev Log: Make test resistant to line numbers changing Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL: http://llvm.org/viewvc/llvm-pr

r348471 - Add test for ObjC generics

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev Log: Add test for ObjC generics Modified: cfe/trunk/test/AST/ast-dump-decl.m Modified: cfe/trunk/test/AST/ast-dump-decl.m URL: http://llvm.org/viewvc/llvm-projec

r348470 - Extend OMP test

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 01:23:53 2018 New Revision: 348470 URL: http://llvm.org/viewvc/llvm-project?rev=348470&view=rev Log: Extend OMP test Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/dump

r348541 - Use relative line offsets in test

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 14:51:51 2018 New Revision: 348541 URL: http://llvm.org/viewvc/llvm-project?rev=348541&view=rev Log: Use relative line offsets in test Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

Re: r348469 - Make test resistant to line numbers changing

2018-12-06 Thread Stephen Kelly via cfe-commits
On 06/12/2018 12:45, Aaron Ballman wrote: On Thu, Dec 6, 2018 at 4:25 AM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Thu Dec 6 01:22:12 2018 New Revision: 348469 URL: http://llvm.org/viewvc/llvm-project?rev=348469&view=rev Log: Make test resistant to line numbers changin

r348543 - Add more expected content to match in test

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 15:23:10 2018 New Revision: 348543 URL: http://llvm.org/viewvc/llvm-project?rev=348543&view=rev Log: Add more expected content to match in test Modified: cfe/trunk/test/AST/ast-dump-decl.m Modified: cfe/trunk/test/AST/ast-dump-decl.m URL: http://llvm.org/vi

Re: r348471 - Add test for ObjC generics

2018-12-06 Thread Stephen Kelly via cfe-commits
On 06/12/2018 12:48, Aaron Ballman wrote: On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev Log: Add test for ObjC generics Modified:

r348545 - NFC: Move VisitStmt code to dumpStmt

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 15:33:27 2018 New Revision: 348545 URL: http://llvm.org/viewvc/llvm-project?rev=348545&view=rev Log: NFC: Move VisitStmt code to dumpStmt Summary: This call is duplicated in Visits of all direct subclasses of Stmt. Reviewers: aaron.ballman Subscribers: cfe-comm

r348546 - NFC: Move VisitExpr code to dumpStmt

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 15:33:33 2018 New Revision: 348546 URL: http://llvm.org/viewvc/llvm-project?rev=348546&view=rev Log: NFC: Move VisitExpr code to dumpStmt Summary: The call is duplicated in the handlers of all Expr subclasses. This change makes it easy to split statement handlin

r348553 - Add test for InitListExpr

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 16:08:14 2018 New Revision: 348553 URL: http://llvm.org/viewvc/llvm-project?rev=348553&view=rev Log: Add test for InitListExpr Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp URL: http://llvm.org/viewvc/llvm-pro

r348713 - Fix InitListExpr test

2018-12-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 9 05:13:41 2018 New Revision: 348713 URL: http://llvm.org/viewvc/llvm-project?rev=348713&view=rev Log: Fix InitListExpr test Wrong case of Check meant this has no effect. Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp Modified: cfe/trunk/test/AST/ast-dump-stm

r348714 - Re-order content from InitListExpr

2018-12-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 9 05:15:18 2018 New Revision: 348714 URL: http://llvm.org/viewvc/llvm-project?rev=348714&view=rev Log: Re-order content from InitListExpr Summary: This causes no change in the output of ast-dump-stmt.cpp due to the way child nodes are printed with a delay. Reviewe

r348715 - Inline dumpFullComment into callers

2018-12-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 9 05:18:55 2018 New Revision: 348715 URL: http://llvm.org/viewvc/llvm-project?rev=348715&view=rev Log: Inline dumpFullComment into callers It causes confusion over whether it or dumpComment is the more important. It is easier to refactor with fewer utility methods.

  1   2   3   4   >